From patchwork Thu Jan 19 12:07:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 91868 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp243176qgi; Thu, 19 Jan 2017 04:08:47 -0800 (PST) X-Received: by 10.28.134.146 with SMTP id i140mr25627241wmd.100.1484827727231; Thu, 19 Jan 2017 04:08:47 -0800 (PST) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id i190si6274183wmd.75.2017.01.19.04.08.45; Thu, 19 Jan 2017 04:08:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E5D0EA7607; Thu, 19 Jan 2017 13:08:44 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hk7WDN7fUIFp; Thu, 19 Jan 2017 13:08:44 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0557EA75D5; Thu, 19 Jan 2017 13:08:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BA8F5B3877 for ; Thu, 19 Jan 2017 13:08:38 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id afNIgAQD4Ffs for ; Thu, 19 Jan 2017 13:08:38 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from conuserg-11.nifty.com (conuserg-11.nifty.com [210.131.2.78]) by theia.denx.de (Postfix) with ESMTPS id 0FE49A75C9 for ; Thu, 19 Jan 2017 13:08:34 +0100 (CET) Received: from pug.jp.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id v0JC7x4S001063; Thu, 19 Jan 2017 21:08:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com v0JC7x4S001063 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1484827681; bh=7aqp0TzF5MD04sTIOJs5HQpVOA/GV7tl3oe6NXVc0QE=; h=From:To:Cc:Subject:Date:From; b=fg5cvufKJKbVxkTnu4qIMkphJJiZmoisycF0QbhqMJmwqcol8CRt1c1Rpv0U7BNdk ln4BHH2zQqLWPL+sfEJJ3SYJqBJagYIstLHGzVuszqVeqzPedElzy+V7+22i25YpJ+ QFtLdwgwRGvD5LbPGtauSRBH7XhNo0TE14DHxpK18NaWiEouVvcsT4d6TdPclfBl1M /eoGbN+CoOXtJVQ/I4nh6cYxYlKEtJWZOv07uKo7xtUHr/uc8IhZQoBLPtM7fbynPh KgI3qF9RNMOi5IRv7hvh7zIDc3uQRhjWYXlYzewCxm0KfMF9UmtGzzNtdgw6T634+4 hPQbRF/vOWErg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: u-boot@lists.denx.de Date: Thu, 19 Jan 2017 21:07:53 +0900 Message-Id: <1484827674-31341-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Cc: Albert Aribaud Subject: [U-Boot] [PATCH] arm64: spin-table: add more information in Kconfig help X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This feature seems to be sometimes misunderstood. The intention is [1] Bring the slaves into U-Boot proper image, not SPL (unless you have a special reason). [2] The operation must be done in a board (SoC) specific manner since how to wake the slaves from the Boot ROM is SoC specific. [3] The slaves must enter U-Boot proper after U-Boot relocates itself because the "cpu-release-addr" property points to the relocated memory area. [2] is already explained in the help. We can make [1] even clearer by mentioning "U-Boot proper" instead of "U-Boot". [3] is missing, so I am adding it to the list. Signed-off-by: Masahiro Yamada --- arch/arm/cpu/armv8/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot Reviewed-by: Oded Gabbay diff --git a/arch/arm/cpu/armv8/Kconfig b/arch/arm/cpu/armv8/Kconfig index 22dce88..7388eca 100644 --- a/arch/arm/cpu/armv8/Kconfig +++ b/arch/arm/cpu/armv8/Kconfig @@ -12,8 +12,11 @@ config ARMV8_SPIN_TABLE To use this feature, you must do: - Specify enable-method = "spin-table" in each CPU node in the Device Tree you are using to boot the kernel - - Let secondary CPUs in U-Boot (in a board specific manner) - before the master CPU jumps to the kernel + - Bring secondary CPUs into U-Boot proper (in a board specific + manner) before the master CPU jumps to the kernel, but *after* + relocation. Otherwise, the master CPU will see a different copy + of the spin code, then the secondary CPUs will spin in the + unprotected memory area. U-Boot automatically does: - Set "cpu-release-addr" property of each CPU node