From patchwork Wed Dec 27 12:25:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 122779 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2123969qgn; Wed, 27 Dec 2017 04:35:41 -0800 (PST) X-Google-Smtp-Source: ACJfBosdU6ZB8Js7wYeNsLlE0/GsandXbjGqptvek4WG3LFkvd1LGOU9tg6wICxMIEsLxDqJJMBp X-Received: by 10.80.146.51 with SMTP id i48mr36558169eda.198.1514378141739; Wed, 27 Dec 2017 04:35:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514378141; cv=none; d=google.com; s=arc-20160816; b=016bQiGU56EMJwX8h69OdLtMkAEOf3nyZfMNIon6/O+lgRa6VouGKSeOevyyhq2+P2 seTjVss0bmSGhr6k3jyH2BHBjUIwbXzPMv9qvDIUrULlElnBKiC0bDx5koabA/hU07hJ 1AMAueOO9FnZGj2NVN0ZdzRx75LfSrS6z6EP9ffliMyoAB3qgheEuyUPbFhBRnU9ei8n /Nao7U2zEHaiTsjemHVIrGirBlm6oVcvkBpAUsmVxGeILF73/yhhvOjoRZ7yp8nUzmg8 1273AYiqUU9bcXbCyhG1iEzUsKwiU/EKXb5SoRWmwTfa5h5AgZ4+Fb1DaJunlHnEd+q6 yIaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:arc-authentication-results; bh=Y82BvYHY3XlpyxrokB2/Y2pViezj54lE3bXW5fWVox8=; b=WvRXPM7fkeyGUXiFxUQeLdihYIEIZh1on8ZRyHijIQuX2pa8obu9qTXA0Nr+y3p4i5 YFlFI6LnJn7JwPHQKzngQ4NZuYvjWaXa+9LW9Xevj02xzM/tv9+Qu5HoLW09THwzEIZb qQkJ5cV/HSBVaLQKus/6kd3bVp6nI+zts7yTAhDzwht309StmoosXxt5kIzcPPGHKSad lpMi8pNdy4R1QEY5CiaAg4JeootkkWnprHneKIRAxAa3HDekgaYwSFrSFEy5kljRloLS UU9bVvfwn6Ea0F19/n5aBjf5uSGJy7+5gIlPCfh8bgLReJrKpVNdftBab/kHPx8NUdKs Ac2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ahtVbaDv; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id q24si4251941edb.107.2017.12.27.04.35.41; Wed, 27 Dec 2017 04:35:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ahtVbaDv; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 3E027C21E3C; Wed, 27 Dec 2017 12:34:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 25B16C21E30; Wed, 27 Dec 2017 12:33:03 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A8994C21DA3; Wed, 27 Dec 2017 12:26:22 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by lists.denx.de (Postfix) with ESMTPS id 48AF1C21C59 for ; Wed, 27 Dec 2017 12:26:22 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id i11so39006637wmf.4 for ; Wed, 27 Dec 2017 04:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o2Ff1RU1WsLNRKqi39u9XKnIcRPvaVD8I/HvlAOG288=; b=ahtVbaDvIOAo0Sh07nOppNhaa/qgLUFwB3vy74Mw6fZPDJS4NGoIK8WUTFxx3Xt2dB +G+vruUWzYfnMqBty9b9U9CPrVuSoRBRHH4DyQ1eVgpBw7Lkrd8jl18BBDDF08En11+R CKhwR7hcNAOTSHECwFhlBd9Mwu0q5CDzD+Th0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o2Ff1RU1WsLNRKqi39u9XKnIcRPvaVD8I/HvlAOG288=; b=kH0vTYggWaaKNETyighLc7jLYWmvVaZAO4qlJsdtEwMncCyIwtjqiPopx50DLvppzQ AmPO00DHjynaGOvmKyqPCUXgOR90DTR/1F6Vr6ltvQH8Q80Tmo740zPbpd4mVkWsEi36 GdeMwivdlCb3KdS06dXcaImlR1uUogRckeXeumZbn6+nbGfu/00KlfEP1UPpcHKSSjev oM4UNg4yGlni0TnADGXmA4jsCsKoP3Dtb8ceM6GOrvXm12egVxJAMvq2MZrO93kOXDrA GVt/bOCrtB/vVbjjOGeANG2QVTjVsFQC//bNp9fuUS0fTdfhrEEnrQJytC7/VsPYlvA7 dGJw== X-Gm-Message-State: AKGB3mIoo65X0KdHGMBzChCYuRAnpo+3pRbqcJK30CbYvcp5HUsP6nu4 lc7JRI80pZ+Bj4lN2OTdHMCPOl31SGQ= X-Received: by 10.80.180.187 with SMTP id w56mr35760777edd.3.1514377581678; Wed, 27 Dec 2017 04:26:21 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id a5sm28388838edm.47.2017.12.27.04.26.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Dec 2017 04:26:21 -0800 (PST) From: Bryan O'Donoghue To: u-boot@lists.denx.de Date: Wed, 27 Dec 2017 12:25:46 +0000 Message-Id: <1514377566-28512-4-git-send-email-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514377566-28512-1-git-send-email-bryan.odonoghue@linaro.org> References: <1514377566-28512-1-git-send-email-bryan.odonoghue@linaro.org> X-Mailman-Approved-At: Wed, 27 Dec 2017 12:32:58 +0000 Cc: Fabio Estevam Subject: [U-Boot] [PATCH 03/23] arm: imx: hab: Optimise flow of authenticate_image on is_enabled fail X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" There is no need to call is_enabled() twice in authenticate_image - it does nothing but add an additional layer of indentation. We can check for is_enabled() at the start of the function and return the result code directly. Signed-off-by: Bryan O'Donoghue Cc: Stefano Babic Cc: Fabio Estevam Cc: Peng Fan Cc: Albert Aribaud Cc: Sven Ebenfeld Cc: George McCollister --- arch/arm/mach-imx/hab.c | 138 ++++++++++++++++++++++++------------------------ 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/arch/arm/mach-imx/hab.c b/arch/arm/mach-imx/hab.c index 9fe6d43..6f86c02 100644 --- a/arch/arm/mach-imx/hab.c +++ b/arch/arm/mach-imx/hab.c @@ -428,91 +428,91 @@ int authenticate_image(uint32_t ddr_start, uint32_t image_size) hab_rvt_entry = hab_rvt_entry_p; hab_rvt_exit = hab_rvt_exit_p; - if (is_hab_enabled()) { - printf("\nAuthenticate image from DDR location 0x%x...\n", - ddr_start); + if (!is_hab_enabled()) { + puts("hab fuse not enabled\n"); + return result; + } - hab_caam_clock_enable(1); + printf("\nAuthenticate image from DDR location 0x%x...\n", + ddr_start); - if (hab_rvt_entry() == HAB_SUCCESS) { - /* If not already aligned, Align to ALIGN_SIZE */ - ivt_offset = (image_size + ALIGN_SIZE - 1) & - ~(ALIGN_SIZE - 1); + hab_caam_clock_enable(1); - start = ddr_start; - bytes = ivt_offset + IVT_SIZE + CSF_PAD_SIZE; + if (hab_rvt_entry() == HAB_SUCCESS) { + /* If not already aligned, Align to ALIGN_SIZE */ + ivt_offset = (image_size + ALIGN_SIZE - 1) & + ~(ALIGN_SIZE - 1); + + start = ddr_start; + bytes = ivt_offset + IVT_SIZE + CSF_PAD_SIZE; #ifdef DEBUG - printf("\nivt_offset = 0x%x, ivt addr = 0x%x\n", - ivt_offset, ddr_start + ivt_offset); - puts("Dumping IVT\n"); - print_buffer(ddr_start + ivt_offset, - (void *)(ddr_start + ivt_offset), - 4, 0x8, 0); - - puts("Dumping CSF Header\n"); - print_buffer(ddr_start + ivt_offset+IVT_SIZE, - (void *)(ddr_start + ivt_offset+IVT_SIZE), - 4, 0x10, 0); + printf("\nivt_offset = 0x%x, ivt addr = 0x%x\n", + ivt_offset, ddr_start + ivt_offset); + puts("Dumping IVT\n"); + print_buffer(ddr_start + ivt_offset, + (void *)(ddr_start + ivt_offset), + 4, 0x8, 0); + + puts("Dumping CSF Header\n"); + print_buffer(ddr_start + ivt_offset + IVT_SIZE, + (void *)(ddr_start + ivt_offset + IVT_SIZE), + 4, 0x10, 0); #if !defined(CONFIG_SPL_BUILD) - get_hab_status(); + get_hab_status(); #endif - puts("\nCalling authenticate_image in ROM\n"); - printf("\tivt_offset = 0x%x\n", ivt_offset); - printf("\tstart = 0x%08lx\n", start); - printf("\tbytes = 0x%x\n", bytes); + puts("\nCalling authenticate_image in ROM\n"); + printf("\tivt_offset = 0x%x\n", ivt_offset); + printf("\tstart = 0x%08lx\n", start); + printf("\tbytes = 0x%x\n", bytes); #endif - /* - * If the MMU is enabled, we have to notify the ROM - * code, or it won't flush the caches when needed. - * This is done, by setting the "pu_irom_mmu_enabled" - * word to 1. You can find its address by looking in - * the ROM map. This is critical for - * authenticate_image(). If MMU is enabled, without - * setting this bit, authentication will fail and may - * crash. - */ - /* Check MMU enabled */ - if (is_soc_type(MXC_SOC_MX6) && get_cr() & CR_M) { - if (is_mx6dq()) { - /* - * This won't work on Rev 1.0.0 of - * i.MX6Q/D, since their ROM doesn't - * do cache flushes. don't think any - * exist, so we ignore them. - */ - if (!is_mx6dqp()) - writel(1, MX6DQ_PU_IROM_MMU_EN_VAR); - } else if (is_mx6sdl()) { - writel(1, MX6DLS_PU_IROM_MMU_EN_VAR); - } else if (is_mx6sl()) { - writel(1, MX6SL_PU_IROM_MMU_EN_VAR); - } + /* + * If the MMU is enabled, we have to notify the ROM + * code, or it won't flush the caches when needed. + * This is done, by setting the "pu_irom_mmu_enabled" + * word to 1. You can find its address by looking in + * the ROM map. This is critical for + * authenticate_image(). If MMU is enabled, without + * setting this bit, authentication will fail and may + * crash. + */ + /* Check MMU enabled */ + if (is_soc_type(MXC_SOC_MX6) && get_cr() & CR_M) { + if (is_mx6dq()) { + /* + * This won't work on Rev 1.0.0 of + * i.MX6Q/D, since their ROM doesn't + * do cache flushes. don't think any + * exist, so we ignore them. + */ + if (!is_mx6dqp()) + writel(1, MX6DQ_PU_IROM_MMU_EN_VAR); + } else if (is_mx6sdl()) { + writel(1, MX6DLS_PU_IROM_MMU_EN_VAR); + } else if (is_mx6sl()) { + writel(1, MX6SL_PU_IROM_MMU_EN_VAR); } + } - load_addr = (uint32_t)hab_rvt_authenticate_image( - HAB_CID_UBOOT, - ivt_offset, (void **)&start, - (size_t *)&bytes, NULL); - if (hab_rvt_exit() != HAB_SUCCESS) { - puts("hab exit function fail\n"); - load_addr = 0; - } - } else { - puts("hab entry function fail\n"); + load_addr = (uint32_t)hab_rvt_authenticate_image( + HAB_CID_UBOOT, + ivt_offset, (void **)&start, + (size_t *)&bytes, NULL); + if (hab_rvt_exit() != HAB_SUCCESS) { + puts("hab exit function fail\n"); + load_addr = 0; } + } else { + puts("hab entry function fail\n"); + } - hab_caam_clock_enable(0); + hab_caam_clock_enable(0); #if !defined(CONFIG_SPL_BUILD) - get_hab_status(); + get_hab_status(); #endif - } else { - puts("hab fuse not enabled\n"); - } - - if ((!is_hab_enabled()) || (load_addr != 0)) + if (load_addr != 0) result = 0; return result;