diff mbox series

[3/3] x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge

Message ID 1590984915-21854-3-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 95cfa1d46c61461bdadb195799a205b48b907a5e
Headers show
Series [1/3] x86: baytrail: acpi: Create buffers outside of the methods | expand

Commit Message

Bin Meng June 1, 2020, 4:15 a.m. UTC
PCI Firmware specification requires _UID() and doesn't require _ADR()
to be set. Replace latter by former. This fixes the following warning
reported by ACPICA 20200430:

  Warning 3073 - Multiple types (Device object requires either a _HID
  or _ADR, but not both)

Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
---

 arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko June 1, 2020, 8:42 a.m. UTC | #1
On Sun, May 31, 2020 at 09:15:15PM -0700, Bin Meng wrote:
> PCI Firmware specification requires _UID() and doesn't require _ADR()
> to be set. Replace latter by former. This fixes the following warning
> reported by ACPICA 20200430:
> 
>   Warning 3073 - Multiple types (Device object requires either a _HID
>   or _ADR, but not both)
> 

For all three:
Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>

> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
> 
>  arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> index fe9edc1..384dab2 100644
> --- a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> +++ b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> @@ -8,7 +8,7 @@ Device (PCI0)
>  	Name(_HID, EISAID("PNP0A08"))	/* PCIe */
>  	Name(_CID, EISAID("PNP0A03"))	/* PCI */
>  
> -	Name(_ADR, 0)
> +	Name(_UID, 0)
>  	Name(_BBN, 0)
>  
>  	Name(MCRS, ResourceTemplate()
> -- 
> 2.7.4
>
Bin Meng June 2, 2020, 1:18 a.m. UTC | #2
On Mon, Jun 1, 2020 at 4:42 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Sun, May 31, 2020 at 09:15:15PM -0700, Bin Meng wrote:
> > PCI Firmware specification requires _UID() and doesn't require _ADR()
> > to be set. Replace latter by former. This fixes the following warning
> > reported by ACPICA 20200430:
> >
> >   Warning 3073 - Multiple types (Device object requires either a _HID
> >   or _ADR, but not both)
> >
>
> For all three:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> >
> >  arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
index fe9edc1..384dab2 100644
--- a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
@@ -8,7 +8,7 @@  Device (PCI0)
 	Name(_HID, EISAID("PNP0A08"))	/* PCIe */
 	Name(_CID, EISAID("PNP0A03"))	/* PCI */
 
-	Name(_ADR, 0)
+	Name(_UID, 0)
 	Name(_BBN, 0)
 
 	Name(MCRS, ResourceTemplate()