From patchwork Thu Apr 18 12:43:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 16239 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-gg0-f200.google.com (mail-gg0-f200.google.com [209.85.161.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 17AC723974 for ; Thu, 18 Apr 2013 12:45:38 +0000 (UTC) Received: by mail-gg0-f200.google.com with SMTP id i2sf3884806ggn.3 for ; Thu, 18 Apr 2013 05:45:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :x-auth-info:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:message-id:x-gm-message-state :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-google-group-id:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=eUA3PoViiaAx6pRvyKUBCgyilsXHXNJcilyrRV/MwB8=; b=EWrGNlUI9AHJdMXl+HNb2g5gn05NzsWgs7D4hmk6o+4FWf1n2MvxgNoyeLSaGxkv3f RP7tcFThBO6wmRM2pOpindoZ4wuUEXa1mbSuNK3pvA+xpGOJN+tvfA+d/lwYp6B6iX5Q yaDOHuTMkZyTePMIB4YcRnrZKQwOFOkotIHKmcwrD6niBHQ8qYMkQMZAxWYNRyoNo2eE eUwckADDyHelQ4n8nucpIGpNr9tTFLH6KIASaXtXSwpxlOlR/XtJhSYsPl9jdoAE0PZe IKZzIaLcKGtoqPRc27Ehe+s9D/xm6QIIik7fqhzGPo44gPlDQGdhekWWNIo6/JwkOMix BMkw== X-Received: by 10.224.160.65 with SMTP id m1mr7900142qax.2.1366289100783; Thu, 18 Apr 2013 05:45:00 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.97.131 with SMTP id ea3ls1426348qeb.20.gmail; Thu, 18 Apr 2013 05:45:00 -0700 (PDT) X-Received: by 10.58.144.133 with SMTP id sm5mr8090179veb.23.1366289020075; Thu, 18 Apr 2013 05:43:40 -0700 (PDT) Received: from mail-vb0-x231.google.com (mail-vb0-x231.google.com [2607:f8b0:400c:c02::231]) by mx.google.com with ESMTPS id a9si6472670vcy.54.2013.04.18.05.43.40 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Apr 2013 05:43:40 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::231 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::231; Received: by mail-vb0-f49.google.com with SMTP id 11so2315322vbf.36 for ; Thu, 18 Apr 2013 05:43:40 -0700 (PDT) X-Received: by 10.58.84.164 with SMTP id a4mr7450268vez.9.1366289019902; Thu, 18 Apr 2013 05:43:39 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp121685veb; Thu, 18 Apr 2013 05:43:38 -0700 (PDT) X-Received: by 10.204.231.6 with SMTP id jo6mr3933013bkb.30.1366289018316; Thu, 18 Apr 2013 05:43:38 -0700 (PDT) Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by mx.google.com with ESMTPS id uk5si3076140bkb.42.2013.04.18.05.43.37 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 18 Apr 2013 05:43:38 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of marex@denx.de) client-ip=212.18.0.10; Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3Zs0Nn42XSz3hhjv; Thu, 18 Apr 2013 14:43:37 +0200 (CEST) X-Auth-Info: 5Vcd1NmNaSAgY1mED8gULdRwOFThVB6JHGMfTPQ+Sxo= Received: from mashiro.localnet (unknown [195.140.253.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mnet-online.de (Postfix) with ESMTPSA id 3Zs0Nn30PGzbc6l; Thu, 18 Apr 2013 14:43:37 +0200 (CEST) From: Marek Vasut To: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support Date: Thu, 18 Apr 2013 14:43:36 +0200 User-Agent: KMail/1.13.7 (Linux/3.8-trunk-amd64; KDE/4.8.4; x86_64; ; ) Cc: Vivek Gautam , u-boot-review@google.com, patches@linaro.org, Vivek Gautam , rajeshwari.s@samsung.com, vikas.sajjan@samsung.com, Julius Werner References: <1365764680-10917-1-git-send-email-gautam.vivek@samsung.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <201304181443.36677.marex@denx.de> X-Gm-Message-State: ALoCoQnkpnq3JF5eCFXXPtFAxYVkBq5VJnu6CGCCe+zud4knHHCQfKGNosyx+BtWWGwJPaXSl07n X-Original-Sender: marex@denx.de X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::231 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Dear Vivek Gautam, > HI Marek, > > On Thu, Apr 18, 2013 at 4:29 PM, Vivek Gautam wrote: > > On Thu, Apr 18, 2013 at 11:54 AM, Vivek Gautam > > > > wrote: > >> Hi Marek, > >> > >> On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut wrote: > >>> Dear Vivek Gautam, > >>> > >>>> Based on 'u-boot-usb' master branch. > >>>> > >>>> This patch-series includes majorly some clean-up, few fixes and > >>>> then some basic super-speed usb infrastructure addition, to help > >>>> put support for XHCI in near future. > >>> > >>> btw can you test your patches with MAKEALL -a arm? I get this: > >>> > >>> --------------------- SUMMARY ---------------------------- > >>> Boards compiled: 306 > >>> Boards with errors: 65 ( qong mx35pdk gplugd at91sam9m10g45ek_nandflash > >>> pogo_e02 dns325 iconnect lschlv2 lsxhl d2net_v2 inetspace_v2 > >>> net2big_v2 netspace_lite_v2 netspace_max_v2 netspace_v2 wireless_space > >>> dreamplug guruplug mv88f6281gtw_ge openrd_base openrd_client > >>> openrd_ultimate rd6281a sheevaplug ib62x0 dockstar tk71 zmx25 > >>> mx23_olinuxino apx4devkit mx23evk m28evk mx28evk sc_sps_1 edminiv2 > >>> mx51_efikamx mx51_efikasb mx51evk mx53loco mx6qsabreauto mx6qsabrelite > >>> nitrogen6dl nitrogen6dl2g nitrogen6q nitrogen6q2g nitrogen6s > >>> nitrogen6s1g cm_t35 mt_ventoux omap3_beagle mcx twister omap4_panda > >>> snow smdk5250 harmony seaboard ventana whistler colibri_t20_iris > >>> plutux medcom-wide tec paz00 trimslice ) > >>> ---------------------------------------------------------- > >> > >> Tried with MAKEALL > >> got following result > >> > >> --------------------- SUMMARY ---------------------------- > >> Boards compiled: 306 > >> Boards with errors: 1 ( omap3_evm ) > >> Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3 > >> h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv > >> vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2 > >> colibri_pxa270 ) > >> ---------------------------------------------------------- > > I actually checked now just for omap3_evm configuration by trying out: > make distclean > make omap3_evm_config > make > > But strangely i didn't get any build errros for omap3_evm board on > explicitly compiling for it. > Any clue ? > > > **Without my patches i get following result > > > > --------------------- SUMMARY ---------------------------- > > Boards compiled: 306 > > Boards with warnings but no errors: 17 ( VCMA9 smdk2410 kzm9g balloon3 > > h2200 lubbock palmld palmtc polaris pxa255_idp trizepsiv > > vpac270_nor_128 vpac270_nor_256 vpac270_ond_256 xaeniax zipitz2 > > colibri_pxa270 ) > > ---------------------------------------------------------- > > > >> There's something to do with Cross Compiler version ?? > >> btw what environment are you compiling the source with. > > I am using "arm-2011.09" cross toolchain. I use ELDK 5.3 and Debian 4.7.2-5 to do by builds. But now that I'm looking at it, it's this patch that caused it, sorry. commit 28b31a5937b89528c40df24dd6c9122578880605 Author: Julius Werner Date: Thu Feb 28 18:08:40 2013 +0000 usb: Add new command to set USB 2.0 port test modes debug("req=%u (%#x), type=%u (%#x), value=%u, index=%u\n", This change fixes is, right Julius ? Best regards, Marek Vasut diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 8464850..19d4352 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -630,7 +630,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, printf("The request port(%d) is not configured\n", port - 1); return -1; } - status_reg = (uint32_t *)&hcor->or_portsc[port - 1]; + status_reg = (uint32_t *)&ctrl->hcor->or_portsc[port - 1]; srclen = 0;