From patchwork Mon Aug 20 12:32:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 144607 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3918066ljj; Mon, 20 Aug 2018 05:32:33 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxSIJ07QwU/VvlM9uzTffERlgLW7sRh/5ScHekF1H5st0a0S+IvwR7jJaX7eKd2T1yMx4D9 X-Received: by 2002:a50:f31a:: with SMTP id p26-v6mr55924721edm.68.1534768353865; Mon, 20 Aug 2018 05:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534768353; cv=none; d=google.com; s=arc-20160816; b=JAA1LlnC+Ekvr+RE93t4Kl/1u2Yo7+bOKYdSBb3sIOw9H58zoopMsijU0AA5WRMVh8 KHOl4PnZqWVD1wnXd8cTj+TONPOAdEE9AWaAGjwFPd0IYKNrk4FG4kL4Saa7iIvFx+mQ 9Up+5LK8YDU1a5nwQMuSAPRlmNyIK+tK5ZMV0vfFVIgLiESyBNVhAfjNs+EroelRlXSY 3AHGMTC+v7rCHvecen8dOcdybN1IrmSo0KA8LXYn/Ra1LkOKaiqnC85bDodf3r8WE5Uq cHSQtakMK1xXptIrJxv4mHUQ+pwork9wmWQjpBO3IinBDce+SGU5tl3VcXm9q9nfgoBd ReVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:arc-authentication-results; bh=vcX2dNlMVfdQ7Ir8+GlqGipzYYqQhVPSX9MlBxjUBF0=; b=cW1hsL9Acs8dtXm1RQtJQOQP0VPs7U8VbDV6bGbzWkT+JVR0BLkokeSUXDxTEgFSRf W/h+IO9VGg5CH8PYAXr7WpBrSNgk5xk6HWILX7cDWBTJWUmekoSFKwy5uHito2oeNFlC Bb6VbE0vp2boCzieStIbRjfcg1/e0hbuDHjXw2TlFCCttCQ/GYPyeGWCyyXfOutZMyHO PIES00vxZlw14waiacuNgMZs4syPdHfiZra0sVk7mYK6WoKCU5G/drub8zeVWFqhKkiL H2kLSBR/9XkYUhO3blINuMpYcwymxPev11rVb8Q66GNDoQdhgezENRocIR3lWP2jgJkb 6TNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id d29-v6si955798edb.244.2018.08.20.05.32.33; Mon, 20 Aug 2018 05:32:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id 6CDBAC21E39; Mon, 20 Aug 2018 12:32:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5C3E7C21C8B; Mon, 20 Aug 2018 12:32:26 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D2A77C21DEC; Mon, 20 Aug 2018 12:32:24 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by lists.denx.de (Postfix) with ESMTPS id D4680C21C2F for ; Mon, 20 Aug 2018 12:32:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7EC7DADF4; Mon, 20 Aug 2018 12:32:23 +0000 (UTC) From: Alexander Graf To: U-Boot Mailing List Date: Mon, 20 Aug 2018 14:32:19 +0200 Message-Id: <20180820123220.55342-3-agraf@suse.de> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20180820123220.55342-1-agraf@suse.de> References: <20180820123220.55342-1-agraf@suse.de> Cc: Heinrich Schuchardt , Tom Rini Subject: [U-Boot] [PATCH 2/3] x86: Enable -fdata-sections always X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" We left -fdata-sections disabled for x86_64 before because we encountered random bugs that were at that time inexplicable. Turns out this really was just side effects of missing .bss* statements in the linker scripts. With those fixed, we can enable data sections for all targets. Signed-off-by: Alexander Graf Reviewed-by: Bin Meng Tested-by: Bin Meng --- arch/x86/config.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/config.mk b/arch/x86/config.mk index 586e11a0dd..5b04febd68 100644 --- a/arch/x86/config.mk +++ b/arch/x86/config.mk @@ -23,13 +23,11 @@ endif ifeq ($(IS_32BIT),y) PLATFORM_CPPFLAGS += -march=i386 -m32 -# TODO: These break on x86_64; need to debug further -PLATFORM_RELFLAGS += -fdata-sections else PLATFORM_CPPFLAGS += $(if $(CONFIG_SPL_BUILD),,-fpic) -fno-common -m64 endif -PLATFORM_RELFLAGS += -ffunction-sections -fvisibility=hidden +PLATFORM_RELFLAGS += -fdata-sections -ffunction-sections -fvisibility=hidden PLATFORM_LDFLAGS += -Bsymbolic -Bsymbolic-functions PLATFORM_LDFLAGS += -m $(if $(IS_32BIT),elf_i386,elf_x86_64)