From patchwork Mon Feb 24 17:22:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 236763 List-Id: U-Boot discussion From: masahiroy at kernel.org (Masahiro Yamada) Date: Tue, 25 Feb 2020 02:22:27 +0900 Subject: [PATCH] global_data.h: make self-contained Message-ID: <20200224172227.13302-1-masahiroy@kernel.org> The compiler never knows what 'bd_t' is without including . By changing it to (struct bd_info), the compiler learns it is struct. Signed-off-by: Masahiro Yamada --- Maybe, we should replace 'bd_t' with 'struct bd_info' globally by using coccinelle or something. Linux coding style (Documentation/process/coding-style.rst) apparently discourages typedef for cases like this. include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index 5d027329fe..d9e220cfe3 100644 --- a/include/asm-generic/global_data.h +++ b/include/asm-generic/global_data.h @@ -25,7 +25,7 @@ #include typedef struct global_data { - bd_t *bd; + struct bd_info *bd; unsigned long flags; unsigned int baudrate; unsigned long cpu_clk; /* CPU clock in Hz! */