diff mbox series

[v2,3/4] video: mxsfb: add clk_enable()

Message ID 20200427151107.101075-4-giulio.benetti@benettiengineering.com
State Superseded
Headers show
Series Various i.MXRT bug/typo fixes | expand

Commit Message

Giulio Benetti April 27, 2020, 3:11 p.m. UTC
BROM doesn't enable lcdif by default so add clk_enable() after
clk_set_rate().

Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
---
V1->V2:
* call clk_enable() after clk_set_rate() as suggested by Fabio
---
 drivers/video/mxsfb.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Anatolij Gustschin April 27, 2020, 3:20 p.m. UTC | #1
On Mon, 27 Apr 2020 17:11:06 +0200
Giulio Benetti giulio.benetti at benettiengineering.com wrote:

> BROM doesn't enable lcdif by default so add clk_enable() after
> clk_set_rate().
> 
> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>

Reviewed-by: Anatolij Gustschin <agust at denx.de>

--
Anatolij
Fabio Estevam April 27, 2020, 3:35 p.m. UTC | #2
Hi Giulio,

On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
<giulio.benetti at benettiengineering.com> wrote:
>
> BROM doesn't enable lcdif by default so add clk_enable() after
> clk_set_rate().
>
> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
> ---
> V1->V2:
> * call clk_enable() after clk_set_rate() as suggested by Fabio

Thanks for the respin:

Reviewed-by: Fabio Estevam <festevam at gmail.com>
diff mbox series

Patch

diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 8a5a61c9fb..12d00b4689 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -77,6 +77,12 @@  static void mxs_lcd_init(struct udevice *dev, u32 fb_addr,
 		dev_err(dev, "Failed to set mxs clk: %d\n", ret);
 		return;
 	}
+
+	ret = clk_enable(&per_clk);
+	if (ret < 0) {
+		dev_err(dev, "Failed to enable mxs clk: %d\n", ret);
+		return;
+	}
 #else
 	/* Kick in the LCDIF clock */
 	mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000);