From patchwork Fri May 8 05:50:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 245300 List-Id: U-Boot discussion From: takahiro.akashi at linaro.org (AKASHI Takahiro) Date: Fri, 8 May 2020 14:50:47 +0900 Subject: [PATCH] cmd: efidebug: fix a wrong handling of arguments Message-ID: <20200508055047.7453-1-takahiro.akashi@linaro.org> Coverity detected a dead code, but actually there is a bug in a check against a number of arguments. So simply fix it. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300330) --- cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 70aba446a937..56bf9af77248 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -606,7 +606,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag, + sizeof(struct efi_device_path); /* for END */ /* optional data */ - if (argc < 6) + if (argc == 6) lo.optional_data = NULL; else lo.optional_data = (const u8 *)argv[6];