diff mbox series

[v2,08/10] rtc: i2c_rtc_emul: catch any write to the "reset" register

Message ID 20200519220117.24448-9-rasmus.villemoes@prevas.dk
State Accepted
Commit a3e36525a9b853c09d5f5726eff3641cd0cb5619
Headers show
Series [v2,01/10] rtc: add rtc_read helper and ->read method | expand

Commit Message

Rasmus Villemoes May 19, 2020, 10:01 p.m. UTC 
It's more natural that any write that happens to touch the reset
register should cause a reset, rather than just a write that starts at
that offset.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
---
 drivers/rtc/i2c_rtc_emul.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Simon Glass May 31, 2020, 2:07 p.m. UTC | #1 
On Tue, 19 May 2020 at 16:01, Rasmus Villemoes
<rasmus.villemoes at prevas.dk> wrote:
>
> It's more natural that any write that happens to touch the reset
> register should cause a reset, rather than just a write that starts at
> that offset.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
>  drivers/rtc/i2c_rtc_emul.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>
diff mbox series

Patch

diff --git a/drivers/rtc/i2c_rtc_emul.c b/drivers/rtc/i2c_rtc_emul.c
index d4b33e59d6..3a7f1fe53e 100644
--- a/drivers/rtc/i2c_rtc_emul.c
+++ b/drivers/rtc/i2c_rtc_emul.c
@@ -196,7 +196,8 @@  static int sandbox_i2c_rtc_xfer(struct udevice *emul, struct i2c_msg *msg,
 
 			/* Write the register */
 			memcpy(plat->reg + offset, ptr, len);
-			if (offset == REG_RESET)
+			/* If the reset register was written to, do reset. */
+			if (offset <= REG_RESET && REG_RESET < offset + len)
 				reset_time(emul);
 		}
 	}