| Message ID | 20200522163226.6.I1e88f035ad8ba4d943ea914eaa536d4cbdc06495@changeid |
|---|---|
| State | Accepted |
| Commit | dd5b0fad8f295c6e786f1528d09f03fa546289cd |
| Headers | show |
| Series | checkpatch.pl: Add features to help improve U-Boot code | expand |
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 22869992e90..33ec4e2bfd4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2259,6 +2259,12 @@ sub u_boot_line { WARN("CMD_TEST", "Possible new command - make sure you add a test\n" . $herecurr); } + + # use if instead of #if + if ($line =~ /^\+#if.*CONFIG.*/) { + WARN("PREFER_IF", + "Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible\n" . $herecurr); + } } sub process {
There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, suggest using the compile-time construct. Signed-off-by: Simon Glass <sjg at chromium.org> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)