diff mbox series

[1/4] crypto/fsl: make SEC%u status line consistent

Message ID 20200602220554.22477-2-michael@walle.cc
State New
Headers show
Series crypto/fsl: add RNG support | expand

Commit Message

Michael Walle June 2, 2020, 10:05 p.m. UTC
Align the status line with all the other output in U-Boot.

Before the change:
DDR    3.9 GiB (DDR3, 32-bit, CL=11, ECC on)
SEC0: RNG instantiated
WDT:   Started with servicing (60s timeout)

After the change:
DDR    3.9 GiB (DDR3, 32-bit, CL=11, ECC on)
SEC0:  RNG instantiated
WDT:   Started with servicing (60s timeout)

Signed-off-by: Michael Walle <michael at walle.cc>
---
 drivers/crypto/fsl/jr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Horia Geanta June 3, 2020, 5 p.m. UTC | #1
On 6/3/2020 1:06 AM, Michael Walle wrote:
> @@ -657,7 +657,7 @@ int sec_init_idx(uint8_t sec_idx)
>  			printf("SEC%u: RNG instantiation failed\n", sec_idx);
>  			return -1;
>  		}
> -		printf("SEC%u: RNG instantiated\n", sec_idx);
> +		printf("SEC%u:  RNG instantiated\n", sec_idx);
Shouldn't also the string printed in case of failure be updated?

Horia
Heinrich Schuchardt June 3, 2020, 5:10 p.m. UTC | #2
On 6/3/20 12:05 AM, Michael Walle wrote:
> Align the status line with all the other output in U-Boot.
>
> Before the change:
> DDR    3.9 GiB (DDR3, 32-bit, CL=11, ECC on)
> SEC0: RNG instantiated
> WDT:   Started with servicing (60s timeout)
>
> After the change:
> DDR    3.9 GiB (DDR3, 32-bit, CL=11, ECC on)
> SEC0:  RNG instantiated
> WDT:   Started with servicing (60s timeout)
>
> Signed-off-by: Michael Walle <michael at walle.cc>
> ---
>  drivers/crypto/fsl/jr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c
> index e2d9216cfc..612e86818b 100644
> --- a/drivers/crypto/fsl/jr.c
> +++ b/drivers/crypto/fsl/jr.c
> @@ -657,7 +657,7 @@ int sec_init_idx(uint8_t sec_idx)
>  			printf("SEC%u: RNG instantiation failed\n", sec_idx);

And how about this line?

>  			return -1;
>  		}
> -		printf("SEC%u: RNG instantiated\n", sec_idx);
> +		printf("SEC%u:  RNG instantiated\n", sec_idx);
>  	}
>  #endif
>  	return ret;
>
diff mbox series

Patch

diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c
index e2d9216cfc..612e86818b 100644
--- a/drivers/crypto/fsl/jr.c
+++ b/drivers/crypto/fsl/jr.c
@@ -657,7 +657,7 @@  int sec_init_idx(uint8_t sec_idx)
 			printf("SEC%u: RNG instantiation failed\n", sec_idx);
 			return -1;
 		}
-		printf("SEC%u: RNG instantiated\n", sec_idx);
+		printf("SEC%u:  RNG instantiated\n", sec_idx);
 	}
 #endif
 	return ret;