| Message ID | 20200625075958.9868-6-patrick.delaunay@st.com |
|---|---|
| State | New |
| Headers | show |
| Series | env: ext4: corrections and add test for env in ext4 | expand |
On Thu, Jun 25, 2020 at 09:59:49AM +0200, Patrick Delaunay wrote: > Add the ops .load for nowhere ENV backend to load the > default environment. > > This ops is needed for the command 'env load' > > > > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> Reviewed-by: Tom Rini <trini at konsulko.com>
On Thu, Jun 25, 2020 at 09:59:49AM +0200, Patrick Delaunay wrote: > Add the ops .load for nowhere ENV backend to load the > default environment. > > This ops is needed for the command 'env load' > > > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > Reviewed-by: Tom Rini <trini@konsulko.com> > --- > > Changes in v3: > - new: add ?load ops in nowhere > > env/nowhere.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/env/nowhere.c b/env/nowhere.c > index f5b0a17652..6949810a1f 100644 > --- a/env/nowhere.c > +++ b/env/nowhere.c > @@ -27,8 +27,17 @@ static int env_nowhere_init(void) > return 0; > } > > +static int env_nowhere_load(void) > +{ > + env_set_default(NULL, 0); > + gd->env_valid = ENV_INVALID; > + > + return 0; > +} > + > U_BOOT_ENV_LOCATION(nowhere) = { > .location = ENVL_NOWHERE, > .init = env_nowhere_init, > + .load = env_nowhere_load, > ENV_NAME("nowhere") > }; Build testing this, we get 8KiB size increase in SPL in targets which have ENV_NOWHERE in SPL. Can we guard this somehow, with a logical tie-in to being needed for 'env load' ? Thanks! -- Tom
diff --git a/env/nowhere.c b/env/nowhere.c index f5b0a17652..6949810a1f 100644 --- a/env/nowhere.c +++ b/env/nowhere.c @@ -27,8 +27,17 @@ static int env_nowhere_init(void) return 0; } +static int env_nowhere_load(void) +{ + env_set_default(NULL, 0); + gd->env_valid = ENV_INVALID; + + return 0; +} + U_BOOT_ENV_LOCATION(nowhere) = { .location = ENVL_NOWHERE, .init = env_nowhere_init, + .load = env_nowhere_load, ENV_NAME("nowhere") };
Add the ops .load for nowhere ENV backend to load the default environment. This ops is needed for the command 'env load' Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> --- Changes in v3: - new: add ?load ops in nowhere env/nowhere.c | 9 +++++++++ 1 file changed, 9 insertions(+)