From patchwork Wed Nov 11 11:18:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 322919 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp299893ils; Wed, 11 Nov 2020 03:19:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwI0Tlq0pGhYlYMQt8t6xp+oHeMnxmBT0qGXDI39qe6aYeDv6/a7TX3hKrtNe3kZlL9/Oj4 X-Received: by 2002:a17:906:3e91:: with SMTP id a17mr24261272ejj.82.1605093560141; Wed, 11 Nov 2020 03:19:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605093560; cv=none; d=google.com; s=arc-20160816; b=PP7YPvQL0jvb0sjlpdZXMbr9f2unmc4BBFw9BBoynl04KUOKB7dpRrxRnoQ2nBPsF6 XIG1z0pdMBzLu4unD2xhu6s5iUS7OTsGyPA9hFb6UHhsPYjgAKuUKMREDzeH0md8lD4w MzErVFfVUtTWc8nQm+vo1qJx1kdVGDsVfZjA0jy64xDRkXzFC2YC+/XUSpz6V8LMVAYi mmsCOh49BInAa7LgPaU/C1VwoSXRgjGTTuf97Z/zn3yGf3ZO3xkcYWoG0aIe0TJlp5nr i0PT3s1MF6b1mZ0pl9NLUQE32FZxw0h7p55WXpB5qTN9jXZCdnwEZGN6kP14LA+oJGt4 hlsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FX1BkwrA+lvxKaBBN5lK1E6AFRT4+HWtrgVxTNcpkAg=; b=NPruLTohDsuKyNNYDQKbMtcjqcQ4QalPDOY+XK5AyqlQC8OLc20WS1LLC3PjGotyKR PFCr2OKHYr9UknTTVU3+BPCxDuYvd5VjoYRsAnUENgSTG9kj/I81GNmH4ytuPXR4QkYJ TImCJysMzwm6BEqH7MSWHjflhpR/PuSGf0heOuqNYpSJqvFXTsZR13g1rz2Y2CFdv0bK Hq9XrXrjCTzLfCR6IxqIyg2NJFFbHPrZQ11PSMJo6EvZagB4f4Kie7RsY6SB2akrruSR 5TpL7FmcB4lNzgw7DTqLFs11gD/IgYEEj3OFFzU8SnOu1IbUkahEDx6oxx3BfuvAs5Fy tF9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=QdNk8Bu7; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id r2si1052967ejb.548.2020.11.11.03.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 03:19:20 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=QdNk8Bu7; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EEC7582523; Wed, 11 Nov 2020 12:19:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QdNk8Bu7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C29C082545; Wed, 11 Nov 2020 12:19:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3515F824F7 for ; Wed, 11 Nov 2020 12:18:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=joel.stan@gmail.com Received: by mail-pf1-x441.google.com with SMTP id x15so101072pfm.9 for ; Wed, 11 Nov 2020 03:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FX1BkwrA+lvxKaBBN5lK1E6AFRT4+HWtrgVxTNcpkAg=; b=QdNk8Bu7HwhWaWrDcGiMMA65HLdY7/CkHLms6LDvr32k8yL55zPLbm1phm4ihTWL/O pjXBcwO2s12nG3h6Dn+kGK22KEz1Dap6pm6jxW6Ho19XnQ7jD5AcvJrWLvmk7L3AmFHu fCoWEbhG3MHIiEy8b94hDNXeGmTGhQ32cnKg73LqXi8ux2VgwN298qD05Gjuqi1HJIRg rYb4oySnupt5n0Bw7Rrx58lpnLPBd2I98/rboMp4HES5HqiP2ywMJ4KM1Utd01UNG5XM +50XecRKGEjHzmN7OU8QZYsVhuPTB75AZIar/0AOZdzPs6LtN6EeeJA4js0lMLIhVEbT 7dPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FX1BkwrA+lvxKaBBN5lK1E6AFRT4+HWtrgVxTNcpkAg=; b=HnTDAfI+bA1EwD6bmUPr8WJL9k2z2nFGO8qpHIi87mGW2IWuRxTj3iTkGs8W9Nxfdc mKPz1qnPSSh0IYEdms2hDk/fjYcIHuFbOU6bDnbWpeQhxvsSb7stoVwoIGD3h5oKuBTp nKTHyMPHoFR4ryfFHYiS9cD5ir8Uz3D/xB7ok7by6b0ZvEENwTiuJ8lnonAZeel64Ff7 B/ewwxs7VmbzNtnfEbWR4z4pmUoZ/upbfwyLl5JqyfSfwLzRCxGi8a/+mRgxsnP0ZOV4 7Jt+n+pfKHE5oBOBc9aCwTakc89E2tImloyhvp9W96diRarH1xbQtU4eqBIVGq/5I7ct 0VKw== X-Gm-Message-State: AOAM532lJq9NcAEw14apC+OcieePYnHybaW3js1uYCdtnBGrV8frSWOJ nIZr79kOeFUgCqbqGDY5ugU= X-Received: by 2002:a05:6a00:213a:b029:18b:4b8b:68c with SMTP id n26-20020a056a00213ab029018b4b8b068cmr5205488pfj.18.1605093537810; Wed, 11 Nov 2020 03:18:57 -0800 (PST) Received: from voyager.lan ([45.124.203.14]) by smtp.gmail.com with ESMTPSA id l62sm2339495pga.63.2020.11.11.03.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 03:18:56 -0800 (PST) From: Joel Stanley To: Simon Glass , Philippe Reynes Cc: Andrew Jeffery , u-boot@lists.denx.de Subject: [PATCH 1/3] tools/Makefile: FIT_CIPHER requires libssl Date: Wed, 11 Nov 2020 21:48:31 +1030 Message-Id: <20201111111833.741937-2-joel@jms.id.au> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201111111833.741937-1-joel@jms.id.au> References: <20201111111833.741937-1-joel@jms.id.au> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean If CONFIG_FIT_CIPHER=y and CONFIG_FIT_SIGNATURE=n then mkimage and dumpimage will fail to link: /usr/bin/ld: tools/common/image-cipher.o: in function `fit_image_decrypt_data': image-cipher.c:(.text+0x9a): undefined reference to `image_get_host_blob' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x10): undefined reference to `EVP_aes_128_cbc' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x40): undefined reference to `EVP_aes_192_cbc' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x70): undefined reference to `EVP_aes_256_cbc' /usr/bin/ld: tools/lib/aes/aes-encrypt.o: in function `image_aes_encrypt': aes-encrypt.c:(.text+0x22): undefined reference to `EVP_CIPHER_CTX_new' /usr/bin/ld: aes-encrypt.c:(.text+0x6f): undefined reference to `EVP_EncryptInit_ex' /usr/bin/ld: aes-encrypt.c:(.text+0x8d): undefined reference to `EVP_EncryptUpdate' /usr/bin/ld: aes-encrypt.c:(.text+0xac): undefined reference to `EVP_CIPHER_CTX_free' /usr/bin/ld: aes-encrypt.c:(.text+0xf2): undefined reference to `EVP_EncryptFinal_ex' collect2: error: ld returned 1 exit status Signed-off-by: Joel Stanley --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0 Reviewed-by: Philippe Reynes diff --git a/tools/Makefile b/tools/Makefile index 51123fd92983..103b3ab8a7f2 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -154,7 +154,7 @@ HOSTCFLAGS_kwbimage.o += -DCONFIG_KWB_SECURE endif # MXSImage needs LibSSL -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_ARMADA_39X)$(CONFIG_FIT_SIGNATURE),) +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_ARMADA_39X)$(CONFIG_FIT_SIGNATURE)$(CONFIG_FIT_CIPHER),) HOSTCFLAGS_kwbimage.o += \ $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") HOSTLDLIBS_mkimage += \