From patchwork Wed Nov 9 03:37:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahisa Kojima X-Patchwork-Id: 622918 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp19282pvb; Tue, 8 Nov 2022 19:36:21 -0800 (PST) X-Google-Smtp-Source: AMsMyM5LOcEBW05JGb33czLM8V1yqc7bzP5D5KBnMuQ87k6CbpGK7CcC2WcKcBF35P1a5oQSn9g7 X-Received: by 2002:a05:6402:13d6:b0:461:b1b9:bed0 with SMTP id a22-20020a05640213d600b00461b1b9bed0mr1079812edx.122.1667964981631; Tue, 08 Nov 2022 19:36:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667964981; cv=none; d=google.com; s=arc-20160816; b=R2SxaTYhW5bIBfMf3Fte66TgPdS7jMgp7Gb696Ak0okDgSh5AEZrFK/TWUHCMNdyhH fIdCzm8yz/RCTHe8vAhzPQRvqV64lWSOX9uNQEznaTGARKRL1koQwRyPuAJh57cz3FBN 5HttvYpYKilblyXfdM753MSWHcyCJgRILRJLjjt6v+/dc8Ie36sozhilUAYs5Kl77Iw1 mwDjK+r28c+hjAC/NuWaSYmM3XkFMoUsRWyGX9ZVMVW8CYTPigrWXBORyC5uLqGp7UM2 HP76kYvZPVbsvxOr8M4j8ZQWNlzdS5WHCxEmBVifKrT6owhCNYzHuu9nkjocDQWzxW6g CSgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=pE903HxakBHXj9pxiGvbOZxjnU/ZFKD7OO3eVtHpiy0=; b=BBpX8wn6s6rLluaI5MNztmEYdkRv1ol+dHlq3LtxZ7REn5pltYj9Y4aYJbuNn9nfd2 83EEeL7690YGaY0brZ7X8+LzpMgGAn+HKnwiS4kJjkCP77wjIJQd2ijnV/kFtkXtvQQ5 NciYBDwaMHfm/DwzgZrN3m5lOXE4HGkrZe50oCTRc34PNwGQ/ZevL8QwkY+HmguAnpOX ihy/Rvb+rDEjGuOqHUkWXxl6E8R9B8ed8dZETDdSBKJyiFLHq8/fgZ9rpDCIsWjh/E3i Cialqb4xjTm0+aCIjUSj2Xk+154wOcESqObz5xqFF62kw9+p+a2uu4JvsJsFQ9g/CFFQ j1Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ls/dwJrZ"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id hd13-20020a170907968d00b007ae61d89b3esi13918265ejc.356.2022.11.08.19.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 19:36:21 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ls/dwJrZ"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 620F885045; Wed, 9 Nov 2022 04:36:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ls/dwJrZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 07F5B84FF9; Wed, 9 Nov 2022 04:35:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C9CA384EF6 for ; Wed, 9 Nov 2022 04:35:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=masahisa.kojima@linaro.org Received: by mail-pl1-x62a.google.com with SMTP id c2so15909877plz.11 for ; Tue, 08 Nov 2022 19:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=pE903HxakBHXj9pxiGvbOZxjnU/ZFKD7OO3eVtHpiy0=; b=ls/dwJrZCaKIPaICEp9Y3YqCmz+0ILuGm2uXiwmUaFVKD1Cgi6+r4G+EFFgODAIasP 7FZrKZgZK6Uvylj9dFDvojBfQ+OpIEbU5reBTbjEuJZ2Jwv6dbtgOck6R4u/B3Mkr464 cECcTIP0a71QqQpIUr6kDIk6v9ezrySSpPHbV+y+AG3NqMXjGcQKSfiSoqOUwIeD7shL WknPFUnP3cqQs3/NNJSnVvULMHzPJeDnZgDagM0d/yIYzZ+qp6jgrfk9FDyoqKK9YzCX 6AUoNBL4u3PFx/nFk3byBiiIfpiXc/TBk7KfwAW5b6c222xPWyYoq3emPPoZsjgir9Eb GaIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pE903HxakBHXj9pxiGvbOZxjnU/ZFKD7OO3eVtHpiy0=; b=yhfyLKzlu3TFFnAoDiGU0dU3L52TOPv4sQjUFA/if5kaWQ07dR+0/cq/3J4wsNlb5J LWd7cnGqeJQhRdtSTJu4B0QZLHhhgJM/pBDaUBez3U72+U8c5KZzWMPYA/jAA+ChQKZ+ uKHUzsCsVfP8mrEa/Wd6cVafIlSe9DzuU4+y8rFVUF583y9XRndTCAA2oUN7fNJnLkHJ u5AMdC9Jkuid3VTvTP+g5z45JZC/ZbkaHcs9S/9gnTXE3oAxL3ZSBP5DYETuvz6lWEKx vcZ+8MY9tFIvNO0VHiTWw6btinOqKJpzyZ+r8cPkhHqwsOtgFLwyrbw2Y/G/S8qpwmbZ y7vQ== X-Gm-Message-State: ACrzQf2faJgEQdvaeZnwBd4/yz0Tm0HJs9jDSG6nv+vBz7xpvD37pGJ5 Kh7nuiwrs+BfUM7xHDJPvv0Nnw== X-Received: by 2002:a17:902:e548:b0:186:f0d5:1ac2 with SMTP id n8-20020a170902e54800b00186f0d51ac2mr42400026plf.144.1667964951096; Tue, 08 Nov 2022 19:35:51 -0800 (PST) Received: from localhost.localdomain ([240d:1a:cf7:5800:82fa:5bff:fe4b:26b1]) by smtp.gmail.com with ESMTPSA id e17-20020a17090301d100b00177f25f8ab3sm7838370plh.89.2022.11.08.19.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 19:35:50 -0800 (PST) From: Masahisa Kojima To: kojima.masahisa@socionext.com, u-boot@lists.denx.de Cc: Heinrich Schuchardt , Ilias Apalodimas , Simon Glass , Takahiro Akashi , Etienne Carriere , Masahisa Kojima Subject: [PATCH v7 1/5] eficonfig: refactor file selection handling Date: Wed, 9 Nov 2022 12:37:24 +0900 Message-Id: <20221109033728.5623-2-masahisa.kojima@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221109033728.5623-1-masahisa.kojima@linaro.org> References: <20221109033728.5623-1-masahisa.kojima@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean eficonfig_select_file_handler() is commonly used to select the file. eficonfig_display_select_file_option() adds an additional menu to clear the selected file. eficonfig_display_select_file_option() is not always necessary for the file selection process, so it must be outside of eficonfig_select_file_handler(). This commit also renames the following functions to avoid confusion. eficonfig_select_file_handler() -> eficonfig_process_select_file() eficonfig_select_file() -> eficonfig_show_file_selection() eficonfig_display_select_file_option() -> eficonfig_process_show_file_option() Finally, test_eficonfig.py need to be updated to get aligned with the above modification. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- Changes in v7: - rename functio name to avoid confusion - remove unused function - update commit message newly created in v2 cmd/eficonfig.c | 37 ++++++------------- include/efi_config.h | 2 +- .../py/tests/test_eficonfig/test_eficonfig.py | 1 + 3 files changed, 13 insertions(+), 27 deletions(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 2595dd9563..571e2b9ac0 100644 --- a/cmd/eficonfig.c +++ b/cmd/eficonfig.c @@ -756,14 +756,14 @@ out: } /** - * eficonfig_select_file() - construct the file selection menu + * eficonfig_show_file_selection() - construct the file selection menu * * @file_info: pointer to the file selection structure * @root: pointer to the file handle * Return: status code */ -static efi_status_t eficonfig_select_file(struct eficonfig_select_file_info *file_info, - struct efi_file_handle *root) +static efi_status_t eficonfig_show_file_selection(struct eficonfig_select_file_info *file_info, + struct efi_file_handle *root) { u32 count = 0, i; efi_uintn_t len; @@ -938,17 +938,6 @@ static efi_status_t eficonfig_boot_edit_save(void *data) return EFI_SUCCESS; } -/** - * eficonfig_process_select_file() - callback function for "Select File" entry - * - * @data: pointer to the data - * Return: status code - */ -efi_status_t eficonfig_process_select_file(void *data) -{ - return EFI_SUCCESS; -} - /** * eficonfig_process_clear_file_selection() - callback function for "Clear" entry * @@ -973,19 +962,19 @@ static struct eficonfig_item select_file_menu_items[] = { {"Quit", eficonfig_process_quit}, }; - /** - * eficonfig_display_select_file_option() - display select file option + * eficonfig_process_show_file_option() - display select file option * * @file_info: pointer to the file information structure * Return: status code */ -efi_status_t eficonfig_display_select_file_option(struct eficonfig_select_file_info *file_info) +efi_status_t eficonfig_process_show_file_option(void *data) { efi_status_t ret; struct efimenu *efi_menu; - select_file_menu_items[1].data = file_info; + select_file_menu_items[0].data = data; + select_file_menu_items[1].data = data; efi_menu = eficonfig_create_fixed_menu(select_file_menu_items, ARRAY_SIZE(select_file_menu_items)); if (!efi_menu) @@ -1001,12 +990,12 @@ efi_status_t eficonfig_display_select_file_option(struct eficonfig_select_file_i } /** - * eficonfig_select_file_handler() - handle user file selection + * eficonfig_process_select_file() - handle user file selection * * @data: pointer to the data * Return: status code */ -efi_status_t eficonfig_select_file_handler(void *data) +efi_status_t eficonfig_process_select_file(void *data) { size_t len; efi_status_t ret; @@ -1016,10 +1005,6 @@ efi_status_t eficonfig_select_file_handler(void *data) struct eficonfig_select_file_info *tmp = NULL; struct eficonfig_select_file_info *file_info = data; - ret = eficonfig_display_select_file_option(file_info); - if (ret != EFI_SUCCESS) - return ret; - tmp = calloc(1, sizeof(struct eficonfig_select_file_info)); if (!tmp) return EFI_OUT_OF_RESOURCES; @@ -1046,7 +1031,7 @@ efi_status_t eficonfig_select_file_handler(void *data) if (ret != EFI_SUCCESS) goto out; - ret = eficonfig_select_file(tmp, root); + ret = eficonfig_show_file_selection(tmp, root); if (ret == EFI_ABORTED) continue; if (ret != EFI_SUCCESS) @@ -1284,7 +1269,7 @@ static efi_status_t prepare_file_selection_entry(struct efimenu *efi_menu, char utf8_utf16_strcpy(&p, devname); u16_strlcat(file_name, file_info->current_path, len); ret = create_boot_option_entry(efi_menu, title, file_name, - eficonfig_select_file_handler, file_info); + eficonfig_process_show_file_option, file_info); out: free(devname); free(file_name); diff --git a/include/efi_config.h b/include/efi_config.h index 098cac2115..cc6aa51393 100644 --- a/include/efi_config.h +++ b/include/efi_config.h @@ -89,7 +89,7 @@ void eficonfig_print_msg(char *msg); void eficonfig_destroy(struct efimenu *efi_menu); efi_status_t eficonfig_process_quit(void *data); efi_status_t eficonfig_process_common(struct efimenu *efi_menu, char *menu_header); -efi_status_t eficonfig_select_file_handler(void *data); +efi_status_t eficonfig_process_select_file(void *data); efi_status_t eficonfig_get_unused_bootoption(u16 *buf, efi_uintn_t buf_size, u32 *index); efi_status_t eficonfig_append_bootorder(u16 index); diff --git a/test/py/tests/test_eficonfig/test_eficonfig.py b/test/py/tests/test_eficonfig/test_eficonfig.py index 99606d9c4b..102bfd7541 100644 --- a/test/py/tests/test_eficonfig/test_eficonfig.py +++ b/test/py/tests/test_eficonfig/test_eficonfig.py @@ -349,6 +349,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data): press_up_down_enter_and_wait(0, 1, True, 'Quit') press_up_down_enter_and_wait(0, 0, True, 'No block device found!') press_escape_key(False) + press_escape_key(False) check_current_is_maintenance_menu() # Return to U-Boot console press_escape_key(True)