From patchwork Tue Jan 10 12:41:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 640842 Delivered-To: patch@linaro.org Received: by 2002:a17:522:f3c4:b0:4b4:3859:abed with SMTP id in4csp2669991pvb; Tue, 10 Jan 2023 04:42:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXu0nmqcDzHahWHE4tKT7w0l0esMQ2Hm5PNyIGLR33+OAXeMyk+jar/bWvzYabKHgRf25h6y X-Received: by 2002:a05:6808:1920:b0:35e:9662:b3bf with SMTP id bf32-20020a056808192000b0035e9662b3bfmr47421799oib.51.1673354522422; Tue, 10 Jan 2023 04:42:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673354522; cv=none; d=google.com; s=arc-20160816; b=QsLXaLCRvKQmXCb2AXP/s23QWPazjMpLBStRJldlFZYuULQwBF75jb0Suoqrfnk1VW ARm/zsCFZtz8BJaDFZprEXNhznj76CqHCwiacrb2iJduZQhd6NGs5EOoLrqW/Mew2OPA y1NFD2/LLYmysOo65KfprBlYGAPXE0tAkxH39bDLydtCOOvutbgie+8fh+I2gM4v8VFL 8aEifhG3nMOzZAJvnUMRr/HoiAWMGMJ2QNsf1XGnxyH0Wq3ZEFgf2zL6Q3nO7nzKVom1 7iyEogxEBEvFtSr5Yc9ZlDvmLIMKMD2igGu7u/eHWTywJZysRepHvH3rdnNEeAnqRa0H GkgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=fH8nSka0Ec0VpfMD7GJXqhN3h+AYBnWKHkyNtSzBEF+9L/jegcnKmbO1+nwObjs1Nf UcKrpy3jU+soKpvgN0zsHivWI9OUCI1yZjcqscncF6PsWfbasBroH/+fZjedWwWx3Ltb M7KlFKRXqJYKhf4kIRCCqBAQiDCVcWFTVJK6sVSskDR0OOPB9UfbdqG8ZuEkSqn7gLjT wzDDVmihXWQtsAdVgzzL02bsl03w58dln2U5gh0Ecuu7hu+l/2IF58DbxWP6h9bPY2xw 0CwOHcgkM4vDrh63XtTxsarRg3jaBa8luxDvnfcNFnE2JUpSOQbBcVtQAWnZ5IunQd2q UNlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Bjyn07/C"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id bm12-20020a056830374c00b0066dcd53156asi11051228otb.114.2023.01.10.04.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 04:42:02 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Bjyn07/C"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 18876853AC; Tue, 10 Jan 2023 13:42:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Bjyn07/C"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C77A98539D; Tue, 10 Jan 2023 13:41:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0391A8542B for ; Tue, 10 Jan 2023 13:41:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=loic.poulain@linaro.org Received: by mail-wr1-x434.google.com with SMTP id d17so11592041wrs.2 for ; Tue, 10 Jan 2023 04:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=Bjyn07/CWYvk4iVJvZES27FvjN7RCM+w3yi8k21PAieW9qd1q5S8MIfXBOYpIKZKV+ MQS9UsdODFkrXIg9AOPf3qA8T0T5dJM/SRHbpw1hHa0GMHcYjLOU84x2DoVoHRZbm8dw dxIOfDdCJH73d87py3qQaFA9b80akQV+a76043rYNTsjmeYQNdwo7J8CFaVc4bA6dWpZ HcLy36A8m9NpM1rgGyZXPnxOzoU5ag4f+MqEgjkGh7s3PRak2z2ecA5ycPUHn4AbMrya hMuhLyQVQq0ULEz41gP78OdyO+LlPlPlAQQXMO0Iu4QKtKIZimlzxUK9qZDYhQA+Z5uf TYMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=41Smz58RkhBlaumjHxjhrJknRoX9kuRPXVW5tXzq4erY6ChYOOS7t8lgbySovt58lD pgE/O3gOnAcs3LeTf0U19C9MFOf2PkYTNFG1nxId9Lv/aIdM4zeAfAZ6/xT7A5iuFQA2 Z5qII6a0m3HEq789tmTF9ULQAtyk5CrbANAwQXXjyvL8XZa9Tzi3NpXfuY4aeHcwsUdJ k+InU6+ukxZHqhAfPAyZkNMmvvG2liUeM5MsPEz9WTl8FsPvl/2PRGyIvbJVOj+3ynBA jvYQ9uZd8ed9th3nl3RB53MQMZhGRn92zBZgxeZmvqnFKyZI6LyEQ7wzvrAxtxEw1B6U Eo0g== X-Gm-Message-State: AFqh2ko9n0t5yU2zinMH7WvQXnl5+pfnt0UP9pnnJwBmtwLw3griaj5H NmpJspYFGg/4vewINnLLc29FvA== X-Received: by 2002:a05:6000:384:b0:297:175c:3cbd with SMTP id u4-20020a056000038400b00297175c3cbdmr28478134wrf.66.1673354511358; Tue, 10 Jan 2023 04:41:51 -0800 (PST) Received: from loic-ThinkPad-T470p.. ([2a01:e0a:82c:5f0:a2ad:457f:18a:ffcb]) by smtp.gmail.com with ESMTPSA id q11-20020adff50b000000b0027f9f073211sm11220112wro.65.2023.01.10.04.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 04:41:50 -0800 (PST) From: Loic Poulain To: sbabic@denx.de, festevam@gmail.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, LW@karo-electronics.de, Loic Poulain Subject: [PATCH v2 1/2] serial: mxc: Speed-up character transmission Date: Tue, 10 Jan 2023 13:41:46 +0100 Message-Id: <20230110124147.1780670-1-loic.poulain@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Instead of waiting for empty FIFO condition before writing a character, wait for non-full FIFO condition. This helps in saving several tens of milliseconds during boot (depending verbosity). Signed-off-by: Loic Poulain --- v2: Add 2/2 fixing transfert abort & char corruption drivers/serial/serial_mxc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 82c0d84628..f8c49865be 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -223,11 +223,11 @@ static void mxc_serial_putc(const char c) if (c == '\n') serial_putc('\r'); - writel(c, &mxc_base->txd); - /* wait for transmitter to be ready */ - while (!(readl(&mxc_base->ts) & UTS_TXEMPTY)) + while (readl(&mxc_base->ts) & UTS_TXFULL) schedule(); + + writel(c, &mxc_base->txd); } /* Test whether a character is in the RX buffer */ @@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch) struct mxc_serial_plat *plat = dev_get_plat(dev); struct mxc_uart *const uart = plat->reg; - if (!(readl(&uart->ts) & UTS_TXEMPTY)) + if (readl(&uart->ts) & UTS_TXFULL) return -EAGAIN; writel(ch, &uart->txd);