| Message ID | 20230805113458.1430239-7-sughosh.ganu@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Integrate EFI capsule tasks into u-boot's build flow | expand |
On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > Build the mkeficapsule tool for all the sandbox variants. This tool > will be used subsequently for testing capsule generation in binman. > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > --- > Changes since V6: > * New patch which has been split up from the binman capsule entry > support patch from earlier version, as suggested by Simon Glass. > * Enables mkeficapsule tool for all sandbox variants, instead of only > for sandbox_spl variant. > > tools/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org> At some point after this series is in, please take a look at why this tool isn't enabled for all builds.
On Sat, Aug 05, 2023 at 09:03:49AM -0600, Simon Glass wrote: > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > will be used subsequently for testing capsule generation in binman. > > > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > > --- > > Changes since V6: > > * New patch which has been split up from the binman capsule entry > > support patch from earlier version, as suggested by Simon Glass. > > * Enables mkeficapsule tool for all sandbox variants, instead of only > > for sandbox_spl variant. > > > > tools/Kconfig | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > At some point after this series is in, please take a look at why this > tool isn't enabled for all builds. The tool requires a bunch of stuff (see the rules in tools/Makefile).
Hi Tom, On Sat, 5 Aug 2023 at 16:15, Tom Rini <trini@konsulko.com> wrote: > > On Sat, Aug 05, 2023 at 09:03:49AM -0600, Simon Glass wrote: > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > > will be used subsequently for testing capsule generation in binman. > > > > > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > > > --- > > > Changes since V6: > > > * New patch which has been split up from the binman capsule entry > > > support patch from earlier version, as suggested by Simon Glass. > > > * Enables mkeficapsule tool for all sandbox variants, instead of only > > > for sandbox_spl variant. > > > > > > tools/Kconfig | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > > > At some point after this series is in, please take a look at why this > > tool isn't enabled for all builds. > > The tool requires a bunch of stuff (see the rules in tools/Makefile). Oh, I see. It requires uuid and gnutils Even so, would it be too bad to require those packages for building U-Boot? Regards, Simon
On Sat, Aug 05, 2023 at 08:04:43PM -0600, Simon Glass wrote: > Hi Tom, > > On Sat, 5 Aug 2023 at 16:15, Tom Rini <trini@konsulko.com> wrote: > > > > On Sat, Aug 05, 2023 at 09:03:49AM -0600, Simon Glass wrote: > > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > > > will be used subsequently for testing capsule generation in binman. > > > > > > > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > > > > --- > > > > Changes since V6: > > > > * New patch which has been split up from the binman capsule entry > > > > support patch from earlier version, as suggested by Simon Glass. > > > > * Enables mkeficapsule tool for all sandbox variants, instead of only > > > > for sandbox_spl variant. > > > > > > > > tools/Kconfig | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > > > > > At some point after this series is in, please take a look at why this > > > tool isn't enabled for all builds. > > > > The tool requires a bunch of stuff (see the rules in tools/Makefile). > > Oh, I see. It requires uuid and gnutils > > Even so, would it be too bad to require those packages for building U-Boot? We can always re-evaluate this later depending on the uptake of capsules. On the other hand we have a config for host tools only, for distros to use, and this isn't the only "sometimes" tool.
diff --git a/tools/Kconfig b/tools/Kconfig index 6e23f44d55..353a855243 100644 --- a/tools/Kconfig +++ b/tools/Kconfig @@ -91,10 +91,10 @@ config TOOLS_SHA512 Enable SHA512 support in the tools builds config TOOLS_MKEFICAPSULE - bool "Build efimkcapsule command" - default y if EFI_CAPSULE_ON_DISK + bool "Build mkeficapsule tool" + default y if EFI_CAPSULE_ON_DISK || SANDBOX help - This command allows users to create a UEFI capsule file and, + This tool allows users to create a UEFI capsule file and, optionally sign that file. If you want to enable UEFI capsule update feature on your target, you certainly need this.
Build the mkeficapsule tool for all the sandbox variants. This tool will be used subsequently for testing capsule generation in binman. Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> --- Changes since V6: * New patch which has been split up from the binman capsule entry support patch from earlier version, as suggested by Simon Glass. * Enables mkeficapsule tool for all sandbox variants, instead of only for sandbox_spl variant. tools/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)