From patchwork Thu Jul 4 07:35:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sughosh Ganu X-Patchwork-Id: 809935 Delivered-To: patch@linaro.org Received: by 2002:adf:a199:0:b0:367:895a:4699 with SMTP id u25csp1043411wru; Thu, 4 Jul 2024 00:41:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUXjxsmwa2Q6ai7JbqYWP3+9Ta6+lnUZyJVsXg6CjGxAT3gZSg2LymeylpPqkUHwfwKYTKD6pFDKCsJDz21oeZ3 X-Google-Smtp-Source: AGHT+IHIC0MAYzUGAwjpJyHrusCqYfZabcvxPsnX0zjt9tanXNCcJz61myedVRy48SgqgHrXlyzP X-Received: by 2002:a17:907:3d9f:b0:a6f:5318:b8f0 with SMTP id a640c23a62f3a-a77ba48df9dmr60701166b.37.1720078886518; Thu, 04 Jul 2024 00:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720078886; cv=none; d=google.com; s=arc-20160816; b=j/cj2CnhCo+kz1Y8H+U3DuUyjVQm3RJ3uWoDzv9VfEXTUuRviPvmRU02EmiF01UvJJ fLPiBoIE72v5TQnenowSvTJQoQJRw6SEFd0zSGvV6dvFNMwD7GYV65DMVtgVMLCPNJTx H9dl/C0s1HxN9KyuJHVeOZfDoVWKw9nJ043L3BgCLtU1KxMIBDVaIBsrPoNOOiFk6HcJ 39hrgEdppyvQJj/l8jfQ6PgRSr929Pp2cobdTZbV7LDNcghvcHmVqNYTdtiMHUwRoqF3 sGirrlV/B5PHfPRySaXqbTtxNSmHbVWxylpBrIfkKc47dUsyYO6bkfQBjVNOp2rekES0 CQKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=2hj2AD3uK8BlXbEZ4YLUE+sF2Qa8qCOBILdTeDLBPPs=; fh=ez1zzjhC0XWyqTp7tWutqrA/nFdALDnQKrnQnXYhk5Q=; b=OXbdOUrPz0Hz8oZtv5drA1lUwGGTVPYALabzLZtfQvM6uxwNhKRThLuCfXlh9Nhx3g jK4kTQQdjIVuYR15jAL/J8y5v71hKq4OPA+miKOnD0hcoRlqNgtuNAQylTF7sqDTa056 B5TvZqkOp5u5ozyMt36Q+rSa6QXe1CrWzbYDMXBH77yn0cebJTPHdfTfr400X8475ucq DGsMuxn4/AZlsq5BvS3kAtRC/WltnaGtwoha5EIBoXMyXxphArdMo6o3kZ2xCCvhyZW+ lNPX5BHpu/aBYNs/wDgy+A+CqpeCr3vuCzTDtoJk3tBTsp8U4v6NL8yukIHL8bqY0I0E b6LA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id a640c23a62f3a-a72aaef5ce6si702608966b.111.2024.07.04.00.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 00:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED9B58892A; Thu, 4 Jul 2024 09:37:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9867688939; Thu, 4 Jul 2024 09:37:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id A0536888C6 for ; Thu, 4 Jul 2024 09:37:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sughosh.ganu@linaro.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D6C6367; Thu, 4 Jul 2024 00:38:12 -0700 (PDT) Received: from a079122.blr.arm.com (a079122.arm.com [10.162.17.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A5353F762; Thu, 4 Jul 2024 00:37:43 -0700 (PDT) From: Sughosh Ganu To: u-boot@lists.denx.de Cc: Tom Rini , Ilias Apalodimas , Heinrich Schuchardt , Simon Glass , Marek Vasut , Mark Kettenis , Fabio Estevam , Michal Simek , Sughosh Ganu Subject: [RFC PATCH v2 28/48] test: cedit: use allocated address for reading file Date: Thu, 4 Jul 2024 13:05:24 +0530 Message-Id: <20240704073544.670249-29-sughosh.ganu@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240704073544.670249-1-sughosh.ganu@linaro.org> References: <20240704073544.670249-1-sughosh.ganu@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Instead of a randomly selected address, use an LMB allocated one for reading the file into memory. With the LMB map now being persistent and global, the address used for reading the file might be already allocated as non-overwritable, resulting in a failure. Get a valid address from LMB and then read the file to that address. Signed-off-by: Sughosh Ganu --- Changes since V1: * Free up the memory allocated once done with it. test/boot/cedit.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/boot/cedit.c b/test/boot/cedit.c index fd19da0a0c..923ddd1481 100644 --- a/test/boot/cedit.c +++ b/test/boot/cedit.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -61,7 +62,7 @@ static int cedit_fdt(struct unit_test_state *uts) struct video_priv *vid_priv; extern struct expo *cur_exp; struct scene_obj_menu *menu; - ulong addr = 0x1000; + ulong addr; struct ofprop prop; struct scene *scn; oftree tree; @@ -86,6 +87,8 @@ static int cedit_fdt(struct unit_test_state *uts) str = abuf_data(&tline->buf); strcpy(str, "my-machine"); + addr = lmb_alloc(1024, 1024); + ut_asserteq(!!addr, !0); ut_assertok(run_command("cedit write_fdt hostfs - settings.dtb", 0)); ut_assertok(run_commandf("load hostfs - %lx settings.dtb", addr)); ut_assert_nextlinen("1024 bytes read"); @@ -94,6 +97,7 @@ static int cedit_fdt(struct unit_test_state *uts) tree = oftree_from_fdt(fdt); node = ofnode_find_subnode(oftree_root(tree), CEDIT_NODE_NAME); ut_assert(ofnode_valid(node)); + lmb_free(addr, 1024); ut_asserteq(ID_CPU_SPEED_2, ofnode_read_u32_default(node, "cpu-speed", 0));