mbox series

[edk2,v2,0/2] ArmplatformPkg: clean up PL011 support library

Message ID 20171116174708.24964-1-ard.biesheuvel@linaro.org
Headers show
Series ArmplatformPkg: clean up PL011 support library | expand

Message

Ard Biesheuvel Nov. 16, 2017, 5:47 p.m. UTC
Clean up the PL011 UART support library, by moving it into the appropriate
place for libraries, and splitting the header file into an implementation
and an interface part.

Ard Biesheuvel (2):
  ArmPlatformPkg: reorganize PL011 code
  ArmVirtPkg: switch to new PL011UartLib implementation

 ArmPlatformPkg/ArmPlatformPkg.dec                                     |   3 +
 ArmPlatformPkg/Include/Library/PL011UartLib.h                         | 187 ++++++++
 ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c        |   5 +-
 ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h                       | 120 +++++
 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c                    | 474 ++++++++++++++++++++
 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf                  |  43 ++
 ArmVirtPkg/ArmVirt.dsc.inc                                            |   2 +-
 ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c |   5 +-
 ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.c      |   5 +-
 9 files changed, 834 insertions(+), 10 deletions(-)
 create mode 100644 ArmPlatformPkg/Include/Library/PL011UartLib.h
 create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h
 create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c
 create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Nov. 16, 2017, 6:41 p.m. UTC | #1
On Thu, Nov 16, 2017 at 05:47:06PM +0000, Ard Biesheuvel wrote:
> Clean up the PL011 UART support library, by moving it into the appropriate

> place for libraries, and splitting the header file into an implementation

> and an interface part.


For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> Ard Biesheuvel (2):

>   ArmPlatformPkg: reorganize PL011 code

>   ArmVirtPkg: switch to new PL011UartLib implementation

> 

>  ArmPlatformPkg/ArmPlatformPkg.dec                                     |   3 +

>  ArmPlatformPkg/Include/Library/PL011UartLib.h                         | 187 ++++++++

>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c        |   5 +-

>  ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h                       | 120 +++++

>  ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c                    | 474 ++++++++++++++++++++

>  ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf                  |  43 ++

>  ArmVirtPkg/ArmVirt.dsc.inc                                            |   2 +-

>  ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c |   5 +-

>  ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.c      |   5 +-

>  9 files changed, 834 insertions(+), 10 deletions(-)

>  create mode 100644 ArmPlatformPkg/Include/Library/PL011UartLib.h

>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h

>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c

>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf

> 

> -- 

> 2.11.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 17, 2017, 10:06 a.m. UTC | #2
On 16 November 2017 at 18:41, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Nov 16, 2017 at 05:47:06PM +0000, Ard Biesheuvel wrote:

>> Clean up the PL011 UART support library, by moving it into the appropriate

>> place for libraries, and splitting the header file into an implementation

>> and an interface part.

>

> For the series:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Pushed as

12156134fe82 ArmPlatformPkg: reorganize PL011 code
1195b8578764 ArmVirtPkg: switch to new PL011UartLib implementation

(with Laszlo's feedback incorporated)


>> Ard Biesheuvel (2):

>>   ArmPlatformPkg: reorganize PL011 code

>>   ArmVirtPkg: switch to new PL011UartLib implementation

>>

>>  ArmPlatformPkg/ArmPlatformPkg.dec                                     |   3 +

>>  ArmPlatformPkg/Include/Library/PL011UartLib.h                         | 187 ++++++++

>>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c        |   5 +-

>>  ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h                       | 120 +++++

>>  ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c                    | 474 ++++++++++++++++++++

>>  ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf                  |  43 ++

>>  ArmVirtPkg/ArmVirt.dsc.inc                                            |   2 +-

>>  ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c |   5 +-

>>  ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.c      |   5 +-

>>  9 files changed, 834 insertions(+), 10 deletions(-)

>>  create mode 100644 ArmPlatformPkg/Include/Library/PL011UartLib.h

>>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h

>>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c

>>  create mode 100644 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf

>>

>> --

>> 2.11.0

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel