From patchwork Wed Dec 12 10:33:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 153564 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1660865ljp; Wed, 12 Dec 2018 02:33:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/XHsFHULg33rqDvuyP0OPt4JX6U3kmPmkHrbX0F9GJDNZGVnqMkruiEFqAscVmHnUHVn9po X-Received: by 2002:a63:c846:: with SMTP id l6mr17692060pgi.78.1544610795556; Wed, 12 Dec 2018 02:33:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544610795; cv=none; d=google.com; s=arc-20160816; b=jkZ59dp/lfZpaU/Di7642SacQIeUnDC4f9Mjgt8mkgsrL5iVgl6QYIsCOZV7xCbs2H uCyodq9cFaps3+/ZODcLGCySLVTrIy5BlM0fqdRHN3Dp8POU3/D3LXAI2q1efqCC5P0u 4Sxa7Dfu2BeVsPV4FwqJjhOXx+Io2eltRWjIY16H9qadofYrrVf936UWfeAcFOwaD7Aj cCWex0MZo1WTM45GcPck3LPGJmcNfb742feIJ4vJ5BVegVXAyCM+fAl/3Z/K2oGBFaig zmjI3p4i3RxGsLJUK7DdguXOL1bkmiLWPAU9cSpsL5mhR6f/tmiaDQ9frokiNDWnyDwu N/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=n2CHiXpR3Qijp0XQsnnnmPOrKfJfTr8pOakBomfeQnk=; b=ByXM/8mjrH/zKMcdcvr38l4w39XKI21FCgBp8psHJYJSeioJl0R+OJkWujvuogS10t hNAKB3tsMRyMcev8GSG35PC1Pm4T8RqeJ6euwL094A/BxhiRjaq4epC590JMLBzQ2e1o LgPU62Nw3WOpVsBZSHeouq9iMatZ9ppWdhLvODV6mBb9fvGkkQxThuhdVFZCnR0l7NfQ Yy+t2Vpm0U6+0SKjMH6JkGdyD6XB8oyOGc4NWsn4aj0LheUJv4yXcgKJXm8BQkuXk90k Kev4opyY+rgW8ZLDHJMprpwgByoLJvZWlVxO6lmItSp0qKF0gXVls5ROKaAGqzWjcvFB NXPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=I6ww57Lb; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id t11si14073242plo.293.2018.12.12.02.33.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 02:33:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=I6ww57Lb; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D73EB2119C8A1; Wed, 12 Dec 2018 02:33:14 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8951E2119C89A for ; Wed, 12 Dec 2018 02:33:13 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c126so5339220wmh.0 for ; Wed, 12 Dec 2018 02:33:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i513wfbH3j76LpwJyFFDSQM+0c411CzdAYABUEix51U=; b=I6ww57LbO1F23Q1jlSCM0ixChT/N7IQaie71FgU2Xacz2yqIoCRIXVG94mkXOe32w8 CA85sYVpSGHLJ65WCtt6K+QomdcvZTGLf7L0nDmvN248zhTKdFaPKs4UXWMwt3YiCEZF b+KbC1dA05Mwlx9T1ZdNLO3DaFrkRXXSzS42A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i513wfbH3j76LpwJyFFDSQM+0c411CzdAYABUEix51U=; b=kpFyy7r/D0rrbd6g3L/NTHLDcejRw6rx/L5wqAkY4sd4zZ8d2zGnT7KC2mq8qaKYzq cKMMnJkCeDD155sZKcIMOPTWOARGYYbiya9Gh9iSJd0Q0gYdk6V/blTpVJv/V0IINkTI yqoVRCPojFeJg2Mmfu9rsl07X5vrV41vWzISOXHAVot8XMgnvgAb5aVrrxTzsmSYsusS W0tBqGbr1lNRJmarNww1K5fv7kzrszPP+0akjm/sr08oeJb2thSjpTb+Hgy4nyj2D+m5 9g9tTfYaGASrnDgo+z8I3vv6hRO4k9h+AOlEbejmNaI5BICQeJ8MoO7uoaNwwrG+Ng3z O+mA== X-Gm-Message-State: AA+aEWbxnRloN5+ehFIiW+5E2rnLq6qU2PUF9bFlo2CqLHuyMgCyWjRT A98j3Rt63FtjogMJRFvHfG6/e8v4IM+JBg== X-Received: by 2002:a1c:90d5:: with SMTP id s204mr5791366wmd.148.1544610791362; Wed, 12 Dec 2018 02:33:11 -0800 (PST) Received: from harold.home ([2a01:cb1d:112:6f00:1db:abd7:f798:3277]) by smtp.gmail.com with ESMTPSA id r69sm3132789wmd.4.2018.12.12.02.33.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 02:33:10 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 12 Dec 2018 11:33:05 +0100 Message-Id: <20181212103308.8099-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liming Gao , Michael D Kinney , Laszlo Ersek Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Building with Clang 3.5 for ARM may result in build breakage, due to the fact that it may emit non-adjacent movw/movt instructions pairs which cannot be relocated in PE/COFF. We pass -mno-movt in some places to work around a related issue in the relocatable PrePi in ArmVirtPkg, but we need to disable movw/movt entirely to really address this issue. So first, fix some breakage that results from building with -mlong-calls in the optimized BaseMemoryLib code (#1) Patch #2 switches to -mkernel, which disables movw/movt generation (and enabled -mlong-calls as a side effect) Patch #3 removes the now redundant, and incompatible command line overrides for the relocatable PrePi. Cc: Michael D Kinney Cc: Liming Gao Cc: Bob Feng Cc: Leif Lindholm Cc: Laszlo Ersek Ard Biesheuvel (3): MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- ArmVirtPkg/ArmVirtXen.dsc | 5 ----- BaseTools/Conf/tools_def.template | 2 +- MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ 7 files changed, 9 insertions(+), 11 deletions(-) -- 2.19.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm