From patchwork Mon Mar 7 10:42:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 63641 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1364830lbc; Mon, 7 Mar 2016 02:42:57 -0800 (PST) X-Received: by 10.98.65.206 with SMTP id g75mr31823768pfd.94.1457347377862; Mon, 07 Mar 2016 02:42:57 -0800 (PST) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id a17si30480pfj.20.2016.03.07.02.42.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2016 02:42:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B63CF1A1E75; Mon, 7 Mar 2016 02:43:09 -0800 (PST) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BD2D81A1E50 for ; Mon, 7 Mar 2016 02:43:08 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DE1A219CBCE; Mon, 7 Mar 2016 10:42:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u27AgsQa013817; Mon, 7 Mar 2016 05:42:55 -0500 From: Laszlo Ersek To: edk2-devel@ml01.01.org Date: Mon, 7 Mar 2016 11:42:51 +0100 Message-Id: <1457347371-18229-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: Fu Siyuan Subject: [edk2] [PATCH] NetworkPkg: HttpBootDxe: fix gcc build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Commit fa848a404894 ("NetworkPkg: Add URI configuration form to HTTP boot driver") causes the build to fail with gcc: > NetworkPkg/HttpBootDxe/HttpBootConfig.c: In function > 'HttpBootAddBootOption': > NetworkPkg/HttpBootDxe/HttpBootConfig.c:148:14: > error: passing argument 3 of 'GetVariable2' from incompatible pointer > type [-Werror] > ); > ^ > In file included from NetworkPkg/HttpBootDxe/HttpBootDxe.h:31:0, > from NetworkPkg/HttpBootDxe/HttpBootConfig.c:15: > MdePkg/Include/Library/UefiLib.h:708:1: note: expected 'void **' but > argument is of type 'CHAR16 **' > GetVariable2 ( > ^ > cc1: all warnings being treated as errors Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- NetworkPkg/HttpBootDxe/HttpBootConfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c index db14da06d5cb..597192349d6b 100644 --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c @@ -143,7 +143,7 @@ HttpBootAddBootOption ( Status = GetVariable2 ( L"BootOrder", &gEfiGlobalVariableGuid, - &CurrentOrder, + (VOID **)&CurrentOrder, &Length ); if (EFI_ERROR (Status) && Status != EFI_NOT_FOUND) {