From patchwork Mon Oct 16 18:03:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 115975 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3966686qgn; Mon, 16 Oct 2017 11:03:57 -0700 (PDT) X-Received: by 10.98.156.15 with SMTP id f15mr9205811pfe.35.1508177037187; Mon, 16 Oct 2017 11:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508177037; cv=none; d=google.com; s=arc-20160816; b=QN+R0z3DggEmAsOik5WEEeo8/DG9tI/i4uLj2SLs2Mbc3LyYscJRZRxdWrkICgO48y VQvHBxxMLbQyKoiWzdM8JjVSnUvYT3yBT2fkLTVbawU41Yjb/fGarrUnM1PRYV0IX9RD P/+JzHVOfyw8tjSY0xrX0t285zR0LoNFulcxn3sYM8p+GhWVB6ex91FoOSxwH2eHT0Dm Ei5d8ssi1TaKN8Y0JkjNZY8r7t4WXbQo1WYlaBEFu6gYQTa6WYwnuQF/vdAU6pQYOi0m PPDenrHkX7cwgc00vIn9TifzSKwYaushxhuI+wJcWHojoNnBB86x1bdTpWAtu29eQ1y6 wBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=dDuOIsMOscFzfosrIbz9OmyiPmq6D5x7Zs4yqASK/Lo=; b=FlWgMt696A5gx98mJc5pHSt2JNZXrgTSnKMo+XivJ18vwvA+8XN4V/zkTMZPzihpw/ G2uKQyyb1hhGG6f94/xFVI5zi/TRzU0aEjX9LNkhAQnoU48EQ/wsVsp1agaoY+eF3Ooa QRnpVsztuOB2v5z7h+eMGnrTGwSMWs6sqbOCgXvujW940U9zqbJrAf80LMKnWlln8f/C rSM4+vLRjQm51DEnAAhV275nSxJpudzjS/54rqAAN+JRTd8XMDMR3MSs5Wr7OGSlGtcF cwWvq1GuZYm+uqZhl3Ql9Ua1aUDX9Ap3va2hjTAqzHQaqblQL4cnzapsvDoAgGX2ifHj Oc6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AbOYqz73; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id b1si4876027pld.656.2017.10.16.11.03.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 11:03:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AbOYqz73; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C89D6202E6173; Mon, 16 Oct 2017 11:00:20 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22f; helo=mail-wm0-x22f.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7114202E6152 for ; Mon, 16 Oct 2017 11:00:19 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id k4so5713307wmc.1 for ; Mon, 16 Oct 2017 11:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=reiXY8M7maJQK+TKfO2Wg+sdWKzODiPnwz/knkPl034=; b=AbOYqz73OTKJOOPV6/9rnHXFkzOJzYCyH5aQqyVy5f3VamnMoAwpIErKeLF/N8edoz JiFCEjynxg+Qv04734mrl+Pb4D+ZNl74mHLZ/kRHqtyRFZETCxy/GFz4sJi0fJGrBAA9 XybPvznQaZSefLrXnATgaZdlltLe5vWRwRc8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=reiXY8M7maJQK+TKfO2Wg+sdWKzODiPnwz/knkPl034=; b=kdCfC1o/52W69cLSIoV4TGna7a5l3Ta7nfh9W02qFRitl9tCu9s8wxNsq9ykG5/Zz4 leXZ66BPqDniFO0bDgZkEM93IlC1ic0DvZ6MjFRg1povvcwqCXia9++yCcqOp9cGnu0s +s4o5UIzSHjjrkVga1U2EcYA7jGrQhbkFEWHkMgLnnwyTu7waDiQcQUxzBoA0ExJl/W8 nN944y6wrDOGhPqCArfdFEXRgxklXIGPovDfBvpIrKIpwTW21G3GeP94JaeKJmzickK8 6czy7b4QwQjK+dh8pyMJCtmeJgvrZwqYmwFLJ7glATuS/vNmP2/PGnuQNG5f9qiPTZLm tfDA== X-Gm-Message-State: AMCzsaWMcsF32jty3VWG51E7q625K7ajl397pCnyX0b4lz38I19dGBWN 6l5+K5VSxhCViVkkElm075ZWi2HAwUQ= X-Google-Smtp-Source: ABhQp+THXGEYjm/qWCNf7DjofVlk1LDmLxCLHdX9H6yadMtqmfaeg9vVgiWFYgk/O2tlc4OpMdJhFg== X-Received: by 10.28.24.134 with SMTP id 128mr1659976wmy.61.1508177033122; Mon, 16 Oct 2017 11:03:53 -0700 (PDT) Received: from localhost.localdomain ([154.144.50.139]) by smtp.gmail.com with ESMTPSA id p128sm6687980wmb.1.2017.10.16.11.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 11:03:52 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org Date: Mon, 16 Oct 2017 19:03:47 +0100 Message-Id: <20171016180347.22930-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [edk2] [PATCH edk2-platforms] Platform/ARM: remove ReportStatusCodeLib resolutions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , sudeep.holla@arm.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The generic ResetSystemRuntimeDxe may invoke ReportStatusCodeLib, and this may happen at runtime. If the chosen resolution is not suitable for runtime, this will result in a crash. Given that we don't actually use status codes, let's just switch to the NULL instance for all modules and be done with it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Tested-by: Sudeep Holla diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc index 8bcb84869c84..b758c58c9872 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc @@ -153,7 +153,7 @@ CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf + ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf [LibraryClasses.common.SEC] ArmPlatformSecExtraActionLib|ArmPlatformPkg/Library/DebugSecExtraActionLib/DebugSecExtraActionLib.inf @@ -182,7 +182,6 @@ MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf - OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf @@ -195,7 +194,6 @@ MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf - OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf @@ -358,8 +356,6 @@ # DEBUG_ERROR 0x80000000 // Error gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F - gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 - gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000