diff mbox series

[edk2,edk2-platforms,v1,21/38] Silicon/Hisilicon/D0x: Move macro definition to PlatformArch.h

Message ID 20180724070922.63362-22-ming.huang@linaro.org
State New
Headers show
Series Upload for D06 platform | expand

Commit Message

Ming Huang July 24, 2018, 7:09 a.m. UTC 
From: Sun Yuanchen <sunyuanchen@huawei.com>


Unify MemorySubClassDxe by Moving macro definition
to PlatformArch.h

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sun Yuanchen <sunyuanchen@huawei.com>

Signed-off-by: Ming Huang <ming.huang@linaro.org>

Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

---
 Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h | 2 --
 Silicon/Hisilicon/Hi1610/Include/PlatformArch.h                     | 1 +
 Silicon/Hisilicon/Hi1616/Include/PlatformArch.h                     | 1 +
 Silicon/Hisilicon/Hi1620/Include/PlatformArch.h                     | 1 +
 4 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 3, 2018, 1:44 p.m. UTC | #1 
On Tue, Jul 24, 2018 at 03:09:05PM +0800, Ming Huang wrote:
> From: Sun Yuanchen <sunyuanchen@huawei.com>

> 

> Unify MemorySubClassDxe by Moving macro definition

> to PlatformArch.h

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Sun Yuanchen <sunyuanchen@huawei.com>

> Signed-off-by: Ming Huang <ming.huang@linaro.org>

> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

(If you drop the extra Signed-off-by:s)

/
    Leif

> ---

>  Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h | 2 --

>  Silicon/Hisilicon/Hi1610/Include/PlatformArch.h                     | 1 +

>  Silicon/Hisilicon/Hi1616/Include/PlatformArch.h                     | 1 +

>  Silicon/Hisilicon/Hi1620/Include/PlatformArch.h                     | 1 +

>  4 files changed, 3 insertions(+), 2 deletions(-)

> 

> diff --git a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h

> index c35ce39d61..0c201b4870 100644

> --- a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h

> +++ b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h

> @@ -44,8 +44,6 @@

>  

>  extern UINT8 MemorySubClassStrings[];

>  

> -#define MAX_DIMM_SIZE       32  // In GB

> -

>  struct SPD_JEDEC_MANUFACTURER

>  {

>      UINT8  MfgIdLSB;

> diff --git a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h

> index 03e96cfd31..4843b60536 100644

> --- a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h

> +++ b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h

> @@ -26,6 +26,7 @@

>  #define MAX_DIMM        3

>  #define MAX_RANK_CH     12

>  #define MAX_RANK_DIMM   4

> +#define MAX_DIMM_SIZE   32  // In GB

>  // Max NUMA node number for each node type

>  #define MAX_NUM_PER_TYPE 8

>  

> diff --git a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h

> index 14e9b483af..49618f6559 100644

> --- a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h

> +++ b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h

> @@ -26,6 +26,7 @@

>  #define MAX_DIMM        3

>  #define MAX_RANK_CH     12

>  #define MAX_RANK_DIMM   4

> +#define MAX_DIMM_SIZE   32  // In GB

>  // Max NUMA node number for each node type

>  #define MAX_NUM_PER_TYPE 8

>  

> diff --git a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h

> index ac90e9dfb5..2626751a0d 100644

> --- a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h

> +++ b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h

> @@ -26,6 +26,7 @@

>  #define MAX_DIMM        2

>  #define MAX_RANK_CH     8

>  #define MAX_RANK_DIMM   4

> +#define MAX_DIMM_SIZE   256  // In GB

>  // Max NUMA node number for each node type

>  #define MAX_NUM_PER_TYPE 8

>  

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h
index c35ce39d61..0c201b4870 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h
+++ b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h
@@ -44,8 +44,6 @@ 
 
 extern UINT8 MemorySubClassStrings[];
 
-#define MAX_DIMM_SIZE       32  // In GB
-
 struct SPD_JEDEC_MANUFACTURER
 {
     UINT8  MfgIdLSB;
diff --git a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h
index 03e96cfd31..4843b60536 100644
--- a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h
+++ b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h
@@ -26,6 +26,7 @@ 
 #define MAX_DIMM        3
 #define MAX_RANK_CH     12
 #define MAX_RANK_DIMM   4
+#define MAX_DIMM_SIZE   32  // In GB
 // Max NUMA node number for each node type
 #define MAX_NUM_PER_TYPE 8
 
diff --git a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h
index 14e9b483af..49618f6559 100644
--- a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h
+++ b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h
@@ -26,6 +26,7 @@ 
 #define MAX_DIMM        3
 #define MAX_RANK_CH     12
 #define MAX_RANK_DIMM   4
+#define MAX_DIMM_SIZE   32  // In GB
 // Max NUMA node number for each node type
 #define MAX_NUM_PER_TYPE 8
 
diff --git a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h
index ac90e9dfb5..2626751a0d 100644
--- a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h
+++ b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h
@@ -26,6 +26,7 @@ 
 #define MAX_DIMM        2
 #define MAX_RANK_CH     8
 #define MAX_RANK_DIMM   4
+#define MAX_DIMM_SIZE   256  // In GB
 // Max NUMA node number for each node type
 #define MAX_NUM_PER_TYPE 8