diff mbox series

[edk2,edk2-platforms,v1,06/38] Hisilicon/D06: Add OemMiscLibD06

Message ID 20180724070922.63362-7-ming.huang@linaro.org
State New
Headers show
Series Upload for D06 platform | expand

Commit Message

Ming Huang July 24, 2018, 7:08 a.m. UTC
This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
use for several modules like PciHostBridgeLib and Smbios.
Enlarge macro PCIEDEVICE_REPORT_MAX for D06.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

---
 Platform/Hisilicon/D06/D06.dsc                                          |   1 +
 Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c          | 432 ++++++++++++++++++++
 Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni | Bin 0 -> 5204 bytes
 Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c            | 157 +++++++
 Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf          |  47 +++
 Silicon/Hisilicon/Include/Library/OemMiscLib.h                          |   2 +-
 6 files changed, 638 insertions(+), 1 deletion(-)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 2, 2018, 5:22 p.m. UTC | #1
On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote:
> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,

> use for several modules like PciHostBridgeLib and Smbios.

> Enlarge macro PCIEDEVICE_REPORT_MAX for D06.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <ming.huang@linaro.org>

> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

> ---

>  Platform/Hisilicon/D06/D06.dsc                                          |   1 +

>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c          | 432 ++++++++++++++++++++

>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni | Bin 0 -> 5204 bytes


We appear to be permitting UTF-8 these days, which would be easier to
review. Would you be able to convert this for the next revision?

>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c            | 157 +++++++

>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf          |  47 +++

>  Silicon/Hisilicon/Include/Library/OemMiscLib.h                          |   2 +-

>  6 files changed, 638 insertions(+), 1 deletion(-)

> 

> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc

> index 88869ba26e..f4dfef1087 100644

> --- a/Platform/Hisilicon/D06/D06.dsc

> +++ b/Platform/Hisilicon/D06/D06.dsc

> @@ -71,6 +71,7 @@

>  

>    TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf

>    RealTimeClockLib|Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf

> +  OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf

>    OemAddressMapLib|Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.inf

>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf

>  

> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c

> new file mode 100644

> index 0000000000..c8f6cd0e29

> --- /dev/null

> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c

> @@ -0,0 +1,432 @@

> +/** @file

> +*

> +*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.

> +*  Copyright (c) 2018, Linaro Limited. All rights reserved.

> +*

> +*  This program and the accompanying materials

> +*  are licensed and made available under the terms and conditions of the BSD License

> +*  which accompanies this distribution.  The full text of the license may be found at

> +*  http://opensource.org/licenses/bsd-license.php

> +*

> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +*

> +**/

> +

> +#include <Uefi.h>

> +#include <IndustryStandard/SmBios.h>

> +#include <Library/BaseMemoryLib.h>

> +#include <Library/DebugLib.h>

> +#include <Library/HiiLib.h>

> +#include <Library/I2CLib.h>

> +#include <Library/IoLib.h>

> +#include <Library/OemMiscLib.h>

> +#include <Library/SerdesLib.h>

> +#include <Protocol/Smbios.h>

> +

> +#include <PlatformArch.h>

> +

> +I2C_DEVICE gDS3231RtcDevice = {


*cough* *cough*

> +  .Socket = 0,

> +  .Port = 5,

> +  .DeviceType = DEVICE_TYPE_SPD,

> +  .SlaveDeviceAddress = 0x68

> +};

> +

> +SERDES_POLARITY_INVERT gSerdesPolarityTxDesc[] =

> +{

> +  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}

> +};

> +

> +SERDES_POLARITY_INVERT gSerdesPolarityRxDesc[] =

> +{

> +  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}

> +};

> +

> +SERDES_PARAM gSerdesParamNA = {

> +  .Hilink0Mode = EmHilink0Hccs1X8Width16,

> +  .Hilink1Mode = EmHilink1Hccs0X8Width16,

> +  .Hilink2Mode = EmHilink2Pcie2X8,

> +  .Hilink3Mode = 0x0,

> +  .Hilink4Mode = 0xF,

> +  .Hilink5Mode = EmHilink5Sas1X4,

> +  .Hilink6Mode = 0x0,

> +  .UseSsc      = 0,

> +};

> +

> +SERDES_PARAM gSerdesParamNB = {

> +  .Hilink0Mode = EmHilink0Pcie1X8,

> +  .Hilink1Mode = EmHilink1Pcie0X8,

> +  .Hilink2Mode = EmHilink2Sas0X8,

> +  .Hilink3Mode = 0x0,

> +  .Hilink4Mode = 0xF,

> +  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,

> +  .Hilink6Mode = 0xF,

> +  .UseSsc      = 0,

> +};

> +

> +SERDES_PARAM gSerdesParamS1NA = {

> +  .Hilink0Mode = EmHilink0Hccs1X8Width16,

> +  .Hilink1Mode = EmHilink1Hccs0X8Width16,

> +  .Hilink2Mode = EmHilink2Pcie2X8,

> +  .Hilink3Mode = 0x0,

> +  .Hilink4Mode = 0xF,

> +  .Hilink5Mode = EmHilink5Sas1X4,

> +  .Hilink6Mode = 0x0,

> +  .UseSsc      = 0,

> +};

> +

> +SERDES_PARAM gSerdesParamS1NB = {

> +  .Hilink0Mode = EmHilink0Pcie1X8,

> +  .Hilink1Mode = EmHilink1Pcie0X8,

> +  .Hilink2Mode = EmHilink2Sas0X8,

> +  .Hilink3Mode = 0x0,

> +  .Hilink4Mode = 0xF,

> +  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,

> +  .Hilink6Mode = 0xF,

> +  .UseSsc      = 0,

> +};

> +

> +

> +EFI_STATUS

> +OemGetSerdesParam (

> +  OUT SERDES_PARAM *ParamA,

> +  OUT SERDES_PARAM *ParamB,

> +  IN  UINT32       SocketId

> + )

> +{

> +  if (NULL == ParamA) {

> +    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));

> +    return EFI_INVALID_PARAMETER;

> +  } if (NULL == ParamB) {

> +    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));

> +    return EFI_INVALID_PARAMETER;

> +  }

> +

> +  if (0 == SocketId) {

> +    (VOID) CopyMem (ParamA, &gSerdesParamNA, sizeof (*ParamA));

> +    (VOID) CopyMem (ParamB, &gSerdesParamNB, sizeof (*ParamB));

> +  } else {

> +    (VOID) CopyMem (ParamA, &gSerdesParamS1NA, sizeof (*ParamA));

> +    (VOID) CopyMem (ParamB, &gSerdesParamS1NB, sizeof (*ParamB));

> +  }

> +

> +  return EFI_SUCCESS;

> +}

> +

> +VOID

> +OemPcieResetAndOffReset (

> +  VOID

> +  )

> +{

> +  return;

> +}

> +

> +SMBIOS_TABLE_TYPE9 gPcieSlotInfo[] = {

> +  // PCIe0 Slot 1

> +  {

> +    {                                       // Hdr

> +        EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +        0,                                  // Length,

> +        0                                   // Handle

> +    },

> +    1,                                      // SlotDesignation

> +    SlotTypePciExpressX16,                  // SlotType

> +    SlotDataBusWidth16X,                    // SlotDataBusWidth

> +    SlotUsageAvailable,                     // SlotUsage

> +    SlotLengthOther,                        // SlotLength

> +    0x0001,                                 // SlotId

> +    {                                       // SlotCharacteristics1

> +        0,                                  // CharacteristicsUnknown  :1;

> +        0,                                  // Provides50Volts         :1;

> +        0,                                  // Provides33Volts         :1;

> +        0,                                  // SharedSlot              :1;

> +        0,                                  // PcCard16Supported       :1;

> +        0,                                  // CardBusSupported        :1;

> +        0,                                  // ZoomVideoSupported      :1;

> +        0                                   // ModemRingResumeSupported:1;

> +    },

> +    {                                       // SlotCharacteristics2

> +        0,                                  // PmeSignalSupported      :1;

> +        0,                                  // HotPlugDevicesSupported  :1;


Alignment of that :1.

> +        0,                                  // SmbusSignalSupported    :1;

> +        0                                   // Reserved                :5;

> +    },

> +    0x00,                                   // SegmentGroupNum

> +    0x00,                                   // BusNum

> +    0                                       // DevFuncNum

> +  },

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0002,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;


Alignment of that :1.

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0003,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;


Alignment of that :1.

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +

> +

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0004,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;


Alignment of that :1.

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX16,                  // SlotType

> +      SlotDataBusWidth16X,                    // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0005,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;


Alignment of that :1.
(I'm going to stop now. Please address for all instances.)

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0006,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0007,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +  {

> +      {                                       // Hdr

> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,

> +          0,                                  // Length,

> +          0                                   // Handle

> +      },

> +      1,                                      // SlotDesignation

> +      SlotTypePciExpressX8,                   // SlotType

> +      SlotDataBusWidth8X,                     // SlotDataBusWidth

> +      SlotUsageAvailable,                     // SlotUsage

> +      SlotLengthOther,                        // SlotLength

> +      0x0008,                                 // SlotId

> +      {                                       // SlotCharacteristics1

> +          0,                                  // CharacteristicsUnknown  :1;

> +          0,                                  // Provides50Volts         :1;

> +          0,                                  // Provides33Volts         :1;

> +          0,                                  // SharedSlot              :1;

> +          0,                                  // PcCard16Supported       :1;

> +          0,                                  // CardBusSupported        :1;

> +          0,                                  // ZoomVideoSupported      :1;

> +          0                                   // ModemRingResumeSupported:1;

> +      },

> +      {                                       // SlotCharacteristics2

> +          0,                                  // PmeSignalSupported      :1;

> +          0,                                  // HotPlugDevicesSupported  :1;

> +          0,                                  // SmbusSignalSupported    :1;

> +          0                                   // Reserved                :5;

> +      },

> +      0x00,                                   // SegmentGroupNum

> +      0x00,                                   // BusNum

> +      0                                       // DevFuncNum

> +  },

> +

> +  };

> +

> +UINT8

> +OemGetPcieSlotNumber (

> +  VOID

> +  )

> +{

> +  return sizeof (gPcieSlotInfo) / sizeof (SMBIOS_TABLE_TYPE9);

> +}

> +

> +EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM] = {

> +  {{STRING_TOKEN(STR_LEMON_C10_DIMM_000), STRING_TOKEN(STR_LEMON_C10_DIMM_001)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_010), STRING_TOKEN(STR_LEMON_C10_DIMM_011)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_020), STRING_TOKEN(STR_LEMON_C10_DIMM_021)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_030), STRING_TOKEN(STR_LEMON_C10_DIMM_031)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_040), STRING_TOKEN(STR_LEMON_C10_DIMM_041)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_050), STRING_TOKEN(STR_LEMON_C10_DIMM_051)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_060), STRING_TOKEN(STR_LEMON_C10_DIMM_061)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_070), STRING_TOKEN(STR_LEMON_C10_DIMM_071)}},

> +

> +  {{STRING_TOKEN(STR_LEMON_C10_DIMM_100), STRING_TOKEN(STR_LEMON_C10_DIMM_101)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_110), STRING_TOKEN(STR_LEMON_C10_DIMM_111)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_120), STRING_TOKEN(STR_LEMON_C10_DIMM_121)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_130), STRING_TOKEN(STR_LEMON_C10_DIMM_131)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_140), STRING_TOKEN(STR_LEMON_C10_DIMM_141)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_150), STRING_TOKEN(STR_LEMON_C10_DIMM_151)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_160), STRING_TOKEN(STR_LEMON_C10_DIMM_161)},

> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_170), STRING_TOKEN(STR_LEMON_C10_DIMM_171)}}

> +};

> +

> +EFI_HII_HANDLE

> +EFIAPI

> +OemGetPackages (

> +  VOID

> +  )

> +{

> +  return HiiAddPackages (

> +           &gEfiCallerIdGuid,

> +           NULL,

> +           OemMiscLibStrings,

> +           NULL,

> +           NULL

> +           );

> +}

> +

> +

> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni

> new file mode 100644

> index 0000000000..f3994d9d4d

> Binary files /dev/null and b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni differ

> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c

> new file mode 100644

> index 0000000000..009a53b2c8

> --- /dev/null

> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c

> @@ -0,0 +1,157 @@

> +/** @file

> +*

> +*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.

> +*  Copyright (c) 2018, Linaro Limited. All rights reserved.

> +*

> +*  This program and the accompanying materials

> +*  are licensed and made available under the terms and conditions of the BSD License

> +*  which accompanies this distribution.  The full text of the license may be found at

> +*  http://opensource.org/licenses/bsd-license.php

> +*

> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +*

> +**/

> +

> +#include <Uefi.h>

> +#include <PlatformArch.h>

> +#include <Library/DebugLib.h>

> +#include <Library/IoLib.h>

> +#include <Library/LpcLib.h>

> +#include <Library/OemAddressMapLib.h>

> +#include <Library/OemMiscLib.h>

> +#include <Library/PcdLib.h>

> +#include <Library/PlatformSysCtrlLib.h>

> +#include <Library/SerdesLib.h>

> +#include <Library/SerialPortLib.h>

> +#include <Library/TimerLib.h>

> +

> +REPORT_PCIEDIDVID2BMC PcieDeviceToReport[PCIEDEVICE_REPORT_MAX] = {

> +  {67,0,0,0},

> +  {225,0,0,3},

> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF},

> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF}

> +};

> +

> +// Right now we only support 1P

> +BOOLEAN

> +OemIsSocketPresent (

> +  UINTN Socket

> +  )

> +{

> +  UINT32 SocketMask = PcdGet32 (PcdSocketMask);

> +  return (BOOLEAN)((SocketMask & (1 << Socket)) ? TRUE : FALSE);

> +}

> +

> +

> +UINTN

> +OemGetSocketNumber (

> +  VOID

> +  )

> +{

> +  if(!OemIsMpBoot ()) {

> +    return 1;

> +  }

> +

> +  return 2;


What is 2?
(Guessing NUMBER_PROCESSOR_SOCKETS.)

> +}

> +

> +

> +UINTN

> +OemGetDdrChannel (

> +  VOID

> +  )

> +{

> +  return 8;


What is 8?
(Guessing NUMBER_MEMORY_CHANNELS.)

> +}

> +

> +

> +UINTN

> +OemGetDimmSlot (

> +  UINTN Socket,

> +  UINTN Channel

> +  )

> +{

> +  return 2;


What is 2?
(Guessing SLOTS_PER_DDR_CHANNEL.)

> +}

> +

> +

> +// Nothing to do for EVB

> +VOID

> +OemPostEndIndicator (

> +  VOID

> +  )

> +{

> +  DEBUG ((DEBUG_ERROR,"M3 release reset CONFIG........."));


DEBUG_INFO.

> +

> +  MmioWrite32 (0xd0002180, 0x3);

> +  MmioWrite32 (0xd0002194, 0xa4);

> +  MmioWrite32 (0xd0000a54, 0x1);


Please create some #defines for those addresses, and those values.

> +

> +  MicroSecondDelay (10000);


Why 10000?
Is a MemoryFence () needed?

> +

> +  MmioWrite32 (0xd0002108, 0x1);

> +  MmioWrite32 (0xd0002114, 0x1);

> +  MmioWrite32 (0xd0002120, 0x1);

> +  MmioWrite32 (0xd0003108, 0x1);


Please create some #defines for those addresses, and those values.

> +

> +  MicroSecondDelay (500000);


Why 500000?
Is a MemoryFence () needed?

> +  DEBUG ((DEBUG_ERROR, "Done\n"));


DEBUG_INFO.

> +}

> +

> +

> +

> +VOID

> +CoreSelectBoot (

> +  VOID

> +  )

> +{

> +  if (!PcdGet64 (PcdTrustedFirmwareEnable))

> +  {

> +    StartupAp ();

> +  }

> +

> +  return;

> +}

> +

> +BOOLEAN

> +OemIsMpBoot (

> +  VOID

> +  )

> +{

> +  return PcdGet32 (PcdIsMPBoot);

> +}

> +

> +VOID

> +OemLpcInit (

> +  VOID

> +  )

> +{

> +  LpcInit ();

> +  return;

> +}

> +

> +UINT32

> +OemIsWarmBoot (

> +  VOID

> +  )

> +{

> +  return 0;

> +}

> +

> +VOID

> +OemBiosSwitch (

> +  UINT32 Master

> +  )

> +{

> +  (VOID)Master;

> +  return;

> +}

> +

> +BOOLEAN

> +OemIsNeedDisableExpanderBuffer (

> +  VOID

> +  )

> +{

> +  return TRUE;

> +}

> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf

> new file mode 100644

> index 0000000000..acb7366078

> --- /dev/null

> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf

> @@ -0,0 +1,47 @@

> +#/** @file

> +#

> +#    Copyright (c) 2018, Hisilicon Limited. All rights reserved.

> +#    Copyright (c) 2018, Linaro Limited. All rights reserved.

> +#

> +#    This program and the accompanying materials

> +#    are licensed and made available under the terms and conditions of the BSD License

> +#    which accompanies this distribution. The full text of the license may be found at

> +#    http://opensource.org/licenses/bsd-license.php

> +#

> +#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +#

> +#**/

> +

> +[Defines]

> +  INF_VERSION                    = 0x0001001A

> +  BASE_NAME                      = OemMiscLib

> +  FILE_GUID                      = 3002911C-C160-4C46-93BB-782846673EEA

> +  MODULE_TYPE                    = BASE

> +  VERSION_STRING                 = 1.0

> +  LIBRARY_CLASS                  = OemMiscLib

> +

> +[Sources.common]

> +  BoardFeatureD06.c

> +  OemMiscLibD06.c

> +  BoardFeatureD06Strings.uni


Please sort files alphabetically.

> +

> +[Packages]

> +  ArmPkg/ArmPkg.dec

> +  MdeModulePkg/MdeModulePkg.dec

> +  MdePkg/MdePkg.dec

> +  Silicon/Hisilicon/HisiPkg.dec

> +

> +[LibraryClasses]

> +  PcdLib

> +  TimerLib

> +  SerdesLib


Please sort Libraries alphabetically.

> +

> +[Ppis]

> +  gEfiPeiReadOnlyVariable2PpiGuid   ## SOMETIMES_CONSUMES

> +

> +[Pcd]

> +  gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable

> +  gHisiTokenSpaceGuid.PcdSocketMask

> +  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz

> +  gHisiTokenSpaceGuid.PcdIsMPBoot


Please sort Pcds alphabetically (where there is not a more logical
grouping).

> diff --git a/Silicon/Hisilicon/Include/Library/OemMiscLib.h b/Silicon/Hisilicon/Include/Library/OemMiscLib.h

> index 6f18c0fa72..53e7a37a68 100644

> --- a/Silicon/Hisilicon/Include/Library/OemMiscLib.h

> +++ b/Silicon/Hisilicon/Include/Library/OemMiscLib.h

> @@ -22,7 +22,7 @@

>  #include <PlatformArch.h>

>  #include <Library/I2CLib.h>

>  

> -#define PCIEDEVICE_REPORT_MAX      4

> +#define PCIEDEVICE_REPORT_MAX      8


Does this have any impact on existing platforms?
Boot-time?

/
    Leif

>  typedef struct _REPORT_PCIEDIDVID2BMC{

>      UINTN   Bus;

>      UINTN   Device;

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ming Huang Aug. 8, 2018, 3:49 a.m. UTC | #2
在 8/3/2018 1:22 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote:
>> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
>> use for several modules like PciHostBridgeLib and Smbios.
>> Enlarge macro PCIEDEVICE_REPORT_MAX for D06.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/D06.dsc                                          |   1 +
>>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c          | 432 ++++++++++++++++++++
>>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni | Bin 0 -> 5204 bytes
> 
> We appear to be permitting UTF-8 these days, which would be easier to
> review. Would you be able to convert this for the next revision?
> 

Yes.
Could you tell me how to convert the .uni to UTF8?

>>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c            | 157 +++++++
>>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf          |  47 +++
>>  Silicon/Hisilicon/Include/Library/OemMiscLib.h                          |   2 +-
>>  6 files changed, 638 insertions(+), 1 deletion(-)
>>
>> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
>> index 88869ba26e..f4dfef1087 100644
>> --- a/Platform/Hisilicon/D06/D06.dsc
>> +++ b/Platform/Hisilicon/D06/D06.dsc
>> @@ -71,6 +71,7 @@
>>  
>>    TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>>    RealTimeClockLib|Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf
>> +  OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
>>    OemAddressMapLib|Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.inf
>>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf
>>  
>> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c
>> new file mode 100644
>> index 0000000000..c8f6cd0e29
>> --- /dev/null
>> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c
>> @@ -0,0 +1,432 @@
>> +/** @file
>> +*
>> +*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.
>> +*  Copyright (c) 2018, Linaro Limited. All rights reserved.
>> +*
>> +*  This program and the accompanying materials
>> +*  are licensed and made available under the terms and conditions of the BSD License
>> +*  which accompanies this distribution.  The full text of the license may be found at
>> +*  http://opensource.org/licenses/bsd-license.php
>> +*
>> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +*
>> +**/
>> +
>> +#include <Uefi.h>
>> +#include <IndustryStandard/SmBios.h>
>> +#include <Library/BaseMemoryLib.h>
>> +#include <Library/DebugLib.h>
>> +#include <Library/HiiLib.h>
>> +#include <Library/I2CLib.h>
>> +#include <Library/IoLib.h>
>> +#include <Library/OemMiscLib.h>
>> +#include <Library/SerdesLib.h>
>> +#include <Protocol/Smbios.h>
>> +
>> +#include <PlatformArch.h>
>> +
>> +I2C_DEVICE gDS3231RtcDevice = {
> 
> *cough* *cough*
> 

The name of global variable will be modify by another patch.

>> +  .Socket = 0,
>> +  .Port = 5,
>> +  .DeviceType = DEVICE_TYPE_SPD,
>> +  .SlaveDeviceAddress = 0x68
>> +};
>> +
>> +SERDES_POLARITY_INVERT gSerdesPolarityTxDesc[] =
>> +{
>> +  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}
>> +};
>> +
>> +SERDES_POLARITY_INVERT gSerdesPolarityRxDesc[] =
>> +{
>> +  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}
>> +};
>> +
>> +SERDES_PARAM gSerdesParamNA = {
>> +  .Hilink0Mode = EmHilink0Hccs1X8Width16,
>> +  .Hilink1Mode = EmHilink1Hccs0X8Width16,
>> +  .Hilink2Mode = EmHilink2Pcie2X8,
>> +  .Hilink3Mode = 0x0,
>> +  .Hilink4Mode = 0xF,
>> +  .Hilink5Mode = EmHilink5Sas1X4,
>> +  .Hilink6Mode = 0x0,
>> +  .UseSsc      = 0,
>> +};
>> +
>> +SERDES_PARAM gSerdesParamNB = {
>> +  .Hilink0Mode = EmHilink0Pcie1X8,
>> +  .Hilink1Mode = EmHilink1Pcie0X8,
>> +  .Hilink2Mode = EmHilink2Sas0X8,
>> +  .Hilink3Mode = 0x0,
>> +  .Hilink4Mode = 0xF,
>> +  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,
>> +  .Hilink6Mode = 0xF,
>> +  .UseSsc      = 0,
>> +};
>> +
>> +SERDES_PARAM gSerdesParamS1NA = {
>> +  .Hilink0Mode = EmHilink0Hccs1X8Width16,
>> +  .Hilink1Mode = EmHilink1Hccs0X8Width16,
>> +  .Hilink2Mode = EmHilink2Pcie2X8,
>> +  .Hilink3Mode = 0x0,
>> +  .Hilink4Mode = 0xF,
>> +  .Hilink5Mode = EmHilink5Sas1X4,
>> +  .Hilink6Mode = 0x0,
>> +  .UseSsc      = 0,
>> +};
>> +
>> +SERDES_PARAM gSerdesParamS1NB = {
>> +  .Hilink0Mode = EmHilink0Pcie1X8,
>> +  .Hilink1Mode = EmHilink1Pcie0X8,
>> +  .Hilink2Mode = EmHilink2Sas0X8,
>> +  .Hilink3Mode = 0x0,
>> +  .Hilink4Mode = 0xF,
>> +  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,
>> +  .Hilink6Mode = 0xF,
>> +  .UseSsc      = 0,
>> +};
>> +
>> +
>> +EFI_STATUS
>> +OemGetSerdesParam (
>> +  OUT SERDES_PARAM *ParamA,
>> +  OUT SERDES_PARAM *ParamB,
>> +  IN  UINT32       SocketId
>> + )
>> +{
>> +  if (NULL == ParamA) {
>> +    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));
>> +    return EFI_INVALID_PARAMETER;
>> +  } if (NULL == ParamB) {
>> +    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));
>> +    return EFI_INVALID_PARAMETER;
>> +  }
>> +
>> +  if (0 == SocketId) {
>> +    (VOID) CopyMem (ParamA, &gSerdesParamNA, sizeof (*ParamA));
>> +    (VOID) CopyMem (ParamB, &gSerdesParamNB, sizeof (*ParamB));
>> +  } else {
>> +    (VOID) CopyMem (ParamA, &gSerdesParamS1NA, sizeof (*ParamA));
>> +    (VOID) CopyMem (ParamB, &gSerdesParamS1NB, sizeof (*ParamB));
>> +  }
>> +
>> +  return EFI_SUCCESS;
>> +}
>> +
>> +VOID
>> +OemPcieResetAndOffReset (
>> +  VOID
>> +  )
>> +{
>> +  return;
>> +}
>> +
>> +SMBIOS_TABLE_TYPE9 gPcieSlotInfo[] = {
>> +  // PCIe0 Slot 1
>> +  {
>> +    {                                       // Hdr
>> +        EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +        0,                                  // Length,
>> +        0                                   // Handle
>> +    },
>> +    1,                                      // SlotDesignation
>> +    SlotTypePciExpressX16,                  // SlotType
>> +    SlotDataBusWidth16X,                    // SlotDataBusWidth
>> +    SlotUsageAvailable,                     // SlotUsage
>> +    SlotLengthOther,                        // SlotLength
>> +    0x0001,                                 // SlotId
>> +    {                                       // SlotCharacteristics1
>> +        0,                                  // CharacteristicsUnknown  :1;
>> +        0,                                  // Provides50Volts         :1;
>> +        0,                                  // Provides33Volts         :1;
>> +        0,                                  // SharedSlot              :1;
>> +        0,                                  // PcCard16Supported       :1;
>> +        0,                                  // CardBusSupported        :1;
>> +        0,                                  // ZoomVideoSupported      :1;
>> +        0                                   // ModemRingResumeSupported:1;
>> +    },
>> +    {                                       // SlotCharacteristics2
>> +        0,                                  // PmeSignalSupported      :1;
>> +        0,                                  // HotPlugDevicesSupported  :1;
> 
> Alignment of that :1.
> 
>> +        0,                                  // SmbusSignalSupported    :1;
>> +        0                                   // Reserved                :5;
>> +    },
>> +    0x00,                                   // SegmentGroupNum
>> +    0x00,                                   // BusNum
>> +    0                                       // DevFuncNum
>> +  },
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0002,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
> 
> Alignment of that :1.
> 
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0003,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
> 
> Alignment of that :1.
> 
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +
>> +
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0004,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
> 
> Alignment of that :1.
> 
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX16,                  // SlotType
>> +      SlotDataBusWidth16X,                    // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0005,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
> 
> Alignment of that :1.
> (I'm going to stop now. Please address for all instances.)
> 
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0006,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0007,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +  {
>> +      {                                       // Hdr
>> +          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
>> +          0,                                  // Length,
>> +          0                                   // Handle
>> +      },
>> +      1,                                      // SlotDesignation
>> +      SlotTypePciExpressX8,                   // SlotType
>> +      SlotDataBusWidth8X,                     // SlotDataBusWidth
>> +      SlotUsageAvailable,                     // SlotUsage
>> +      SlotLengthOther,                        // SlotLength
>> +      0x0008,                                 // SlotId
>> +      {                                       // SlotCharacteristics1
>> +          0,                                  // CharacteristicsUnknown  :1;
>> +          0,                                  // Provides50Volts         :1;
>> +          0,                                  // Provides33Volts         :1;
>> +          0,                                  // SharedSlot              :1;
>> +          0,                                  // PcCard16Supported       :1;
>> +          0,                                  // CardBusSupported        :1;
>> +          0,                                  // ZoomVideoSupported      :1;
>> +          0                                   // ModemRingResumeSupported:1;
>> +      },
>> +      {                                       // SlotCharacteristics2
>> +          0,                                  // PmeSignalSupported      :1;
>> +          0,                                  // HotPlugDevicesSupported  :1;
>> +          0,                                  // SmbusSignalSupported    :1;
>> +          0                                   // Reserved                :5;
>> +      },
>> +      0x00,                                   // SegmentGroupNum
>> +      0x00,                                   // BusNum
>> +      0                                       // DevFuncNum
>> +  },
>> +
>> +  };
>> +
>> +UINT8
>> +OemGetPcieSlotNumber (
>> +  VOID
>> +  )
>> +{
>> +  return sizeof (gPcieSlotInfo) / sizeof (SMBIOS_TABLE_TYPE9);
>> +}
>> +
>> +EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM] = {
>> +  {{STRING_TOKEN(STR_LEMON_C10_DIMM_000), STRING_TOKEN(STR_LEMON_C10_DIMM_001)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_010), STRING_TOKEN(STR_LEMON_C10_DIMM_011)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_020), STRING_TOKEN(STR_LEMON_C10_DIMM_021)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_030), STRING_TOKEN(STR_LEMON_C10_DIMM_031)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_040), STRING_TOKEN(STR_LEMON_C10_DIMM_041)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_050), STRING_TOKEN(STR_LEMON_C10_DIMM_051)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_060), STRING_TOKEN(STR_LEMON_C10_DIMM_061)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_070), STRING_TOKEN(STR_LEMON_C10_DIMM_071)}},
>> +
>> +  {{STRING_TOKEN(STR_LEMON_C10_DIMM_100), STRING_TOKEN(STR_LEMON_C10_DIMM_101)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_110), STRING_TOKEN(STR_LEMON_C10_DIMM_111)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_120), STRING_TOKEN(STR_LEMON_C10_DIMM_121)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_130), STRING_TOKEN(STR_LEMON_C10_DIMM_131)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_140), STRING_TOKEN(STR_LEMON_C10_DIMM_141)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_150), STRING_TOKEN(STR_LEMON_C10_DIMM_151)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_160), STRING_TOKEN(STR_LEMON_C10_DIMM_161)},
>> +   {STRING_TOKEN(STR_LEMON_C10_DIMM_170), STRING_TOKEN(STR_LEMON_C10_DIMM_171)}}
>> +};
>> +
>> +EFI_HII_HANDLE
>> +EFIAPI
>> +OemGetPackages (
>> +  VOID
>> +  )
>> +{
>> +  return HiiAddPackages (
>> +           &gEfiCallerIdGuid,
>> +           NULL,
>> +           OemMiscLibStrings,
>> +           NULL,
>> +           NULL
>> +           );
>> +}
>> +
>> +
>> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni
>> new file mode 100644
>> index 0000000000..f3994d9d4d
>> Binary files /dev/null and b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni differ
>> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
>> new file mode 100644
>> index 0000000000..009a53b2c8
>> --- /dev/null
>> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
>> @@ -0,0 +1,157 @@
>> +/** @file
>> +*
>> +*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.
>> +*  Copyright (c) 2018, Linaro Limited. All rights reserved.
>> +*
>> +*  This program and the accompanying materials
>> +*  are licensed and made available under the terms and conditions of the BSD License
>> +*  which accompanies this distribution.  The full text of the license may be found at
>> +*  http://opensource.org/licenses/bsd-license.php
>> +*
>> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +*
>> +**/
>> +
>> +#include <Uefi.h>
>> +#include <PlatformArch.h>
>> +#include <Library/DebugLib.h>
>> +#include <Library/IoLib.h>
>> +#include <Library/LpcLib.h>
>> +#include <Library/OemAddressMapLib.h>
>> +#include <Library/OemMiscLib.h>
>> +#include <Library/PcdLib.h>
>> +#include <Library/PlatformSysCtrlLib.h>
>> +#include <Library/SerdesLib.h>
>> +#include <Library/SerialPortLib.h>
>> +#include <Library/TimerLib.h>
>> +
>> +REPORT_PCIEDIDVID2BMC PcieDeviceToReport[PCIEDEVICE_REPORT_MAX] = {
>> +  {67,0,0,0},
>> +  {225,0,0,3},
>> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF},
>> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF}
>> +};
>> +
>> +// Right now we only support 1P
>> +BOOLEAN
>> +OemIsSocketPresent (
>> +  UINTN Socket
>> +  )
>> +{
>> +  UINT32 SocketMask = PcdGet32 (PcdSocketMask);
>> +  return (BOOLEAN)((SocketMask & (1 << Socket)) ? TRUE : FALSE);
>> +}
>> +
>> +
>> +UINTN
>> +OemGetSocketNumber (
>> +  VOID
>> +  )
>> +{
>> +  if(!OemIsMpBoot ()) {
>> +    return 1;
>> +  }
>> +
>> +  return 2;
> 
> What is 2?
> (Guessing NUMBER_PROCESSOR_SOCKETS.)
> 

Exactly.
Modify 2 to MAX_SOCKET(defined in PlatformArch.h)?

>> +}
>> +
>> +
>> +UINTN
>> +OemGetDdrChannel (
>> +  VOID
>> +  )
>> +{
>> +  return 8;
> 
> What is 8?
> (Guessing NUMBER_MEMORY_CHANNELS.)
> 

Exactly.
Modify 8 to MAX_CHANNEL(defined in PlatformArch.h)?

>> +}
>> +
>> +
>> +UINTN
>> +OemGetDimmSlot (
>> +  UINTN Socket,
>> +  UINTN Channel
>> +  )
>> +{
>> +  return 2;
> 
> What is 2?
> (Guessing SLOTS_PER_DDR_CHANNEL.)
> 

Yes.
Modify 8 to MAX_DIMM(defined in PlatformArch.h)?

>> +}
>> +
>> +
>> +// Nothing to do for EVB
>> +VOID
>> +OemPostEndIndicator (
>> +  VOID
>> +  )
>> +{
>> +  DEBUG ((DEBUG_ERROR,"M3 release reset CONFIG........."));
> 
> DEBUG_INFO.
> 
>> +
>> +  MmioWrite32 (0xd0002180, 0x3);
>> +  MmioWrite32 (0xd0002194, 0xa4);
>> +  MmioWrite32 (0xd0000a54, 0x1);
> 
> Please create some #defines for those addresses, and those values.
> 

After search all source code, this function is not invoked for D06.
I will remove it.

>> +
>> +  MicroSecondDelay (10000);
> 
> Why 10000?
> Is a MemoryFence () needed?
> 
>> +
>> +  MmioWrite32 (0xd0002108, 0x1);
>> +  MmioWrite32 (0xd0002114, 0x1);
>> +  MmioWrite32 (0xd0002120, 0x1);
>> +  MmioWrite32 (0xd0003108, 0x1);
> 
> Please create some #defines for those addresses, and those values.
> 
>> +
>> +  MicroSecondDelay (500000);
> 
> Why 500000?
> Is a MemoryFence () needed?
> 
>> +  DEBUG ((DEBUG_ERROR, "Done\n"));
> 
> DEBUG_INFO.
> 
>> +}
>> +
>> +
>> +
>> +VOID
>> +CoreSelectBoot (
>> +  VOID
>> +  )
>> +{
>> +  if (!PcdGet64 (PcdTrustedFirmwareEnable))
>> +  {
>> +    StartupAp ();
>> +  }
>> +
>> +  return;
>> +}
>> +
>> +BOOLEAN
>> +OemIsMpBoot (
>> +  VOID
>> +  )
>> +{
>> +  return PcdGet32 (PcdIsMPBoot);
>> +}
>> +
>> +VOID
>> +OemLpcInit (
>> +  VOID
>> +  )
>> +{
>> +  LpcInit ();
>> +  return;
>> +}
>> +
>> +UINT32
>> +OemIsWarmBoot (
>> +  VOID
>> +  )
>> +{
>> +  return 0;
>> +}
>> +
>> +VOID
>> +OemBiosSwitch (
>> +  UINT32 Master
>> +  )
>> +{
>> +  (VOID)Master;
>> +  return;
>> +}
>> +
>> +BOOLEAN
>> +OemIsNeedDisableExpanderBuffer (
>> +  VOID
>> +  )
>> +{
>> +  return TRUE;
>> +}
>> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
>> new file mode 100644
>> index 0000000000..acb7366078
>> --- /dev/null
>> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
>> @@ -0,0 +1,47 @@
>> +#/** @file
>> +#
>> +#    Copyright (c) 2018, Hisilicon Limited. All rights reserved.
>> +#    Copyright (c) 2018, Linaro Limited. All rights reserved.
>> +#
>> +#    This program and the accompanying materials
>> +#    are licensed and made available under the terms and conditions of the BSD License
>> +#    which accompanies this distribution. The full text of the license may be found at
>> +#    http://opensource.org/licenses/bsd-license.php
>> +#
>> +#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +#
>> +#**/
>> +
>> +[Defines]
>> +  INF_VERSION                    = 0x0001001A
>> +  BASE_NAME                      = OemMiscLib
>> +  FILE_GUID                      = 3002911C-C160-4C46-93BB-782846673EEA
>> +  MODULE_TYPE                    = BASE
>> +  VERSION_STRING                 = 1.0
>> +  LIBRARY_CLASS                  = OemMiscLib
>> +
>> +[Sources.common]
>> +  BoardFeatureD06.c
>> +  OemMiscLibD06.c
>> +  BoardFeatureD06Strings.uni
> 
> Please sort files alphabetically.
> 
>> +
>> +[Packages]
>> +  ArmPkg/ArmPkg.dec
>> +  MdeModulePkg/MdeModulePkg.dec
>> +  MdePkg/MdePkg.dec
>> +  Silicon/Hisilicon/HisiPkg.dec
>> +
>> +[LibraryClasses]
>> +  PcdLib
>> +  TimerLib
>> +  SerdesLib
> 
> Please sort Libraries alphabetically.
> 
>> +
>> +[Ppis]
>> +  gEfiPeiReadOnlyVariable2PpiGuid   ## SOMETIMES_CONSUMES
>> +
>> +[Pcd]
>> +  gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
>> +  gHisiTokenSpaceGuid.PcdSocketMask
>> +  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
>> +  gHisiTokenSpaceGuid.PcdIsMPBoot
> 
> Please sort Pcds alphabetically (where there is not a more logical
> grouping).
> 
>> diff --git a/Silicon/Hisilicon/Include/Library/OemMiscLib.h b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
>> index 6f18c0fa72..53e7a37a68 100644
>> --- a/Silicon/Hisilicon/Include/Library/OemMiscLib.h
>> +++ b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
>> @@ -22,7 +22,7 @@
>>  #include <PlatformArch.h>
>>  #include <Library/I2CLib.h>
>>  
>> -#define PCIEDEVICE_REPORT_MAX      4
>> +#define PCIEDEVICE_REPORT_MAX      8
> 
> Does this have any impact on existing platforms?
> Boot-time?
> 

This have no impact on existing platform, just enlarge the
global array. This is used for SMBIOS.

Ming

> /
>     Leif
> 
>>  typedef struct _REPORT_PCIEDIDVID2BMC{
>>      UINTN   Bus;
>>      UINTN   Device;
>> -- 
>> 2.17.0
>>
Leif Lindholm Aug. 8, 2018, 9:43 a.m. UTC | #3
On Wed, Aug 08, 2018 at 11:49:41AM +0800, Ming wrote:
> > 在 8/3/2018 1:22 AM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote:
> >> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
> >> use for several modules like PciHostBridgeLib and Smbios.
> >> Enlarge macro PCIEDEVICE_REPORT_MAX for D06.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> >> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> >> ---
> >>  Platform/Hisilicon/D06/D06.dsc                                          |   1 +
> >>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c          | 432 ++++++++++++++++++++
> >>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni | Bin 0 -> 5204 bytes
> > 
> > We appear to be permitting UTF-8 these days, which would be easier to
> > review. Would you be able to convert this for the next revision?
> 
> Yes.
> Could you tell me how to convert the .uni to UTF8?

iconv -f UCS2 -t UTF-8 -o <output file> <input file>

At my end, I think this leaves the BOM in the file, which I don't
think it a good thing. But it can easily be edited out.

Doing that, I do however spot that there are inconsistent line endings
in this file. Please convert them all to CRLF.

> >>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c            | 157 +++++++
> >>  Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf          |  47 +++
> >>  Silicon/Hisilicon/Include/Library/OemMiscLib.h                          |   2 +-
> >>  6 files changed, 638 insertions(+), 1 deletion(-)
> >>

> >> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni
> >> new file mode 100644
> >> index 0000000000..f3994d9d4d
> >> Binary files /dev/null and b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni differ
> >> diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
> >> new file mode 100644
> >> index 0000000000..009a53b2c8
> >> --- /dev/null
> >> +++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
> >> @@ -0,0 +1,157 @@
> >> +/** @file
> >> +*
> >> +*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.
> >> +*  Copyright (c) 2018, Linaro Limited. All rights reserved.
> >> +*
> >> +*  This program and the accompanying materials
> >> +*  are licensed and made available under the terms and conditions of the BSD License
> >> +*  which accompanies this distribution.  The full text of the license may be found at
> >> +*  http://opensource.org/licenses/bsd-license.php
> >> +*
> >> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> >> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> >> +*
> >> +**/
> >> +
> >> +#include <Uefi.h>
> >> +#include <PlatformArch.h>
> >> +#include <Library/DebugLib.h>
> >> +#include <Library/IoLib.h>
> >> +#include <Library/LpcLib.h>
> >> +#include <Library/OemAddressMapLib.h>
> >> +#include <Library/OemMiscLib.h>
> >> +#include <Library/PcdLib.h>
> >> +#include <Library/PlatformSysCtrlLib.h>
> >> +#include <Library/SerdesLib.h>
> >> +#include <Library/SerialPortLib.h>
> >> +#include <Library/TimerLib.h>
> >> +
> >> +REPORT_PCIEDIDVID2BMC PcieDeviceToReport[PCIEDEVICE_REPORT_MAX] = {
> >> +  {67,0,0,0},
> >> +  {225,0,0,3},
> >> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF},
> >> +  {0xFFFF,0xFFFF,0xFFFF,0xFFFF}
> >> +};
> >> +
> >> +// Right now we only support 1P
> >> +BOOLEAN
> >> +OemIsSocketPresent (
> >> +  UINTN Socket
> >> +  )
> >> +{
> >> +  UINT32 SocketMask = PcdGet32 (PcdSocketMask);
> >> +  return (BOOLEAN)((SocketMask & (1 << Socket)) ? TRUE : FALSE);
> >> +}
> >> +
> >> +
> >> +UINTN
> >> +OemGetSocketNumber (
> >> +  VOID
> >> +  )
> >> +{
> >> +  if(!OemIsMpBoot ()) {
> >> +    return 1;
> >> +  }
> >> +
> >> +  return 2;
> > 
> > What is 2?
> > (Guessing NUMBER_PROCESSOR_SOCKETS.)
> > 
> 
> Exactly.
> Modify 2 to MAX_SOCKET(defined in PlatformArch.h)?

MAX_PROCESSOR_SOCKETS would be good.

> >> +}
> >> +
> >> +
> >> +UINTN
> >> +OemGetDdrChannel (
> >> +  VOID
> >> +  )
> >> +{
> >> +  return 8;
> > 
> > What is 8?
> > (Guessing NUMBER_MEMORY_CHANNELS.)
> > 
> 
> Exactly.
> Modify 8 to MAX_CHANNEL(defined in PlatformArch.h)?

MAX_MEMORY_CHANNELS would be good.

> >> +}
> >> +
> >> +
> >> +UINTN
> >> +OemGetDimmSlot (
> >> +  UINTN Socket,
> >> +  UINTN Channel
> >> +  )
> >> +{
> >> +  return 2;
> > 
> > What is 2?
> > (Guessing SLOTS_PER_DDR_CHANNEL.)
> > 
> 
> Yes.
> Modify 8 to MAX_DIMM(defined in PlatformArch.h)?

MAX_DIMM_PER_CHANNEL?


> >> diff --git a/Silicon/Hisilicon/Include/Library/OemMiscLib.h b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
> >> index 6f18c0fa72..53e7a37a68 100644
> >> --- a/Silicon/Hisilicon/Include/Library/OemMiscLib.h
> >> +++ b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
> >> @@ -22,7 +22,7 @@
> >>  #include <PlatformArch.h>
> >>  #include <Library/I2CLib.h>
> >>  
> >> -#define PCIEDEVICE_REPORT_MAX      4
> >> +#define PCIEDEVICE_REPORT_MAX      8
> > 
> > Does this have any impact on existing platforms?
> > Boot-time?
> > 
> 
> This have no impact on existing platform, just enlarge the
> global array. This is used for SMBIOS.

OK, that's fine then.

/
    Leif
diff mbox series

Patch

diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index 88869ba26e..f4dfef1087 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -71,6 +71,7 @@ 
 
   TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
   RealTimeClockLib|Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf
+  OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
   OemAddressMapLib|Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.inf
   PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf
 
diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c
new file mode 100644
index 0000000000..c8f6cd0e29
--- /dev/null
+++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c
@@ -0,0 +1,432 @@ 
+/** @file
+*
+*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.
+*  Copyright (c) 2018, Linaro Limited. All rights reserved.
+*
+*  This program and the accompanying materials
+*  are licensed and made available under the terms and conditions of the BSD License
+*  which accompanies this distribution.  The full text of the license may be found at
+*  http://opensource.org/licenses/bsd-license.php
+*
+*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+*
+**/
+
+#include <Uefi.h>
+#include <IndustryStandard/SmBios.h>
+#include <Library/BaseMemoryLib.h>
+#include <Library/DebugLib.h>
+#include <Library/HiiLib.h>
+#include <Library/I2CLib.h>
+#include <Library/IoLib.h>
+#include <Library/OemMiscLib.h>
+#include <Library/SerdesLib.h>
+#include <Protocol/Smbios.h>
+
+#include <PlatformArch.h>
+
+I2C_DEVICE gDS3231RtcDevice = {
+  .Socket = 0,
+  .Port = 5,
+  .DeviceType = DEVICE_TYPE_SPD,
+  .SlaveDeviceAddress = 0x68
+};
+
+SERDES_POLARITY_INVERT gSerdesPolarityTxDesc[] =
+{
+  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}
+};
+
+SERDES_POLARITY_INVERT gSerdesPolarityRxDesc[] =
+{
+  {SERDES_INVALID_MACRO_ID, SERDES_INVALID_LANE_NUM}
+};
+
+SERDES_PARAM gSerdesParamNA = {
+  .Hilink0Mode = EmHilink0Hccs1X8Width16,
+  .Hilink1Mode = EmHilink1Hccs0X8Width16,
+  .Hilink2Mode = EmHilink2Pcie2X8,
+  .Hilink3Mode = 0x0,
+  .Hilink4Mode = 0xF,
+  .Hilink5Mode = EmHilink5Sas1X4,
+  .Hilink6Mode = 0x0,
+  .UseSsc      = 0,
+};
+
+SERDES_PARAM gSerdesParamNB = {
+  .Hilink0Mode = EmHilink0Pcie1X8,
+  .Hilink1Mode = EmHilink1Pcie0X8,
+  .Hilink2Mode = EmHilink2Sas0X8,
+  .Hilink3Mode = 0x0,
+  .Hilink4Mode = 0xF,
+  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,
+  .Hilink6Mode = 0xF,
+  .UseSsc      = 0,
+};
+
+SERDES_PARAM gSerdesParamS1NA = {
+  .Hilink0Mode = EmHilink0Hccs1X8Width16,
+  .Hilink1Mode = EmHilink1Hccs0X8Width16,
+  .Hilink2Mode = EmHilink2Pcie2X8,
+  .Hilink3Mode = 0x0,
+  .Hilink4Mode = 0xF,
+  .Hilink5Mode = EmHilink5Sas1X4,
+  .Hilink6Mode = 0x0,
+  .UseSsc      = 0,
+};
+
+SERDES_PARAM gSerdesParamS1NB = {
+  .Hilink0Mode = EmHilink0Pcie1X8,
+  .Hilink1Mode = EmHilink1Pcie0X8,
+  .Hilink2Mode = EmHilink2Sas0X8,
+  .Hilink3Mode = 0x0,
+  .Hilink4Mode = 0xF,
+  .Hilink5Mode = EmHilink5Pcie2X2Pcie3X2,
+  .Hilink6Mode = 0xF,
+  .UseSsc      = 0,
+};
+
+
+EFI_STATUS
+OemGetSerdesParam (
+  OUT SERDES_PARAM *ParamA,
+  OUT SERDES_PARAM *ParamB,
+  IN  UINT32       SocketId
+ )
+{
+  if (NULL == ParamA) {
+    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));
+    return EFI_INVALID_PARAMETER;
+  } if (NULL == ParamB) {
+    DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Param == NULL!\n", __FUNCTION__, __LINE__));
+    return EFI_INVALID_PARAMETER;
+  }
+
+  if (0 == SocketId) {
+    (VOID) CopyMem (ParamA, &gSerdesParamNA, sizeof (*ParamA));
+    (VOID) CopyMem (ParamB, &gSerdesParamNB, sizeof (*ParamB));
+  } else {
+    (VOID) CopyMem (ParamA, &gSerdesParamS1NA, sizeof (*ParamA));
+    (VOID) CopyMem (ParamB, &gSerdesParamS1NB, sizeof (*ParamB));
+  }
+
+  return EFI_SUCCESS;
+}
+
+VOID
+OemPcieResetAndOffReset (
+  VOID
+  )
+{
+  return;
+}
+
+SMBIOS_TABLE_TYPE9 gPcieSlotInfo[] = {
+  // PCIe0 Slot 1
+  {
+    {                                       // Hdr
+        EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+        0,                                  // Length,
+        0                                   // Handle
+    },
+    1,                                      // SlotDesignation
+    SlotTypePciExpressX16,                  // SlotType
+    SlotDataBusWidth16X,                    // SlotDataBusWidth
+    SlotUsageAvailable,                     // SlotUsage
+    SlotLengthOther,                        // SlotLength
+    0x0001,                                 // SlotId
+    {                                       // SlotCharacteristics1
+        0,                                  // CharacteristicsUnknown  :1;
+        0,                                  // Provides50Volts         :1;
+        0,                                  // Provides33Volts         :1;
+        0,                                  // SharedSlot              :1;
+        0,                                  // PcCard16Supported       :1;
+        0,                                  // CardBusSupported        :1;
+        0,                                  // ZoomVideoSupported      :1;
+        0                                   // ModemRingResumeSupported:1;
+    },
+    {                                       // SlotCharacteristics2
+        0,                                  // PmeSignalSupported      :1;
+        0,                                  // HotPlugDevicesSupported  :1;
+        0,                                  // SmbusSignalSupported    :1;
+        0                                   // Reserved                :5;
+    },
+    0x00,                                   // SegmentGroupNum
+    0x00,                                   // BusNum
+    0                                       // DevFuncNum
+  },
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0002,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0003,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+
+
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0004,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX16,                  // SlotType
+      SlotDataBusWidth16X,                    // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0005,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0006,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0007,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+  {
+      {                                       // Hdr
+          EFI_SMBIOS_TYPE_SYSTEM_SLOTS,       // Type,
+          0,                                  // Length,
+          0                                   // Handle
+      },
+      1,                                      // SlotDesignation
+      SlotTypePciExpressX8,                   // SlotType
+      SlotDataBusWidth8X,                     // SlotDataBusWidth
+      SlotUsageAvailable,                     // SlotUsage
+      SlotLengthOther,                        // SlotLength
+      0x0008,                                 // SlotId
+      {                                       // SlotCharacteristics1
+          0,                                  // CharacteristicsUnknown  :1;
+          0,                                  // Provides50Volts         :1;
+          0,                                  // Provides33Volts         :1;
+          0,                                  // SharedSlot              :1;
+          0,                                  // PcCard16Supported       :1;
+          0,                                  // CardBusSupported        :1;
+          0,                                  // ZoomVideoSupported      :1;
+          0                                   // ModemRingResumeSupported:1;
+      },
+      {                                       // SlotCharacteristics2
+          0,                                  // PmeSignalSupported      :1;
+          0,                                  // HotPlugDevicesSupported  :1;
+          0,                                  // SmbusSignalSupported    :1;
+          0                                   // Reserved                :5;
+      },
+      0x00,                                   // SegmentGroupNum
+      0x00,                                   // BusNum
+      0                                       // DevFuncNum
+  },
+
+  };
+
+UINT8
+OemGetPcieSlotNumber (
+  VOID
+  )
+{
+  return sizeof (gPcieSlotInfo) / sizeof (SMBIOS_TABLE_TYPE9);
+}
+
+EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM] = {
+  {{STRING_TOKEN(STR_LEMON_C10_DIMM_000), STRING_TOKEN(STR_LEMON_C10_DIMM_001)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_010), STRING_TOKEN(STR_LEMON_C10_DIMM_011)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_020), STRING_TOKEN(STR_LEMON_C10_DIMM_021)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_030), STRING_TOKEN(STR_LEMON_C10_DIMM_031)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_040), STRING_TOKEN(STR_LEMON_C10_DIMM_041)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_050), STRING_TOKEN(STR_LEMON_C10_DIMM_051)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_060), STRING_TOKEN(STR_LEMON_C10_DIMM_061)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_070), STRING_TOKEN(STR_LEMON_C10_DIMM_071)}},
+
+  {{STRING_TOKEN(STR_LEMON_C10_DIMM_100), STRING_TOKEN(STR_LEMON_C10_DIMM_101)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_110), STRING_TOKEN(STR_LEMON_C10_DIMM_111)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_120), STRING_TOKEN(STR_LEMON_C10_DIMM_121)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_130), STRING_TOKEN(STR_LEMON_C10_DIMM_131)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_140), STRING_TOKEN(STR_LEMON_C10_DIMM_141)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_150), STRING_TOKEN(STR_LEMON_C10_DIMM_151)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_160), STRING_TOKEN(STR_LEMON_C10_DIMM_161)},
+   {STRING_TOKEN(STR_LEMON_C10_DIMM_170), STRING_TOKEN(STR_LEMON_C10_DIMM_171)}}
+};
+
+EFI_HII_HANDLE
+EFIAPI
+OemGetPackages (
+  VOID
+  )
+{
+  return HiiAddPackages (
+           &gEfiCallerIdGuid,
+           NULL,
+           OemMiscLibStrings,
+           NULL,
+           NULL
+           );
+}
+
+
diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni
new file mode 100644
index 0000000000..f3994d9d4d
Binary files /dev/null and b/Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06Strings.uni differ
diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
new file mode 100644
index 0000000000..009a53b2c8
--- /dev/null
+++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
@@ -0,0 +1,157 @@ 
+/** @file
+*
+*  Copyright (c) 2018, Hisilicon Limited. All rights reserved.
+*  Copyright (c) 2018, Linaro Limited. All rights reserved.
+*
+*  This program and the accompanying materials
+*  are licensed and made available under the terms and conditions of the BSD License
+*  which accompanies this distribution.  The full text of the license may be found at
+*  http://opensource.org/licenses/bsd-license.php
+*
+*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+*
+**/
+
+#include <Uefi.h>
+#include <PlatformArch.h>
+#include <Library/DebugLib.h>
+#include <Library/IoLib.h>
+#include <Library/LpcLib.h>
+#include <Library/OemAddressMapLib.h>
+#include <Library/OemMiscLib.h>
+#include <Library/PcdLib.h>
+#include <Library/PlatformSysCtrlLib.h>
+#include <Library/SerdesLib.h>
+#include <Library/SerialPortLib.h>
+#include <Library/TimerLib.h>
+
+REPORT_PCIEDIDVID2BMC PcieDeviceToReport[PCIEDEVICE_REPORT_MAX] = {
+  {67,0,0,0},
+  {225,0,0,3},
+  {0xFFFF,0xFFFF,0xFFFF,0xFFFF},
+  {0xFFFF,0xFFFF,0xFFFF,0xFFFF}
+};
+
+// Right now we only support 1P
+BOOLEAN
+OemIsSocketPresent (
+  UINTN Socket
+  )
+{
+  UINT32 SocketMask = PcdGet32 (PcdSocketMask);
+  return (BOOLEAN)((SocketMask & (1 << Socket)) ? TRUE : FALSE);
+}
+
+
+UINTN
+OemGetSocketNumber (
+  VOID
+  )
+{
+  if(!OemIsMpBoot ()) {
+    return 1;
+  }
+
+  return 2;
+}
+
+
+UINTN
+OemGetDdrChannel (
+  VOID
+  )
+{
+  return 8;
+}
+
+
+UINTN
+OemGetDimmSlot (
+  UINTN Socket,
+  UINTN Channel
+  )
+{
+  return 2;
+}
+
+
+// Nothing to do for EVB
+VOID
+OemPostEndIndicator (
+  VOID
+  )
+{
+  DEBUG ((DEBUG_ERROR,"M3 release reset CONFIG........."));
+
+  MmioWrite32 (0xd0002180, 0x3);
+  MmioWrite32 (0xd0002194, 0xa4);
+  MmioWrite32 (0xd0000a54, 0x1);
+
+  MicroSecondDelay (10000);
+
+  MmioWrite32 (0xd0002108, 0x1);
+  MmioWrite32 (0xd0002114, 0x1);
+  MmioWrite32 (0xd0002120, 0x1);
+  MmioWrite32 (0xd0003108, 0x1);
+
+  MicroSecondDelay (500000);
+  DEBUG ((DEBUG_ERROR, "Done\n"));
+}
+
+
+
+VOID
+CoreSelectBoot (
+  VOID
+  )
+{
+  if (!PcdGet64 (PcdTrustedFirmwareEnable))
+  {
+    StartupAp ();
+  }
+
+  return;
+}
+
+BOOLEAN
+OemIsMpBoot (
+  VOID
+  )
+{
+  return PcdGet32 (PcdIsMPBoot);
+}
+
+VOID
+OemLpcInit (
+  VOID
+  )
+{
+  LpcInit ();
+  return;
+}
+
+UINT32
+OemIsWarmBoot (
+  VOID
+  )
+{
+  return 0;
+}
+
+VOID
+OemBiosSwitch (
+  UINT32 Master
+  )
+{
+  (VOID)Master;
+  return;
+}
+
+BOOLEAN
+OemIsNeedDisableExpanderBuffer (
+  VOID
+  )
+{
+  return TRUE;
+}
diff --git a/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
new file mode 100644
index 0000000000..acb7366078
--- /dev/null
+++ b/Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf
@@ -0,0 +1,47 @@ 
+#/** @file
+#
+#    Copyright (c) 2018, Hisilicon Limited. All rights reserved.
+#    Copyright (c) 2018, Linaro Limited. All rights reserved.
+#
+#    This program and the accompanying materials
+#    are licensed and made available under the terms and conditions of the BSD License
+#    which accompanies this distribution. The full text of the license may be found at
+#    http://opensource.org/licenses/bsd-license.php
+#
+#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+[Defines]
+  INF_VERSION                    = 0x0001001A
+  BASE_NAME                      = OemMiscLib
+  FILE_GUID                      = 3002911C-C160-4C46-93BB-782846673EEA
+  MODULE_TYPE                    = BASE
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = OemMiscLib
+
+[Sources.common]
+  BoardFeatureD06.c
+  OemMiscLibD06.c
+  BoardFeatureD06Strings.uni
+
+[Packages]
+  ArmPkg/ArmPkg.dec
+  MdeModulePkg/MdeModulePkg.dec
+  MdePkg/MdePkg.dec
+  Silicon/Hisilicon/HisiPkg.dec
+
+[LibraryClasses]
+  PcdLib
+  TimerLib
+  SerdesLib
+
+[Ppis]
+  gEfiPeiReadOnlyVariable2PpiGuid   ## SOMETIMES_CONSUMES
+
+[Pcd]
+  gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
+  gHisiTokenSpaceGuid.PcdSocketMask
+  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
+  gHisiTokenSpaceGuid.PcdIsMPBoot
diff --git a/Silicon/Hisilicon/Include/Library/OemMiscLib.h b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
index 6f18c0fa72..53e7a37a68 100644
--- a/Silicon/Hisilicon/Include/Library/OemMiscLib.h
+++ b/Silicon/Hisilicon/Include/Library/OemMiscLib.h
@@ -22,7 +22,7 @@ 
 #include <PlatformArch.h>
 #include <Library/I2CLib.h>
 
-#define PCIEDEVICE_REPORT_MAX      4
+#define PCIEDEVICE_REPORT_MAX      8
 typedef struct _REPORT_PCIEDIDVID2BMC{
     UINTN   Bus;
     UINTN   Device;