From patchwork Tue May 10 15:18:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Lloyd X-Patchwork-Id: 67463 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp2185153qge; Tue, 10 May 2016 08:18:51 -0700 (PDT) X-Received: by 10.98.25.74 with SMTP id 71mr58874168pfz.94.1462893531246; Tue, 10 May 2016 08:18:51 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id c125si3235203pfc.145.2016.05.10.08.18.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 May 2016 08:18:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@armh.onmicrosoft.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1B5BA1A1F69; Tue, 10 May 2016 08:18:50 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from eu-smtp-delivery-143.mimecast.com (eu-smtp-delivery-143.mimecast.com [146.101.78.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B4811A1F68 for ; Tue, 10 May 2016 08:18:48 -0700 (PDT) Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1lrp0017.outbound.protection.outlook.com [213.199.154.17]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-25-hilYD9f7QWms-FsvS61iKg-1; Tue, 10 May 2016 16:18:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TcsmC+wbsISof8XNTgNCi6ywJNcMKoorAF+TEIjoikU=; b=KbLmwYgpDV1fGgaxu8HtDTfqDyFNDiPEp80qwUBGNdL8kaBEpjmmaR313znPAuW2CqrRb7nLWeGP7f13E2fMy1VcgX40X+D0B9r5Jx66r1Ssgfdr4GZtk9aPr7GauLPWbRW766ZS4uBV5hyeRaEDslsLqdpmlO26f6uO2xL6kDw= Received: from DB5PR08MB0918.eurprd08.prod.outlook.com (10.166.13.137) by DB5PR08MB0919.eurprd08.prod.outlook.com (10.166.13.138) with Microsoft SMTP Server (TLS) id 15.1.492.11; Tue, 10 May 2016 15:18:42 +0000 Received: from DB5PR08MB0918.eurprd08.prod.outlook.com ([10.166.13.137]) by DB5PR08MB0918.eurprd08.prod.outlook.com ([10.166.13.137]) with mapi id 15.01.0492.016; Tue, 10 May 2016 15:18:42 +0000 From: Evan Lloyd To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" Thread-Topic: [edk2] [PATCH] BaseTools AARCH64/ARM: remove -save-temps GCC option Thread-Index: AdGqzQMWN4evqg3/QPuAvek8pR4Z+Q== Date: Tue, 10 May 2016 15:18:42 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.96.140] x-ms-office365-filtering-correlation-id: 088b2695-bdfc-4fc4-39dc-08d378e65f38 x-microsoft-exchange-diagnostics: 1; DB5PR08MB0919; 5:xX09ei0OvPIr0tf98Ci2O9VNF6k0R6VPN53Wkqqe1kjQZiTpHh9qFO+9gW7hPVqJSwxLEDMNlavXR8JvXAVtugyj4+Eqm6WDtGX8EIEW9NwlIcPeLMmwoH/CE4XFyq9ICgZKTD40r+lwV9BY1se/Mg==; 24:DsG2ffueIQnLLfpm/n3DEtl82hYw6rn0XzqNizbiaqUfHMRkdFn2Az0BeXaQ9F9SmhjGg/hhi4+DmLMKmB3a4UDiKjBeKrWYm/PdAMnnbx0=; 7:zxpiiDDcihp1BiTnpFimn8S/cbgpPKeIODAEmKBmzwEeLuUDjF9q3k8YIZSpLNkl3+kfxPVam+2/VIWEkZEb3iFRNAOcTTnO+hm0yeLWLXuajlUny6Oa8P4w3HKiXyLnFGOkN9LjiaUhiJTtfgwTnInuBjO05Hoh2Zj0aZaxXkPjaCu7gtob3vhRBV4Ts787; 20:uWuJvaBVylTvsmyXHygKqhl+/11kcbIULQvEIThooPzROFUqFvvApV5HDgaPIZNETaND4YCkmI/QXQmfXi9w3Aj7shK5MBe/Z8po16lSMNEuSAoC4/yLidKvfwvgXfrL3NlUw2s8qWZA9qVLiXNah0bIBDXjLE6XoKgdq6VZjbU= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0919; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:DB5PR08MB0919; BCL:0; PCL:0; RULEID:; SRVR:DB5PR08MB0919; x-forefront-prvs: 0938781D02 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(40434004)(81166005)(2201001)(5002640100001)(15975445007)(2900100001)(33656002)(10400500002)(76576001)(66066001)(77096005)(3846002)(54356999)(3660700001)(50986999)(19580405001)(19580395003)(2906002)(3280700002)(92566002)(5003600100002)(1220700001)(107886002)(5890100001)(102836003)(2501003)(86362001)(8936002)(11100500001)(189998001)(9686002)(6116002)(122556002)(5001770100001)(5004730100002)(5008740100001)(586003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR08MB0919; H:DB5PR08MB0918.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2016 15:18:42.3140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0919 X-MC-Unique: hilYD9f7QWms-FsvS61iKg-1 Subject: Re: [edk2] [PATCH] BaseTools AARCH64/ARM: remove -save-temps GCC option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Hi Ard. This is not a major inconvenience, but we do occasionally find the -save-temps flag vital when debugging. What does seem strange is using GCC_ARM_CC_FLAGS, etc for a CLANG compiler. Surely there ought to be CLANG_*_CC_FLAGS (which could be played with to your hearts content, without disrupting other compilers). Regards, Evan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel Sent: 10 May 2016 14:56 To: edk2-devel@lists.01.org; leif.lindholm@linaro.org Cc: Ard Biesheuvel Subject: [edk2] [PATCH] BaseTools AARCH64/ARM: remove -save-temps GCC option Recent CLANG version choke on the -save-temps options. Of course, this is not GCC's fault, but since it seems we don't need this option, just remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 2065fa34998f..616a27871978 100644 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -4323,8 +4323,8 @@ DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-strict-aliasing - DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone -Wno-address -mno-stack-arg-probe DEFINE GCC_IPF_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -minline-int-divide-min-latency -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -save-temps -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft -DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -save-temps -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft +DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie DEFINE GCC_DLINK2_FLAGS_COMMON = --script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds