From patchwork Fri Mar 30 13:15:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sjoerd Simons X-Patchwork-Id: 132607 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp3031965ljb; Fri, 30 Mar 2018 06:15:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx492E+mjhGmCTGbgR398kesDIZsa6wre9VSxQKiw3/5nmt1b6NBFb3HHwf7H4mJ7RhqwcPeN X-Received: by 2002:a17:902:6b86:: with SMTP id p6-v6mr7207148plk.32.1522415759818; Fri, 30 Mar 2018 06:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522415759; cv=none; d=google.com; s=arc-20160816; b=A9Qq4emVoxZCE9TkLu4KqlVm9iUzxasWxJCptddKAzLgDc27Qg5i+RekOfB5kepBd5 nwkGDU6/A6TNeEAkK8Tz0MaRT32Z/9R6pN/5wLFUhKdX51IGAlFCDaVS1YNMr/ySeQTV uGUTWxpKhUb1ZXi9gEYfCnaQ6WGYl3Y0M3tG+SfljRthhm8XNDWQbeF/a0ibVQIe4iji jITmqxOg4dbZA0domID45Zl/XEWnAKh0uJM1mSWKLzsprOT4R2kS0OkPGTq+UKNZy0zW 55SIb378wri7HedX+dvIOam/HFLWvbhdXqpf3vr2rldxuYvuk9mD/MbTNAcn/xodwX25 dbeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:delivered-to :arc-authentication-results; bh=JuYcDOgbIziicPPsrN50I3UpKPwiB4HHKZAlI/HNbTI=; b=f0Waej4YGoj3byk0FBaqa1FFAsjQcEAX8ynUukRZcZRPrwrlqq7EAqTGkyyD4EdfCm qxPgH+Fy5wlIYDiRN4B2ZTKokonOVoAYVsLTOEjYdW1utw3qzdefCX2z5JdLDYLtJYwB NNfFAaXh7IAvkwiBwa7FcIIVYs5w8lexLnwsvSIPvL3/4NQQRbqGwKEGq2R4EdPSWq4J 8zi9xJ5xv/9M666jK3EDD2Gr2GQ6hpsM3OXN/iW1dGekDLKK/Y+d9/NruqQhVYU/kSRk uc0M8dFK+piBeKyhLpXEf0prWga85lSDZEZtFDADycZF1jzohMZyGmJqRMkIEGJyuosi nWmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a8-v6si8771908pln.234.2018.03.30.06.15.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Mar 2018 06:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0BC66E88C; Fri, 30 Mar 2018 13:15:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62B166E88C for ; Fri, 30 Mar 2018 13:15:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sjoerd) with ESMTPSA id 1C0E5263A29 Received: by beast.luon.net (Postfix, from userid 1000) id BCA603E230E; Fri, 30 Mar 2018 15:15:53 +0200 (CEST) From: Sjoerd Simons To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/tilcdc: Defer probe if there are no connectors Date: Fri, 30 Mar 2018 15:15:53 +0200 Message-Id: <20180330131553.9060-1-sjoerd.simons@collabora.co.uk> X-Mailer: git-send-email 2.16.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Tomi Valkeinen , kernel@collabora.com, linux-kernel@vger.kernel.org, Jyri Sarha MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" During probe there may not be any connectors yet if e.g. the panel failed or hasn't been probed yet. I hitting this in practice the panels probing was being delayed due to using a gpio backlight. Fix this by returning -EPROBE_DEFER so the probing will be retried. Signed-off-by: Sjoerd Simons --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 1afde61f1247..59f0a44bb6e3 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -380,7 +380,7 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) if (!priv->external_connector && ((priv->num_encoders == 0) || (priv->num_connectors == 0))) { dev_err(dev, "no encoders/connectors found\n"); - ret = -ENXIO; + ret = -EPROBE_DEFER; goto init_failed; }