From patchwork Thu Apr 5 08:35:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 132845 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp6018661ljb; Thu, 5 Apr 2018 01:38:55 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+6doYY/9oyiHp9cF2mbaFuZT4TOnlgjMzHHlo5cBqaXem5rVRlQpYwbO1zOhZsQXOzAjeU X-Received: by 10.28.106.17 with SMTP id f17mr10700804wmc.92.1522917534991; Thu, 05 Apr 2018 01:38:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522917534; cv=none; d=google.com; s=arc-20160816; b=qg0ar1hdwoZ/fYzkNKj0lqpQH4OTazuOIcful8tvSYkkoDfRqG3/t+Sw5/DBxnpxEw 3JWEGIbqrMksuB8/IE5KlckFZ3ZDeJdtbq57ifJdZknuk8UBFrm37xyNh1TAUyZZtcTo fkQSEKJVvIJ7AaSzq2UnqJNupJis1M3OaXCzfmfpyvVrFeA9kgVtmgV6thIZNXyyWo9J jBLlXJi7DOE6J6zVTSK4ZZHM1OCuJqmFFARp6j+VTMCZWVYo1qehc7nSn3cVV9h7KSDh ZYMmZFBBiPkbyOyOQIT6FoxYVwD93osGOeCPxAbhuMKjgazE4NPOtOWOA0j3O4uZSZ67 lnCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:message-id:date:cc:to:from :dkim-signature:arc-authentication-results; bh=gxmK053qoTKqk7LqTBD4N+ta4MzP22FlzHz0ydnSBCk=; b=eQEQo7z3+OxE2Gi1dyDRjYznGgm+dwV+C5PSkuqSKmRqeo+lXz8GgZX4NaO3hFHaRJ htwT1heeo9L9nb66V+MHYCb+ma4lk4wXWRNmxFRTLyXNgfXjImN/t2AAxfI9tfCj0Mdb jBBkf4pg+Xppdg430D5B2WNkYkOlNjXyysTZuSG4EbMLH3I1AO1CRpRyj7LcoL6RC46Y bubcreTjPXdV8mAz6ILrr9DdJB4zLJa0lvSYaoaCfFQAsrZ319he+CR6xrndfPhMOWz4 SrUCc4+4RagAVAQVqO4Gjpazmxd3Pxk7VY5ic/NNOMiWHuM1D+28PNfjZtW+mvNdFtAZ L7DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=IZslYUkS; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id w6si5362973wrc.153.2018.04.05.01.38.54; Thu, 05 Apr 2018 01:38:54 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=IZslYUkS; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B70EE1C9D9; Thu, 5 Apr 2018 10:38:53 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) by dpdk.org (Postfix) with ESMTP id DF9AC1C9D4 for ; Thu, 5 Apr 2018 10:38:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gxmK053qoTKqk7LqTBD4N+ta4MzP22FlzHz0ydnSBCk=; b=IZslYUkSKSjUXRDY5zOr0wTTJ9WpKeb+EN/4YnE4yFrDSQJ/bp+dBajNPOJcEW0QaTUE8EZ6VLuAtYx+nvP4lc5w9kcmDvmo+AbDIoZiBw/UWBr0Bclu08NLVd6ht1AAzfK5AwaRy7QoPN+WVsJkm7s+BE+ETi+lneyNCfP/AAw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.10; Thu, 5 Apr 2018 08:38:47 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, akhil.goyal@nxp.com, dpdk-up@NXP1.onmicrosoft.com Date: Thu, 5 Apr 2018 14:05:48 +0530 Message-Id: <1522917349-19049-1-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::17) To AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 03f76199-f515-4f01-1c0c-08d59ad0a689 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0754; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 3:SnpUOGFIURYdAiYUOs6+nrS5TDjKhe4tuOoI/JleJGtCfVsLPZSIqCDG7Ju6DhrRtyuA2ZfTbrUHUyveGRxdswmp+HrhgyywZzLk+xCJMhqA87LKzKG4eZY+qrsOHUuMxkKBW1WsZNljMkIfoEcNIdpdn9nrFEI7PaCx0BduIp00AioLaDspJROVcfthmo65j2OR8sG+Ihi4MF8vwi7ZUW2YJa3blbP3VWxptxOzth/oSG84AfrlCqQr/SADL//z; 25:QycuZRxQogn9lM/XBC45w3NQjhUbDwl+pYxVeyqAxAoBtNBcqlxyE+LqGMyk7mbcD0u26I085qJXpIdizsvd3jJrSsAMZgXTQzPjZg8camsSvBnfywBa6AO/fC6tRAR3ov4qOe25aZTOk0GVofQYobA8gdNolX1/mGTDcsOWCKEOwqsYHxwlvFObCLsBmmHO/cMZMGvYFpMZP8L/8jRsUziH8TVu2tGx+NwpI+8vwJDINDtTHdEOFmVsUmkqnIyCOMLnkeXm06WSZjptnjH0fr1DLRHwvDAGIcJOf3OML1GUyEb8uYlgVw2vlOvtv3TesX3O95fKKE9RDdbBTFIOYg==; 31:gZhozOiNPRi9kcC8yDGm2qer84e46ZqkdeiCFh6FNmWUujealEEF9/0vn7kN64N65VpyggqJZO/tYVLcKssoL576gPI7AHQCZ7vFTvwPr+D8zvRdArgkHzVu/QQLuHA2bKqpnfOb4pEm4Kbpk1PhABYqcjc4MZNJS6trMJ5uqPPu102iOt3ZYX0Dx220Xme7UxJqGQOJadGVCa29RlwmEEFQHQb8rlFgibzqYJg6Gg0= X-MS-TrafficTypeDiagnostic: AM2PR04MB0754: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 20:0mjOK9agYf8JkkTAUpgcjjlPHMKQeP1dF/uZc863KH7cJudqD4cGeCkCCT00FmfS3kDb8xE9atZseaIK5mymqJIf/QgoejCRTY2oWQnbTDG0iauyAOTu2vfmBKFiDdYX1lDbkEXtcivsRveFFB31YrGSM8cffVqQAfG5/KtGfz4gx5G/UBT9yDYbOgdJCZ5FoRVckdcHXsQzekVjt7tXlrhA7c3PC9pGGuvNY8EnVg7vhljOxPBW48PU3cA/keN/y6kDxgSg+AAKbDJGyu+zfvQOuumIR2odh7ziHmVeRtEn4F+WLh6LtFcuIfL2GfryHMbTR5c4veyrhz8CXmp2Lp31U5F9pqmVN1Coe8PrRCpNduWHmDq9sV43u/Xn80H89UzMcuxdVfyYHaLTG/LxrO3mxqx1c9PGiF+eYpaDqaKONSKNE3DYUHXb4+HVLqZADwHSY/BH/4K74r3iujYDfBBBsadMJoBYNgTTZ7a4r7wOjEwrNRyjvSXf3sZlsMED; 4:LEwA2mgnPRTPOoLy+nRpuxh41Jqz3RZTbsZmUwUeBgCI4l70EdG+vVzKPpe65mH6qyJ4k7mqPpMEaUbQzgDWFduY91k7X/r7uroheiBa6C1HjZ8pm26jl38Mgh6U3Dmi+Bjxx6qQ1JX/lXIW/vtgZtAgBsGRXWig/JsjeDT5ARPLk9aH/Ds0aIaXNSJStY8nX48dZ/N/lCzSLLCGLKY3fzmBjTaDbYSI+n/bmuy2HGYWs8W/lOOB2zcNJXxrWy1X1dALfltRza9VDVWVT76+2rFPYsNQuDAAWpvgDWcWLpEMjBefmbSlVKfDkSl1rQKV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0754; X-Forefront-PRVS: 06339BAE63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(346002)(376002)(39860400002)(366004)(189003)(199004)(6486002)(107886003)(26005)(97736004)(2351001)(2616005)(53936002)(86362001)(4326008)(105586002)(956004)(25786009)(16526019)(486006)(305945005)(7736002)(5009440100003)(186003)(2906002)(2361001)(55236004)(52116002)(478600001)(51416003)(8676002)(50466002)(476003)(6916009)(5660300001)(81166006)(81156014)(386003)(68736007)(73566003)(6512007)(316002)(36756003)(50226002)(48376002)(6116002)(106356001)(8936002)(3846002)(59450400001)(47776003)(6506007)(16586007)(66066001)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0754; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0754; 23:AigzbmH1tK482FUdWswqeahX2GedrjbCmxMx4QhEN?= 2/mRzq93WgYJ43ElVzMp7Oaa4JP7jnWMePU/dnj/d0z3rCklB1ou/Bfr8GVWEL4svcQz/P0xqtPQrBvuNyMbsZ5ZoEB0a0d0efJbtGvC6zk8TgOVeYcpWSODmd6OzSiZY9azU3pVDXFGD9qwqNnBwTNkVZgd4AoP5ndOjp4z4IHMU7KcAyD1k9jSOqT/X8ChQ6vaD92L4AsL/R2CWKYb4HlMOISyggnGBe1/BR9g1IJbDQLgJgEu92jX3ZZWnBquDjc7TrR+2GqfsoUmzBVXkdIjAk42HZsdnnXVSMOYNjorekGBdGQKBEcXXwguc4FErBNviOkAZVWI5aXfvH//C5M2pMwp3IJkxZM3QIAFYqmY7HVp34CND7QqJGf0DyIRgUKPTDEQClpmYEmg5UD/g3EKDwvkSQMWEMObhU0RXvNZiq2pH2j4Q3erj0JRH/VDSszFI0iw5GNSrPA4PmezaMyqZGcjJtyLz/Lx/2Mki8tv04MbaNyo+eBp9VTZpLRtHX14mAIjMmLW8OOjJ3W1IMN7DrXwGqDirZkTvIVFQeuF9wcf8rbcdlV0FSR9FJDYObTOjAVbNWAGNncJfsfG3MCIBTBu0GodMBp+EDbDUZ2XfuraB6Pt2XX69d6X4PfsCb1fGP2dp4LcZPzUOEYcQQ1VR/e6lGODDrZFYpPRrYBLvyAD6tGIz9Y6B4zsr/Yhph3aCYNqcfBuoOj8NkCJmNcICj4xONbBISEw412MM58lFQ/fl4ajnDhlp3SfEL8gX8ZrxH2jX7egeN3I2yWYqFjXtKz3itHRnihm2BJ/wGWzs6p1vnFgCiN+IqtbPzDmdQOrZdSP6qyYWKXmLC4Mpop5GJmVrYxYwXUPp2Opfph26SE80b78XI256s1nQzMhe/it+yl3rb1MFm6XBjUH2evMfveW07wPXOZjrpWrT9YFgIoD17I5yJqIi6oLPXmh/vp2C26jY/uOPnsozwsIqvvhukUoVXD4dYUzxc8ZzxuYYzRO3yYiSXTUZTU9KsSH+tx+oobGRWqXwId9LlVRs4CLm2u26YGiryXxSGyburCYG7nZ4u4DpXZ7be1kZ53uv72V1tMQUuCgEBI2S7KCWGwpAZsh0jDN0uJEncuzZk/stmxa1mnjNv5DCT21CgZH8yTWQK1r+i/VDS9xF1wqV7r7Z4tv1JOF+wXDuOlWTCKX99Rb3TS74cVapKVKQYAZeSHJkuSPLRbI8zrVdxGzFiaO5HGM8H49/wdvCHtQkWuug== X-Microsoft-Antispam-Message-Info: 1amyosqjC+hf4LaO6IfLsnhHDx+8MgHcTryh+73hdNMbGPg5gCxFuiSKq0FRviZ9oVrMVXyPX1k9n6OHuM/rzPIM9wEp7uCyCW8C6JP5GN/T8lL5nDk2ha0zYY3XWgtKEMHIMldIKxLFABYIhq5AyjucNLJ9qBNl/50XWXlLGJQdd8fyeWXSoL4QcHxsovD7 X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 6:a4yj2Z5r3HI4JwRch06fciKmi3zhi7HbvJtjRoCQciyYi1HO8DR85QdiC5xYRxOfGZ/p66pUwrUtrXo/mt29VMWgnFn5cz4SydGst9O3vDAkftTPVQFipBNQmPm+t9NPzJss+EwxtYKg/mQk+kosYYmxjnhfsiYyV3tWmK8OZBNU3e5oIzjOsTvdtzuh92cbcJ7Zul/iwI1UNUzUy5tTHZRsYv/PFVHahdGCtSQGf7QbYeHrOzGn1plBBYnL30leLqCHDJ9NZWtyM6CZCSQRsstCdSZ8HxzzBLYumETLrfK6h068CxbWQPXY6kc24F6IcbXW9h95xDg/LqQaZ7cRLTarnc5ppvedQ2pFMLe7HwiW4mMxLIIz8QChvbkx0IxGNbjxV0076ifitWCK0B1++22knY2P+2Jpzem2cj4jFEYDOauXya+Kx3jDNJQ7ITLH5eQlrPkNWw5QxO2jGz3cyw==; 5:lOORWwEd3sY/A+ooyHUnwYQOcmIih8vTD1Azjw2P1PdnUbDnGhYhd8wO5TkXfJxglxF3yG/gL9ub+PGXCIGsLzswbxXsG2wf5WtmmiHt6+HKuL3qM38z5eLen4GR7+bXywMEZLMLU7xGjNc4IbjSJposl+taTDvqiUP+XGU0Quc=; 24:xRqHSkmifAyIK3ylrdE5oQPKFtIKasoNFLtjlJmy1VhjDcHBEaP1IXfL40C/3ZKAIDbZLYI4kbBlu5K95jSU6QLbByY15Tlss0auKFlwwdE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 7:ZWDrZR23DYZLMQ//PTBXFLvI5ABzpxMkWWSNT9NR4CeM62zQVnIvaeiyGXSL4oxST78ssdhTtXXqB2Vp52ywB+wHW0kLm7Q6tBqOdlI/atcHQxNC+xW8EgVh0PplcC+y1UgAqRMz7nwbr0CFAKCW3voRXrsdu1nypux5eqeoYs/Ey1w5jAy42Kqk8cr5j81tlC7PHKKIr5SQOf6hsnyaSkPivYWiP4jPMo3S3/LaJGmlTIORKsYe7AQzxlHPelXZ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2018 08:38:47.1609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03f76199-f515-4f01-1c0c-08d59ad0a689 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754 Subject: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve the error checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Sunil Kumar Kori Reported by NXP's internal coverity Signed-off-by: Sunil Kumar Kori --- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.7.4 Acked-by: Akhil Goyal diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index c5191ce..79ccb22 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -388,7 +388,7 @@ static int dpaa_sec_prep_cdb(dpaa_sec_session *ses) { struct alginfo alginfo_c = {0}, alginfo_a = {0}, alginfo = {0}; - uint32_t shared_desc_len = 0; + int32_t shared_desc_len = 0; struct sec_cdb *cdb = &ses->cdb; int err; #if RTE_BYTE_ORDER == RTE_BIG_ENDIAN @@ -530,6 +530,12 @@ dpaa_sec_prep_cdb(dpaa_sec_session *ses) ses->digest_length, ses->dir); } } + + if (shared_desc_len < 0) { + PMD_TX_LOG(ERR, "error in preparing command block\n"); + return shared_desc_len; + } + cdb->sh_hdr.hi.field.idlen = shared_desc_len; cdb->sh_hdr.hi.word = rte_cpu_to_be_32(cdb->sh_hdr.hi.word); cdb->sh_hdr.lo.word = rte_cpu_to_be_32(cdb->sh_hdr.lo.word); From patchwork Thu Apr 5 08:35:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 132846 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp6018752ljb; Thu, 5 Apr 2018 01:39:01 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/IDhINV/P5E07Fu6Xe1vIVLsiIaVvZY18VPMoJ5m+YsEDBJuY9iYfGG9Vt9va1DJTs8FDY X-Received: by 10.28.22.66 with SMTP id 63mr8957683wmw.5.1522917541850; Thu, 05 Apr 2018 01:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522917541; cv=none; d=google.com; s=arc-20160816; b=C0IXHo8MliIPfYpGZ/LWyXgen31unwBiYnlxcglhMp+RZwUXnJrdwT6YZF637IrXi4 R/VLKc9i9N+oe3amiHu65ZxKYchpbjoLnF3QMUQAQiPpmdFDYWNuSSfD22FZBsA1FdMr JaODx3SSx/Q9K+8vqj8jAE9Jwdx6Mbs9o4ZBsoUpgAtNuomRwNgDueeYQd60BvzSMFRF IUrtbHpfyCDmFoBbfM2MxmWQ9QxdH3jmqNRMj3CYE/yyBGD4d8bZXIppheTxq3jlHRAW A8BlgqXEOV5slYvaG5hQ8LKbJsigZWclXmTW7r83eC/Y15AEnmFTEdUyF/SDBVuWCXPS XsbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=prsyJn0aLXwQM3IktZiucZs3V/q1J6ItaBDJ8T1HTP0=; b=LXoK32nXJT2C8Zh5BP4XNC42YkBCWw50nBokn54SYeFP893LeUkrxRyOOLSUoLiI2J D9MfCw81O9Vd1xl1GCnPq7S1ikoYOwXz2RL7A1bK70s03qlmQC94ud01aJJbYCu609bq RFmEPxy3gaqr/y2nZZaM6DbLjor0+2e05SXgllnpoMECg4HiVLnUsky1dC6EUUo9Uo+q PX7WG2qfjiVlWADccAuJL/CgR66NlM/wck1pIfQPd8uOzZB45PtR2xHXZdRa6xjGj4Mi 8R6zk0dgknJ1k7ogPkiY3IpBgHGwk9m10tphTS1pW/kLygtV8K8RX+5TKoR/xAD34B9B jzzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=JvPVsbl1; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id s8si3663514wmb.65.2018.04.05.01.39.01; Thu, 05 Apr 2018 01:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=JvPVsbl1; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 853F01C9E5; Thu, 5 Apr 2018 10:38:55 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20077.outbound.protection.outlook.com [40.107.2.77]) by dpdk.org (Postfix) with ESMTP id BA9561C9DA for ; Thu, 5 Apr 2018 10:38:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=prsyJn0aLXwQM3IktZiucZs3V/q1J6ItaBDJ8T1HTP0=; b=JvPVsbl1RoUXFfS3QFUW/h7VLbvf/GOb3KQC1CjueuRUiqPGArrNsxWhAEWpZFhuxb+ls2Q4uh2Enkb4Q3BBBje9Bi2zAVWF9FV4ckcsewxHw658zUG5A1cod/RDW0eZnK+T+IBYqMY1twHr1HgDgod157lXvM8Q2JKwMu0DAJM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.10; Thu, 5 Apr 2018 08:38:50 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, akhil.goyal@nxp.com, dpdk-up@NXP1.onmicrosoft.com Date: Thu, 5 Apr 2018 14:05:49 +0530 Message-Id: <1522917349-19049-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522917349-19049-1-git-send-email-hemant.agrawal@nxp.com> References: <1522917349-19049-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::17) To AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2c6a9bac-3a39-4651-52ef-08d59ad0a8a6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0754; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 3:9QuURRQ7TfXnaR8hiTsT7cIrwAdtG4GdJAHOBWd1Qqk2/+hkBgFy9H5JBdBnn2NfdelKYtdezR5pm6O4o+wzN+AIRimNndod3fj69vT7wsKh/WjYRoy09ap/dpLQdfXrO96DBJDIGerrfSMeSu75Jx3aNVvih6hTJT43X4WOOS0AIp1U0AvbHiZoT11kzO+Y9+Ruo1rwhfJK3rqeISUQ9RdYT4d9x6cSHAEi4b6aDlfQ5ZbrpYkvQueWJ00aPP/4; 25:9ESc75fDTfiKZlevpWhov7ZYJdBg7oH4/Ylrsr8o15Ln23GIoNC6Wjs85MV4Z1UBmQZN8OQ3MWsy6mP2wXkL+LZUeHAV49MbK2SMxM+KAsQk9xlzz22v+LIewrSqmTGF6PSBwLCsmJlQO9gfGnhEaqeoJqSFh64hiyqnWbJDCfVmqXKAVoj0dG/7e+0KRaWT4MEWaw90WKAP6QPhUiuKQ1yjFDDuFnKQT+788LvEWDO8mII42WCF1Ovt27j5ShC7H70q76VZfNJ2zxQF6UZCSxSJqrRgCkPTiM588TLrueys5EWIlKSt55sHffBlHGL4Mce+m7sCwVOTbSEgg/RZkQ==; 31:CodVG6qQzwbhNFAmMLuZRYvh2B0ijVkumWZpSDlWX6WCJWzovrsXZD2LFpXq+altdj8SF0x2l6EygXQ+y8MkWvJ45hGLxOFlQx7hzfp/TqrlX0bhM88P4VWjSAaQSU7aDt0vrk78cFfnPwf95fc5Qbr0bhuxIM8xydNj3jFt5sIuoaSJmDw2bplnvyzLXN7aFMvh6fVcWDa9fxPMpHk5hjT8JvYRNEpzKqAq5W8dBGQ= X-MS-TrafficTypeDiagnostic: AM2PR04MB0754: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 20:AgnkD8sfEzSVwj/iWYNKOPnttRKdQlv3uCIUl1bL+Jfl8D0JAkULmZ9rGB5RhgK/aRjX/XsqRCsQeGmqTTaNQ8PZHKqooDp8H5x+yYB/rr4X1rymTij/DyU5NMr1dhU+leXaoeMmXbgB6nS9Uc6K/wWO9OgWONdN1fma2EqbBpihnrbTwdmIJlEpatYa9ZCnPtXq3iHjJiIVmUT8r4CqfZ2nIFT5AFklEFQGptrARivK1YBoZmfBdGV30Bw2TTid2m7/KF87v9O1kzNhfMYfiymO0WRAtNwnj9iJitEjeUrW3fwffRXyFhUt8qwCY5DzDVlwpJ3DWN/K16ZZMP/v7j5ChgcNCzTGyVdv/V4Q5i5oS0Zg6ezTqYpi58Hs47u+u/5foOOXeKe1F+k/NOYWgcJRneJYg5TUkBiIxNhwNuf+/udKIf6TJrkEDsq49zZx3CGU9Q96UdXKzxGp8yWTfOWYEOXi52zwePZmqzfJnDXotdOh9Zqa90Ln/pXiIxps; 4:fFZZR/kyhQYlMrqRSBl90yKqzQReTpcFvXnEgBbCpA6WOF1vY12uqSY55GqQgdFPT1ZaxwTJTUxMOLYDRKBsUjVIpnfAGiXwxtJhugD240P3BkTRBORqAR/6TeDtMYF+QzUS4y9G3mKB14nyJvYC+Y+mrotmv6eobadejT7T8WruY8wAxwpotVEJKybykg05f75+pJZaAyHoz/Yo49+OtcNFhYWOSjMt1FBcE+PKBFxkjor7rIutKGSo6NVtB5Kx9k0dAX0siid7J+Z5pHQ98VrNNUkNxmjOViNdquYsAHGtorP5DtYzIsPb4vLoQf7J X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0754; X-Forefront-PRVS: 06339BAE63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(346002)(376002)(39860400002)(366004)(189003)(199004)(6486002)(107886003)(26005)(97736004)(2351001)(2616005)(53936002)(86362001)(4326008)(105586002)(956004)(25786009)(16526019)(486006)(305945005)(7736002)(5009440100003)(186003)(2906002)(2361001)(446003)(55236004)(52116002)(478600001)(51416003)(8676002)(50466002)(476003)(6916009)(5660300001)(81166006)(81156014)(11346002)(386003)(76176011)(68736007)(73566003)(6512007)(316002)(36756003)(50226002)(48376002)(6116002)(106356001)(8936002)(3846002)(47776003)(6506007)(16586007)(66066001)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0754; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0754; 23:9hcT8nM2KFkr1AeZ9KTO+NfXE3jMxgE1vmaAiEVyu?= uF5F95Wk2GZU04N1SwGVMnhoLJxfQ7F+gh7kkoh2fSCQsuSTlQJFADqtvsnuYoF9vIqC8hhhQnibTTZOnSg4fhbr6sxC9zQrbdnuWQFxGj9eailxvBzFVGxZaayOcgO4qTEaim/s+XqJzhpDjJ9jvXYAceIYD4rme6MWXY21PZYsaN32/zWVqq2Sf7f4BmWu7AD5ltJAzbsmwW08x9RTmdjpCY8StZvFxGWDpMr3pfwwGFqEm//rKevp0poZ/o8JzC1ZHmrtIXz36g8ody3iO2csZb6rDfRpO1JD2YKw1By774xhenuwvNxkjihROkK1c/4qHHEVqJyLkCKLDffvG399z/qasdpmzo1SVvprykLkHczGdAVhU2S7JRbClbtlnLGtFAW5Yb1LhQ9+6WtNkjX15NtkrzOcvx4emNj/fg0ND+YJhYd27xSG4n4GjCbuXMhB0fAmQJ5uq9uwxBMm8iQKCh+8BRpmNBcI+UmihFnSNsaZajBktIlQbC4a+C5628+yM1FOoetYx2HBpRuJKL7Q761LlcdmB+qt+WBBSz8y6ygYu10shLXfg9wSFMRlvK41yIBgtj8+CYMGpKiBBqc6BTDegdKJZ0C8Wk3HbUlrFooeryH7rZuQC22vtPSVlua2O2iBCxoE/7mEjpRcnh5J6+8uIlse3wWsrKtDt09F5uKH1SobOSa70KymkKmoAwKV/FEYJh6954tHwHMq6w8+96Jvb7o9aRn/2AyWDRPWc/houHqb1M2mhTSLylhcbSCGPMV7M6XBVLmPO3BVdwfASjALtxHfN/EboBTWmFTma8LNA0XjLM7wbHtIigBgNsbRIV7Ni0OM9rdqAVy3vl5S1nD52FSE5yFKKjQYjWInVfyhpw3/bNxvxWwn7FQxiguZmuku0PFHg1IwF0YVdBt6DX059nESX9lslBXToo+Y/CyD23UloW8FwZHAF1g3Sec5D8LnyE5r8+O2LVmuRXzP/M7hMFd7Dmv1n7wMx6/BKzpF7EByoO6cbp0Rzsks1W1d62uW/D86DGN1VOy1ektL3x3vQSHREuN10yRlpe7PCe4S/HNw2SxLoLkEm4k7RpcpH/3k2oYbgaycidMEmxKGpHVjQCCjzr4V+FI/mgtjjYqfkqMwXBLhDgWX524PKywLY7X/cPoGsGzCrFXdqtSno2deXcHw/Va3ql0Kjwk1fgagFrZVh1bHKLh5liOMIQIdUNcR6SLB8mme+8IBIAXK//Wivjrw6iq/AYFWnvEbqPjXTJuytyb4q1QgSjsNRA= X-Microsoft-Antispam-Message-Info: mapaLn50XNoOKhgpuhT//afN9/ycx+rJvgHyizR44qacuvHeqSc3v4YezYZz51fq4/ZsIvXkqv1j8EgUWOFXc4AXBllqA+ZPTbI+7Jte3CwfFWcuEGdUAl37VUqgyJQLntKPC3LT+HBrVkZ/mTovWvuMMoS8ljRvNcl5t4rlbQE93v5Eap0UWV5N8OBfLKt3 X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 6:qKJ92Qr8mjIMpYrNgSB+HDcmU3cQQQWHEgqWBFyMNlwMJKDqoj7ndZArk7fu094/oZhiqd6S+YJYJXfKvUusOArxg0lP7nfAUmWqp6C2llBAN/39QK7he9CZ6f9CLxfLAVUrci5vmNuqYK1sNIDKw1wIz9fhBemBvRUVLKLwGgrhFSQlt1T3XNyGacoknSDC/wCdfILtyZJODefJ5Q1xF0qomM3+fgplCZhK1CuIgg2rsgvFzOQjJCdd7umUBx61xeE99CnI2TBsQeLLfklolB9AqUfaYQrJRonpQAtzYX/687FzeJm9uLlYOb2dpA7OV3fdndqoORdo+IndOgopbE9yX1dFZe5iUWbpPN3cqOAhBS+ut9fLYt/jg3zyQkBMlLx3nPgtPfkG0IXgGlul0nBlYD4YHADoBamPhk4X8MIMz+6fRXiG5uWlo7dRtvFlMVxPSFZD6z6QTYwkDbk0UA==; 5:NAszOHbJC1RIbMWIErSbA717mXcOi/8xg8Wc8NTMrdKnSW1M+BCamqypskMmWjtvf7V4ATVMxri+R4eQ5roAaJain220yGlqXSjNrF5kjPdqIzDdCFynEMX7Pz+CGPY6TRSz9O6046cte/jZjaQs6OEjrMIZ8guJJAUKpUFzVNc=; 24:uUM7JyCdRe0LVmTc/Hv4BjwZjzVmgvjttZ8vXfrOHUX+I1vhdSfyg4OJjFD/iqFZe947x/cXXnBU4PQGggeChmCDOYRsc2/Gum/8NxDYXEE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 7:nyRTHa77EldojDQ2HJRads+fcV/Lf8e/akwKXZAOdlMJ1vh3Cne88a3/uJgikgA3yFj4RVBwuI8u0lNG/EjmgiWJZgCY0OgY+JAIIY2qQHw3+ETIWEK3P4TsbYznVFy6zji/uO/PtIy8eDdOjcxCR55o3PQ0RY+p7u6HPxPSfqqZ/fcHBUAbGd+kTmfE0PpCgewO7ElL08/zRp3S7bW8RZSLPTYK9bXK8T0v//2L58oNYwRCsZVfV/wI8uYMYqTd X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2018 08:38:50.7078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c6a9bac-3a39-4651-52ef-08d59ad0a8a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754 Subject: [dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: improve error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Sunil Kumar Kori Fixed as reported by NXP's internal coverity. Also part of dpdk coverity. Coverity issue: 268331 Coverity issue: 268333 Signed-off-by: Sunil Kumar Kori --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) -- 2.7.4 Acked-by: Akhil Goyal diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 23012e3..d02d821 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -1627,7 +1627,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev, { struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private; struct alginfo authdata; - unsigned int bufsize, i; + int bufsize, i; struct ctxt_priv *priv; struct sec_flow_context *flc; @@ -1723,6 +1723,10 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev, bufsize = cnstr_shdsc_hmac(priv->flc_desc[DESC_INITFINAL].desc, 1, 0, &authdata, !session->dir, session->digest_length); + if (bufsize < 0) { + DPAA2_SEC_ERR("Crypto: Invalid buffer length"); + goto error_out; + } flc->word1_sdl = (uint8_t)bufsize; flc->word2_rflc_31_0 = lower_32_bits( @@ -1753,7 +1757,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, struct dpaa2_sec_aead_ctxt *ctxt = &session->ext_params.aead_ctxt; struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private; struct alginfo aeaddata; - unsigned int bufsize, i; + int bufsize, i; struct ctxt_priv *priv; struct sec_flow_context *flc; struct rte_crypto_aead_xform *aead_xform = &xform->aead; @@ -1844,6 +1848,11 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, priv->flc_desc[0].desc, 1, 0, &aeaddata, session->iv.length, session->digest_length); + if (bufsize < 0) { + DPAA2_SEC_ERR("Crypto: Invalid buffer length"); + goto error_out; + } + flc->word1_sdl = (uint8_t)bufsize; flc->word2_rflc_31_0 = lower_32_bits( (size_t)&(((struct dpaa2_sec_qp *) @@ -1873,7 +1882,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, struct dpaa2_sec_aead_ctxt *ctxt = &session->ext_params.aead_ctxt; struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private; struct alginfo authdata, cipherdata; - unsigned int bufsize, i; + int bufsize, i; struct ctxt_priv *priv; struct sec_flow_context *flc; struct rte_crypto_cipher_xform *cipher_xform; @@ -2065,6 +2074,10 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, ctxt->auth_only_len, session->digest_length, session->dir); + if (bufsize < 0) { + DPAA2_SEC_ERR("Crypto: Invalid buffer length"); + goto error_out; + } } else { DPAA2_SEC_ERR("Hash before cipher not supported"); goto error_out; @@ -2156,7 +2169,7 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev, struct ipsec_encap_pdb encap_pdb; struct ipsec_decap_pdb decap_pdb; struct alginfo authdata, cipherdata; - unsigned int bufsize; + int bufsize; struct sec_flow_context *flc; PMD_INIT_FUNC_TRACE(); @@ -2346,6 +2359,12 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev, 1, 0, &decap_pdb, &cipherdata, &authdata); } else goto out; + + if (bufsize < 0) { + DPAA2_SEC_ERR("Crypto: Invalid buffer length"); + goto out; + } + flc->word1_sdl = (uint8_t)bufsize; /* Enable the stashing control bit */