From patchwork Fri Mar 5 17:03:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 393527 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp596732jai; Fri, 5 Mar 2021 09:04:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7pGYIO7xUa/b6snp3CJQrOz3uUzy8Ka/S4BosW6OQXfdhNIPGAmUUAXM/17L3A2pBhdfI X-Received: by 2002:a05:6a00:884:b029:1b4:440f:bce7 with SMTP id q4-20020a056a000884b02901b4440fbce7mr10284208pfj.20.1614963839885; Fri, 05 Mar 2021 09:03:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614963839; cv=none; d=google.com; s=arc-20160816; b=ldEKQGHEuTMbcfb2+6XlpC4pIW/2GPeBa6iRuNk6sv9DkFwxibYyUjAuizJN4tTRGg Z9Nytl3ZFeXS0rbPX0Q4zFmM7p0CmHABCvME2BtMG8GgT7+cNbta1QzHFFJ7+4OYGdLN SnT+z7USgzGp7ZH1e8YQEJZT/nJCFk5NnIhF3e4o1xpiJAhlGV24EBJXgDOoJWL/5bAq YcO1GjBEQt0J2UJsoO8RwTqAtFUJdnChoBSbpk88Ren1/NtvkK4WlGetbCrGP7fzIQFm 32tLSviAhNUS3gReFLQwZ5vmH251f9MNhjshjjU7kPLR5+17Qw74lcoL2W4IpR4BQ+CG agJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=OSH1tdk71siA+L8I4oWGHr7gNJCPHLxAbaOhafupgHc=; b=hlW4QDffYvtUI7Fjxh7eL+gaDEAaazlu8zQN7kQB2uHXop65uh4HeD/FZbsLLQW/CJ CB9VkqYHzdlG0f1Nbnz2yuOxmMehOmDMjxZcTahdsD4lb65GE/RULTf9QfVFqte0PyLk i4JibJsBokwlLeGozStKFW4/B+WIytS6X78fKop/JPHM8qU8gG3KHy+yFluVGAMyCC6G QBZ4DvLCZo8ZdavpsidoUL1/uoBVv7TE1OZNZPyOGOMGH9YvL0G6NeYybxfFBBQqT7b3 xCzD7XlXfqZo05nqTrIW3Vgsz8eNTtmiT8icSyqrP7CM3ohpItiudPEFxP8Plkv6cm36 zoBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgZURChU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id y10si3135932plp.242.2021.03.05.09.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgZURChU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1AD26E223; Fri, 5 Mar 2021 17:03:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF9E66E13C for ; Fri, 5 Mar 2021 17:03:54 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id e23so2067006wmh.3 for ; Fri, 05 Mar 2021 09:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=TgZURChUGXUbgDO2bV0UsU+s1j/d5KKVOwy39jkcxWe/38xJxE8XgQo917QUm+QWZx 2rsQ+GfXyOcIsol9aos7nC+fVNMkUvQwzoG5Zz6McgO7oengrXe5q+vHiuUp+foGg+49 Sda8/VQh1uaa3anhia/BbnTRkLROiFiCh+yjAMM2y4Kt5Z0Vz/E9vgcbBTKTsFBN18Z3 us1vgkBE5QhZ3hUt66DqUWgUzb23W/10IX7tmRGQrOgYj/m6dnbsJfywsit+pgpB+JW1 koIJk3T02fYaDHy/Xf2D/JPPaD7P24OeeE/UgmWLHqJ7eLs/J6XJUXjBQPjrNY+FA4nl 3YoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=t017CSj8b+xF7aYsfq/jXmUJG2cq5NByaqTClHMsYW1h+UpEn8ydeFE3j9MwdG7QqR RsYoVcZu0rlUNMVxUTeMikN7hQ18dIXYUuESD8B2x8rMuPzE/IUoB+6HbPKlkDwnV8+Q E0JZrsGZDi9btQmMnNqR0UrfeM/gGmPCBbvJBgw0RU7bQg5nj7TeYBizMFnAmrhfb0Jy FmcxKD5rMtKqJyX/NUQvyIpq7MWFKYlpxEXzJX/ZAkKHcMpWtisPuEJNrkHgwNOGvm0U z6jyd7QSqCRELh0Qmc1qwtyDTl31uIBl8GkWd+POKuLR1yluVuqXRLTTghTZDeLLZeMS bFVg== X-Gm-Message-State: AOAM531pyt5Vze3nVMVIgOq/JiF/D9/XvZEYzZCwd3dGAUH1fKmH1NyI tcUXqGMJGrJdXFuNuPDciHIvcA== X-Received: by 2002:a05:600c:35c1:: with SMTP id r1mr9670239wmq.60.1614963832386; Fri, 05 Mar 2021 09:03:52 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id p17sm4760934wmq.47.2021.03.05.09.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:51 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v2 2/4] devfreq/drivers/lima: Use devfreq cooling device registration Date: Fri, 5 Mar 2021 18:03:35 +0100 Message-Id: <20210305170338.13647-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305170338.13647-1-daniel.lezcano@linaro.org> References: <20210305170338.13647-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:DRM DRIVERS FOR LIMA" , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS FOR LIMA" , steven.price@arm.com, Qiang Yu , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/lima/lima_devfreq.c | 14 +------------- drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..86aea1bdc4f4 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -7,7 +7,6 @@ */ #include #include -#include #include #include #include @@ -84,17 +83,13 @@ static struct devfreq_dev_profile lima_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, + .is_cooling_device = true, }; void lima_devfreq_fini(struct lima_device *ldev) { struct lima_devfreq *devfreq = &ldev->devfreq; - if (devfreq->cooling) { - devfreq_cooling_unregister(devfreq->cooling); - devfreq->cooling = NULL; - } - if (devfreq->devfreq) { devm_devfreq_remove_device(ldev->dev, devfreq->devfreq); devfreq->devfreq = NULL; @@ -110,7 +105,6 @@ void lima_devfreq_fini(struct lima_device *ldev) int lima_devfreq_init(struct lima_device *ldev) { - struct thermal_cooling_device *cooling; struct device *dev = ldev->dev; struct opp_table *opp_table; struct devfreq *devfreq; @@ -173,12 +167,6 @@ int lima_devfreq_init(struct lima_device *ldev) ldevfreq->devfreq = devfreq; - cooling = of_devfreq_cooling_register(dev->of_node, devfreq); - if (IS_ERR(cooling)) - dev_info(dev, "Failed to register cooling device\n"); - else - ldevfreq->cooling = cooling; - return 0; err_fini: diff --git a/drivers/gpu/drm/lima/lima_devfreq.h b/drivers/gpu/drm/lima/lima_devfreq.h index 2d9b3008ce77..c43a2069e5d3 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.h +++ b/drivers/gpu/drm/lima/lima_devfreq.h @@ -9,7 +9,6 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; struct lima_device; @@ -17,7 +16,6 @@ struct lima_devfreq { struct devfreq *devfreq; struct opp_table *clkname_opp_table; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; ktime_t busy_time; ktime_t idle_time; From patchwork Fri Mar 5 17:03:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 393528 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp596792jai; Fri, 5 Mar 2021 09:04:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQvX8+0Q0TbG33um/1u4jxoiZNRX2+RV/DJjfqtnvDL1WkyuCTpvR4zQehfUhqj0mM+G/8 X-Received: by 2002:a63:534f:: with SMTP id t15mr10009935pgl.126.1614963843188; Fri, 05 Mar 2021 09:04:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614963843; cv=none; d=google.com; s=arc-20160816; b=nPTn/4GfiZYCefDtnz9dfd+vb6lyDFxBlIQMeJQ+SBNfXLwBeRtHyPA4jZ3AzChXzc 1Vhmcy8qmAWtUJKFeTCfTN6ONIHzYZwVNRuRBbhQrm5L4yP1xhhX+G4Rgk7asJwsncNx v7D5eZoAONlCNiEMqCbX6qx8cw9/1K7BtRQgQ6zx+p4tTwPTaY7fWMZ2FVjbUjJzyB/Y rAcYE0h1rq8kyHcbiC4IbF6EIJxSlDEoQPXn6KYT2f1YFmV7A306DEpexA1aqas+vgyU sQPGbCqxrDZ/3Yc8oQ2QUAZrG2duJ9pUjNkF3He82ycQyRpgV3qP8+qvJ2QdES7smmUV RfLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=7LEJW/C5E7y4xVwd66YXAzGRxCjBZYD4mQkAdnSSYdQ=; b=PS6Gv6PD30d1gFGfBSLWdz+z2JI7iY7RGuhRmwt0QwfHmeSe2AexvsSSucGS4U/CUv MLHFuXDk1h3NKcfFS5nA3SntnitQd3UcKwYT/QyhhZIaqs6CJKvZz+diAOiAz5PIDwfQ G5K4Ii32Kh1VumqLFMQxLiY1KDg9ApEWSrmVsFLKTn/oD6R6gXiJi+gnHAXMvA4+rQ0G RX1gWODZfMHBkisQMc6AhKJADPAA2r/QCADk6rEsCp0KO78r93JtddeBs7VG3C04wh9h fhkqxNbQV6allsAbtS8BgNTC8OWVcJaQDzY/ckkmXj+zVCanJ533vs4KyECa44+vb7Sl Edag== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oNEKdz6x; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r190si108626pfc.5.2021.03.05.09.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:04:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oNEKdz6x; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 821AD6EBFE; Fri, 5 Mar 2021 17:03:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6769F6E13C for ; Fri, 5 Mar 2021 17:03:55 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id u16so2863386wrt.1 for ; Fri, 05 Mar 2021 09:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=oNEKdz6xPt7rWWlY08YTlqJ+lKrJjFhTuySIUMQ0e+4R72ftmlHWkmFwbJE/yj/0L9 KQMDY7H55bE4DUmCGgWXZyl+eFIMBmfgbneFavsgAAhHFKhJqgZ0E2SRJFr8EYlYdBX3 HLYPLXCO66AqeADhGbMjohltUr1f+KTc3M9FN9QB1IMSKfgOS5XfD/kaKEdd5SRqmln3 ckKfK0l4tR15SPjWq+QWJuU49+H+lNH4Fuxx/IhwJfx6LBmYllz+9uOYVE1kgQg8wMgQ DUzBop11GMlwrMWg2owHd0e46fK8c8XFG/ErkGfIy15tj6hntwGkhRBFjr1eyuGxUJT6 9Pjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=NntntCZXzToJCcmd4VGk8anQ6WJ7SEdl+TNFlLQe6FEXoft0fyBmd1V31WkJzgU0E1 t2qaU3tkZLzK+VMWBBMQHavaWBZb308qQVZo9CaEKS8jqP1iTuXbLd62GrQYx5tRNNOY JP5oo5t29Rw24z2rzZ+8cfx8RMEsEH2lw4ks1xXaZPS1fNEGRuLPtuDLCtLPrVEFu1QD 95nl11fw5IY4d9sz95A7LsBOGOzQsmAbbiWBjmhsUPXa9rBZkklomeoTi60sn+DXXsM4 wCaL4neTeskYW2KsVnJs826+l410LxA9P1eK/JENmqVQdDc7pj/o8i4lcQ9vaa1420Mq ggyQ== X-Gm-Message-State: AOAM530DC6SicGwo/jDSGKhHh2TUUJtXOFUen/sDwhOHPLsElF6upaaR ufcDRvONOCCl5mLLJiAnRDpdQA== X-Received: by 2002:a5d:68cd:: with SMTP id p13mr10821095wrw.247.1614963833977; Fri, 05 Mar 2021 09:03:53 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id p17sm4760934wmq.47.2021.03.05.09.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:53 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v2 3/4] devfreq/drivers/msm: Use devfreq cooling device registration Date: Fri, 5 Mar 2021 18:03:36 +0100 Message-Id: <20210305170338.13647-3-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305170338.13647-1-daniel.lezcano@linaro.org> References: <20210305170338.13647-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-kernel@vger.kernel.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" , steven.price@arm.com, Sean Paul , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on dragonboard 845c Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/msm/msm_gpu.c | 12 +----------- drivers/gpu/drm/msm/msm_gpu.h | 2 -- 2 files changed, 1 insertion(+), 13 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index ab7c167b0623..eade94271a60 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include @@ -82,6 +81,7 @@ static struct devfreq_dev_profile msm_devfreq_profile = { .target = msm_devfreq_target, .get_dev_status = msm_devfreq_get_dev_status, .get_cur_freq = msm_devfreq_get_cur_freq, + .is_cooling_device = true, }; static void msm_devfreq_init(struct msm_gpu *gpu) @@ -112,14 +112,6 @@ static void msm_devfreq_init(struct msm_gpu *gpu) } devfreq_suspend_device(gpu->devfreq.devfreq); - - gpu->cooling = of_devfreq_cooling_register(gpu->pdev->dev.of_node, - gpu->devfreq.devfreq); - if (IS_ERR(gpu->cooling)) { - DRM_DEV_ERROR(&gpu->pdev->dev, - "Couldn't register GPU cooling device\n"); - gpu->cooling = NULL; - } } static int enable_pwrrail(struct msm_gpu *gpu) @@ -1056,6 +1048,4 @@ void msm_gpu_cleanup(struct msm_gpu *gpu) if (gpu->worker) { kthread_destroy_worker(gpu->worker); } - - devfreq_cooling_unregister(gpu->cooling); } diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index d7cd02cd2109..93419368bac8 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -155,8 +155,6 @@ struct msm_gpu { struct msm_gpu_state *crashstate; /* True if the hardware supports expanded apriv (a650 and newer) */ bool hw_apriv; - - struct thermal_cooling_device *cooling; }; static inline struct msm_gpu *dev_to_gpu(struct device *dev) From patchwork Fri Mar 5 17:03:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 393529 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp596844jai; Fri, 5 Mar 2021 09:04:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8IZK2qhgQsbdLgcppU2lCdb+iDButCjJKJyBMRoJHwzNEAODWvHlxooTRkptVOy7R4+5g X-Received: by 2002:a63:d24e:: with SMTP id t14mr9341605pgi.348.1614963845644; Fri, 05 Mar 2021 09:04:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614963845; cv=none; d=google.com; s=arc-20160816; b=SUU0tEcmx5M6ITY9Myd1r88REgtoWTesZoFe1xiL17AgSzGNSanUwq6m8srWo1FUMd 2BB5LJuZI4aRPQ9HkXlz/RMZG6EA7LWUPNNebi8t+iMF9gQoXibEJLVpnHaVG/5KPvgU N35X8mP8lAea8KijavICuc58kIv+W+ZV6JiXWl1r/ZSAb+qlB73XA8ovOMK/9B7mr21T F7YCeRxElyE+XBGQMz0gjQmgC07frbQxxFT7OBH+i+JBtAlNjL0HsVgLycOMc7/T4+It G8Y627Rg1qWkEJSZ3NvNJRV2ffZIRO4KeeiCLlg1Uh70+HhRojWdhIjZWMsrmoe/U+4R HehA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=N+kS6nGilrRZWlxzLwj9S5TsHpH3UhA/Fid0a8fqpWM=; b=vZe8Pw3Gki7Le0o/jcPi9AUY8cZ7G8x36Z2jJq2KY7sNiM4IRNDEQmEbj0AblNii63 3tp4i0EP+g7UlrVDoS/qdRv758NuBjruIfn3l5MobYpow+CKSZhyPZoCGgpYG3hzy6hg JqLGa6DLZh3tohBAZjhq2hIEm8gXLbu2vLYA51V+hjyrDWHYjy7U8lZ8FQwCG/ZWxJw/ NUhc8rJhlDB7qussdZD+h0HiCgGQEc050XQXXM9aB/NEEDzswE8jKfwotUgAoJt2hazc 9DXsH1kr/Eb4LcgavG8GURDozs9Svl6x8xiBDcrCYfiSj1ZijwTm0dNMn5qrbJd2ZGcD WIsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=swIYYukm; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id 205si3308636pgf.216.2021.03.05.09.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:04:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=swIYYukm; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 747326EB95; Fri, 5 Mar 2021 17:03:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id D20F26EB95 for ; Fri, 5 Mar 2021 17:03:56 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id d11so2852573wrj.7 for ; Fri, 05 Mar 2021 09:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=swIYYukmXBPaja9sOQciBRpjvLCS+zDwCEO0LYBBETH1USSmuqSzF0c5EQfiCG2Wo2 GLUPdq8UftrXP9o9q2Eu3qYe6zVzpqQIbQPM3uClUG5+DcyhsuBHBe+fsv5Qrs5K5EfX oNfWy6b3fFjbQ6xAo4gIYcM9qYdOUwz3NJk84Bk3TbBXf8p7dSkL0pBOSDclsPQzWJ1z XM6+6xA4ghBTSuC6vRQ3m60/51XI68pU/kbjgztoQqNuUg7aWcj0EDDJFfl/Dp6W7Rvo 2iireZy5lAjM/nLHQ13lB3v80mBbVi2Ka4GHqjgQl87pIk4q0ChWX7Q/P3tHGPNuzOfP 2l1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=jGFH/PsSspCnsQEYQKp5o85ME6QoiWRm51jF3FBXCj+R61I3s/KiniWjOuz+KQQguU nb9fwRp0tFEBYJkIg9X/GhTrIHWnN5e1s6pf1Yn7CmoMo2r2WQt08gfYOW6E26n9kAw0 1psgKNZ/hw9Kyn6IF3U8vMfHN2o06fD350qcgHB5KdcxRrWSSLkmBIfavP8CoZPkM8n7 v6VhoM7EwMkeY8L420aA7/byLKSp6fmSg6Ic6VpHijL5uTA6/YNPREVgpZ1ArtnWy95Z Ex9RdKQm/BX4Ok+Ju8/tasuKMl8NDx3lYzno9M8KL1BK5qmr8aDQYMADwpgg28MxvdB3 WKHg== X-Gm-Message-State: AOAM532bfWkQevghyB992MXWwvrEXCz/WLM0+pJA3f6hyjTQu5ijFLP3 ypJAWP4L0hwoSaMUW79fkbR0i9jS9F61Dw== X-Received: by 2002:a5d:6b0a:: with SMTP id v10mr10296497wrw.183.1614963835502; Fri, 05 Mar 2021 09:03:55 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id p17sm4760934wmq.47.2021.03.05.09.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:55 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v2 4/4] devfreq/drivers/panfrost: Use devfreq cooling device registration Date: Fri, 5 Mar 2021 18:03:37 +0100 Message-Id: <20210305170338.13647-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305170338.13647-1-daniel.lezcano@linaro.org> References: <20210305170338.13647-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:ARM MALI PANFROST DRM DRIVER" , steven.price@arm.com, Alyssa Rosenzweig , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on rock960. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 14 +------------- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 3 --- 2 files changed, 1 insertion(+), 16 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 56b3f5935703..4d96edf1bc54 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -3,7 +3,6 @@ #include #include -#include #include #include @@ -80,6 +79,7 @@ static struct devfreq_dev_profile panfrost_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = panfrost_devfreq_target, .get_dev_status = panfrost_devfreq_get_dev_status, + .is_cooling_device = true, }; int panfrost_devfreq_init(struct panfrost_device *pfdev) @@ -90,7 +90,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) struct device *dev = &pfdev->pdev->dev; struct devfreq *devfreq; struct opp_table *opp_table; - struct thermal_cooling_device *cooling; struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, @@ -139,12 +138,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) } pfdevfreq->devfreq = devfreq; - cooling = devfreq_cooling_em_register(devfreq, NULL); - if (IS_ERR(cooling)) - DRM_DEV_INFO(dev, "Failed to register cooling device\n"); - else - pfdevfreq->cooling = cooling; - return 0; err_fini: @@ -156,11 +149,6 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev) { struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; - if (pfdevfreq->cooling) { - devfreq_cooling_unregister(pfdevfreq->cooling); - pfdevfreq->cooling = NULL; - } - if (pfdevfreq->opp_of_table_added) { dev_pm_opp_of_remove_table(&pfdev->pdev->dev); pfdevfreq->opp_of_table_added = false; diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.h b/drivers/gpu/drm/panfrost/panfrost_devfreq.h index db6ea48e21f9..470f5c974703 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.h +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.h @@ -9,14 +9,11 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; - struct panfrost_device; struct panfrost_devfreq { struct devfreq *devfreq; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; bool opp_of_table_added; ktime_t busy_time;