From patchwork Wed Apr 18 14:10:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakob Unterwurzacher X-Patchwork-Id: 133635 Delivered-To: patch@linaro.org Received: by 10.80.173.174 with SMTP id a43csp1307391edd; Wed, 18 Apr 2018 07:10:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/juPRUsK/aJjT097ZN2sR8KcVViCwXhEoJpNc+fJOTXJFcsU6PnKoRztpJTZ2zehbE2Sxd X-Received: by 10.99.103.1 with SMTP id b1mr1886319pgc.346.1524060641873; Wed, 18 Apr 2018 07:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524060641; cv=none; d=google.com; s=arc-20160816; b=BolITKm/j56bcPOFgYOK57T5Tjd7IkK7HoditKyvKgJDrEWAMev/PmZQOAOAhOJpFv CuFsSKTL9YOs1zCUFJml0rxA+KSIAWnXOIWvCMfJeWzm2HsOzS4WN1aF41Xk5xWLzKmn 9mcnjkYQj62BxW7veqNqxEqsCM9jZHilmcB7FQlXPZr2sLUO0f3vxHxve2P9+tfJdjPe ZRcPjm6y84XnEWa/bfE/KELQT4IXTrMK1MtBDiBV4ETmXEhIjkApqS4FCq/nW5mckcl+ GvO0OXK/pWm4IIlPNOmoqsNu6YQflf2U3FM3mVmOD6OgJb5s8g5lzF9RKBRkoAhl8X7m ro/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=oN6vOIFX+DgVrp6hX9U0uLqBB/f4G1PExPS9VgS7hno=; b=d1PKtmuexHRMEzn97ivU7wwADhSyKD+366YuV0IuvIxiNRaJ4iORmxbkN9efO+D8GT ZZS+uuP67RnKg9RchkoaZgJLPMc8czAKKjIf7b4Lv4PcMyilQ2HQbPQFkiRiqGD/b9ZL cq1aYRRYZdOjH41VvKdbNzpjvlcJbtcpS03IGGj01dYn2cHjKYC1IhyScGQNKz6MG5HC CcI304wuGhcUQehc3R0IxKlSEWfKDxHyrpKbNAd84Lcf69hzvM0Cer0MpP+4mX6YVHoq EHUxzYBsTZTvdCZ8fBc8d+/A9h9MuagSUqM90wNQC/DyblCpwic8yvemTcYIU43zrHEm hIsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l12si1148683pgc.438.2018.04.18.07.10.37; Wed, 18 Apr 2018 07:10:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbeDROKf (ORCPT + 29 others); Wed, 18 Apr 2018 10:10:35 -0400 Received: from vegas.theobroma-systems.com ([144.76.126.164]:46368 "EHLO mail.theobroma-systems.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbeDROKd (ORCPT ); Wed, 18 Apr 2018 10:10:33 -0400 Received: from [86.59.122.178] (port=43140 helo=blau.lan) by mail.theobroma-systems.com with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1f8nn5-0004Ea-6T; Wed, 18 Apr 2018 16:10:31 +0200 From: Jakob Unterwurzacher To: jakob.unterwurzacher@theobroma-systems.com Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] can: dev: increase bus-off message severity Date: Wed, 18 Apr 2018 16:10:03 +0200 Message-Id: <20180418141003.10229-1-jakob.unterwurzacher@theobroma-systems.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bus-off is usually caused by hardware malfunction or configuration error (baud rate mismatch) and causes a complete loss of communication. Increase the "bus-off" message's severity from netdev_dbg to netdev_info to make it visible to the user. A can interface going into bus-off is similar in severity to ethernet's "Link is Down" message, which is also printed at info level. It is debatable whether the the "restarted" message should also be changed to netdev_info to make the interface state changes comprehensible from the kernel log. I have chosen to keep the "restarted" message at dbg for now as the "bus-off" message should be enough for the user to notice and investigate the problem. Signed-off-by: Jakob Unterwurzacher Cc: linux-can@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b1779566c5bb..3c71f1cb205f 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -605,7 +605,7 @@ void can_bus_off(struct net_device *dev) { struct can_priv *priv = netdev_priv(dev); - netdev_dbg(dev, "bus-off\n"); + netdev_info(dev, "bus-off\n"); netif_carrier_off(dev);