From patchwork Fri Apr 20 11:25:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 133870 Delivered-To: patch@linaro.org Received: by 10.46.66.142 with SMTP id h14csp157002ljf; Fri, 20 Apr 2018 04:26:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/MP3o+PwtSd1geptTYa1cqzWiLk+f0YjfqoB8VhKsV3LTrAZmMAISz2LSrwszCuUk15plZ X-Received: by 2002:a17:902:6ecd:: with SMTP id l13-v6mr10082709pln.113.1524223564579; Fri, 20 Apr 2018 04:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524223564; cv=none; d=google.com; s=arc-20160816; b=woOu5lzlN9LpnrdMV3YKF/P6rCCX30xRdvBmPIKRysXvu7WUeXg6N6IAtjnesxG3c2 D4o9XpbXccVHih8+U20raVlOxXFXngB78e4diIY82ZHsbUuWjExCXrXQdXFrbdWSY/Is FKUct+QG4f1wFjBAvcfCQBWzEt+EWL+xuavU7vae9MehEdru0czeX6vV+ZgJm/+3MtW5 Qw0B4PHC0MSGmu/IN4VG37l4x9m5bNcStQesZTnWciJConkvFFGRnK3mXf7CR2ywjGsj 8FWoe55E1aXrQHYsKUnJnSzjBGw4kUivtVqgM8lcBNMeKsqxXNPguRxadVft/3IsXSli nRfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=XWBFie2sVJrLaZgwPIc7qPl63da3nJKsukd+0etsuJU=; b=YajF6mf41MVLnR/VDsvTCD6O1vhQ6HMCtw5/NjGdXul/+FIjwPnZhaCxEv2Ge2CI7q 5ylfnNlvkovNQmRYZhZa4rXQ8jEoe95hYxi1UttD9CI8nuzvA4rlIF2jpjgy9ToK78RS XAGYBpIZ8rQuMt2KeuZS3GN2HNbwAE8gJ6uKnsEh+4XIdqALXZkQ5AZnWvLj/fnzPNWF trIx0lCDxsZOP5Au1bLAn+m0d18yvLFm1X1PeMtGz7z4nbBJwTwQ/TiCLcq+ikHWnBQR Qyh4t8CMBJtClHHdKboEG2Y4/haQS3+zsYIBjsNgop95tBaxTNuGO2JIeaC/YpzS+CDD J6dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WtccWvoc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l15si2969301pgn.414.2018.04.20.04.26.04; Fri, 20 Apr 2018 04:26:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WtccWvoc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744AbeDTL0C (ORCPT + 29 others); Fri, 20 Apr 2018 07:26:02 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:46201 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754726AbeDTLZ7 (ORCPT ); Fri, 20 Apr 2018 07:25:59 -0400 Received: by mail-lf0-f65.google.com with SMTP id j68-v6so4622386lfg.13 for ; Fri, 20 Apr 2018 04:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XWBFie2sVJrLaZgwPIc7qPl63da3nJKsukd+0etsuJU=; b=WtccWvoc2tyusyDa5M+TlgsVC5kpF6PM/bF0+3dShCKyORzEgtr9VL820mQRAJxaVL /lFBAnSkSNeuep9xcb75ElXvYKNBMopRSsQh3e+8PCt04TgVj8ZmjyzrvfhVMMpwzxXQ tQKoAgR2K6053iIV+fl1r35ZW8zKrun/Zq+GY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XWBFie2sVJrLaZgwPIc7qPl63da3nJKsukd+0etsuJU=; b=g0X8tpEUdjpZExH46gTCkbh0KhyVkenEFU9ugl/S0G6VEQKYBxirqNFcFuCXLH/ubQ /sQnztaEN33R1pnl/Mg40Z3OlmDBh/5FJ9BXm0x/RHMhijAmf8D6sLlMhaGUNjJB657Q XBQA0zw7L7xdJ//ehOg3Or1FoOflA14A/rJXUyIB8gkST5vid8HL4lz5r/i1wrEEcapn UU42qwR+kvy65YWRCNxd/ZuE3bw4vhj6A4yEJD+Og1efy65AXNG8j6UuMmaFhh6GvCic mlBSCmyRvh2bJkE6nV7jQP3TgFMHwwGQ/mAco2Ptmgj9IsN4uJ1lIIdtFF8ygKDCbelu aztA== X-Gm-Message-State: ALQs6tD5t0Di0Qr/8jIWCw68ySd5do0XzN6NojaHPvFXP2kjQnRkWlPI VNDFmAhtsh5nKSipXOM4q0jvlg== X-Received: by 10.46.69.5 with SMTP id s5mr4818169lja.41.1524223558075; Fri, 20 Apr 2018 04:25:58 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.cust.bredbandsbolaget.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id 76-v6sm1290312lfq.70.2018.04.20.04.25.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 04:25:57 -0700 (PDT) From: Anders Roxell To: tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF Date: Fri, 20 Apr 2018 13:25:51 +0200 Message-Id: <20180420112551.27027-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_OF selected. CC drivers/video/fbdev/core/fbmem.o drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c: In function ‘omapdss_update_prop’: drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c:68:2: error: implicit declaration of function ‘of_update_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] of_update_property(node, prop); ^~~~~~~~~~~~~~~~~~ of_get_property cc1: some warnings being treated as errors scripts/Makefile.build:312: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o' failed make[7]: *** [drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o] Error 1 scripts/Makefile.build:559: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss' failed make[6]: *** [drivers/video/fbdev/omap2/omapfb/dss] Error 2 make[6]: *** Waiting for unfinished jobs.... Add OF dependency in order to make all configurations work again. of_update_property() has no inline stub, and that that could be added as an alternative. Signed-off-by: Anders Roxell --- drivers/video/fbdev/omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig index 82008699d253..4de381f2452e 100644 --- a/drivers/video/fbdev/omap2/Kconfig +++ b/drivers/video/fbdev/omap2/Kconfig @@ -1,4 +1,4 @@ -if ARCH_OMAP2PLUS || COMPILE_TEST +if OF && (ARCH_OMAP2PLUS || COMPILE_TEST) source "drivers/video/fbdev/omap2/omapfb/Kconfig"