From patchwork Thu May 3 18:38:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 134920 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp2256146lji; Thu, 3 May 2018 11:39:22 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrP5p3rcSwlPCL+UoP6DrRzPW5erhW7Wjt+UeyrLhsx5h+ADeDp3Q4e4z4MT/MgsQEmxKU9 X-Received: by 2002:a65:5b4a:: with SMTP id y10-v6mr20177377pgr.243.1525372762614; Thu, 03 May 2018 11:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525372762; cv=none; d=google.com; s=arc-20160816; b=EJp6w2KzPvvIoHNh7dnPF4lCFn2IgcaCsOXloVXkHYjMb5TNm+l3E2Bt4e5T8aCBMy VnZ0sjQ7yzMcUGIMwkSkk9IVCZcDGlh5WyJfUioZuqRzxw3Kl+9/9+oqDTlKV6MXjf5i XrXktq0bB9NhMI4MARL9XOoci/cey36vYkzMM0d5Z9NFDtsloWwG9Bk7h7WD0q7MRx/d OuK7Kgucg3SMdaYB4J0lINFWcd/Fc9IHJeCqekuaUpXxuAlD7ae2AeDx+gWLgrGvF/HD nJb1NjL7jJFMiVUeWKXHeZAaPiv94LEVd62QgYwsEPAfWWw2dKSxeJnJbCG0lHakq6xm M1Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=9iZpnFi91fGjnnkmlx0FIIj7BaEja2eKczsD9g4Djr4=; b=fF/r1dIaIiOJoMtTYXYAUqbuo9TxOgI7m1/Oh+sOanfIS9WgMMk/nOSzxIxr6z9mL4 IM1JYkp81iFVFY3ceU4eXjML4s9zxVhwoGkfj2DOWojMHgsjhvLUDxjQ0sADhtcxAgSq qEUDSmfs4nl2SJSx2xKRqq8MY1ILIM6zyRcKJnhMtf1LyXvly5IGCpa7ab0W1NL8SosH wSbnxuDWxPBFIRM3jUa2sgo0G+0TeqjcwY9TunEtF4Q3riP9pkULMhJI4IMhIYxLVeez SqT6vwKaN4uS4n8irAbbkUoiRauDua2XZ86aVGAN3WLmcbjdLJG9CvfMaRNCw4raZw2P FcDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I7PGfRR4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b73-v6si12028537pga.106.2018.05.03.11.39.22; Thu, 03 May 2018 11:39:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I7PGfRR4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbeECSjT (ORCPT + 3 others); Thu, 3 May 2018 14:39:19 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38413 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeECSjP (ORCPT ); Thu, 3 May 2018 14:39:15 -0400 Received: by mail-pg0-f67.google.com with SMTP id n9-v6so13735547pgq.5 for ; Thu, 03 May 2018 11:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9iZpnFi91fGjnnkmlx0FIIj7BaEja2eKczsD9g4Djr4=; b=I7PGfRR4TLBKrwp0gDjtYsNsjUxJhB+43bFcm8EqbVQ5LHR2EgDXEjsjOcwrcULqIm hYF2Tv8Wcx1kxqDa7QT2vzRD1FV7aKnU/55BYXHoKgMOLTTBS3LYXbN6R0YLDfcwisiq M1oDRrJywPY+fy9PNQP/AkuXNuQSLT1zFlFXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9iZpnFi91fGjnnkmlx0FIIj7BaEja2eKczsD9g4Djr4=; b=m7kNBsq9U+IWKIzyOaknBuYxjjxpvklYZTg5NTG2UuT++O+Ksetd7kyd6Lp7JE934y A3JXgRT3KwaDzIo72J+TwabNRmJV7XmHOSrtA1z/rBqTsMHiupaHRrFtAsol/k6PuQTC DV0tWq2bsHfI0vlj65sHcEDO3bZcRGMAocTz1EFYXdgBvnMgXLSPI8jEtwSURFxstlgd q5Azed6TRLVbJ+R48lVnN79svIycl0zXei9J8/AinAS/9BD0nA4vMiJrRatRbc6w+pbo tPcJjQgYH4Id8YehYEwboFTvzEz5JMkoMGSEVUil/nVV4uf+V2cF8UAMWaNzxPM7ereF LxGQ== X-Gm-Message-State: ALQs6tARW9Ls2LJAulTqc0mqo07EUmBbE43F236LtCsEvlyPr2APSh/J yTd2yLDC3zjnREDbouCCCNKDhQ== X-Received: by 2002:a17:902:4483:: with SMTP id l3-v6mr25113248pld.282.1525372754750; Thu, 03 May 2018 11:39:14 -0700 (PDT) Received: from localhost.localdomain ([106.51.17.226]) by smtp.gmail.com with ESMTPSA id o5-v6sm4130786pgv.47.2018.05.03.11.39.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 May 2018 11:39:13 -0700 (PDT) From: Amit Pundir To: lkml , linux-wireless@vger.kernel.org Cc: Suren Baghdasaryan , Samuel Ortiz , Christophe Ricard , Andy Shevchenko , Greg KH , John Stultz , Dmitry Shmidt , Todd Kjos , Android Kernel Team Subject: [PATCH v3 4/4] NFC: fdp: Remove __func__ from dev_dbg() Date: Fri, 4 May 2018 00:08:56 +0530 Message-Id: <1525372736-25094-4-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525372736-25094-1-git-send-email-amit.pundir@linaro.org> References: <1525372736-25094-1-git-send-email-amit.pundir@linaro.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove redundant __func__ parameter from dev_dgb() calls and delete empty dev_dbg() trace calls, which are redundant if function tracer is enabled. Signed-off-by: Amit Pundir Reviewed-by: Andy Shevchenko --- v3: Updated commit message. v2: Deleted empty dev_dbg() trace calls, which are redundant if function tracer is enabled. drivers/nfc/fdp/fdp.c | 18 +++--------------- drivers/nfc/fdp/i2c.c | 17 ++++------------- 2 files changed, 7 insertions(+), 28 deletions(-) -- 2.7.4 diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index d5784a47fc13..f64a6fd65c41 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -249,8 +249,6 @@ static int fdp_nci_open(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - r = info->phy_ops->enable(info->phy); return r; @@ -261,7 +259,6 @@ static int fdp_nci_close(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); return 0; } @@ -270,8 +267,6 @@ static int fdp_nci_send(struct nci_dev *ndev, struct sk_buff *skb) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - if (atomic_dec_and_test(&info->data_pkt_counter)) info->data_pkt_counter_cb(ndev); @@ -283,7 +278,6 @@ int fdp_nci_recv_frame(struct nci_dev *ndev, struct sk_buff *skb) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); return nci_recv_frame(ndev, skb); } EXPORT_SYMBOL(fdp_nci_recv_frame); @@ -498,8 +492,6 @@ static int fdp_nci_setup(struct nci_dev *ndev) int r; u8 patched = 0; - dev_dbg(dev, "%s\n", __func__); - r = nci_core_init(ndev); if (r) goto error; @@ -609,7 +601,6 @@ static int fdp_nci_core_reset_ntf_packet(struct nci_dev *ndev, struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); info->setup_reset_ntf = 1; wake_up(&info->setup_wq); @@ -622,7 +613,6 @@ static int fdp_nci_prop_patch_ntf_packet(struct nci_dev *ndev, struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); info->setup_patch_ntf = 1; info->setup_patch_status = skb->data[0]; wake_up(&info->setup_wq); @@ -637,7 +627,7 @@ static int fdp_nci_prop_patch_rsp_packet(struct nci_dev *ndev, struct device *dev = &info->phy->i2c_dev->dev; u8 status = skb->data[0]; - dev_dbg(dev, "%s: status 0x%x\n", __func__, status); + dev_dbg(dev, "status 0x%x\n", status); nci_req_complete(ndev, status); return 0; @@ -650,7 +640,7 @@ static int fdp_nci_prop_set_production_data_rsp_packet(struct nci_dev *ndev, struct device *dev = &info->phy->i2c_dev->dev; u8 status = skb->data[0]; - dev_dbg(dev, "%s: status 0x%x\n", __func__, status); + dev_dbg(dev, "status 0x%x\n", status); nci_req_complete(ndev, status); return 0; @@ -695,7 +685,7 @@ static int fdp_nci_core_get_config_rsp_packet(struct nci_dev *ndev, dev_dbg(dev, "OTP version %d\n", info->otp_version); dev_dbg(dev, "RAM version %d\n", info->ram_version); dev_dbg(dev, "key index %d\n", info->key_index); - dev_dbg(dev, "%s: status 0x%x\n", __func__, rsp->status); + dev_dbg(dev, "status 0x%x\n", rsp->status); nci_req_complete(ndev, rsp->status); @@ -798,8 +788,6 @@ void fdp_nci_remove(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - nci_unregister_device(ndev); nci_free_device(ndev); } diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c index 2c5ed2224c5e..bb14d30c568c 100644 --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -57,7 +57,6 @@ static int fdp_nci_i2c_enable(void *phy_id) { struct fdp_i2c_phy *phy = phy_id; - dev_dbg(&phy->i2c_dev->dev, "%s\n", __func__); fdp_nci_i2c_reset(phy); return 0; @@ -67,7 +66,6 @@ static void fdp_nci_i2c_disable(void *phy_id) { struct fdp_i2c_phy *phy = phy_id; - dev_dbg(&phy->i2c_dev->dev, "%s\n", __func__); fdp_nci_i2c_reset(phy); } @@ -113,8 +111,8 @@ static int fdp_nci_i2c_write(void *phy_id, struct sk_buff *skb) } if (r < 0 || r != skb->len) - dev_dbg(&client->dev, "%s: error err=%d len=%d\n", - __func__, r, skb->len); + dev_dbg(&client->dev, "error err=%d len=%d\n", + r, skb->len); if (r >= 0) { if (r != skb->len) { @@ -152,8 +150,7 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy *phy, struct sk_buff **skb) r = i2c_master_recv(client, tmp, len); if (r != len) { - dev_dbg(&client->dev, "%s: i2c recv err: %d\n", - __func__, r); + dev_dbg(&client->dev, "i2c recv err: %d\n", r); goto flush; } @@ -167,8 +164,7 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy *phy, struct sk_buff **skb) * and force resynchronization */ if (lrc) { - dev_dbg(&client->dev, "%s: corrupted packet\n", - __func__); + dev_dbg(&client->dev, "corrupted packet\n"); phy->next_read_size = 5; goto flush; } @@ -224,7 +220,6 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id) } client = phy->i2c_dev; - dev_dbg(&client->dev, "%s\n", __func__); r = fdp_nci_i2c_read(phy, &skb); @@ -305,8 +300,6 @@ static int fdp_nci_i2c_probe(struct i2c_client *client) u32 clock_freq; int r = 0; - dev_dbg(dev, "%s\n", __func__); - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { nfc_err(dev, "No I2C_FUNC_I2C support\n"); return -ENODEV; @@ -368,8 +361,6 @@ static int fdp_nci_i2c_remove(struct i2c_client *client) { struct fdp_i2c_phy *phy = i2c_get_clientdata(client); - dev_dbg(&client->dev, "%s\n", __func__); - fdp_nci_remove(phy->ndev); fdp_nci_i2c_disable(phy);