From patchwork Fri May 25 10:31:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136837 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3400020lji; Fri, 25 May 2018 03:36:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqvwR9RkIzP1+b7uLLVjKREt12YKg07jKl7Hb/76huI0wP0zXJiXbKaHyHX8WXRIASfmf30 X-Received: by 2002:a17:902:26a:: with SMTP id 97-v6mr2025460plc.367.1527244573097; Fri, 25 May 2018 03:36:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244573; cv=none; d=google.com; s=arc-20160816; b=pJwNFkz7UwAtemWB9cRT5fkqdcjATVEfmU2hKmVIX0rg43nWdymQselk7H4LDerjCT iS3UqYi+sInvvXbEbJXFXe/y8EObj0+ISHYtPo88Liz+5gZkkhivY1bbdSXSF00DGQiD hqrtRHS11lktyiHv4jnWeCfxnwWN65mjUDL4qhxlR4m0kqjSdjz5wlbSUb6c9JNj7o1x U6dHwUkFUwzq3KfCdXNaT7pFygPMyRmwOtPnRsrnLcZRBDhDw3Vp76EBtl5+Zo3iveLu vDdRDAUJbgaVEanXF6OeOAYOEHvvzka2ePsVYg3LG289HfaghJvzSWDykxdSx6LxgizG AEvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=4uWh1YKXzULVqnP+X4fmoMtDBhEKwtinparWMGRrJSE=; b=V/wO5SLiMbGALUjeH5IH+nc2RFmhcgt0vHGBjEFGDlXbdrayYKb1LLHcOJjJfJt4mh j1LEANPHVYzkkqc6J+MC5rxuqpP2Fe/JyczrdFWo2l6srN7eS13l08CRUGcLIfxLE4/r t01XFEoAtZDBpp3obvrJB6256OC5aIORKYnUjQ+vUWPt17N3Lyvcsjr0M7PHxjtzvdMP oCD8Hhng1AEQxKZ2Ph16pQN5y+3oVBiPVsmzaI79+NfEAf2XltXMQiqF0zJdi4wktZo1 L8s9ojTo0YPjC8p9g02bBh5+iLYqIQpCXwDvycUWYd1dS0vU4imb1cmj7OyEKLG0Al1X r7EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=c1X1JR2V; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k127-v6si18256430pgk.256.2018.05.25.03.36.12; Fri, 25 May 2018 03:36:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=c1X1JR2V; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965647AbeEYKgL (ORCPT + 5 others); Fri, 25 May 2018 06:36:11 -0400 Received: from mail-pl0-f43.google.com ([209.85.160.43]:39458 "EHLO mail-pl0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965646AbeEYKcW (ORCPT ); Fri, 25 May 2018 06:32:22 -0400 Received: by mail-pl0-f43.google.com with SMTP id f1-v6so2473805plt.6 for ; Fri, 25 May 2018 03:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Pn3l07UH/U/9Xj/tYtqmRgaPYD/poUqxy7JOF26SYEg=; b=c1X1JR2VHKzu53UlWcSPNvLCUlGkDqlICqvssgDc5BFB6OJKBpulROX9vuE8q2zG8S NzBQH8Ar8mcd9848/KeoKrgy1RTo/OqK4Ud6LQbIdy27p3tEuulL6/QCunJ/VgTNnecm 1aD2M6UpDg2nQax4uWWh8j8bWOQdKS9mpgQbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=Pn3l07UH/U/9Xj/tYtqmRgaPYD/poUqxy7JOF26SYEg=; b=CWZZwLZL1DQWNe0CubcFxQYG1kzEIDYxM3f1JYCGnOi/9Ua59GXBbvY8mbEo7s4rcV 6FMPsyapgOS11StW7HkYtqoih/QdEYY3dKOs/s1K5fPLwdVJWaNHgOIHgWIEXZC883pr 0FDxkQym4mG3bmrlunrbGZstibSzp8jLiw/krDXmH3bbsTlX6JQ19BPpzApkNhozHfoz RyaZCTHk5kIbgysiSu2qK46W2uehZpsVFpAG5lGOCLTAlp4nXEsoHmwjPuClO8F9el4x Vny1ATXZ6XfvlRIVyLMVHMWRGjB6GiOceekUoS6wMjp3ckzhydjMPIMxAV9jSVJ7OR1G indg== X-Gm-Message-State: ALKqPwerse45aIMYa/t9/I+45SWchhtrjSz7JjOio10SzRKUU3tK80Ic Ah9GlBWbMO1Isp+ajeGZmJ0uYQ== X-Received: by 2002:a17:902:b68f:: with SMTP id c15-v6mr1989769pls.201.1527244342182; Fri, 25 May 2018 03:32:22 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id z13-v6sm62866966pfk.156.2018.05.25.03.32.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:21 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/15] arm: dts: armada: Fix "#cooling-cells" property's name Date: Fri, 25 May 2018 16:01:47 +0530 Message-Id: <26a0666368694db610414a85a08843435ea070a7.1527244201.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org It should be "#cooling-cells" instead of "cooling-cells". Fix it. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/armada-385-synology-ds116.dts b/arch/arm/boot/dts/armada-385-synology-ds116.dts index 6782ce481ac9..d8769956cbfc 100644 --- a/arch/arm/boot/dts/armada-385-synology-ds116.dts +++ b/arch/arm/boot/dts/armada-385-synology-ds116.dts @@ -139,7 +139,7 @@ 3700 5 3900 6 4000 7>; - cooling-cells = <2>; + #cooling-cells = <2>; }; gpio-leds { From patchwork Fri May 25 10:31:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136824 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396537lji; Fri, 25 May 2018 03:32:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp9ddGp8fKRZHKABZQ3C/Swiz6jHwTt0kxd/yRSV1K/h0W1kkVVNpdnQBbdu0w0y6sPl1G+ X-Received: by 2002:a65:51c4:: with SMTP id i4-v6mr1532945pgq.190.1527244353955; Fri, 25 May 2018 03:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244353; cv=none; d=google.com; s=arc-20160816; b=g6adD0fgyYC7tbXpy9LG8M9C5xmrED/YOhZVMBvb+tdHesO3T1wH9kuKtwNRveTWRn KpMwfENwOqUHEJddtydlUsQSe6ZnKvLOIcWRIkm9hL6CERJzhmguvLySJ7Znjnk79+u/ QEFASQVPTcc0Ttq8V+xxcsvbC3iHhaLxXDhdTLQvvQFTdRZJuJ6PfXVv2Ya+va0kHW4/ Esdl7C5UR8coNlyHnRBwyzBC/XmAtIitmp9fY70arDPQHKRMf8uxuZrWBKhcXLqZBng/ jWnzRQ0CsrsdFIZsNpZpNzhfd9oAttG6VstYoeoW5yIbhcnVloZCJf6Yq0ttZSVvDLnv 0smA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=M+vZ0AWa/sI5eFKg7q9MVwaVqzInL1hf5szvrzccWBU=; b=PaYjHoZ0LVxRKDWpqskwDM1i9P+1pjzBEbO/zWcSiORJ7GV3+3rVASF2OkcCVhFwUY VXzToZayrG54aFvhk4F010O3aPNBSKFsATfXzqMiWBKi6drM1K9JTs5vfZBl5LSzyECA YsSXRwh/dM8U647SGNRB6brWcmiQoDZ0EMTtJrQPCj0hLgtvp4S6UptjsJZHVKnX7995 1PP8LHypodvFn8q6FguKG/Roggr9GU5DYIpKBv2ylH3uBkGCL6apMWoB1crTi9tZ8tBA 0pWE5MnWe3zWYJwtfalaLknyEL6PO/7MopdpZdJtOWt+NSggkDGWtbn4aahPNHMmwR8r lDmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Fc2YfJFq; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si884969plc.415.2018.05.25.03.32.33; Fri, 25 May 2018 03:32:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Fc2YfJFq; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966089AbeEYKcb (ORCPT + 5 others); Fri, 25 May 2018 06:32:31 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36532 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966038AbeEYKc3 (ORCPT ); Fri, 25 May 2018 06:32:29 -0400 Received: by mail-pf0-f194.google.com with SMTP id w129-v6so2399646pfd.3 for ; Fri, 25 May 2018 03:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TZd640iggeYulDoamOxegpwL3G7+X0vwf14RRKbmqs0=; b=Fc2YfJFqZ5YGrkGENvb92PAf1mveIQj6VnLn4F/duer2LiKIn8GZpJk86t0LWMWF7K Pf/dwf6uQnPAoInGw2M8a0mynFH0ob6C6WKp7Oe6lDpwJsDl+MDsPRs8sPn9YP/8z5fa a2SdxtAIDnAsQjuvyZreZxvZG4Ys3zp6rtaF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TZd640iggeYulDoamOxegpwL3G7+X0vwf14RRKbmqs0=; b=rwOYF1UCuSjeqLdc/Ne+1F40CHKh7VmVOsbQQAXBxeENBMaROwYS/4rbugb8b1NrXz vWVLFzkSmi/tvu7rLYyHYPLfPQuF0DJjs95evBg6gVAlWo0WguK0HfBkIbuPHaFopgYi Z1eA+5UuSNAhAim8+ja6OeqCzXHnvXmi5v/jywmKjRszf9ijed4xhvkDNZ3qGoY0zHnU mrYYHRt9fWn/1OTEhhbYdgisg/tZNK+1xsc/RXK8rXh65OE70meonSl1h5r5oGc/wJBf KlkF1g9qLVnQyyshNW/FlDIiefiWaHhnYuP4x6303mLDqVtn96Amc0wNkvRfxSLOBMb5 LacA== X-Gm-Message-State: ALKqPwfOc+jjp201+KePnsrPmFYIOhmfRrH5cB0fzW/mY14TeRQoaehd RYWgbkygPiyK4sDEDeikJzP+/g== X-Received: by 2002:a65:4b8d:: with SMTP id t13-v6mr1541259pgq.446.1527244347997; Fri, 25 May 2018 03:32:27 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id r5-v6sm30740021pgp.81.2018.05.25.03.32.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:27 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Matthias Brugger , Rob Herring , Mark Rutland Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/15] arm: dts: mediatek: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 16:01:49 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/mt7623.dtsi | 3 +++ 1 file changed, 3 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index d1eb123bc73b..1cdc346a05e8 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi @@ -92,6 +92,7 @@ <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; clock-frequency = <1300000000>; }; @@ -103,6 +104,7 @@ <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; clock-frequency = <1300000000>; }; @@ -114,6 +116,7 @@ <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; clock-frequency = <1300000000>; }; }; From patchwork Fri May 25 10:31:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136826 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396632lji; Fri, 25 May 2018 03:32:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp+4nv/ujKrcZxlPFnY8VciG3DAJ+4FVv1E1o1YPXWADi1+Q1DmHgWujXednqNt6X34HG8/ X-Received: by 2002:a17:902:ba87:: with SMTP id k7-v6mr2004787pls.193.1527244360145; Fri, 25 May 2018 03:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244360; cv=none; d=google.com; s=arc-20160816; b=WxPlOKGHY/jxdmVQYad1hK+c/8lul9hAeCV0FCgNuXir9/ZZddhfG7aUe1c1YZmkO+ xQdGABsvemZR657DB7I9S5uhTKrv13sI/NGB6Iq73ZY8ntcaL0pAxSjhsF2dRQTxR1Pf MsBW8afGOVdAlNxKUeo+Z6R63FgHhip9rDLLDXvlIhLOWeewfaiEXEmGu+rA89jMUYnm 9UnUR7ZEUe31rtksK6SZl8PItwediaafi2QvGVXM7NQX/+g7BJum0gNTxdApLThUYXxA NdgbqDK1E7wLmAjBCo8jSTK7ogFPE13gmoCz+GEWy/Wdk2JCumE/5C0SW0ELtwwKDvPh RMrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Ah2gLfcn3NEjf5tg3F6RjteguCp0qfTjScflYPGbcoE=; b=U+VwgTZnoZ1gqTME7QGml0vXerwHRRdoFJSqIVhaGnnE94qKONdv4YSltiTFrejyhj 8qptmUsUr6i9jUAaXgkwFyUBo1AB/LOfyboycmc3WWktxEHMkwGaXovGdNseJhCFB2kw Grti6nHpiedRJa2Ipyv1YKlZXEIruC0y7viGM9H7zCXYuHgImst1k3FBl0RCK9ZQYwEh qfA6N9GYDUgE/SbIHNaJCNdUyNB7x7A0x9iNRZDASsDiJdjE0Cw2qFnZF6cTeLA3kcqf MqhxhkuTftKiB9LA0Cfu+U19MSaGu33080wVhHWos6MIaLzxhx04FQqld6F0DFiyidLm hhbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GUbOhct5; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19-v6si22708780plo.287.2018.05.25.03.32.39; Fri, 25 May 2018 03:32:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GUbOhct5; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966178AbeEYKci (ORCPT + 5 others); Fri, 25 May 2018 06:32:38 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:45812 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966158AbeEYKcd (ORCPT ); Fri, 25 May 2018 06:32:33 -0400 Received: by mail-pl0-f68.google.com with SMTP id bi12-v6so2908884plb.12 for ; Fri, 25 May 2018 03:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=GfNvIOQ3ENb5MwJeAgOrPVPiZNlrnbH8fOGyllgETxg=; b=GUbOhct5kIQ+R0I4l0Hrn6nmKnNuIqpXSMQoGQiyiAx5mmO0+p0/0VD6Kyy2xH4ctb hDdGYKhjx3eZgWS2dqgpM1RqfcWAcjbWBdPCVTPv35iEQNWUR5kiKb7fXrT+R3DCH3CY 8tfSzJNAB/IWkwn5SVpQY6Q2RLMD9KaAXRNHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=GfNvIOQ3ENb5MwJeAgOrPVPiZNlrnbH8fOGyllgETxg=; b=lfZCGiYvKVu1fKKu9iAOyu6kXde1iIq0Yxz4uEs9Jv0RE+UMSkzIsY4nKWYv3bA2PX dY2iHBC54t4UA0Q6YBNugrWEG8dffjS7kg8CElLmdP+RuYMPJ3mkJkoLyGXaXpIZRDMr YF1ChYRdMSU35MVKveWmhixuMq3yPoAyXqh+CY1D9Lu9QMlb8Wxh8wdYbGLkMs6MeG+m /fCkDeO2pcUtOihW5bV0rD/du49HvBmzdotodebmBYZN7gmZx33d5w2tErI2/wFKQL5J OZMMvBzhwZDoGnyhcU4pceChDfouMcYSwswwmmvPAFKYDS5oRW3g0ow+szPb0IKk/yG3 xAog== X-Gm-Message-State: ALKqPwe6jozX7DLj2rQfX+TNzsuOVVzOvlCk4YtOv42Fft4yyeSo5xym 22aecRAvzJcAISxg5FnmrlkfnA== X-Received: by 2002:a17:902:52c8:: with SMTP id a66-v6mr1994081pli.131.1527244353350; Fri, 25 May 2018 03:32:33 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id n10-v6sm51881460pfk.145.2018.05.25.03.32.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:32 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Rob Herring , Mark Rutland , Masahiro Yamada Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/15] arm: dts: uniphier: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 16:01:51 +0530 Message-Id: <51ac4a5f0466aeed3f223663d9c34d6345b2a1f2.1527244201.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/uniphier-pxs2.dtsi | 3 +++ 1 file changed, 3 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi b/arch/arm/boot/dts/uniphier-pxs2.dtsi index debcbd15c24b..40ed15465095 100644 --- a/arch/arm/boot/dts/uniphier-pxs2.dtsi +++ b/arch/arm/boot/dts/uniphier-pxs2.dtsi @@ -36,6 +36,7 @@ enable-method = "psci"; next-level-cache = <&l2>; operating-points-v2 = <&cpu_opp>; + #cooling-cells = <2>; }; cpu2: cpu@2 { @@ -46,6 +47,7 @@ enable-method = "psci"; next-level-cache = <&l2>; operating-points-v2 = <&cpu_opp>; + #cooling-cells = <2>; }; cpu3: cpu@3 { @@ -56,6 +58,7 @@ enable-method = "psci"; next-level-cache = <&l2>; operating-points-v2 = <&cpu_opp>; + #cooling-cells = <2>; }; }; From patchwork Fri May 25 10:31:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136827 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396642lji; Fri, 25 May 2018 03:32:41 -0700 (PDT) X-Google-Smtp-Source: AB8JxZohJxhoZKxMgf9L25S+VHdHF5p+i7/6oQNZ7aX7ZlQyp8sD2zdLyNROZg1+yuwStUv7UMsK X-Received: by 2002:a17:902:822:: with SMTP id 31-v6mr2071222plk.172.1527244361325; Fri, 25 May 2018 03:32:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244361; cv=none; d=google.com; s=arc-20160816; b=KmY/k3/QLSbcHrLczOwI6k/tBUhm8M1ssAl/JxN9+LUyCHeCjfRfkugFJUuVWr+H3I f/E/wX5ahneTXC3sIwiUBGxUM70OwUj4yfz6VYGtHgnasierg5Dx9zsI2Xzh8oKUAdBv NGIQYVDPiLs6ITHqO+EiMti+lClQE1fiLYu7v+0m7DiiTmqFnZabpAYoa9j8RDc+sae3 hv8c5rxM/Gwn2FXDyUFxL+nRJS+DVz4tR1Fj6RH2/8ZE71nR0gtm6FvZFG/DCCZPWl/R Mk+4fd4Dt3EjgLqEcvzSdK4nbrK1D44t9CAzWTk3y1CDMTlQeD3iBroV2kh2epc6+phW fALQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=+zoHpU2g0l+SsXxACJc8OtrLMRWfk4Z8yOSPTSVgSHE=; b=nSYXreLSF1CoHOnvnwCRlus1f3lLsxjHF+dy3Pf0u9VCX+UdESuJxUA0pV7jB8HhYJ BkK4bn2YhAeHkwtcFWsVHHLV0ZnIQi8dsMmhovW9aj19g4rUMcGa5f2lLGA5XLw0irs3 Rw49pBVQxjoDmwTta8CmAmC1v0vfkSMWfyj2kuvbQL1qLA3KIxgRVYvzUIRIpGLLOVjT qYSbqEu263CBfCpg2RhWCoMVxPJlj/tw9FvUmadChHlVl+Y7DZ8aqg7K9g/rRRvePSRx Uf1VSbTAC20ojcjuRqLuGpJIsBgGsYcBSJsoqQukQCYxLLsWOj8bxitxBpfYnrxnC/Q6 87jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZHVKV597; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19-v6si22708780plo.287.2018.05.25.03.32.41; Fri, 25 May 2018 03:32:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZHVKV597; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966151AbeEYKcj (ORCPT + 5 others); Fri, 25 May 2018 06:32:39 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33237 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966081AbeEYKcg (ORCPT ); Fri, 25 May 2018 06:32:36 -0400 Received: by mail-pf0-f196.google.com with SMTP id a20-v6so2400345pfo.0 for ; Fri, 25 May 2018 03:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=XE6OgpSTNlTBCGjLGkhYWb3esagTBf6X4g5axr00Eqk=; b=ZHVKV597OW/4IhWJQB3len6m2aeCNxnbesy2DEwZ+KtLJ/88iqPk8EaNL/E8146ecg MnneXZx7hCi1CBal6ash+0Aj/1hB1TPpIp/BiTrfR0MvUcSk+poytaknzqk28I8qVa9i GUzDxWc9kDrKQGJtsJtTjTdFRE1S4aMnS3MME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XE6OgpSTNlTBCGjLGkhYWb3esagTBf6X4g5axr00Eqk=; b=irm4OXMw9Z2ziNEzep19c8mj3mr1Hg+03O9vNtK0rOyKOG/jdQT58c6gDaYVz11OBe bGAy7rYguj8lPe0Y1qrY008khgYH7jx+/ZVoTBxkbaPUU8tO5z9si9dkwLBWXOKQtHrB yPvZoajK/9q7qymcUlMPt676V1VCphJi3oIV4Gs7aYpXEIZjw7C/4y6Bly8JnKH+C4n6 uBXl14o8RdS7gHDfYSeTbQusJQydhuFQfpeZw03ZT9MzfzJ81kZdEzfPDd9xgIL8hEFk t5gfNmPZtj//0iLnkLlog4JaYBcTNdEwV4SiOo3IuSdAJaez97k5pbrK8wSwQa/z4SuH 2o2g== X-Gm-Message-State: ALKqPwdX/chsD3HsA8nYrMF+3sq52E44oMftNsXWVRAcJOR2nJW27LtC iLxmAsDJ0qy7GFGrTT+qrbkphg== X-Received: by 2002:a65:61a5:: with SMTP id i5-v6mr1464334pgv.405.1527244356343; Fri, 25 May 2018 03:32:36 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id c3-v6sm43882352pfn.62.2018.05.25.03.32.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:35 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 16:01:52 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, OPP, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/sun6i-a31.dtsi | 30 ++++++++++++++++++++++++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 13 +++++++++++++ arch/arm/boot/dts/sun8i-a33.dtsi | 9 +++++++++ arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ 4 files changed, 61 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index c72992556a86..debc0bf22ea3 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -119,18 +119,48 @@ compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <1>; + clocks = <&ccu CLK_CPU>; + clock-latency = <244144>; /* 8 32k periods */ + operating-points = < + /* kHz uV */ + 1008000 1200000 + 864000 1200000 + 720000 1100000 + 480000 1000000 + >; + #cooling-cells = <2>; }; cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <2>; + clocks = <&ccu CLK_CPU>; + clock-latency = <244144>; /* 8 32k periods */ + operating-points = < + /* kHz uV */ + 1008000 1200000 + 864000 1200000 + 720000 1100000 + 480000 1000000 + >; + #cooling-cells = <2>; }; cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <3>; + clocks = <&ccu CLK_CPU>; + clock-latency = <244144>; /* 8 32k periods */ + operating-points = < + /* kHz uV */ + 1008000 1200000 + 864000 1200000 + 720000 1100000 + 480000 1000000 + >; + #cooling-cells = <2>; }; }; diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index e529e4ff2174..35372a0cfc8d 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -122,6 +122,19 @@ compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <1>; + clocks = <&ccu CLK_CPU>; + clock-latency = <244144>; /* 8 32k periods */ + operating-points = < + /* kHz uV */ + 960000 1400000 + 912000 1400000 + 864000 1300000 + 720000 1200000 + 528000 1100000 + 312000 1000000 + 144000 1000000 + >; + #cooling-cells = <2>; }; }; diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi index 8d278ee001e9..4e92741b24a7 100644 --- a/arch/arm/boot/dts/sun8i-a33.dtsi +++ b/arch/arm/boot/dts/sun8i-a33.dtsi @@ -132,21 +132,30 @@ }; cpu@1 { + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <2>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <3>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; }; diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi index 41d57c76f290..9dff6887923c 100644 --- a/arch/arm/boot/dts/sun8i-h3.dtsi +++ b/arch/arm/boot/dts/sun8i-h3.dtsi @@ -84,21 +84,30 @@ compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <1>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <2>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <3>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; }; From patchwork Fri May 25 10:31:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136829 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396742lji; Fri, 25 May 2018 03:32:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq83HkI62s3vAC2F/xnWmPChineanABYr2k5fqSdjr5xne4b47Pod5Bhm/AJp2TSQG9GG35 X-Received: by 2002:a62:49d7:: with SMTP id r84-v6mr1980948pfi.146.1527244366749; Fri, 25 May 2018 03:32:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244366; cv=none; d=google.com; s=arc-20160816; b=jTZ7eJzqpzPAIjwSSM8NdL4w/w5CNtDzLq5/S/CZgKz4I5DlSKgNz+73sSYTOxYSVb fZ83yAoniQXPFrSPUFMGAB20TQ7EJ4sTj6yNCQwqknyoWKlpfitOsyevV3kwktyAk3CV JXDj5qzmwb/FHXwzYZlUXY6hTYCXOMz7vRIrF5EP8zpgshKwylsWgWlY7i0U+0di58JA du+I1CTmeSjt2VwqDHFwmQbO5msB+UNQWZvEa8Jf4zGu0cTAnH1IYY61L1y16IhutleU /tHk9qAyOVKLxi0nA2JF6D2cHmO0QP8ybFIP4yYAld+XfHCGCdbdAqz+9yrbFg3zQ0UP u5dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=bbgN1H2frIEvA7Gs2HBnkH2p1oQm1y4Yv75vn4pTKUw=; b=BjosBtqfIcwvsmY0AtulV1yC4Uno/5PVUTHbLHqpOjFU7g4tUXnP6+59XFr1NCD/gf 4DEiHEMZaAygzVISvnANzPxU4utrVwuv1QlTBepvUcIdZ/ftZgqs/ew9oa9YZqup5+Bd MiCr19l5Os2MWO76UBikN5ekAiuhkS3vzMzdwmyLgt/kWVk991/bT7d1wddGT19KAvzK zhVnwEffUm1rw80DybpHya7Fd4GrsyYZQ4fPz69PzNRf2xlAbl8TdzAcq6GQZf63Bhv+ GrjQr2eJO9EGhgWYEvypDTbhjar6FXL8vzKXwoOQG7sC1tkp+s68UxjdDI77ioJrwKqb nlfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FXyhO/2a; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a87-v6si23021839pfl.165.2018.05.25.03.32.46; Fri, 25 May 2018 03:32:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FXyhO/2a; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966081AbeEYKcp (ORCPT + 5 others); Fri, 25 May 2018 06:32:45 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:36869 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966258AbeEYKcm (ORCPT ); Fri, 25 May 2018 06:32:42 -0400 Received: by mail-pl0-f65.google.com with SMTP id w19-v6so2921213plq.4 for ; Fri, 25 May 2018 03:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=x1wUHZDBCZ+YFLiFQTI7ToUIj0W2yT3QlH1LX957kTM=; b=FXyhO/2aGteDUwOEvvyM5cLW6jc5UcQy+SsnWe1BhPgSTgxlYCCAs3i8LtlRQiqz8H /Af1rzVfPWsLoLK9U+sjQt7rE3/cAKZrBInMQt6vSWqTARwYfN1B/e4wZXB+oYGfnQMc W1MujLY9N488BnnEqbxWwKw7u60ZOfbxKJJO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=x1wUHZDBCZ+YFLiFQTI7ToUIj0W2yT3QlH1LX957kTM=; b=mEuEgMh4VqYLQqxfxohtJUnwEubzpPJn4Vj0qjByHGmdheOvq17Q2osLLaQuqGyYtR foZIVMnwacby4LCtrAm8BATIFqKfvGF2+8ohoS4zDLlRmxWydjrTKQrr1feHlmSHOUYi W7LdU25OMl6Xb+vSWGU+6+/74ecIY9ECjId8xndnt7SHM+Y8reZhOKIaZYUvR0EXOuSk 7eW4fNCv+JiycHNxwXLzYI/jXxip8UzHcMXAuD85EhfO2qxAVcJVk05EPNPOAjxvwqaO Y6oSSrcADYiA/nPwr3IozcPhaUFrIOgR+3yiJvUxDeM/2SZqmfhumcBk0Q2oxv+66Vld djmQ== X-Gm-Message-State: ALKqPwdLVdE4LT+nrqBLtq1+8S4vIjt1VEUKfrrFFswInsezgVtUTjxE s8VmtR57W9kKoHOjcMiJh/DD0A== X-Received: by 2002:a17:902:bb0b:: with SMTP id l11-v6mr2079691pls.190.1527244362426; Fri, 25 May 2018 03:32:42 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id x124-v6sm40910885pfx.72.2018.05.25.03.32.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:41 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, =?utf-8?q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/15] arm: dts: dra74x: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 16:01:54 +0530 Message-Id: <4860aab6e550b91ecc5c37c80cbffa6a6a70a4c9.1527244201.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, supply, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/dra74x.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/dra74x.dtsi b/arch/arm/boot/dts/dra74x.dtsi index 91e93ab588ca..8f9df09155d8 100644 --- a/arch/arm/boot/dts/dra74x.dtsi +++ b/arch/arm/boot/dts/dra74x.dtsi @@ -18,6 +18,16 @@ compatible = "arm,cortex-a15"; reg = <1>; operating-points-v2 = <&cpu0_opp_table>; + + clocks = <&dpll_mpu_ck>; + clock-names = "cpu"; + + clock-latency = <300000>; /* From omap-cpufreq driver */ + + /* cooling options */ + #cooling-cells = <2>; /* min followed by max */ + + vbb-supply = <&abb_mpu>; }; }; From patchwork Fri May 25 10:31:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136830 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396947lji; Fri, 25 May 2018 03:32:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoSY2NoqtPOVu5KEOYNuPNj0EcrO73i6/qEJUciG207D2aMO+cibsUFTs1aEM+ACO7aLyNW X-Received: by 2002:a63:b307:: with SMTP id i7-v6mr1529205pgf.448.1527244377001; Fri, 25 May 2018 03:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244376; cv=none; d=google.com; s=arc-20160816; b=KyglIJ6TWIRZRJ5PXDcGZ8or707aZNtYPx8U0oVwWj5GdB4XILtFKcH2OqmocNC9iM SruUzcrYB4JuzX+NnLFs8+D6w8AfTLyyxx7LbLsGGfV9a7ozXb9QexHpJdOT2KCUFoM/ GjXYYF4xHySPTPxCxxm+9UpCqzSaG8+ZuLoeoRBgpaDmfxiwhppxOI++Z0oYWasFXAzX fvcuR/WNHlpJzPmhZEZqhkXpgJy3C8JZH3jcmhkTdsAcli+Z3vKrDm72I94RwEv8r9cZ bbIYei3vZW93VAXN/Vpp4madcaW3waxvkZpjuelYIblpJChy0+nP9cf00IUwGNgrWKAl cnMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=BcMhW39DXdd7618odPw1HbTRHsk0odBojz6QjaQBpDo=; b=ZSl9Yd00IZ/BjM85K5EfnnmRIrryTOl3Lobjtt6Xg7n7zQuYKFc/haRRDTlLZFkE2x I+iWdkiJwHdf5Q56RZTqDGv3rmggPs591gh5LaO7gaZLsWmGG3euMFjYV6mJrKsLfF5b v/oW+kzuy79KSsczPYDEP5fGaoo/mXWQAyjuwg52uI4jX7UAoIvitzHnBdGqWh1MmIi1 qQ4D/xLXSUKIrZFW18U2Zb0KvhmDA1TGOr6I5F/q0iYcOLOT5WjArYB/byx0L2n/J+3N 8cnRgpWu46YtaGH+NmQe5eIHhHpOgSs015tICmxE/ErkQOdkktVb02WazyfrAj22MTVN yLew== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b9F9FOac; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si23630336pld.215.2018.05.25.03.32.56; Fri, 25 May 2018 03:32:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b9F9FOac; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966303AbeEYKcy (ORCPT + 5 others); Fri, 25 May 2018 06:32:54 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:40863 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965647AbeEYKcv (ORCPT ); Fri, 25 May 2018 06:32:51 -0400 Received: by mail-pg0-f65.google.com with SMTP id l2-v6so2128728pgc.7 for ; Fri, 25 May 2018 03:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=b9F9FOacHQ112XFsBoUG9iw0JX93Pfsn1kp1pm3OipwS/pMcZKKPnhYfXL9yLE2lLC 2pga+BOZnCHBf9ssymqiu6Gvj98ZNpqB5Uk5NbR+nrWv2PI/CNXfDWQ/lGtnno+Kj7lv fh4OOCJDt4qfRkCc2b31DMGulkxzbK6Sr3dnQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=W5rHXKq1r73YNO7xeX8uDu8rc4CwPB52FSh5V3zgE+uheR/v8ERjICIoRpzVO22Odl SRHaWub6WPvDt37NbGOM4ow7y9hwv25x7b7Js2FeWiVi9BwHvYqnMq5Hu1f/UfmCBHRd anUTc8y3DV5GaHfq0MJA3eKd9ODAkXR6tYTsWGRY+VlmpWcvtSX5SJSbNjwwZ5HhCQqR TqZ1UQONiPBt9dpuJXdxSU36/7zVn30N4MJgBfvg5KzKS/g28B5iLkwZrApCh9d3GpvG KOwIXACLAtfRgtEJpwWzXcj7QqJlZE5xvM78tsejQ/Gt4iGT7OJNn5QoyvDoJyL8RrqT XseQ== X-Gm-Message-State: ALKqPwco/hmwLgcG/3q7EMm0QO3VN/GDgwjHH9pRXShKMzFsbzVHlwc9 Z0lZXKXit3Di3lzRUlR4vRt+0A== X-Received: by 2002:a62:6883:: with SMTP id d125-v6mr2001382pfc.26.1527244371016; Fri, 25 May 2018 03:32:51 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id p71-v6sm58522698pfl.170.2018.05.25.03.32.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:50 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Jisheng Zhang , Sebastian Hesselbarth , Rob Herring , Mark Rutland Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/15] arm: dts: berlin: Add missing OPP properties for CPUs Date: Fri, 25 May 2018 16:01:57 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (clocks, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/berlin2.dtsi | 10 ++++++++++ arch/arm/boot/dts/berlin2q.dtsi | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi index d575823c5750..487e9de53244 100644 --- a/arch/arm/boot/dts/berlin2.dtsi +++ b/arch/arm/boot/dts/berlin2.dtsi @@ -81,6 +81,16 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; }; diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index bf3a6c9a1d34..9cd00ab53f2d 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -76,6 +76,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@2 { @@ -83,6 +94,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <2>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@3 { @@ -90,6 +112,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <3>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; };