From patchwork Wed May 30 14:43:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 137261 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp5414876lji; Wed, 30 May 2018 07:43:42 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK7JTUrnbt98sw3jy1/qhIW3Ut+dBimNlQ+uiB7lrODHvmnoc3+HHLbOXic91v9zzCwARrb X-Received: by 2002:a63:a312:: with SMTP id s18-v6mr2439169pge.187.1527691422819; Wed, 30 May 2018 07:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527691422; cv=none; d=google.com; s=arc-20160816; b=SaKbLGKzRrWzcjvSQZwj/C5gHaAkU+fs9PceoFhD7ujvrE/7bOqQoa+6VG1divk8vG EnpAKxOmQU3NtPftluVbtZ0WRsXbTRGVhkeSsHJhay2D2DflJDtSr1UdrS3atqyreKBU zHaYj2C5Q/1m0j3DN76aZkBIpROoJfKOmq1Q4FVepNYNa2rROKD4o8fw5I/iOicKk16y eBQxOzyRs6M5nbF+hgorGjprVTc1yi2u+WUo7nMF0E60LVlzM7R49AaEV2N94lMnJk/F Q6SpDwG6WimHXTTs5wMlPk2bSLEVHMLhk1cE/dQof7x8vAQU+x3GdE+TaWmSatw59ZYu NcDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=p25IgzOVRbjCeGs9xYnOQ7umpafQwvBarZF7l8IBs6E=; b=Ar1KOTyBnqaHMDWg3UDW05T9aW08Bmz2r64DLMzEld7z3fTz0zsgEg0wz/gTsacXH/ yp0zXhCuvdr0d7zEjEenA0QC7tdyq24iarEJmOtJaKWfNKvIOvbNFTD3mMWFDkt/Uvu3 kJcooTcFhHmRyl8U6rIZbDtKzAidyG3oDL5+iEsvYhu62E0z3nDatdfWRlFhOJdWgVLU Mo1GVnUydIANQ0TZ4kKtUC6jvwYFLHRxiLnp9oYF326fL8oSloS7Cqd8RdxepC4gW/ZA x6ESCm1PUjjdBjAeLS9SOxhAPceNJFy7Lm6u5ckuyQ2uxRCC9fU78kDX9ayIhNntP/6m rXNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=O3xcfDGp; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92-v6si34446481plc.452.2018.05.30.07.43.42; Wed, 30 May 2018 07:43:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=O3xcfDGp; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750990AbeE3Onl (ORCPT + 13 others); Wed, 30 May 2018 10:43:41 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34042 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbeE3Onk (ORCPT ); Wed, 30 May 2018 10:43:40 -0400 Received: by mail-wm0-f67.google.com with SMTP id q4-v6so2007220wmq.1 for ; Wed, 30 May 2018 07:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=EC2jvyZwPw/4PClLRf6t9Rxj97MApWljn0D/7xGa6/o=; b=O3xcfDGpiUQNn28/dJcGaG7GbeeWTzeUeSumvFkKpLtzUecxu0vntrvsFMzpg8QJ5w zKSajfvNOgZdPTvZ/UNQWbIdWlGaTLnfySYYUXzBdRUK0YQ2lMKDvwICRZ7BjuIwqiun maAY6cvRJZ4FpMOKGccG+5yT4yVaRVdrq+WIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EC2jvyZwPw/4PClLRf6t9Rxj97MApWljn0D/7xGa6/o=; b=IRzNzEtBSDi6b+z2a8ORjPQoakYbKbAZqnZh7w7muQ9xSs4DSw3P7ZkefwqU/fEXAn MjelGp3dTHrtDZ0LENgbF6sTmPfCwhKxL8n3ALhjFJofNg/lPu03i/dzagnFpQy3C2yN IW6JXuuPp0Eq3QZEDzXv0gLQ3pC4OcLXJSh2QUpOVz1WYwzLgIBOq6rR9h2Qvut67teU 5FBD9LyBk4jyMi36KUfpDk+UdJpMoIWf86LSa1Q9ZT0tyXjG/TLWhPhx6J+hxYbnGnGk ZqrzS/0H6+AhDfDqIftZ87nxFwOenyoUQOANbdVyLqjNmOi6UuKL68QPh0KYaAYUN9BP z0jA== X-Gm-Message-State: ALKqPwe6lXkU8xGDQ1DPBRD7yWPrdTLIdMKddUrcsSUGU9Sfr9ePlj3v wxiP0crLLwbe4xAkL67wtCfKFw== X-Received: by 2002:a1c:8795:: with SMTP id j143-v6mr1808642wmd.149.1527691418851; Wed, 30 May 2018 07:43:38 -0700 (PDT) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id u3-v6sm13223823wrm.60.2018.05.30.07.43.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 May 2018 07:43:37 -0700 (PDT) From: Georgi Djakov To: ulf.hansson@linaro.org, adrian.hunter@intel.com Cc: vviswana@codeaurora.org, riteshh@codeaurora.org, subhashj@codeaurora.org, stummala@codeaurora.org, asutoshd@codeaurora.org, bjorn.andersson@linaro.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Georgi Djakov Subject: [PATCH] mmc: sdhci-msm: Remove NO_CARD_NO_RESET quirk Date: Wed, 30 May 2018 17:43:35 +0300 Message-Id: <20180530144335.7888-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.16.2 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Now we have a proper implementation for the power irq handling and this quirk is not needed anymore. In fact, it is causing card detection delays on apq8096 platforms and the following error is displayed: sdhci_msm 74a4900.sdhci: mmc0: pwr_irq for req: (4) timed out The quirk is forcing the controller to retain 1.8V signalling on the slot even when a new card is inserted, which is not correct. The proper behavior would be to reset the controller in order to start with 3.3V signaling. Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq") Suggested-by: Vijay Viswanath Signed-off-by: Georgi Djakov --- This can go for v4.18, as it's not a critical fix. Tested on db410c and db820c. --- drivers/mmc/host/sdhci-msm.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index c283291db705..791779173332 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1333,7 +1333,6 @@ static const struct sdhci_ops sdhci_msm_ops = { static const struct sdhci_pltfm_data sdhci_msm_pdata = { .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION | - SDHCI_QUIRK_NO_CARD_NO_RESET | SDHCI_QUIRK_SINGLE_POWER_WRITE | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,