From patchwork Wed May 30 22:00:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 137305 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp5843029lji; Wed, 30 May 2018 15:01:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLatQM2SelI/JEEiO4pyIlFvBsf6SbAJ7ZGi19DERWCDqrT68znTRO8KL66l0YZJGEguG0z X-Received: by 2002:adf:e152:: with SMTP id f18-v6mr3204466wri.42.1527717676142; Wed, 30 May 2018 15:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527717676; cv=none; d=google.com; s=arc-20160816; b=N6eMilaLwiFf0Dk4Pjr8UHvCC1r6FQPA1JqZHcfQZjg0WBQwPDCQu8FXfSQ3IT6XVk lxxgRIRDF9KFXoWWzkcuHV0nx2o6SURmYu8rc18M1BAWCn5N+kz6iUsBxqK775pIttIl iHvt6IxUecxcnsDlYq4mFxhLkrTE7Ro+PL4IDsQoxobbloE51Pqn3uCjB5WzYsbBng0z KOCkxlez6Kx9KhiUFz4ctKELXLO5hyG5sZcBdziAqoKp1/JvI+i4OFrgvmy+v8IMQRo7 oFCZlDomp+P5d8zGvvs9QHp3BopWThoz+JiYXJFp0OJqRmOVEdWo5RaqmTcaqAN5ONxF Ow9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from:delivered-to :arc-authentication-results; bh=ndBzCjUaRHLnclrprDfWT7Ol+aZbV+H1Phrse8rDIVg=; b=Q7GmofLAO1htITbrpjhfosn6u2LZGq8sqPre3zeV5NI8R3P3+6MTGpjrNX48how8Jc fIdRD2YYHgPGnm+zUHEG2J3+baL/+URCds6Y35HlcUWwnkRmI+ICJItomqz6l4iowblj xcHgOeYfHBUFt4jyBKCG/LiCCF9JXpxcOuyxvcwCDr4ENn7q53SjKuI7Zbbusu1p4wf1 RVu8+ehQ9EnfRQn+YvWpWz5wY2w6TU5uY1B5ACrrJCCvAxwiYetAGO+hFregueP1j5gT mujftUaEeyLtL9ezTu+2t8fjUyri017vzFvhZen+9r3lgZZFY+l9MxOzk45PXsP4XvcF 3OhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id 94-v6si7762402wrq.89.2018.05.30.15.01.15; Wed, 30 May 2018 15:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 9FD0C2677D3; Thu, 31 May 2018 00:01:14 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 745342677D7; Thu, 31 May 2018 00:01:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by alsa0.perex.cz (Postfix) with ESMTP id 1DB6C2677D1 for ; Thu, 31 May 2018 00:01:09 +0200 (CEST) Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MbQQe-1fei660HSu-00Ij9s; Thu, 31 May 2018 00:01:02 +0200 From: Arnd Bergmann To: Mark Brown Date: Thu, 31 May 2018 00:00:35 +0200 Message-Id: <20180530220057.1419933-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:UNmyZSfskeazLH3wIYQvWi5pNfMMZTyFpAQMPNq0APHZwPjY+l7 xtuRk+dQ7JbKprX8tJjYZxQpcCtEe3wcY7gPVfY0cAbJElwkBsJZGrKTCzZBD+74365aiIW B771666WJjv45u9H1vHacvRdVAHVd6Kuu+3RROU9wTlhDW86uqfmfyB2TmD8FEM408VNM+6 M3lNrJl5LJFUFnwyDomEA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Yqf7zVcvSUU=:Eke/1CPzRXiURDafNAKwJh Kfu1rMY66d5aUbuwbfbD5LyZJjFYPHL2HisySbK1jz4oozpZK74gI2cLwdVLE0bD2wjsyqR9b WJ8uDdtFQGdiVKF+v69P7vZD+eiNPqWOhXJRSijrpgjpp6zyf6bD+14wdzUYrLeRbOFUgHiAO TUm41uPDXjHB6UPU8zwBOZAqMM0Pl3DETV7jm84JicgSe/cpoVWgBYKeA9lwMPg9zEtbgV9hu ddhKpUFn66H86VZSf6doQEiGPN2LSrNk69yMghaKU5Xhe81zhDlz5oOvr56I3gJFkojDZxH8a WCshlBNHae1WwFJy6IWMq3YPYJGYvNcOfP3F/29HUke/lUoo15jrcBfjZvUq/YUJ5DjioFpkS vLTKk5CBFeBQJqCVk+f8Np1zslNDzap/a06AxQMtOQgoZNG5coZO+GHclHbdLSf3HY/DRE291 mVd8XH88CaLuVQ72+vokBt2VKWhq1CfrA9Z97QOncSnzGYcnYYhHSGbBrOUxGlR0RPGpiHrut TyxyHWj8KIl5sklPil6RpHUBGKiN3crNkQr48a4IrVyV9y3SkMcvy52nALopQgTsLR9YiQzdT ctmMhooNg1UIzKlLHFkiZkVSJmbC0mWeX5D8apJ775AsuuY/C2/aV0qoJUDYzykismySq4ziY Y9Nc3fBFx1iRTKSghSELSgAqo5HXYFDUcxOcAYqyw8wA8iBtAtveCGNVQA5ieZ38r2ZA= Cc: alsa-devel@alsa-project.org, Ryder Lee , Arnd Bergmann , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, KaiChieh Chuang Subject: [alsa-devel] [PATCH] ASoC: mediatek: export mtk-afe symbols as needed X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The new mt6797-afe driver uses some functions in a common file, which works for a built-in driver but fails for a loadable module: ERROR: "mtk_afe_pcm_free" [sound/soc/mediatek/mt6797/snd-soc-mt6797-afe.ko] undefined! ERROR: "mtk_afe_add_sub_dai_control" [sound/soc/mediatek/mt6797/snd-soc-mt6797-afe.ko] undefined! ERROR: "mtk_afe_pcm_new" [sound/soc/mediatek/mt6797/snd-soc-mt6797-afe.ko] undefined! ERROR: "mtk_afe_combine_sub_dai" [sound/soc/mediatek/mt6797/snd-soc-mt6797-afe.ko] undefined! ERROR: "mtk_afe_pcm_ops" [sound/soc/mediatek/mt6797/snd-soc-mt6797-afe.ko] undefined! This exports the five symbols above for modules. Fixes: b3c702f56bf5 ("ASoC: mt6797: combine DAI to register component") Signed-off-by: Arnd Bergmann --- sound/soc/mediatek/common/mtk-afe-platform-driver.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.9.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.c b/sound/soc/mediatek/common/mtk-afe-platform-driver.c index 00618587ef1e..51ec4ff6ed95 100644 --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.c +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.c @@ -57,6 +57,7 @@ int mtk_afe_combine_sub_dai(struct mtk_base_afe *afe) return 0; } +EXPORT_SYMBOL_GPL(mtk_afe_combine_sub_dai); int mtk_afe_add_sub_dai_control(struct snd_soc_component *component) { @@ -90,6 +91,7 @@ int mtk_afe_add_sub_dai_control(struct snd_soc_component *component) return 0; } +EXPORT_SYMBOL_GPL(mtk_afe_add_sub_dai_control); static snd_pcm_uframes_t mtk_afe_pcm_pointer (struct snd_pcm_substream *substream) @@ -130,6 +132,7 @@ const struct snd_pcm_ops mtk_afe_pcm_ops = { .ioctl = snd_pcm_lib_ioctl, .pointer = mtk_afe_pcm_pointer, }; +EXPORT_SYMBOL_GPL(mtk_afe_pcm_ops); int mtk_afe_pcm_new(struct snd_soc_pcm_runtime *rtd) { @@ -143,11 +146,13 @@ int mtk_afe_pcm_new(struct snd_soc_pcm_runtime *rtd) afe->dev, size, size); } +EXPORT_SYMBOL_GPL(mtk_afe_pcm_new); void mtk_afe_pcm_free(struct snd_pcm *pcm) { snd_pcm_lib_preallocate_free_for_all(pcm); } +EXPORT_SYMBOL_GPL(mtk_afe_pcm_free); const struct snd_soc_component_driver mtk_afe_pcm_platform = { .name = AFE_PCM_NAME,