From patchwork Sat Apr 10 11:13:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 418867 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03613C433B4 for ; Sat, 10 Apr 2021 11:16:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29EF361056 for ; Sat, 10 Apr 2021 11:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29EF361056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B8AD6167D; Sat, 10 Apr 2021 13:15:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B8AD6167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618053404; bh=gBMZYdDyIZosK032lR69LBu+F6QBR3jIiOX2E9ZKQvk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O6af3wHzNH0vbp67JKIUD7quIv+0U1V0m9SCuAjOgIftkSwPb3KIZ3Oy98VVU1g7W A0xtolOx0v4p8i/VTZjUHfK6OnZPzNv3igPwGfx82NTX95NIgO56tfrGZYMj+GF33l m5un3OlUcRlnPx0Ga2aKyw3oBAkrKhEmIO8+ms1o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D80CBF8042F; Sat, 10 Apr 2021 13:14:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D3F94F8032C; Sat, 10 Apr 2021 13:14:17 +0200 (CEST) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 21593F80246 for ; Sat, 10 Apr 2021 13:14:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21593F80246 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="cTxE100E" Received: by mail-wm1-x336.google.com with SMTP id k128so4172228wmk.4 for ; Sat, 10 Apr 2021 04:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uz/XMPMDwu/USy5yxTKfqvGGy1RjhUNSpCmU6fo9xwM=; b=cTxE100ExRKHnpQ1JKrCRUOQl5hvHud03dZ1qSIKDgRRCd9kMJ+Qqp6Nh3sjBmuZh1 +ULWzAk2ZXw5RuS3EGilrJViITuxIr21e0PfKmdoDqGd2wm2AJCacOmOF8zF86A5fWXu XcjyS22+fvxmPtG1ouWIXKc/c2mfnMrvu0qp8DCtKQw6VvMiO5OOUM545q/+MYH4fBdg ugNenDSHk75mGuHoz2rsn+PEUTp/mrlVcgT0VZEsAU5q++kNXlHdOPnHTfB1cqd53ywL HitZFWTj8XMCNWCBpWPAVqMoqSATL9U82a6q8a8h6yQAgLSx/CxKCPcjCxeHs18M6hkW Eodw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uz/XMPMDwu/USy5yxTKfqvGGy1RjhUNSpCmU6fo9xwM=; b=neAEOEcwdUHf2ETnvoVY5qkstArNM5hmDeLZ4StRpCc8j0ErpIdaI1BwF6xzK7TOcK mHzCcVVylhYsgQhYvNaUs1rpunjpx8ohq8Tt1t7Jn+jAMXkQBNiDYQfMUna7wQX70Ose g+eolYQ4zynx3hvp3NMK6h+j+hNldydPt7ugIgdL3ibBRlWF+SKtn41ZIEHzW/5FlBSa 7ZjfAouqIlDI+sNjfz0+ifHFO5maXz9GGSYrLr7aJKPE6OUlhyV1K1wEFzEid9mPsLaN yl263L2o+ZCgyJcGoj3TAMhLNC+iSOcNV/CSSp/COF0oOYfpZR7G7OGZEWKNTA9oP3Ny n+Cg== X-Gm-Message-State: AOAM5307j6UBjs9WWgf2vydrihKjQjEBu6qkDkF+s8ivn9KvvqztWPyE J5r9FBnHrDY+r3uh1Y9iI16dww== X-Google-Smtp-Source: ABdhPJweBCqlynJKqrELKofDcADCJIyh3r50EE1Req4qnVkQmoilKGiFcjGHxPxV43o/n0PNcP0MEQ== X-Received: by 2002:a7b:c34a:: with SMTP id l10mr17823837wmj.46.1618053243078; Sat, 10 Apr 2021 04:14:03 -0700 (PDT) Received: from starbuck.lan (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id s8sm8370117wrn.97.2021.04.10.04.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 04:14:02 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Subject: [PATCH 1/5] ASoC: stm32: properly get clk from the provider Date: Sat, 10 Apr 2021 13:13:52 +0200 Message-Id: <20210410111356.467340-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210410111356.467340-1-jbrunet@baylibre.com> References: <20210410111356.467340-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Signed-off-by: Jerome Brunet Reviewed-by: Stephen Boyd --- sound/soc/stm/stm32_sai_sub.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 3aa1cf262402..c1561237ee24 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -484,7 +484,10 @@ static int stm32_sai_add_mclk_provider(struct stm32_sai_sub_data *sai) dev_err(dev, "mclk register returned %d\n", ret); return ret; } - sai->sai_mclk = hw->clk; + + sai->sai_mclk = devm_clk_hw_get_clk(dev, hw, NULL); + if (IS_ERR(sai->sai_mclk)) + return PTR_ERR(sai->sai_mclk); /* register mclk provider */ return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); From patchwork Sat Apr 10 11:13:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 419311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D05C433B4 for ; Sat, 10 Apr 2021 11:16:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74906610CC for ; Sat, 10 Apr 2021 11:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74906610CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 194461679; Sat, 10 Apr 2021 13:15:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 194461679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618053392; bh=p932I4kYOrGf2dFNEWq2zkjWF3ouBS2knhY8Ph1Gev4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tvR3NrBYPU837PljXq1bIywIz6CsqNSoCMywQFniMg+e5RiuK3nKqcNzxjfXp0u5S GuT7+Ikc3T8q4LZ+ZPIauqQo07xvSrqcMfQ3AcyZz9thT1H5Aqoe+FJNZob1uPk9Iu zJtRIKE60DrEC5j3s9NHZ8oRL82CZF9ee9l6rg0E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D97CF80424; Sat, 10 Apr 2021 13:14:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EBE74F8032C; Sat, 10 Apr 2021 13:14:16 +0200 (CEST) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7CD04F800BC for ; Sat, 10 Apr 2021 13:14:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7CD04F800BC Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="cXylEKo+" Received: by mail-wm1-x32c.google.com with SMTP id g18-20020a7bc4d20000b0290116042cfdd8so6060270wmk.4 for ; Sat, 10 Apr 2021 04:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/A1ey0fLWzt4WfgOVIBJQ6OOA/NjG5WdKypO2QtjLjk=; b=cXylEKo+G+FGoGWw/Pc7EvcipCQMgdCwsCVSuOn0lNMElci4Uwgw6QgfFeBTzpxfv9 EtSFvasQCMjEjVFW/9G2U7CsPYrf5PfziFhGF3dNFZMr3uMkU82tc6C1Wwbv7VA0KHc8 ojOqmLZSFhtzbh6iDgmLFjhW/LiWXjoubdAIO0mu6YJGyBTKNHA8a0ldQsuPeAQrhqDN ozDkZ2wc/vJzx52g7FMIIU9DsjeYj/hlKPMGLvGLGNjPKrdUbdRQbNWuqfl2G08X56/L l2oehw6RUsJc9un73dH43V3lZTAbXU6OThn4MWGYBzBt2C5qKNd7ydWlTgpGS4bAYyk0 KBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/A1ey0fLWzt4WfgOVIBJQ6OOA/NjG5WdKypO2QtjLjk=; b=uP0MjlK8MdP0VOTHvtOn48bqeKKhwOi9MGXghzJLjGn0JJJSCvAx0jRwbvqGLonomE sL7elHTStBMnmr6Z6R1ptADuomlAksODsUwYbuKfy66AYAwFqIlsWGIv6k/PywEaLAIb ZOfmEVJb0poSAmj/K2H4CtJab4yVL05LdTwt6aM/oA62ibh62GIrSZBcJ3eKR+JLAZ7+ /yFrLZ6UbfQfRuA/J5zLFAL4tnK7wlzm3fY6bXjHrMA50yWqKBpw8DEoGyMxTgt7UOnI iodg3MlBfsdVf0DVUtij+c5VUt6up5AkglOkqG2nFZ5wXTFlI+bKOIzvMcdIUHKVujBY 8Iiw== X-Gm-Message-State: AOAM530fpz9y4TKLPUNmwh6UnbOo/qjL20tBMZAZSxvbpZ0waCcXgnC0 RzH1erxMRtuzxVKDxfW/DkX4UMkKZn5Qlq8T X-Google-Smtp-Source: ABdhPJxnYmdRljzrAfTykkmUmv8lKocSDXkd37oY600OclPmJY0gM661zX+6NBdKcwz/FMnSFZ4huA== X-Received: by 2002:a1c:6446:: with SMTP id y67mr255983wmb.145.1618053243628; Sat, 10 Apr 2021 04:14:03 -0700 (PDT) Received: from starbuck.lan (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id s8sm8370117wrn.97.2021.04.10.04.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 04:14:03 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Subject: [PATCH 2/5] ASoC: wcd934x: use the clock provider API Date: Sat, 10 Apr 2021 13:13:53 +0200 Message-Id: <20210410111356.467340-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210410111356.467340-1-jbrunet@baylibre.com> References: <20210410111356.467340-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock providers should use the clk_hw API Signed-off-by: Jerome Brunet --- sound/soc/codecs/wcd934x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 5fe403307b72..ae3ea136a9f8 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2116,11 +2116,13 @@ static struct clk *wcd934x_register_mclk_output(struct wcd934x_codec *wcd) wcd->hw.init = &init; hw = &wcd->hw; - ret = clk_hw_register(wcd->dev->parent, hw); + ret = devm_clk_hw_register(wcd->dev->parent, hw); if (ret) return ERR_PTR(ret); - of_clk_add_provider(np, of_clk_src_simple_get, hw->clk); + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); + if (ret) + return ERR_PTR(ret); return NULL; } From patchwork Sat Apr 10 11:13:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 419312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01BC0C433B4 for ; Sat, 10 Apr 2021 11:15:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3EA161165 for ; Sat, 10 Apr 2021 11:15:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3EA161165 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1852C82A; Sat, 10 Apr 2021 13:15:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1852C82A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618053352; bh=bdFl+OyVpqt0kC2WzQn04g4Hi2H6iOoOf17mJP7gLRU=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MZgtwa+gJbdXQbGEeJyfOLNzLa7N3cy+z1IWBX6x98uzJX0NDOgeKKoCttSL9Z9Fb 8WoqvS9NhYOusond2SrJPDaAwqxBOpuecwlSVhA0BvUydA+wQvBnSp/b67kl9qZBC/ auoFaJw68zsegQs9APQcnEq/FR3hN5pomO3Rc9sA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CFA27F80258; Sat, 10 Apr 2021 13:14:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6BA5AF8032D; Sat, 10 Apr 2021 13:14:14 +0200 (CEST) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 64056F80169 for ; Sat, 10 Apr 2021 13:14:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 64056F80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="v9U97RoS" Received: by mail-wm1-x329.google.com with SMTP id k128so4172252wmk.4 for ; Sat, 10 Apr 2021 04:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QNN+T8BLDOEY3hY3Q8J1z1U466PRLMSEBuyc1PHvJfo=; b=v9U97RoSwZSup94uN9Uxxm1PqJKrOJHw3i4+6XE11F7YO0YlBQFFBKNGBgsFykzzO+ SyJybwBPDP3LoWKZbqGTtLsZCmDWDjxCu9p50M6UcKPO5dJIR+z2jXzZwWW+lUZdPibF RPfdXU+rrfv5v6P5U9WSyt/bc8mwJ4eL13BvakKp6hNqd7OJ1yvJYeIxWmp2dZ11zMO9 cvJcLF90mrSx4cVlx5xiEPQUKiEe7l7Orc2kJNhK41wGd1QFHW2wNuwkRy+AqwYUJcTB 9dI5scsAd47NO5N+I48qS/uNxv2InLZFW+7wXZsW3RKCCXFyIHlzdiry+/tuSAjsC9mp +yMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QNN+T8BLDOEY3hY3Q8J1z1U466PRLMSEBuyc1PHvJfo=; b=alRj+WZZSivUS8rFS6FrpOP8Xuh7V0gvUBCL5DAfk3hyYVv9Sp8xsi7JFr/o91VDF5 GK/iYNAA7DLkXfbFXxXsGIKj3bV5Sk9SquwXJaSZU9oUExMwJu37JkvkJ6Vrlxd5OWgj wQNJiTLUODCU6xMganB3F36yoIzGgDOoEY4iTEcrcOz0i3rB1ho2Tw8YGKwK3G728/Dw zSKyhOhuy8R9rEbwUwE/Kq3HqHHl6JybgHcAv9RBi7xqEcuCyVdOpnajMcDWizlV2J6P Wu3Ow0eaFwsnJVpstgnwLJ7wKUv5IpCWXn8ZTJwKz14zVf3RQ/IcgrQkaNCfjjvCORU3 xI0A== X-Gm-Message-State: AOAM530C2PixXM7IFm3sT/oeMSUewN97M3Q+KA1KCQI0a4wDKNoZdCRi QuaLDFytEhUrFhAXczCKlnedEw== X-Google-Smtp-Source: ABdhPJzPWFJbT8j9mVKSkGi4AalpAZcoxl73akrvuCpEf0o1LSZf+CIY4lYmIhXbZ6f56s90pj0Djg== X-Received: by 2002:a05:600c:ad3:: with SMTP id c19mr17827365wmr.125.1618053244161; Sat, 10 Apr 2021 04:14:04 -0700 (PDT) Received: from starbuck.lan (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id s8sm8370117wrn.97.2021.04.10.04.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 04:14:03 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Subject: [PATCH 3/5] ASoC: rt5682: clock driver must use the clock provider API Date: Sat, 10 Apr 2021 13:13:54 +0200 Message-Id: <20210410111356.467340-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210410111356.467340-1-jbrunet@baylibre.com> References: <20210410111356.467340-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock drivers ops should not the clk API but the clock provider (clk_hw) instead. Signed-off-by: Jerome Brunet --- sound/soc/codecs/rt5682.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 0e2a10ed11da..2eee02ac8d49 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2634,7 +2634,7 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate, container_of(hw, struct rt5682_priv, dai_clks_hw[RT5682_DAI_WCLK_IDX]); struct snd_soc_component *component = rt5682->component; - struct clk *parent_clk; + struct clk_hw *parent_hw; const char * const clk_name = clk_hw_get_name(hw); int pre_div; unsigned int clk_pll2_out; @@ -2649,8 +2649,8 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate, * * It will set the codec anyway by assuming mclk is 48MHz. */ - parent_clk = clk_get_parent(hw->clk); - if (!parent_clk) + parent_hw = clk_hw_get_parent(hw); + if (!parent_hw) dev_warn(component->dev, "Parent mclk of wclk not acquired in driver. Please ensure mclk was provided as %d Hz.\n", CLK_PLL2_FIN); From patchwork Sat Apr 10 11:13:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 418868 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F49C433ED for ; Sat, 10 Apr 2021 11:15:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FD7A610CC for ; Sat, 10 Apr 2021 11:15:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FD7A610CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AB5E8165E; Sat, 10 Apr 2021 13:15:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AB5E8165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618053356; bh=8A1YPTSnDuKVDZ+sq1kCg0aKNP8XMXYqT+PB+5SRS2s=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K6bVsNBHVhkW78MsIGKKe9s5C8/jS0QJSQkRCWddWhVPgUOS/T1m4G8reTVpzknxM xplMu7hAYQsk3rX1h6Hc3p+yeyPM2ppeQTwSx+CRyc2VTaD2J9pOs5uzaG+a4zqrq0 6PVn0GGVUbSvshnmIFZjOx4db8wNOLW+S2dGNqFM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8F414F802C8; Sat, 10 Apr 2021 13:14:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7420FF80169; Sat, 10 Apr 2021 13:14:14 +0200 (CEST) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4599BF800EE for ; Sat, 10 Apr 2021 13:14:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4599BF800EE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="A3xrc6nv" Received: by mail-wm1-x32d.google.com with SMTP id o20-20020a05600c4fd4b0290114265518afso4255057wmq.4 for ; Sat, 10 Apr 2021 04:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TP8T7u/GZFTrtgKPlRTZREBN4itlWMrED3RXVnj2Hvk=; b=A3xrc6nvjZqOxDDtK7Wx3wmDtTLWfx71NNoOx2Eq7lEMJwyrIsFIVSq5FFPUIcibcp rkSQB+P1yoi1YGs+ip7cvj3aJ3M7f8k2hlVQOPTwGQsjEQLYe7b/nDCE03dmnjDBU7c3 waSD8DKKGazkEEHzmZo9dX22J9wwfcSztUkq1n/+1OKe6lswa3gTn4325ZxgAwWE4j+4 K0ovXowaDT5Qb3NCmmbghjL2prSKgJbRzwDGoFMkfD64WqZ/iMIVpvQ8pqe0hx3n0M3f 9EaQHGHdiIMARyC3N/GUrt0NuuMpS9W836Bq34pUCMcVQQOvN86EJ8mGAEoVJvLLM9L9 Xrlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TP8T7u/GZFTrtgKPlRTZREBN4itlWMrED3RXVnj2Hvk=; b=f/RRs5ZGMJ05WzE9lnJD7CE76BcokdaSBxdGXgK7rw4TNimNUlAX4FBYRNdGK15098 Zc/5p+4zr0HsCBJuAHD4H66T9RqhOHb3ECW+SorZX1xG+LurDmgDLt7eXH2YXR1fhsXC 6y4atXbFr6XkXcPj4NzrODArvw7kdT/Iv/BQChCwZiO84LhPrx66N/dXozZu9bpnsCF+ 0kdCW7BrCZLTngW4o1kMRk2qSSoKXCkw0ds1V6zwtjxlgwz4fw4BN1YwjmMeiE+OKhyn sT9mGqYlSE0NdZ/Bfpd82yDo+s0lLRGvUqT0vqxLbUvd1B21AYm6/pKALi9lRxwbHShh 08YA== X-Gm-Message-State: AOAM530r8teU2OuQAk0jpuTNziEacxBskU9cQkkofGSgAxlL4/c51beL fXxwWcomHZhPG0HNsZFqMIRcpzkXdwqsvUSZ X-Google-Smtp-Source: ABdhPJw9q7x+1VOwDxzk2hAmfo7HajBJAxPBRPLtfyVt6RgWc3TQJxduuAimU7XHHgvYNPMwoLvJMQ== X-Received: by 2002:a1c:2704:: with SMTP id n4mr18029046wmn.143.1618053244789; Sat, 10 Apr 2021 04:14:04 -0700 (PDT) Received: from starbuck.lan (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id s8sm8370117wrn.97.2021.04.10.04.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 04:14:04 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Subject: [PATCH 4/5] ASoC: lpass: use the clock provider API Date: Sat, 10 Apr 2021 13:13:55 +0200 Message-Id: <20210410111356.467340-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210410111356.467340-1-jbrunet@baylibre.com> References: <20210410111356.467340-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock providers should be registered using the clk_hw API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/lpass-va-macro.c | 2 +- sound/soc/codecs/lpass-wsa-macro.c | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 5294c57b2cd4..56b887301172 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1343,7 +1343,7 @@ static int va_macro_register_fsgen_output(struct va_macro *va) if (ret) return ret; - return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk); + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &va->hw); } static int va_macro_validate_dmic_sample_rate(u32 dmic_sample_rate, diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index e79a70386b4b..acb95e83c788 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2337,10 +2337,9 @@ static const struct clk_ops swclk_gate_ops = { .recalc_rate = swclk_recalc_rate, }; -static struct clk *wsa_macro_register_mclk_output(struct wsa_macro *wsa) +static int wsa_macro_register_mclk_output(struct wsa_macro *wsa) { struct device *dev = wsa->dev; - struct device_node *np = dev->of_node; const char *parent_clk_name; const char *clk_name = "mclk"; struct clk_hw *hw; @@ -2358,11 +2357,9 @@ static struct clk *wsa_macro_register_mclk_output(struct wsa_macro *wsa) hw = &wsa->hw; ret = clk_hw_register(wsa->dev, hw); if (ret) - return ERR_PTR(ret); - - of_clk_add_provider(np, of_clk_src_simple_get, hw->clk); + return ret; - return NULL; + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); } static const struct snd_soc_component_driver wsa_macro_component_drv = { From patchwork Sat Apr 10 11:13:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 419310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABC3C433B4 for ; Sat, 10 Apr 2021 11:17:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CE7C61056 for ; Sat, 10 Apr 2021 11:17:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CE7C61056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B7C4A166E; Sat, 10 Apr 2021 13:16:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B7C4A166E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618053439; bh=dJ4nWjNpIeMJWFWTizvuySO/6A+TwhQGsW7s3Mw1OM4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R83Ai4OxmftKXexePhnRWZWf7v7nRUoFSkSVdK5zTzgNK/HqNgfVzdDBOwEeWvXLq YpULeOq9ss+Uc4fkQGHdOsjm/8Ofgl+pcui5GjspveqJZIoCQL76gWa2bDYesJLwPG Lxj+MEq0M0QsTv/L0P4GqwfDNZmJGbgnI76rvDcg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9C47EF804A9; Sat, 10 Apr 2021 13:14:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5AE56F8032C; Sat, 10 Apr 2021 13:14:18 +0200 (CEST) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27A38F8020B for ; Sat, 10 Apr 2021 13:14:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27A38F8020B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ER/6JODq" Received: by mail-wm1-x330.google.com with SMTP id o20-20020a05600c4fd4b0290114265518afso4255065wmq.4 for ; Sat, 10 Apr 2021 04:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tP2B7PpyvjqGNjx+bX56P7sB4iUvry5KkFolRNleklk=; b=ER/6JODqNnCYiew9ExFspdf9CLFlaQHxcUelbQSKowEOT/MYWOoqxbB0YGIYtZoZaQ UfbcRcDxgBE0dgTQqk6kSDpbLBcLMeIHFpbHP1c1twrlpRTH9pGqPg6TyShwyFG9y5St 5UMnqoWLEEnp4bTDAiyMKB0/CIWckeYyl1As265mnZObJKKifZTo+FIFuWgNBcvVMHUR csmvWilnUGpt/xXOunB0xaW/WkTUyzqzznacYnbFe2n7aY7evhwNw8Hf52WMo21Qhu65 gvEFSpYfKAOXg7yOle1Di7FsnozxDZvCrYz1vlTLuPm0hCyH3F+8LiDXophjGLIFR+y7 KUJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tP2B7PpyvjqGNjx+bX56P7sB4iUvry5KkFolRNleklk=; b=KtDszJX9DrqVZ7LFq6qzkxV+LVYfzFkpz9eUnMtdNLWkQjK1GNLShr6vs8QebHUu+J lHHo1gNZYeysuewK7qK5FV/rj94F7Eup6ItDRTPJ5wpwihIW2Rk8geRG5b0gxtVZ4+RS M4NCg6y3N2pHxx/0Vn6q5ui5jS4dHUONIfTgFp/88wMTmdX+56UOzF7rhSoNV2PjNFKk VG3lRBOoxv0OVZPMSCrh0YZOYh33E/7yy9GRDnzqeXXx0AAzQCzQNMGhSoVkLeHsVnZK 8lsDAYdY+L24nBORZ+BHbrhhvKF53bARdPaP2u2KWdt3uD6tJiSWCRtWs1DuhIcAnLJY PaGg== X-Gm-Message-State: AOAM530dTdRcBKGJ8rwk3oIJc+PisRgoIlg1iCH/7maHDnlnjgKLK9pr 5fxClmRvI6KyNB0MWWKyEXGFMy5FvAtUCRAM X-Google-Smtp-Source: ABdhPJwTzTHbQN8i5k02Db+ienjllS5Z03I5zxFQECMU0GrCRJK2v7QfxBehPGg7/tC1L0hI/k3vTw== X-Received: by 2002:a1c:a182:: with SMTP id k124mr6414729wme.132.1618053245421; Sat, 10 Apr 2021 04:14:05 -0700 (PDT) Received: from starbuck.lan (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id s8sm8370117wrn.97.2021.04.10.04.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 04:14:05 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Subject: [PATCH 5/5] ASoC: da7219: properly get clk from the provider Date: Sat, 10 Apr 2021 13:13:56 +0200 Message-Id: <20210410111356.467340-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210410111356.467340-1-jbrunet@baylibre.com> References: <20210410111356.467340-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/da7219.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 13009d08b09a..bd3c523a8617 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -2181,7 +2181,10 @@ static int da7219_register_dai_clks(struct snd_soc_component *component) ret); goto err; } - da7219->dai_clks[i] = dai_clk_hw->clk; + + da7219->dai_clks[i] = devm_clk_hw_get_clk(dev, dai_clk_hw, NULL); + if (IS_ERR(da7219->dai_clks[i])) + return PTR_ERR(da7219->dai_clks[i]); /* For DT setup onecell data, otherwise create lookup */ if (np) {