From patchwork Mon Jun 11 13:30:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 138243 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4066506lji; Mon, 11 Jun 2018 06:32:49 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIvGhRfMiY9D/tsn4sVf5/a1WnLJWAqMtumFbmvmfo+f3lvpcaFNvvo6VmlMyjRWSkgxlz4 X-Received: by 2002:a63:61d6:: with SMTP id v205-v6mr14871861pgb.432.1528723969587; Mon, 11 Jun 2018 06:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528723969; cv=none; d=google.com; s=arc-20160816; b=fkqHr69cTeQfJ7KWXDw7sKxAagH1JhH/Ua3BcxfcCtdRwke1Cd2d302IrBPaGwsmm9 QdF5knBkR+LyfGf30C91hwukZk3Nr5JaiKGbK3PiDt3EmAtNfvFTErEx5UHSq21aj+c8 Y1XVDYYpyBKK4eBRFqg5KYiIMdV53uk5/QqbWf970lJKWkCsh31kdnXbpYqPZouGIu4h FT4sfLKGBWIkdOC6bDzI8GY9n/1VoJkj/hGGH+pFwfX/f868VJhnYQyBiVsShE4Bf7Ss XrMRhk4LBdbDA1KvgPSDVaSMwO4yLlY+34ybl2M/NA8vndCW0HPyCRqkvWpG4taHM53q VEGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=6awvhZkT4StAkB64KObxkTnMJS8FnlnIBjoYhWMalSc=; b=RlfCGfhCT/VNeGXYowQjty3j+5UZio7rYp7uqEFYP+G9quByEkYGOAnAAz+20fIekf wTGhl/7cg00ulIhsH7viHHwTwtFqV/zCcu+EDF1w8mhixoEoxJ8jft603FQ+abJbVHqG w+KsdBDP2WPW91RxAtXnnPTvnApLdj8AXgdkh6o5UiawNxR2wyjZNFYpQOK4ugn3MjFs 2MQH86nV1DcIR7xHr3PrVoiEfKZyzR7SIN29Qke/lGCfAOuhM+App9Iw0Q1Kjvd0dJpO OMcDeJSKAhmddzZrGRaGRx9T5qDyVyuNtj6JoFHelgVzec7J5LkBgqc8OhUI1G703MfK T3zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SzHgkSmV; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e37-v6si64616463plb.400.2018.06.11.06.32.49; Mon, 11 Jun 2018 06:32:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SzHgkSmV; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933281AbeFKNcr (ORCPT + 5 others); Mon, 11 Jun 2018 09:32:47 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:43953 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754087AbeFKNa7 (ORCPT ); Mon, 11 Jun 2018 09:30:59 -0400 Received: by mail-lf0-f65.google.com with SMTP id n15-v6so30542294lfn.10 for ; Mon, 11 Jun 2018 06:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j3jIepUwDw2xc+pgExVeFYswjqlQIgEI3e1Xbicq7EM=; b=SzHgkSmVMJtI82iO9LMiqiAuLA6XITGgA8fh0lVhSWMYL8V886MllHH8ZcjJoiB2iK eAd4isGTHWYMpM8MICe6nt4KaUegmO53HsOAYXo5AAkcdGZMKBuOwnU8dW1+7tCT3O3e KctIVuoJ8+GekxHKsDz9To7kezqZ41xDoKDxA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j3jIepUwDw2xc+pgExVeFYswjqlQIgEI3e1Xbicq7EM=; b=ZZlFJTDHkqSxnAuq1b2bhrQC457R+90ZZ7mjnXD66xUrAnnTmcWG0uV/oSP0IuXYdw Ah7iKAmT8G35TsL4/TyUto0IU9WDBrV7w127wBci5uMB2tnv7O1CCxOBBRE4bOsk1WTn hWHLzfv0GLvl8bHLoITd3WXnjXM16fMaMdnT6PGyHHr7ZujGFdgAMfZXeLCaPZb94d6P 2X+k2AIuvt13/2xgetdfmI9v1OGs+RiEydD3d2+o2d/LMcylE/hg3VBn5oOgvyiYMvKR Gtma9Zwvl5KFpX99FifKxFW42TU4vdC4vkm4mUbwjwrJICbfnQe8za1h0wmQ9aOHzJDK 46oQ== X-Gm-Message-State: APt69E3EscYsRkrlSMl9X0sT1RqmWwDA6o/ZKm6QNTMai86I5C+ipXrU wydCVycI2yKROGEcepUc4iiIkw== X-Received: by 2002:a2e:163:: with SMTP id 96-v6mr12307996ljb.8.1528723857965; Mon, 11 Jun 2018 06:30:57 -0700 (PDT) Received: from localhost.localdomain (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id u24-v6sm2617712ljj.96.2018.06.11.06.30.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 06:30:57 -0700 (PDT) From: Ivan Khoronzhuk To: grygorii.strashko@ti.com, davem@davemloft.net Cc: corbet@lwn.net, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, vinicius.gomes@intel.com, henrik@austad.us, jesus.sanchez-palencia@intel.com, ilias.apalodimas@linaro.org, p-varis@ti.com, spatton@ti.com, francois.ozog@linaro.org, yogeshs@ti.com, nsekhar@ti.com, Ivan Khoronzhuk Subject: [PATCH net-next 1/6] net: ethernet: ti: cpsw: use cpdma channels in backward order for txq Date: Mon, 11 Jun 2018 16:30:42 +0300 Message-Id: <20180611133047.4818-2-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180611133047.4818-1-ivan.khoronzhuk@linaro.org> References: <20180611133047.4818-1-ivan.khoronzhuk@linaro.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The cpdma channel highest priority is from hi to lo number. The driver has limited number of descriptors that are shared between number of cpdma channels. Number of queues can be tuned with ethtool, that allows to not spend descriptors on not needed cpdma channels. In AVB usually only 2 tx queues can be enough with rate limitation. The rate limitation can be used only for hi priority queues. Thus, to use only 2 queues the 8 has to be created. It's wasteful. So, in order to allow using only needed number of rate limited tx queues, save resources, and be able to set rate limitation for them, let assign tx cpdma channels in backward order to queues. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 534596ce00d3..406537d74ec1 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -967,8 +967,8 @@ static int cpsw_tx_mq_poll(struct napi_struct *napi_tx, int budget) /* process every unprocessed channel */ ch_map = cpdma_ctrl_txchs_state(cpsw->dma); - for (ch = 0, num_tx = 0; ch_map; ch_map >>= 1, ch++) { - if (!(ch_map & 0x01)) + for (ch = 0, num_tx = 0; ch_map & 0xff; ch_map <<= 1, ch++) { + if (!(ch_map & 0x80)) continue; txv = &cpsw->txv[ch]; @@ -2431,7 +2431,7 @@ static int cpsw_update_channels_res(struct cpsw_priv *priv, int ch_num, int rx) void (*handler)(void *, int, int); struct netdev_queue *queue; struct cpsw_vector *vec; - int ret, *ch; + int ret, *ch, vch; if (rx) { ch = &cpsw->rx_ch_num; @@ -2444,7 +2444,8 @@ static int cpsw_update_channels_res(struct cpsw_priv *priv, int ch_num, int rx) } while (*ch < ch_num) { - vec[*ch].ch = cpdma_chan_create(cpsw->dma, *ch, handler, rx); + vch = rx ? *ch : 7 - *ch; + vec[*ch].ch = cpdma_chan_create(cpsw->dma, vch, handler, rx); queue = netdev_get_tx_queue(priv->ndev, *ch); queue->tx_maxrate = 0; @@ -2980,7 +2981,7 @@ static int cpsw_probe(struct platform_device *pdev) u32 slave_offset, sliver_offset, slave_size; const struct soc_device_attribute *soc; struct cpsw_common *cpsw; - int ret = 0, i; + int ret = 0, i, ch; int irq; cpsw = devm_kzalloc(&pdev->dev, sizeof(struct cpsw_common), GFP_KERNEL); @@ -3155,7 +3156,8 @@ static int cpsw_probe(struct platform_device *pdev) if (soc) cpsw->quirk_irq = 1; - cpsw->txv[0].ch = cpdma_chan_create(cpsw->dma, 0, cpsw_tx_handler, 0); + ch = cpsw->quirk_irq ? 0 : 7; + cpsw->txv[0].ch = cpdma_chan_create(cpsw->dma, ch, cpsw_tx_handler, 0); if (IS_ERR(cpsw->txv[0].ch)) { dev_err(priv->dev, "error initializing tx dma channel\n"); ret = PTR_ERR(cpsw->txv[0].ch);