From patchwork Thu Apr 15 16:54:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 422970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0401BC433B4 for ; Thu, 15 Apr 2021 16:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4D196117A for ; Thu, 15 Apr 2021 16:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbhDOQyu (ORCPT ); Thu, 15 Apr 2021 12:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbhDOQyu (ORCPT ); Thu, 15 Apr 2021 12:54:50 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AA39C061574; Thu, 15 Apr 2021 09:54:27 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id 18so9028675qkl.3; Thu, 15 Apr 2021 09:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dx1/r/N68A6cT3i6PlmlaAahaUCvbfGXrjCcPAhDBzw=; b=YgHNKnOsdv0YMHXZW8RrF1EPzF/UsNnC5njhIrZcZTbUN0jevFraJl6ifAxPsgKZjH ZCAV0uJCXeFnk5xyFdC7DYU164c7z/sU8pqN6lMflO6OQihEMJsIuR+oJ8ffhKvgBXDj FvjbVgdBAV8rotE0N6UyQVy6/K0m4U5J3ktzAi9lY2f6L/9p4xjkOp9eeu1ME50WeefW r6IqTFdMyDsrithLZWyTKicveeH24ji1HFeofN5lPWL7oOkK6W5VvB+tXwfiWC2LlZ2w gyGxmw7LgYqXHpGiK44NpJ0VJ7NixccMrA0nAc9oUZQumH6BZZf/QKYz9XGGoTuh9En0 mulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dx1/r/N68A6cT3i6PlmlaAahaUCvbfGXrjCcPAhDBzw=; b=gOODYehXCU25N+X52QI7rVIo8anjfrQTzoFHigYO12kgfJH4cJCbeQA77/8c7E4Ytz xIJW5SX0mH3Ow6ykQAZXinJKR3Te/BNIxqFlZIvxEgygNOKj45bAAhtbMJFx2NvmyUYH sQ8IPvgaOdtPyMt5hRYuFZihKKbh7IrnrucvXuTNQgwBAAtxM1e9Sj2NFvrmqr+UnkkF WH1cXiPB2qeSu6YCElB6hbat9zxLAuCkTRwMznD8uyhn1T/MjPKOyaTVM8RVqPcuCrcS ecBdcJwtZqs9zF2nkD8tSbUkj9/lzlHwjAPVVN18iheTNDll1aeIHHChOuS5kSc+wB1l bVYg== X-Gm-Message-State: AOAM532pPQqfPjFaW5x7uaBcm7eARZncW2MgJ1o8EiV/0m6ECsEf0tna 0kEVXfLyRurpAnX0kfMoMft4zpB/XQMLYZO1 X-Google-Smtp-Source: ABdhPJzESx6Ae1ersyawFYdb9u/Qx2IzcBGRiCY8/MVLLoXmx+Fnv11A4g1FnfXWZsXN3Sl8+cPq+g== X-Received: by 2002:a05:620a:1432:: with SMTP id k18mr4316365qkj.151.1618505666414; Thu, 15 Apr 2021 09:54:26 -0700 (PDT) Received: from focaruja ([138.204.24.234]) by smtp.gmail.com with ESMTPSA id 7sm2416170qkl.107.2021.04.15.09.54.25 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 15 Apr 2021 09:54:26 -0700 (PDT) Date: Thu, 15 Apr 2021 13:54:23 -0300 From: Aline Santana Cordeiro To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 1/4] staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c Message-ID: <2e1b53962aab474ab092b1cf09afeb05de7eeabc.1618505476.git.alinesantanacordeiro@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index abc17ec..8a5796e 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -1132,9 +1132,10 @@ void atomisp_buf_done(struct atomisp_sub_device *asd, int error, asd->frame_status[vb->i] = ATOMISP_FRAME_STATUS_OK; } - } else + } else { asd->frame_status[vb->i] = ATOMISP_FRAME_STATUS_OK; + } } else { asd->frame_status[vb->i] = ATOMISP_FRAME_STATUS_OK; } @@ -4898,9 +4899,9 @@ atomisp_try_fmt_file(struct atomisp_device *isp, struct v4l2_format *f) depth = get_pixel_depth(pixelformat); - if (field == V4L2_FIELD_ANY) + if (field == V4L2_FIELD_ANY) { field = V4L2_FIELD_NONE; - else if (field != V4L2_FIELD_NONE) { + } else if (field != V4L2_FIELD_NONE) { dev_err(isp->dev, "Wrong output field\n"); return -EINVAL; } @@ -6548,17 +6549,17 @@ static int atomisp_get_pipe_id(struct atomisp_video_pipe *pipe) { struct atomisp_sub_device *asd = pipe->asd; - if (ATOMISP_USE_YUVPP(asd)) + if (ATOMISP_USE_YUVPP(asd)) { return IA_CSS_PIPE_ID_YUVPP; - else if (asd->vfpp->val == ATOMISP_VFPP_DISABLE_SCALER) + } else if (asd->vfpp->val == ATOMISP_VFPP_DISABLE_SCALER) { return IA_CSS_PIPE_ID_VIDEO; - else if (asd->vfpp->val == ATOMISP_VFPP_DISABLE_LOWLAT) + } else if (asd->vfpp->val == ATOMISP_VFPP_DISABLE_LOWLAT) { return IA_CSS_PIPE_ID_CAPTURE; - else if (pipe == &asd->video_out_video_capture) + } else if (pipe == &asd->video_out_video_capture) { return IA_CSS_PIPE_ID_VIDEO; - else if (pipe == &asd->video_out_vf) + } else if (pipe == &asd->video_out_vf) { return IA_CSS_PIPE_ID_CAPTURE; - else if (pipe == &asd->video_out_preview) { + } else if (pipe == &asd->video_out_preview) { if (asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO) return IA_CSS_PIPE_ID_VIDEO; else From patchwork Thu Apr 15 16:54:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 422030 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8525EC433ED for ; Thu, 15 Apr 2021 16:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6177E61166 for ; Thu, 15 Apr 2021 16:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234289AbhDOQy4 (ORCPT ); Thu, 15 Apr 2021 12:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234150AbhDOQyy (ORCPT ); Thu, 15 Apr 2021 12:54:54 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58143C061574; Thu, 15 Apr 2021 09:54:31 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id s5so17127922qkj.5; Thu, 15 Apr 2021 09:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hfH9qknOEmohu17OrwvjCdEEb8rYc5CBKzPF1LsT3eY=; b=HzCYmhgbLL5xC8q4+NrcVQ3vIVEBudkfm4plF8E6VgB6YhvtP2uyfobR4oGYRqc2Wi Q5DGBKpm/SDyP1yoMOxMC1jhtsZ2069gFEzpzJ9wx3Q0d8U3ykMwuQNmnqJS3urjDLPL JnEQOW6B8VCio8ObDanO5gEpypAHZWUe0vAnAjAdUiTe6ALa0nNBfuaA0rGXxDtALEwh A71fyif6OZWf6DSJpxi4I2i1enFxLqkggYqtbmp+XybqdK6HpDL+i6/7kU/tGQbIuIob cJESNvbo00sUZobY3tcS8JEurg64cXZLCYpSLuQd84nZmN2LoLd4tzSzBQUxvSXhhYkD TW1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hfH9qknOEmohu17OrwvjCdEEb8rYc5CBKzPF1LsT3eY=; b=MYHqMPvI8YfVfuQu71jAx3niK1LF88FcOXuDYW+YYEx3O9gcOgBSh6jy6xycjl7RPN GdbFfZuXJ5fzJyjTPZooRHgkW2uiPVZIiuJJtoMPSGsJ3uB2DdKPnfIan+Lw5oCu1Sy5 fFpfN8ZhOso4upfy13Uac0B+mqBqxlF0WRQMWNIIDZPA1GFAJGTtxuleHWrqXXbrCRiH /ZhkRV5BVr634Rw2Lc06jlGn55AA6E0Ht1EpiMRUvq7VMK19Pc0RJane719U4Vz+Y9O8 pEHdvo25KRqdhHT787KLceVIzgSq20ZaL6YLC8CNZaQil6ad1MG6rYp7YNxNpIVi0Hby gJIg== X-Gm-Message-State: AOAM530mBVfu0cqvOeZNBuTW7BdZN46vQWSG0KFy+a7YcZT2TtJxDdpb IW7Hu3ipy/8XmRZDke+a3uI= X-Google-Smtp-Source: ABdhPJxHQx7kaQAUYXUKg9bgvGIurPdPr8BTriL9Xg9YPgc770mRYeBfV651EpOCszqCi5yu9FE4Ig== X-Received: by 2002:a37:6693:: with SMTP id a141mr2048435qkc.121.1618505670663; Thu, 15 Apr 2021 09:54:30 -0700 (PDT) Received: from focaruja ([138.204.24.234]) by smtp.gmail.com with ESMTPSA id q125sm2431762qke.11.2021.04.15.09.54.29 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 15 Apr 2021 09:54:30 -0700 (PDT) Date: Thu, 15 Apr 2021 13:54:27 -0300 From: Aline Santana Cordeiro To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 2/4] staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_compat_css20.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c index faa0935..92e2bad 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c @@ -2784,9 +2784,9 @@ int atomisp_get_css_frame_info(struct atomisp_sub_device *asd, int stream_index; struct atomisp_device *isp = asd->isp; - if (ATOMISP_SOC_CAMERA(asd)) + if (ATOMISP_SOC_CAMERA(asd)) { stream_index = atomisp_source_pad_to_stream_id(asd, source_pad); - else { + } else { stream_index = (pipe_index == IA_CSS_PIPE_ID_YUVPP) ? ATOMISP_INPUT_STREAM_VIDEO : atomisp_source_pad_to_stream_id(asd, source_pad); From patchwork Thu Apr 15 16:54:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 422969 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5170BC433ED for ; Thu, 15 Apr 2021 16:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 388EF61184 for ; Thu, 15 Apr 2021 16:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234318AbhDOQzD (ORCPT ); Thu, 15 Apr 2021 12:55:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234326AbhDOQzC (ORCPT ); Thu, 15 Apr 2021 12:55:02 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9FDC061756; Thu, 15 Apr 2021 09:54:37 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id o5so25935156qkb.0; Thu, 15 Apr 2021 09:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sKPscdnN4p036oGIIGdcJly3t0X9xL0TlPcjGDANiX4=; b=kX+aT+xJYRNY3gF53LIK1HUQZ5f+r2tQ37dfCn9Nmm7Wsps7RHfZ/21lgEFLKEyXJ3 cjI6FT2RSfxH4Y5nsPgDzHbDffzZMkgGqm8y+JUEpEOej7GXpT/gvj+QlsCY26fRurjV JZHCHxYO3oh4fZ3T08NbzCAcxb0K0/W4rZIdXe5696aj8gj1JLu0MDeRotPyvFMPrZZT WFBeZ4CIushvjcm6q0sNNqpu5ca3v/duaKWV966+i0oIdALHcPQOstbYQcAtMAkBYYqn c1PG43pMh3QPUSKuzTODwF6QzkOHdPtY3HC4uHa94LExzE08IzkjdaPaP5XSSVwqYlBz xLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sKPscdnN4p036oGIIGdcJly3t0X9xL0TlPcjGDANiX4=; b=b0k8a+6QTByHtDRBUvvw1x5+FyYdlcCZngr4aOJpRdTEftekqi8+cSRVQlfwcQqp8R Ww/B/e/2t4WCBUg6+rUnXC3nRcdDkurTzLeUCxxZCRQayrlPlHbd6sOUgjoustLqenYk CQ69YZsHzXCu1LtyrS+UhpBe01cI49lXC9FczKXHxE7NBQIM0gWel9KqMeUJ9PNuUDuW 4kFksR4JJ/BnHT1BTQEkHM/YvpMWs7ee53LG94iJmHD9ptsPHAIaw0K7VrtLo3y8xr4E nsaVuP1QSPZ05MynHtKH89W7xXvDYg/ZyhgAkLk82oRW8VJJsgGY+gPV8Bl7jGLifITb Hr/g== X-Gm-Message-State: AOAM5306BzCB9zj3dMnNxSGH6TWZHjDq2DG0wkwUHi9YUjrnvjSGZlS8 fgWiwezqEWfXj3ejYtLwyPU= X-Google-Smtp-Source: ABdhPJwswCLrM97/QTIaaO99478ipWzTiiBnhPB0l8ODUefpA7hDJcP3iTIBG0WNzrgNPN5xkKEMvQ== X-Received: by 2002:a37:b103:: with SMTP id a3mr4561489qkf.261.1618505676976; Thu, 15 Apr 2021 09:54:36 -0700 (PDT) Received: from focaruja ([138.204.24.234]) by smtp.gmail.com with ESMTPSA id s12sm2085022qtn.69.2021.04.15.09.54.36 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 15 Apr 2021 09:54:36 -0700 (PDT) Date: Thu, 15 Apr 2021 13:54:34 -0300 From: Aline Santana Cordeiro To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 3/4] staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_subdev.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_subdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c index 2ef5f44..aeabd07 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c @@ -472,9 +472,9 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd, * when dvs is disabled. */ dvs_w = dvs_h = 12; - } else + } else { dvs_w = dvs_h = 0; - + } atomisp_css_video_set_dis_envelope(isp_sd, dvs_w, dvs_h); atomisp_css_input_set_effective_resolution(isp_sd, stream_id, crop[pad]->width, crop[pad]->height); From patchwork Thu Apr 15 16:54:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 422029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E246BC433ED for ; Thu, 15 Apr 2021 16:54:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFFA261166 for ; Thu, 15 Apr 2021 16:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234344AbhDOQzJ (ORCPT ); Thu, 15 Apr 2021 12:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234230AbhDOQzH (ORCPT ); Thu, 15 Apr 2021 12:55:07 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22752C061574; Thu, 15 Apr 2021 09:54:42 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id 130so11681409qkm.4; Thu, 15 Apr 2021 09:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fR/xSrCM/HXuA5hfHE8+/OAjFdohjbHZ5jP2nSMBAdE=; b=ly1ZFEkH3Idb9G5huOwqD5wG1MLCgXGaiyWPzbx89bALJKcD2bIr11Jt4E5v9VNWOP ++CD5FyssgkVeBJNAP16TCyRuxW82Cd8JMZ3VOrlkWv2EpNDmiHy8wmCio0YdcFonbCh 04ydqyC0bqjWECpcHPj3pbIr/jiKbA9W8XOF37nBwPwYSrjMQQB7QYyNnkShkmOkafsC 1XgVBFPdBzmotToKrYgjxBLfnNZO4bc7bCSuQ1uas3BavxfzksPXlLkVV1oMSNGwMwv0 CAcgqrB/u+Mln819pqzIORJ4t/eHcn7URY4TruBTVz0QvKNgPoQO9+6M9I0XOCfwK1ml oTIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fR/xSrCM/HXuA5hfHE8+/OAjFdohjbHZ5jP2nSMBAdE=; b=lyWjSegMoUmLRyujQyePduZUhbNnQ7Np1BJogJuUDOmeswNRpzPNQ00ZhZ52AIlU9x U6Dzs3E+pzXQwevrwBwFPCLc9v4zNucU4zkpGIwsMonqKaJHWuEnpvqF5wHCeGMayMsQ gZC4fx6BsigbyGmtM33uwK2IqhT+MLWsa2bz/Sr2KejXnuR+9kN9DoIrvF7DbBIyHmju hFeYOafOHcGwVSkXZytog3zMBjPlPnVS7cAr0PsIPnjky3sSlM4upqzlRnS8p/Wp0GbG VxUYjh0bNVqhBl9bMQ+/A5q1GdwTf9qrsFlWvD1rc1wzeiO2jGlQmsQTYR69N1g/imuT 5DuA== X-Gm-Message-State: AOAM5314qc5yFXGwB+KuJbLPctoMRafuFhpBpXuKC91sJ6yifeUExr6b sevX9Cq0Re+BbtgOZzsszvs= X-Google-Smtp-Source: ABdhPJxoGHGCZF9G3ACrj3LltTdnSSdSH/QCFgzR8uInxqk8l6KD2rtHRrVhZjmx+/sbNCNFpn4bZA== X-Received: by 2002:a37:8743:: with SMTP id j64mr4210752qkd.299.1618505681316; Thu, 15 Apr 2021 09:54:41 -0700 (PDT) Received: from focaruja ([138.204.24.234]) by smtp.gmail.com with ESMTPSA id 8sm2358598qkb.32.2021.04.15.09.54.40 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 15 Apr 2021 09:54:41 -0700 (PDT) Date: Thu, 15 Apr 2021 13:54:38 -0300 From: Aline Santana Cordeiro To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH 4/4] staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_v4l2.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 6d853f4..948769c 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -1500,9 +1500,9 @@ static int init_atomisp_wdts(struct atomisp_device *isp) for (i = 0; i < isp->num_of_streams; i++) { struct atomisp_sub_device *asd = &isp->asd[i]; - if (!IS_ISP2401) + if (!IS_ISP2401) { timer_setup(&asd->wdt, atomisp_wdt, 0); - else { + } else { timer_setup(&asd->video_out_capture.wdt, atomisp_wdt, 0); timer_setup(&asd->video_out_preview.wdt,