From patchwork Mon Jun 18 07:19:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 138851 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3624564lji; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJJ7jGaT1N6shfrgE3XRKrls4xI0M87iZpYNiYP/7m1UaQ/Z/dcGpczG0ErtJobyDY+3fzd X-Received: by 2002:a63:2c94:: with SMTP id s142-v6mr9727860pgs.39.1529306376546; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529306376; cv=none; d=google.com; s=arc-20160816; b=BdjmJ6YKFE7N37q1IfAy7YuKpTjiWVEVkJXRFBWICzzd7yJuECh1AkdUmXhcvTNxBa S16yTxmu2MjV2+zXtre0dXllMAbjCrH9lqGhT6rt19fr87Ota3cwFWyUdgNesiX6UPpG cwDpQth6nrl1PpEfjtCYtXBL2mUSAqIsDeRuO3+0UkQPC4IOewoR+c3V36C1o/LZC+SD NS1vHH5y5x9ZPcsXeePTECG5OsP7UNCJeURGbw2Mmo482O+DcM6BYonZouvtyZaPbydr L9S1be2Xz/jpoy1VViYS22dG1PNcYZGdoIRhML+S8dkrq0jbH0AtmE+gjwr4022/4WgB mQtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=oofbcjZvbMtoaZYTBOXBtljj1IgsCsbT8QhhBi5fMWr4Hr4arZDIDwT+w26+HA9vNX 0Ne7YYR22Y0tn5hRcpVbeUgl38999SU2jnz8jWmHj8pi+c1BfxaFbgKrGQutwrkKijR7 D6Ma2vt1W+i2J1pJvKIPu5nocvBnh/lSbQJMBg5ZGijSk8i6/qtCetCptTi72qLiKHq6 dQOV2Xow//RirfCQ3E6LPyO5MLzqjCJKLr/n8Y5Hqe2HgMLvy1NMrbJh8JiD47J6GIoH juOkUlMBmwBBfNRvqOGJE9XPUw0U9A4jJASOuy+GUHO+UzfZ1IKPyw/p5J4bHe5LdItm bLPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m3YFM5Gz; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si14773122pli.431.2018.06.18.00.19.36; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m3YFM5Gz; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbeFRHTe (ORCPT + 9 others); Mon, 18 Jun 2018 03:19:34 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36354 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbeFRHTd (ORCPT ); Mon, 18 Jun 2018 03:19:33 -0400 Received: by mail-pf0-f194.google.com with SMTP id a12-v6so7711926pfi.3 for ; Mon, 18 Jun 2018 00:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=m3YFM5Gzx9fIK9uffup2z8NiK8g92/JZ/y84X5rAI4dt8YmITsdWbvUQVDyLV3lLeu EIEb7IEp0+n83HEmH/aDLs9OC+jn+HqTjZPz180W3/xn2BhY/ZSzyVM4BsHn9ovf21Kw DBUlzCXQ7VhPmaqymoXEjFgMWpL8URWQAQkawf02JvhuyqX02MUbwKu6PCeO+3rjH2rA lUXSqkWpcCEaTYVEZLyJVDuLteKP6fvKYjddbNsi7hSHH1blSP0gREz8q3xlOPbZ/vLJ L1VBp1Yd3fpm+OE/uzN/AH2RXZcpp4Tu0PNTeGMpk1nbR39YlAMkcZuXlqnNA8gCcA8R i7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=rxOhMTj81whHqOm7GbE4VE5RdpgTp5jfqGmw3zzM3qRTuAIHN4PVebJt07ss88Oxmu TyzRvBX4yN2sx0ci+ALwvkghvR/3mxnRvX/fgKRsLOaGbIer14L2PEAhC3mmH3n3NTso N41ydJgYg+8DcmmL8T8NM9XTqYmhx/in/htdF/nKckHjDK4HiHcFRBnM+GZ0R3S9NF/V L3H/CSPKjvoaMuVhYOc+x9eL+y27tDJZOTknrfEHcXUeqGlmsAPrVsiyzV0j/lI47/B1 OkzJsn5l6odkBi2TJnZxG3K3M7Wlqwk/uIqMkhsjDAbH8zihIs4hAVMj20SBjS0WG6+N CD2w== X-Gm-Message-State: APt69E31qr19WLXC5GJTUMZV4AE5vdYHBjV2BABZdg4QTUSasTlt5EiR 6B8PWlaftwcRMqFuothyAys= X-Received: by 2002:a62:7db:: with SMTP id 88-v6mr12229944pfh.178.1529306372352; Mon, 18 Jun 2018 00:19:32 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id g80-v6sm29095770pfd.21.2018.06.18.00.19.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 00:19:31 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 18 Jun 2018 16:49:27 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 1/4] net/ncsi: Silence debug messages Date: Mon, 18 Jun 2018 16:49:13 +0930 Message-Id: <20180618071916.6765-2-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618071916.6765-1-joel@jms.id.au> References: <20180618071916.6765-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up This makes all of these messages netdev_dbg. They are still useful to debug eg. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- net/ncsi/ncsi-aen.c | 4 ++-- net/ncsi/ncsi-manage.c | 14 +++++++------- 3 files changed, 10 insertions(+), 10 deletions(-) -- 2.17.1 diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 78db8e62a83f..a78413d5bfde 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1735,7 +1735,7 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd) if (unlikely(nd->state != ncsi_dev_state_functional)) return; - netdev_info(nd->dev, "NCSI interface %s\n", + netdev_dbg(nd->dev, "NCSI interface %s\n", nd->link_up ? "up" : "down"); } diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index e7b05de1e6d1..f899ed61bb57 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, ncm->data[2] = data; ncm->data[4] = ntohl(lsc->oem_status); - netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", - nc->id, data & 0x1 ? "up" : "down"); + netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", + nc->id, data & 0x1 ? "up" : "down"); chained = !list_empty(&nc->link); state = nc->state; diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 5561e221b71f..616441c2b54f 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) } else { hot_nc = NULL; nc->state = NCSI_CHANNEL_INACTIVE; - netdev_warn(ndp->ndev.dev, - "NCSI: channel %u link down after config\n", - nc->id); + netdev_dbg(ndp->ndev.dev, + "NCSI: channel %u link down after config\n", + nc->id); } spin_unlock_irqrestore(&nc->lock, flags); @@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) switch (old_state) { case NCSI_CHANNEL_INACTIVE: ndp->ndev.state = ncsi_dev_state_config; - netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n", + nc->id); ncsi_configure_channel(ndp); break; case NCSI_CHANNEL_ACTIVE: ndp->ndev.state = ncsi_dev_state_suspend; - netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n", + nc->id); ncsi_suspend_channel(ndp); break; default: From patchwork Mon Jun 18 07:19:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 138852 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3624633lji; Mon, 18 Jun 2018 00:19:41 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLxlQpxUMCgY+pojTcwNBvMKfnx7QhzqWZR8TUBVaEJbwRMz+jw9cVJUd8Ur9V5xBPeLKYM X-Received: by 2002:a17:902:b907:: with SMTP id bf7-v6mr12985606plb.331.1529306381286; Mon, 18 Jun 2018 00:19:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529306381; cv=none; d=google.com; s=arc-20160816; b=QrycDlUtz+msFvQQws9DNWhS81NRyfQl35Zn0cLvTSJER1o1C0EhViVa0fWWN81cJA tfnv3gjNyydtBHzd3tUtuzXiGRKA5q9plM0UNKjOwEDZUD2dqIGkroQZ8ZmszvXP/gz/ HWuQof6W+5B0XSUG4EG7pYJR6AQRr7TAMgUTFbKcOFpolOWLAwTrAlO+NtzjL4s0sKfS Necq/v8L17Fy27nQvfqHrqq5Tjn3wsIRDuvDQBtAuHKPvm2PwYWX2HAo7GjBzbLsWSJL LN5pe8QAJ5KUOUHANhsfs8IQaPHZqojeLiN54ikKpPBItvljO2+E0IvewaDI3c1PRf+s V60g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=DZ4o71FUYd/cMDAaDxVBdAwo+7ZWLU2QQf4D+GXQwfY=; b=WDzD7wXZqaV7WIqWY3yZKvn+6XhLCyXqFflomqA9mcaYXjpXoDhS5CANn5AtMuFpz9 V+4FOnlz7A0/QlMOWiGvJlLEiND6WtgazDJt8AJ6dpkn9wftmSyjL5NV1RaOHKcrxOz8 fJurPa6ygvtSL6cD7SdvRRVhsCZtwH3aTFSkMUqRZq0dM076F+tswxLcOebAMLnFMTkC c0c6f3JDPx1YAN6AiLY7q7PRCRmLed+2JOpDyw3ybguivvsuSYd1WpFvXfFHg3XB2kQN D3rEXPPl9c12/+HS6iaumawJ+R54N+fh/RcXZwE3dqPOcb29xV/Z3g008qq8Y8czmZMP yPrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rOYwE2Mb; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si14773122pli.431.2018.06.18.00.19.41; Mon, 18 Jun 2018 00:19:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rOYwE2Mb; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932723AbeFRHTi (ORCPT + 9 others); Mon, 18 Jun 2018 03:19:38 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:40899 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbeFRHTh (ORCPT ); Mon, 18 Jun 2018 03:19:37 -0400 Received: by mail-pg0-f66.google.com with SMTP id w8-v6so4072471pgp.7 for ; Mon, 18 Jun 2018 00:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=DZ4o71FUYd/cMDAaDxVBdAwo+7ZWLU2QQf4D+GXQwfY=; b=rOYwE2Mb/2T+zNTYdnO0xEc9dcG81cS0aw+TW9x7FMhSwSgOZGVbsdeCVwvSNe+1Xn oy7kvEXEo184scpCkAvn9zgDG776aeW219E+RJasEIzmu3lJyjjz4Y/8EuVZPKRM/V5j pTlT37wRwvuMcuwQYjIGyDCwdjIs234/4ao3Qc16ug7iV0hHxymOWzurHyKJuU4CXENS r/bKPE5cMndtu3yxd1WiZL9w1LtK8T5zv4lSREEKxuHGtU54WgTAJRi6c+v/XY5lxvV/ 0UeUUMYmvIszBDHRf8Cj2ijOxfwl4Lzz1dNNfiRqFFIizBxXRpBbc9vyQk5rhHYkVbkp 9UtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=DZ4o71FUYd/cMDAaDxVBdAwo+7ZWLU2QQf4D+GXQwfY=; b=mUnMfdoPShAk9S2S1ePlvdmSEeDVzBikQh9WYRJCaA6x0YG/Q8DRvV589Gpn71nHWP wi/70SxwfkmFjgpgilahsedaWsI0RAZzlwPq/iYZQ7iwG0SZNwc4y4U94tCbx072QjKO 4WXt6QtM0QHvBcHJVFTbVrG4KjLi5v96dPDfOhCa94EUv0Z5I30jsT8xou0D5/kRFzvF OF4THl3FtdC7uTrPVcG1Y5r+Yuimu26nqa7XdI09b8hjWEmHWdpMF4AcBzSyW14c9u7Y Rw4ANtAPU2DBfKShNrVrpqpCXKU/nysEJA52BiMw/XQQzihjeL2dzNL36fqbmEQrrF52 1ayA== X-Gm-Message-State: APt69E3/a94HUUIa/v3WHjmkqs0MqmLF60F2ej6rbIW1Zso7A1ywdV9E 38pvp6Fk35s/gAzkzdzxAfvYvIBN X-Received: by 2002:a63:89c2:: with SMTP id v185-v6mr9867776pgd.196.1529306377244; Mon, 18 Jun 2018 00:19:37 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id x3-v6sm20230806pfm.2.2018.06.18.00.19.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 00:19:36 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 18 Jun 2018 16:49:32 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 2/4] net/ncsi: Drop no more channels message Date: Mon, 18 Jun 2018 16:49:14 +0930 Message-Id: <20180618071916.6765-3-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618071916.6765-1-joel@jms.id.au> References: <20180618071916.6765-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This does not provide useful information. As the ncsi maintainer said: > either we get a channel or broadcom has gone out to lunch Signed-off-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) -- 2.17.1 diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 616441c2b54f..716493a61ba6 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -1226,8 +1226,6 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) return ncsi_choose_active_channel(ndp); } - netdev_printk(KERN_DEBUG, ndp->ndev.dev, - "NCSI: No more channels to process\n"); ncsi_report_link(ndp, false); return -ENODEV; } From patchwork Mon Jun 18 07:19:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 138853 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3624688lji; Mon, 18 Jun 2018 00:19:46 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLCbzgOMidQIPQJJt/fJ1ncmVPa4hdaAFYuwXpBXbhYugWOW83Gz5fxm38P6h124R9A4pUo X-Received: by 2002:a65:5ac9:: with SMTP id d9-v6mr9990132pgt.238.1529306386452; Mon, 18 Jun 2018 00:19:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529306386; cv=none; d=google.com; s=arc-20160816; b=PMhJP/G+/42yXr2I0PCpBBY4fs5tlbcBeh4nB33VsA8/M0NuOJ3H6ErxeXrnMkfcb/ whadkboFiFX9e2w/Kae0fs+RxtlnbeExVMZA8/4cNZGOY/5bmKNoCmWPYGrez5Q45d7t OqnGljXNqNvQ3cc/GNRPgD7xMv3UxvlP1elY4RvIiwcVpPIkvPkSXIGHf2XUicbJw65u U4hr+oE1qKnyS6V0k3rS0pw6R7yEVa8YdyeKoM9oK0VqpPD1oDW1ZJ5CO2ixPgzLCfuw QnfMCwEGc8uYVQI2OFaSJ2cB3JTyh64+Mtb/7AmFgFtUXmpUt//XDvv+wctym0U/HDN+ cctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=CDk5JiIfisTTBMT/Xb80X/B7O6fJ3gDwr/oUVABwraw=; b=bflzEpyGVLoHYXyomjMSO32/l49QfI7RF37DJQLdcqy3b3YaYYqUGHIUM40olSrIgD WnFRpFtGF3+WVA86aXzYQiLZ8UzMgiisiSzYkYnLReGQgJXlBbpC/NAmKViSTjDc7FPr pjLNQJXjJa4Ia/G7TCX4uJc/FlCTNXpzRKEWKJYLCUnNtUo+glF5z4aZ8bVQn3kafamW lAhbODyNi9/Vd8SyXEL/scwdko7LCWYn01i2te7s9PeKiY/SD4jC/kefB6N4TS4ieXfa NHdiMZ6iXTROKjd40baHHTeUbHQBDvdKAQg0kKkTsQog1LIGnoTWzT9+svPo/TBCJVwf rN4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=CvxI9N+I; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si14773122pli.431.2018.06.18.00.19.46; Mon, 18 Jun 2018 00:19:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=CvxI9N+I; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932792AbeFRHTo (ORCPT + 9 others); Mon, 18 Jun 2018 03:19:44 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43428 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbeFRHTn (ORCPT ); Mon, 18 Jun 2018 03:19:43 -0400 Received: by mail-pf0-f194.google.com with SMTP id y8-v6so7700573pfm.10 for ; Mon, 18 Jun 2018 00:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=CDk5JiIfisTTBMT/Xb80X/B7O6fJ3gDwr/oUVABwraw=; b=CvxI9N+IpENYvsS4pFGApPDFn4lxYCnsvjZCh9n3K6MprhvsLpM6w9ckNrJoq5W3kY IeNQT17IKqeSFvTHA+ARRY7xoy4xwWq7q5B+Vr7caCAV7xuW57HSBJmSfjAhcVWF5ccn 7c5Qy9QoXT0+3UdqDsh5fHz7NWzNkwNjdNMkmBU3VTmk7HrVicaQg3OiDESakSwVwYpi Bdq3/KPjeLCgRCvTb3gV+2KgQCHZLMCzRnIUo5B33p6QJqQ/ZOrBmXwr35o9DdGUDXWU 7wlCYjYAXxRz6DM2/ctrf17PY5zZFhwdiPpl1skQqv012KQ4x7RWgVn38it3WnqkXToY IG/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=CDk5JiIfisTTBMT/Xb80X/B7O6fJ3gDwr/oUVABwraw=; b=r/gMUc8eH1gqCsuIFZvWjtNwjc8+SwDF/+MUVWLA+Lfxdr+bfG9RDazkYXOZC0F9qe oK67nBQU1o8NVfD514lGuXXFQzR032OR04jzKO5+qG48LAtDUSborX5wYzGxtitRXCvR EYNXr/CE9LlJnZ+UBEVhAMjiQ57JEkB6ziLw9Tksv57uQbiOHnjXmshG6XCwHiNwWScW 0Hy+gBttWDv8dUN6TSMmfaNVuYVzIYw9Yxu/UL5tCaEkK19t68ngbZpGXo/QYO1Eg/BD d9HRQdhX2mbJJB1TFg9RUCj8+Zjq+YnHeKfY/875GGNwH3OCw6ItFwG05UMUH1c/t48r iiHg== X-Gm-Message-State: APt69E0ALfgv8dlSqIo1lLcRThsINpyuaPhar3qZq3Y5QHWqBIWZAwmO +6ChjMxM/4RS4eQ334Ykrqw= X-Received: by 2002:a63:7a03:: with SMTP id v3-v6mr9774280pgc.285.1529306382469; Mon, 18 Jun 2018 00:19:42 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id y15-v6sm20524896pfm.136.2018.06.18.00.19.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 00:19:41 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 18 Jun 2018 16:49:37 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages Date: Mon, 18 Jun 2018 16:49:15 +0930 Message-Id: <20180618071916.6765-4-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618071916.6765-1-joel@jms.id.au> References: <20180618071916.6765-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to netdev_dbg. There is no change in behaviour. Signed-off-by: Joel Stanley --- net/ncsi/ncsi-aen.c | 6 +++--- net/ncsi/ncsi-manage.c | 33 +++++++++++++++------------------ 2 files changed, 18 insertions(+), 21 deletions(-) -- 2.17.1 Acked-by: Samuel Mendoza-Jonas diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index f899ed61bb57..25e483e8278b 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -148,9 +148,9 @@ static int ncsi_aen_handler_hncdsc(struct ncsi_dev_priv *ndp, hncdsc = (struct ncsi_aen_hncdsc_pkt *)h; ncm->data[3] = ntohl(hncdsc->status); spin_unlock_irqrestore(&nc->lock, flags); - netdev_printk(KERN_DEBUG, ndp->ndev.dev, - "NCSI: host driver %srunning on channel %u\n", - ncm->data[3] & 0x1 ? "" : "not ", nc->id); + netdev_dbg(ndp->ndev.dev, + "NCSI: host driver %srunning on channel %u\n", + ncm->data[3] & 0x1 ? "" : "not ", nc->id); return 0; } diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 716493a61ba6..091284760d21 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -788,8 +788,8 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) } break; case ncsi_dev_state_config_done: - netdev_printk(KERN_DEBUG, ndp->ndev.dev, - "NCSI: channel %u config done\n", nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: channel %u config done\n", + nc->id); spin_lock_irqsave(&nc->lock, flags); if (nc->reconfigure_needed) { /* This channel's configuration has been updated @@ -804,8 +804,7 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) list_add_tail_rcu(&nc->link, &ndp->channel_queue); spin_unlock_irqrestore(&ndp->lock, flags); - netdev_printk(KERN_DEBUG, dev, - "Dirty NCSI channel state reset\n"); + netdev_dbg(dev, "Dirty NCSI channel state reset\n"); ncsi_process_next_channel(ndp); break; } @@ -908,9 +907,9 @@ static int ncsi_choose_active_channel(struct ncsi_dev_priv *ndp) } ncm = &found->modes[NCSI_MODE_LINK]; - netdev_printk(KERN_DEBUG, ndp->ndev.dev, - "NCSI: Channel %u added to queue (link %s)\n", - found->id, ncm->data[2] & 0x1 ? "up" : "down"); + netdev_dbg(ndp->ndev.dev, + "NCSI: Channel %u added to queue (link %s)\n", + found->id, ncm->data[2] & 0x1 ? "up" : "down"); out: spin_lock_irqsave(&ndp->lock, flags); @@ -1316,9 +1315,9 @@ static int ncsi_kick_channels(struct ncsi_dev_priv *ndp) if ((ndp->ndev.state & 0xff00) == ncsi_dev_state_config || !list_empty(&nc->link)) { - netdev_printk(KERN_DEBUG, nd->dev, - "NCSI: channel %p marked dirty\n", - nc); + netdev_dbg(nd->dev, + "NCSI: channel %p marked dirty\n", + nc); nc->reconfigure_needed = true; } spin_unlock_irqrestore(&nc->lock, flags); @@ -1336,8 +1335,7 @@ static int ncsi_kick_channels(struct ncsi_dev_priv *ndp) list_add_tail_rcu(&nc->link, &ndp->channel_queue); spin_unlock_irqrestore(&ndp->lock, flags); - netdev_printk(KERN_DEBUG, nd->dev, - "NCSI: kicked channel %p\n", nc); + netdev_dbg(nd->dev, "NCSI: kicked channel %p\n", nc); n++; } } @@ -1368,8 +1366,8 @@ int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid) list_for_each_entry_rcu(vlan, &ndp->vlan_vids, list) { n_vids++; if (vlan->vid == vid) { - netdev_printk(KERN_DEBUG, dev, - "NCSI: vid %u already registered\n", vid); + netdev_dbg(dev, "NCSI: vid %u already registered\n", + vid); return 0; } } @@ -1388,7 +1386,7 @@ int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid) vlan->vid = vid; list_add_rcu(&vlan->list, &ndp->vlan_vids); - netdev_printk(KERN_DEBUG, dev, "NCSI: Added new vid %u\n", vid); + netdev_dbg(dev, "NCSI: Added new vid %u\n", vid); found = ncsi_kick_channels(ndp) != 0; @@ -1417,8 +1415,7 @@ int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) /* Remove the VLAN id from our internal list */ list_for_each_entry_safe(vlan, tmp, &ndp->vlan_vids, list) if (vlan->vid == vid) { - netdev_printk(KERN_DEBUG, dev, - "NCSI: vid %u found, removing\n", vid); + netdev_dbg(dev, "NCSI: vid %u found, removing\n", vid); list_del_rcu(&vlan->list); found = true; kfree(vlan); @@ -1545,7 +1542,7 @@ void ncsi_stop_dev(struct ncsi_dev *nd) } } - netdev_printk(KERN_DEBUG, ndp->ndev.dev, "NCSI: Stopping device\n"); + netdev_dbg(ndp->ndev.dev, "NCSI: Stopping device\n"); ncsi_report_link(ndp, true); } EXPORT_SYMBOL_GPL(ncsi_stop_dev); From patchwork Mon Jun 18 07:19:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 138854 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3624761lji; Mon, 18 Jun 2018 00:19:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL1RQ7DW0cRPS9Q7VJoZz25ZtLW+xx2SztsviQuwY1U1VJZXERsKqXDDxJNng0Ng4Jg2+qr X-Received: by 2002:a17:902:343:: with SMTP id 61-v6mr12725966pld.344.1529306391433; Mon, 18 Jun 2018 00:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529306391; cv=none; d=google.com; s=arc-20160816; b=G17Ztx93Nffbr9QpBzvWyxyreRDR8x09Flh07e4TdNcW/E8r5838QAAeBr3tDkYarD A+CxWqYYeQqF+b6e9DVA8/sIe3LCo+fvDXIRLiRTwu6xqWzoeX0ZPPM0tHPjSlvDQ227 xehyRE4XFI+u3GCFw33PT+JQcCv6G3MA2a5oGn/m9bq422Af6hC9hIsgkrDrv5OrJh4f V3qpMG4krHLoLHYjwaucCB8J1ldpUmuE0tXwElnQg4Qc7Ubou1fL5iNR6A0v9RBvByJg /eN8qFiW5Mjw0XxQ6txEAUFwmNURYNawp2xoQxSP5pkLWgR6T3pj2KWkaobc/S8YgXqn wAAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=OKdJI6ZNRjZlgZDyf+b+YE1kuUC5t9snuHN5e7mzOaE=; b=iVilasRyfZXClUxMA5TJTkHuUN9Vv1eUIHJverWJDCqo5SDzQzCevoxNQRxQW9V0hv LF0Yxra+OXHRqWrsS1X3WQFOw5aQU9YpttV2gV3Ru4z4WUR2hae6GvalDP1VgqNcHeyH 94GJOF3/uHEWUJtDBz99+R1uqqOozMYqgrPNF7TXfziF3VPlKGNx+/hWqUSNj0yDi5Xc 8hqBPZ7bRI6wdd9YtDbGGHHnYBosBC5JW2u9CSN+MS63Fn/0MhWPWMSgAussWxHrQ7aN ceNKny5bWR/3h0ve+X9wtSYOlaMrxKodaXpETAgF/Bt7hEFOj7vPh8oMc9a3y36JhEWE NJFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WTt6UxiK; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si14773122pli.431.2018.06.18.00.19.51; Mon, 18 Jun 2018 00:19:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WTt6UxiK; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932844AbeFRHTt (ORCPT + 9 others); Mon, 18 Jun 2018 03:19:49 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35305 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbeFRHTr (ORCPT ); Mon, 18 Jun 2018 03:19:47 -0400 Received: by mail-pg0-f65.google.com with SMTP id 15-v6so7103472pge.2 for ; Mon, 18 Jun 2018 00:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=OKdJI6ZNRjZlgZDyf+b+YE1kuUC5t9snuHN5e7mzOaE=; b=WTt6UxiK+VzazuYYeR0TQ/aTgE3/QkT5aYHxMsIHAA4OnpjL61qvwTx8Ajw0sOEybp NyGEfSqBeHS/n+IDnAJOIUPZk8oxPdn13Pupngid3tOqIT8I8Wia0KQkigE8tUSn/Opj iiCpAiomOX7WSAIuXUAMSWUi5vLw1wRGW/kGEVN8TlAjPfiOKkr2mNSqiX8194ezc/uc xM7GWaQAm0hYunmYVLCpVR7YEldyOioUEeWKFiG0qSAAJFciZX8b6J1kF2mGtkYvT+Ic OUp8rXd0lzPzGjJBCscLzpcqKNzVQ0UrNRH4RgXXXDcOX+/CMY5/so5mC5FzKhIBfyUD KKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=OKdJI6ZNRjZlgZDyf+b+YE1kuUC5t9snuHN5e7mzOaE=; b=GAs18mVQsi+QaDLTr8lhrLjFkpdrwgXBMtQPKEkJ5tcXBtFd5VbSX4N2nyzKRInWki 4xN2M7o9Dn104Zai/3BsOtAP+DD3mAJOcsRKFfetGkoQtP6VwSy4iU12qsB3LA9aEqsf CXWzyGCNLAzubmcd71ihNvenP6UVeufiSuIvtUVlHYOHuxniBpwbf1MerfoDJ10OXYGL QAsSB0gcnBuUVcYMtqo78irrZp9tNj5C2Z97NbRdMD6ruV35pk0k2J2GAEIa6iXsjoJM ard4Wdxmc0wmx57mTVnM9nhtN+cby74/cCpjlDgY7VfR8J6+swpSr59L5vQdz+Hq4ylW Cg/g== X-Gm-Message-State: APt69E2a8GuRGmLUOrxcHeyGEFETIIRf8nyEXYJXSZhWrqLsmpttJKIf zf4A0FUSXIgSdSI5qJXVvnI= X-Received: by 2002:a65:590c:: with SMTP id f12-v6mr10219172pgu.128.1529306387370; Mon, 18 Jun 2018 00:19:47 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id p20-v6sm19080426pfn.181.2018.06.18.00.19.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 00:19:46 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 18 Jun 2018 16:49:42 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI Date: Mon, 18 Jun 2018 16:49:16 +0930 Message-Id: <20180618071916.6765-5-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618071916.6765-1-joel@jms.id.au> References: <20180618071916.6765-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sam has been handing the maintenance of NCSI for a number release cycles now. Signed-off-by: Joel Stanley --- MAINTAINERS | 5 +++++ 1 file changed, 5 insertions(+) -- 2.17.1 Acked-by: Samuel Mendoza-Jonas diff --git a/MAINTAINERS b/MAINTAINERS index 9d5eeff51b5f..44851f7c46fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9756,6 +9756,11 @@ L: linux-scsi@vger.kernel.org S: Maintained F: drivers/scsi/NCR_D700.* +NCSI LIBRARY: +M: Samuel Mendoza-Jonas +S: Maintained +F: net/ncsi/ + NCT6775 HARDWARE MONITOR DRIVER M: Guenter Roeck L: linux-hwmon@vger.kernel.org