From patchwork Mon Jun 18 11:59:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 138894 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3863667lji; Mon, 18 Jun 2018 04:59:59 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIEzoPZu4vhmrIfiWQ+UBY29q4ZEWP4Yr/1FqjPYWWdnC4asrpFwWaqAYrfeG/AksjUC14r X-Received: by 2002:a5d:42c8:: with SMTP id t8-v6mr10124504wrr.225.1529323199894; Mon, 18 Jun 2018 04:59:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529323199; cv=none; d=google.com; s=arc-20160816; b=riSHehGhf93ub+NNaAiLhpki21a0QH+u5yFlj3W5kR8UwUcsrxVun68deioWoRa3zZ kNDjizLAAkumiuGMChDsWMyr2t7hq54S8p+EDRbjRS5A6SGkmajkqU6NJA0tHxleXdZl dBKZLwq/EPzpJu0OjuBRfUIocWQQqUN6tQX2e76f4yClbdSSmsmDDhOzNG3ZkxXUnsSB 0uniHSTeWMdhxt4JOpVDbFKc+pAiTzUyDbKaZ7vmPPFwNyBDyvvUyB0lJoRBl3uy0QDc JEb2JUvLLxALkRHCkdJ0FpLuytYFHk2RJRH+BkJJ0UVuD6NUHwp+0Phy+a3O+RKj2kJU 8plg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=holXhg8S0uk2s1w2GO/ygV39lEFZzVKdldjtOd0dKtc=; b=FfCjWMPcDyOTVfcLpBlit2DCodcIs6sDo3Gc26eTq6GfEczDbFbTwrRcUIZ0CDEDEh UNdLqFKAeibPZOU7H9LVMwRiP1eO5Y1+nHGwJubhrTgDpVyiOaS+fQoFVe6gx/tRcUwg sm4JOGeAg93gcmpo9uBJpMjqHUlf8mpXrUpQ8areybO3D9IaNk6p5KqZZnazfFPVs1Ec +tBUSMl15Nc0xJ7hl198xupjSKGeFW97yMYDD81UYKXsO4yHqeCARS0TpyXyKHUwSgaB +ya08ZUfcZ+sJl949SCU7nMCqMUb/QGy7jjumD+A8dmOc+z8apBNSE/htR2AX8vzc4pF 0W1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ORu7gLbn; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id p1-v6si3565234wmd.66.2018.06.18.04.59.59; Mon, 18 Jun 2018 04:59:59 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ORu7gLbn; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 6D9912675E4; Mon, 18 Jun 2018 13:59:58 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2FB7E26760F; Mon, 18 Jun 2018 13:59:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 84E632675D5 for ; Mon, 18 Jun 2018 13:59:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=blTsMbSXb8QHJtXpxEo7TVTYN138dohaDH+uE/aO4PI=; b=ORu7gLbnoLh9 OU5tmnuN8Rd2pujRM8giYApnjFi2mclkHN/Cm7iEvlHQ8XT3pXFrdmV2KrlecKqEygJp6JMZwEB/D M++QStFBI3RuqQ9hjVojrFVducQHsInC610SsRUjIcMe5FfFOisPJ41a/mi2SfrmCv9rqrG8AZAax RdrDs=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fUsp0-0007wB-Qt; Mon, 18 Jun 2018 11:59:46 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fUsp0-0008P8-DO; Mon, 18 Jun 2018 12:59:46 +0100 From: Mark Brown To: Stefan Agner In-Reply-To: <20180617134532.1070-1-stefan@agner.ch> Message-Id: Date: Mon, 18 Jun 2018 12:59:46 +0100 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: codecs: PCM1789: unconditionally flush work" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: codecs: PCM1789: unconditionally flush work has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From a7dc662c6a7b9209df600c64b16d33d72dbf56b1 Mon Sep 17 00:00:00 2001 From: Stefan Agner Date: Sun, 17 Jun 2018 15:45:29 +0200 Subject: [PATCH] ASoC: codecs: PCM1789: unconditionally flush work Work is guaranteed to be initialized on exit. Drop the unnecessary if statement and always call flush_work. This fixes a warning seen with clang: sound/soc/codecs/pcm1789.c:265:13: warning: address of 'priv->work' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&priv->work) ~~ ~~~~~~^~~~ Signed-off-by: Stefan Agner Signed-off-by: Mark Brown --- sound/soc/codecs/pcm1789.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c index 21f15219b3ad..8df6447c76a6 100644 --- a/sound/soc/codecs/pcm1789.c +++ b/sound/soc/codecs/pcm1789.c @@ -262,8 +262,7 @@ int pcm1789_common_exit(struct device *dev) { struct pcm1789_private *priv = dev_get_drvdata(dev); - if (&priv->work) - flush_work(&priv->work); + flush_work(&priv->work); return 0; }