From patchwork Sat May 8 01:53:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 432522 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp842586jao; Fri, 7 May 2021 18:53:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbsKQu6OxSmPGtLAsrOV+n0RALTBKQcz62abEX6DZplIu4a0fIz7Ha7Z3wSB432VTT3Tmv X-Received: by 2002:a17:906:fb04:: with SMTP id lz4mr13645760ejb.66.1620438809034; Fri, 07 May 2021 18:53:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620438809; cv=none; d=google.com; s=arc-20160816; b=zjBvizFM3e5CC3tL50yNrvcbPIbuvMdfmoqEUAwGbZrBVDKoGUS9Gw3lahlYKvPbqJ Hco8U8zdLTteL3Ksb4koQxI2dpJXqS2DzpDZTduSR61MV4ap0sUpTqb22Vde0mXu4TXg OrflOgFriHCMhXihlF+OOOBuyHb3KcUiTc/j9kKrqjK97pYtvsx8TFXD9E/4yXVHCQUa RRLGvhzZhQqJZ9uumVNhrgmvd5MSGxGUerIY6fX0xvol/pljtV782GfutpxJmpeiOGu3 8x/vZ6jbgs0FLbntdiOKb8AAnOGpG5qbfvZ1fT8Bym6eByRpVbGY+xmdTci1N0dvO1Ic TQ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xrg6AqEsEMDoKaaZXubphn/lewqq+9VFL2GGC1xfOOM=; b=KyuarcDRwNcB7L6GT4fVwylYkhl2Ib+CG8Hc1dnmfp0T25c8pzUUoCuaE56WfnfBhs DEG21AhHYjZiZrwl5O/lSgZ6BEuz+drJ6QokIv6DoZur2PfoFX3LJe62kTpvOFbxB4vr 5QhWaYPwxpfc4NpKtHUWFRL9mgGiJJrgyRfRcb5xc0lct8l1OapqkJ6ri3iu2B/28jWt bEni9UXiPACLR0OzUN/B4Wc/mZ2w4KzVmBj7BbddagsT2QgGs7HgMPuzDGyPndXVpoY7 kPoV3m8uHqdD9+6+koNgtH/wzqSDFXRjtl/7pn67hgWx9Foh8ylfTx+HpOEe2V6guoH5 l8Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si7021066ejr.690.2021.05.07.18.53.28; Fri, 07 May 2021 18:53:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbhEHBy2 (ORCPT + 4 others); Fri, 7 May 2021 21:54:28 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:18370 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbhEHBy1 (ORCPT ); Fri, 7 May 2021 21:54:27 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FcVfD5njdzlbxN; Sat, 8 May 2021 09:51:16 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sat, 8 May 2021 09:53:19 +0800 From: Zhen Lei To: Felipe Balbi , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "Li Jun" , linux-usb , linux-arm-kernel , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe() Date: Sat, 8 May 2021 09:53:10 +0800 Message-ID: <20210508015310.1627-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/usb/dwc3/dwc3-imx8mp.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 Acked-by: Felipe Balbi diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c index b13cfab89d53..97810ca17a2c 100644 --- a/drivers/usb/dwc3/dwc3-imx8mp.c +++ b/drivers/usb/dwc3/dwc3-imx8mp.c @@ -167,6 +167,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev) dwc3_np = of_get_child_by_name(node, "dwc3"); if (!dwc3_np) { + err = -ENODEV; dev_err(dev, "failed to find dwc3 core child\n"); goto disable_rpm; }