From patchwork Tue Jun 26 09:20:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139920 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5006118lji; Tue, 26 Jun 2018 02:22:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKuxqZ5ZKJdnFvEP5cTJ40dC8HjpsmW+NGOGgLyLP2NPBi3msrShgTV2dQwC0oBGz/1Gf2c X-Received: by 2002:a63:980a:: with SMTP id q10-v6mr672854pgd.50.1530004963549; Tue, 26 Jun 2018 02:22:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530004963; cv=none; d=google.com; s=arc-20160816; b=yzGiXBSSsDhjdfoeWD/phJhMYGwf7CjRL5Jl7BaM0vpYjOfXWtWf72rtd9hqtK6JKw X17bFF0pay80Q10IglJwIpwO9tRts9nmsukPNAi3Sv/IGh3GxPJvzsPlDng1ZtO7J7cq RQCI+tPBqluk9DKTssGYf6M4YA1GJcJluxilP4uPH5Zt/IfUcP9qpbNQJG5haJPUDzA+ 2yRyXKbSzLrOvPz9UPPvIzKjGN6FY3Edg+g95CrJ5FtqeACZGd/0TRh4KfwsR9hjePXd tzL2aUNue89lE0zAd2v5/pfT3mlclaGyNfIMUmM2dsh0ReWvnfaqc1djucM45nEtB2e1 80uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=zli9OPXToTCwTxHVHeLl0HZXVWIpoxlzZHDFGirmZxw=; b=BkZ3wo3dVKdsJ+qQj7CEI+zwG2P5RwoK6LyL1Q0Y8XxjJlsjnkjKt+Tag9yQoTCSAy 4duSkngRfdbkOTmrmmeA6CqXbyRe+vMQLagqMCM2pBykwfUffiHi8hzp+HvtTMwvHkyJ 22nFPeDwKNj9kK9AQ/HYBR0jsRlRYNRA3B4Nfiu8MY8z154c21cH0sjtkZmMNCRthGr4 zpmIk3jLKj5EO7XTtBMEOEbMaqhYmBshGWQPDl/nQ93J61jFeneNQtg4ll/GUEbibJS8 do8jFTFHlEYiN0Y277ylX2+ZtUK5EHOmXKNeGOwEsYDEH2V71uPXI4InrncHu4UWn30/ UqWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ca/XOO6G"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si1199851plk.397.2018.06.26.02.22.43; Tue, 26 Jun 2018 02:22:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ca/XOO6G"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934010AbeFZJWl (ORCPT + 31 others); Tue, 26 Jun 2018 05:22:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:38365 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933780AbeFZJWa (ORCPT ); Tue, 26 Jun 2018 05:22:30 -0400 Received: by mail-wm0-f65.google.com with SMTP id 69-v6so993975wmf.3 for ; Tue, 26 Jun 2018 02:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zli9OPXToTCwTxHVHeLl0HZXVWIpoxlzZHDFGirmZxw=; b=ca/XOO6G31Et+xOwCvbmdclHba/ISE/w+hGyUIzppQVZBNoVWlm5OtGBuXjR949Hsh S0ye8ty+SqRo35BEE+HSasdBO4gM2+kYERF/qh4/UjxgrFCIp/WLtmD5HRjFkC/DBzJ9 8m6FNGSPgxsVR3upCmq/9kly72y+tj0fw0Fjg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zli9OPXToTCwTxHVHeLl0HZXVWIpoxlzZHDFGirmZxw=; b=klTn8JrpohEOc2ZIWq8M5Kacx3FGHNyUCh5xCYqP23NYBnTqCepBM/XTT4rPr5mB8K QmPCA8Em7n6hruOTmjGLTs86svfO0hVXegfhLDAIdn8NM+Vxt6UauIsSecOswORPkhtO Ld6BNVXzUvtP+bwcS4ls+2DwMZ8Wsol1fFXSB+cXmWOYASCEjwvx/mSNXMDUzO7aSeG7 E+EMo/LwQGt1u6NffIabVmadMN4cqBz+nSO+64OZ0ayj4WlGMLW2n2/2EG4mDnV0HJEy 1bA+2ByUxftW8QSa0hF0Qd+XkoHHiUKhmwpBwXt1+1CCp/XSYhlGjy+bmWDzFid51rbn EUTg== X-Gm-Message-State: APt69E1yJe0d07zh0kzFSCXFIqhKm+m451M8I1+ikDO5kuukKqlgLKak rRLJZ9bifJDPb8fnsMtjKPDtfg== X-Received: by 2002:a1c:6b56:: with SMTP id g83-v6mr936231wmc.143.1530004948848; Tue, 26 Jun 2018 02:22:28 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:28 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 05/12] ASoC: qdsp6: q6asm: use of_platform_populate/depopulate() Date: Tue, 26 Jun 2018 10:20:09 +0100 Message-Id: <20180626092016.9296-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) -- 2.16.2 diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index 530852385cad..c4fd28f168d5 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -177,7 +177,6 @@ struct q6asm { struct platform_device *pcmdev; spinlock_t slock; struct audio_client *session[MAX_SESSIONS + 1]; - struct platform_device *pdev_dais; }; struct audio_client { @@ -1344,7 +1343,6 @@ EXPORT_SYMBOL_GPL(q6asm_cmd_nowait); static int q6asm_probe(struct apr_device *adev) { struct device *dev = &adev->dev; - struct device_node *dais_np; struct q6asm *q6asm; q6asm = devm_kzalloc(dev, sizeof(*q6asm), GFP_KERNEL); @@ -1359,22 +1357,12 @@ static int q6asm_probe(struct apr_device *adev) spin_lock_init(&q6asm->slock); dev_set_drvdata(dev, q6asm); - dais_np = of_get_child_by_name(dev->of_node, "dais"); - if (dais_np) { - q6asm->pdev_dais = of_platform_device_create(dais_np, - "q6asm-dai", dev); - of_node_put(dais_np); - } - - return 0; + return of_platform_populate(dev->of_node, NULL, NULL, dev); } static int q6asm_remove(struct apr_device *adev) { - struct q6asm *q6asm = dev_get_drvdata(&adev->dev); - - if (q6asm->pdev_dais) - of_platform_device_destroy(&q6asm->pdev_dais->dev, NULL); + of_platform_depopulate(&adev->dev); return 0; } From patchwork Tue Jun 26 09:20:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139917 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5006075lji; Tue, 26 Jun 2018 02:22:40 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJASDu7BjUZf7NN/iK/nHTa76vKeoq630eAcjAGledaAn5gIg9rB/OGYPn3bX36e6EUqawj X-Received: by 2002:a63:8a41:: with SMTP id y62-v6mr623842pgd.291.1530004960177; Tue, 26 Jun 2018 02:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530004960; cv=none; d=google.com; s=arc-20160816; b=HMvNv8dw3EPb3AdepgpBBrtysvlN9yteYGFe9jPpw2CZKLVXs6lHgV9QiyWcbOwFv4 ZJsK0UlbM/hMwc6MWZrEMO2v+b82TGc2abC6mOdm5Shezt0exzTdpJ7WGBVbWmmWq35x 2/xzQoDLSmyX9bZR6fduaWo3xl2HRHlBqLc4KbnwV2M+kE7U+rE4Vf0wHUtSjh+M0nJr CTm0R8gpDHUHnRK4Fa29NeJLWe+Ow8LpWxldraRXGARz2tyOV+XnAH4r4FkgwiA/mlJ2 4ppvqT9JFfrw6IJT2o6TFGKxpCuTnQBvwAKkoCIr4RHUdlQX9nilnpfu77u4E1Rs026l F38w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=9ntn7tvil3gnvbRPyAg0hZqRPLNr9XRiNe9LjAxmLwo=; b=LzXt4qnqLS03TDGiwmoBVyvCWaFU09F/HU/WTjemFhBSyPAxQDrpsiQaX6fQaUU3tG XF5dKexMXKLF4fAyrq15+fC9Bx5t7LAdai05AwGmdMTrVb8xBi4SViCmZAEBhMFvSwcT Ca9lnA12GId3WccJYfI4WmuiXAAYozeqJ4uPf8SBAMZXpvbO3KQiANJAFmKOoG2/BLRJ jUUJi9jCgVM8ujGLei9K9bWz82qEIx4d3m7GCKCO4VYJBm4qxdPN3Nm9aAAc5hlqE4qW Xh1cZr3llZ8AuCWPFkj5SrXxHdiuwmZDAj+u2VQss3s94742/XsomzYtlJRol5vd1VTe YyJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OrQYumjQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si1199851plk.397.2018.06.26.02.22.39; Tue, 26 Jun 2018 02:22:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OrQYumjQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933899AbeFZJWh (ORCPT + 31 others); Tue, 26 Jun 2018 05:22:37 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:53189 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933784AbeFZJWb (ORCPT ); Tue, 26 Jun 2018 05:22:31 -0400 Received: by mail-wm0-f67.google.com with SMTP id p126-v6so1040242wmb.2 for ; Tue, 26 Jun 2018 02:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9ntn7tvil3gnvbRPyAg0hZqRPLNr9XRiNe9LjAxmLwo=; b=OrQYumjQI+tnScHt4ElZzhag3QVDdpjFroKkraRlfebj8KKGyZXtzb7vL9MuyhXwaC m5bsQRZXcUMPBZqzSnch419tdNcJoqf3DmJDt0vsZh4lRDUT4Cv7y6Dxi+4pthPWto68 EYLyfGbl83PioMQ6V/nOSPuirpGbv6b16EHf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9ntn7tvil3gnvbRPyAg0hZqRPLNr9XRiNe9LjAxmLwo=; b=BT+A8W4d/ksGD4KoT3fde0ZoHJsSxJva2qnlVlCe631hVhjr57jjEF+lpv1njvpq7Z AvnedXmIQmT2qTTwK2s4kzIj3aUPM5dDEQ1GUt4udUlQsmrGzBqHk3xTxalzUR+pxGlC FUhNiV+MkWG2+t9KLA6+Xr/JdpcB8XHy+aJWxFkQSxFJZKK60biPBeDBCWdgwQ1Qo/D+ pEkzo/TI+REy36jI5WhAtTN63jPqGBclb9qxT/rkDFw7fCLFUazElFKoJ3uDdGzbnLhp wKkriTLWAIuOZyeruIrUZDcrd3GKicq3E1of41VMgALazQ1rArouHpjKzyQWGA6BRI0R G1Dg== X-Gm-Message-State: APt69E3yNxP8CAxuHWYS2vGcrB3/N8BjFS9mwUUC25jxsiF4MiUL5xWC U3khpsDjo5LXlqOaehhCccIn6Q== X-Received: by 2002:a1c:8893:: with SMTP id k141-v6mr931940wmd.133.1530004950022; Tue, 26 Jun 2018 02:22:30 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:29 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 06/12] ASoC: qdsp6: q6afe: use of_platform_populate/depopulate() Date: Tue, 26 Jun 2018 10:20:10 +0100 Message-Id: <20180626092016.9296-7-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- sound/soc/qcom/qdsp6/q6afe.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) -- 2.16.2 diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 01f43218984b..621b67b34db9 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -316,7 +316,6 @@ struct q6afe { struct mutex lock; struct list_head port_list; spinlock_t port_list_lock; - struct platform_device *pdev_dais; }; struct afe_port_cmd_device_start { @@ -1438,7 +1437,6 @@ static int q6afe_probe(struct apr_device *adev) { struct q6afe *afe; struct device *dev = &adev->dev; - struct device_node *dais_np; afe = devm_kzalloc(dev, sizeof(*afe), GFP_KERNEL); if (!afe) @@ -1453,22 +1451,12 @@ static int q6afe_probe(struct apr_device *adev) dev_set_drvdata(dev, afe); - dais_np = of_get_child_by_name(dev->of_node, "dais"); - if (dais_np) { - afe->pdev_dais = of_platform_device_create(dais_np, - "q6afe-dai", dev); - of_node_put(dais_np); - } - - return 0; + return of_platform_populate(dev->of_node, NULL, NULL, dev); } static int q6afe_remove(struct apr_device *adev) { - struct q6afe *afe = dev_get_drvdata(&adev->dev); - - if (afe->pdev_dais) - of_platform_device_destroy(&afe->pdev_dais->dev, NULL); + of_platform_depopulate(&adev->dev); return 0; } From patchwork Tue Jun 26 09:20:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139918 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5006084lji; Tue, 26 Jun 2018 02:22:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdxGoLm6nK6HxnGoUPHT8XB2pf5ATUSp6HosSdTzOxAWF3+KT9Ao0+ymo70O0j3dZHoHeME X-Received: by 2002:a62:170c:: with SMTP id 12-v6mr725520pfx.139.1530004961047; Tue, 26 Jun 2018 02:22:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530004961; cv=none; d=google.com; s=arc-20160816; b=XlAesF+KScKLFGB0t9ZAKkxTB1ZVknHH2uxjIlYkaJG/Hkb0nozZB4ukN+z/dDcd1l iqscAMgLj3lekWbgfHdhASyA5J1C/T6ysAOGOBz9AyxhBSgWH77Esq/u+PsYOMw+lTUl vdktTTbUqCMTZYgMh6rYdWLuxkDCYxuyYjx+nAPPco0Kh21LCl2F+/H2eTKV5zZFgizF zKD/vCRO0EMzxP3RiBHPNxasNVBXGthRIxeh1AASKaFWJLai1WT1xY67lFRtJ8vPiAes 5/q0osyHHXunqDtUQd/sirZyH+QVO661R9ihBh6ZvfflR/Klpt75vBPydhamLVvos0Yo BSLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Pyv1sGt65yF554e8vZ0B1y+2vFmmAQCdYZPZIKxIZYM=; b=bmhP5PcaCeZYQIT64Dm+oiMC7un6P1sfbjHzbZnWx/smNBk8IAA/GAF7QtyBic5rWc vFLyoQstYwxRU8JmTJPsKUVbD/Y9jPhjr4S4DZSQh/twBe2V4PohiCjohr1EVlhBaTKU N26IEazJ1LP2k9i3DSiBnx5KdwQ6nq17MrcAz5DDnfD2NBb2QrRmX26gCLzmBjhY61BF MItc5YTvQEVgKhNBROj/9hrMb2M2wAiNrI2W25pEVHIXNj3+65WW/3M+d4aPOsr7sXwH Pxp2gGbFxlRRHnqo97Sly9GMRj8nHiZUug6CmDWNmv5JcQGWqkaSupdEPWTPhJqt33tE wf+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FZNQGjeK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si1199851plk.397.2018.06.26.02.22.40; Tue, 26 Jun 2018 02:22:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FZNQGjeK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933982AbeFZJWj (ORCPT + 31 others); Tue, 26 Jun 2018 05:22:39 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44534 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933794AbeFZJWc (ORCPT ); Tue, 26 Jun 2018 05:22:32 -0400 Received: by mail-wr0-f193.google.com with SMTP id p12-v6so14823106wrn.11 for ; Tue, 26 Jun 2018 02:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Pyv1sGt65yF554e8vZ0B1y+2vFmmAQCdYZPZIKxIZYM=; b=FZNQGjeKjhaMGmMQFLsKYA0/FjQDWD06mn2tZ67deyQBKg/HntOIvXMZ22FEzv72p1 SdF/ZuQ3EQZbmbv8jLd8QsICeJyYgtWaRCOvB1AalvoYZeAdUGMMnTbx5mPr+FUiMJQS OUPf/3EdgECvrbai4HCqXD1sCp0ZHwoN7hoKI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Pyv1sGt65yF554e8vZ0B1y+2vFmmAQCdYZPZIKxIZYM=; b=UgQWYTOYW8hiZr/8amxZ/a9tykJlldoCmjAFrRSOLhOSM4KmH4JDEqGO19h4yZVYCV ejcJmri7SjUPa0Lrezb6Q2oANqSTUZU3jH7PnPkS2yiuM3DgOiq1cAPVqZa+X8Rfr6Ge rNzEIFeqC2dEl2iTveG0MRwZ+Y8ZZAywtcIyMPdjCYAtEFt1ii9b7LbB2IGFLvkZKfA+ EB0lFbJNMdDhwm5uYLr6rWhAAQs8oTZoXPqkF1SzlAUAfbo6ejb9iqcTKssCrlr7BZ9O RUB+5k2F8DshGAXkdxtOlfkazEQnOG3DvNThZXgsq9Ub0cvQDOez0NE+Wj41ynoyH/vO WT+A== X-Gm-Message-State: APt69E3DJjWIiWlETNM4r1gHoXgmgby9zZOSbsidGoaqPdJhy+cOGp6a POVJzvymH7wefTLtZgSjm+FjPA== X-Received: by 2002:adf:b710:: with SMTP id l16-v6mr741965wre.115.1530004951104; Tue, 26 Jun 2018 02:22:31 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:30 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 07/12] ASoC: qdsp6: q6afe-dai: support dt based module loading Date: Tue, 26 Jun 2018 10:20:11 +0100 Message-Id: <20180626092016.9296-8-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch uses new compatible string to make DT based module loading work. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.16.2 diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index 5002dd05bf27..1d2e5013c121 100644 --- a/sound/soc/qcom/qdsp6/q6afe-dai.c +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c @@ -1290,9 +1290,16 @@ static int q6afe_dai_dev_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id q6afe_dai_device_id[] = { + { .compatible = "qcom,q6afe-dais" }, + {}, +}; +MODULE_DEVICE_TABLE(of, q6afe_dai_device_id); + static struct platform_driver q6afe_dai_platform_driver = { .driver = { .name = "q6afe-dai", + .of_match_table = of_match_ptr(q6afe_dai_device_id), }, .probe = q6afe_dai_dev_probe, .remove = q6afe_dai_dev_remove, From patchwork Tue Jun 26 09:20:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139923 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5006498lji; Tue, 26 Jun 2018 02:23:11 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIUQsrKfT4uSAEZjWV8i21nTcdsZlpqGIQzVnYljCQOziA8gaAAymPrLHP81zj7Jkw+eDKq X-Received: by 2002:a63:24c4:: with SMTP id k187-v6mr655688pgk.434.1530004990988; Tue, 26 Jun 2018 02:23:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530004990; cv=none; d=google.com; s=arc-20160816; b=U/Q3JAf6VKu+UJ+mfknb4/4Za5e0lb8X0ClaxZ3DZFvCMgoGirzA5wHLYxuAyc0nIG AHXJ5sNGOAypKkDDpNK+luYFwURCz7/RTLi9u1PL8JpQBzmLFP8P6KZUJuwD/lAPdurI cyY4wi1WmIvVjpZyjYsKGR5g3kNzspwHMeKioCyrGjmWTlH7Ce0pTke9+0BIHg0PEq2K oSIysHxv8nzfYRmBjP5WI0rpe+XCmYFz1Jaomh6MaFQQRpBTXAECQPkvSOcgeXOecsEP EyIdf9/HuVfP48CydAlXSTEW8dzV1ETfKxBBOP3h2L/gwLRu8ROBYnZ14aVc9qITuKXu aHoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=E2b1SF4lGljXSzLfPBJn6UYbkgznGupv6vAh0HdCRDw=; b=koworN745jDsZGDFOHE9XzVza1kq0O9aqml4tH17cAxcWvYzXUX28j4VQMHP2iVL1S JJPYX5oYRSnDFz78SfzA4rYgzl3AnJn9TCDWutmhH0/a1eJRtffKbIS6W5muxnrUASCO MfP9SGaMPaqjsZbzdn1qRbyfBLsWoApwHdMi+mhETvTbd6dqxTXo6/oYHwXfmc2vijev kzL2ftL8M7QNefHMislLBoGQN0eiEUD5+d9qB54XbWgYgtlj5/xyUCcheDBhsta7FGuQ U+hrenKWOm6RqLZgh5Bv8rFG2lVsmHTc5beqUXk4pGDQudIUXUmJf6C3IMvJ8Z/Nsj8l 8d0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WiSBo2VI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a100-v6si613071pli.122.2018.06.26.02.23.10; Tue, 26 Jun 2018 02:23:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WiSBo2VI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934060AbeFZJXJ (ORCPT + 31 others); Tue, 26 Jun 2018 05:23:09 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34248 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933876AbeFZJWg (ORCPT ); Tue, 26 Jun 2018 05:22:36 -0400 Received: by mail-wm0-f48.google.com with SMTP id l15-v6so14706563wmc.1 for ; Tue, 26 Jun 2018 02:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E2b1SF4lGljXSzLfPBJn6UYbkgznGupv6vAh0HdCRDw=; b=WiSBo2VIvv0zIiPAaiAstN0mLB+Ie6xfF4IWD1J9gArWonO8jGdVczMzamSNW52mAt valQvT10y+MlBNSzOZkn4OHO7mHzkmlsewH6gcIkXbO/1mxSfRnSr0yzlcTN7tT/bTAX ES2G8QELF74VCqJlGy/gBbkNxz95kpLW2Qs44= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E2b1SF4lGljXSzLfPBJn6UYbkgznGupv6vAh0HdCRDw=; b=sgtvluz17y9GtiegRlaPULRqbQyaQcdJBOLNUx/2iy5TFfcaJSt8oYyIV0ktETsgYw guzObXJpdj6K9VHhQKrM6bn2a/AwVrjBYLAAm1nSylv7a2JLD1czjJTRWgbiMvcRrpRQ H48CiUZ2P3jQUoa5M761nY58LYL3rlTZj2Fw0nH/yx75bAiPBX3L/8hlJpbsGeyP1Ntq DTCG3BUpo80CrioD6m8Gn1iG/+vTLuxxlDkLYkmLuf2JxDFNjpt4cCFTp9wAG294hEuY JMxlcWO0lME4zj/b3SeEufj24AKLClQ1cjdLWKTSDJFHkVXyTACs3S5+hRH4I34JAelz Vnzg== X-Gm-Message-State: APt69E3SxhkMbp9SZk2k3mqK6dDQDv2rZAcIudSTt811cd0u30CE8Z6Z KkZfyVrDEwnkssnsViD1LeCi8Q== X-Received: by 2002:a1c:b3c3:: with SMTP id c186-v6mr984726wmf.41.1530004955576; Tue, 26 Jun 2018 02:22:35 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:35 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 11/12] ASoC: qdsp6: q6routing: add proper error check Date: Tue, 26 Jun 2018 10:20:15 +0100 Message-Id: <20180626092016.9296-12-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org q6adm_open can return error pointer or a null in error cases. Fix the return handling. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.2 diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index ab696bf8d1d3..c80fdbc2442e 100644 --- a/sound/soc/qcom/qdsp6/q6routing.c +++ b/sound/soc/qcom/qdsp6/q6routing.c @@ -310,7 +310,7 @@ int q6routing_stream_open(int fedai_id, int perf_mode, session->channels, topology, perf_mode, session->bits_per_sample, 0, 0); - if (!copp) { + if (IS_ERR_OR_NULL(copp)) { mutex_unlock(&routing_data->lock); return -EINVAL; } From patchwork Tue Jun 26 09:20:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139924 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5006669lji; Tue, 26 Jun 2018 02:23:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJD4WSzn/uvthl6pJrIxg/pxU1iLiZDpiGAM2wluhGY1HPqqSBhH8Bnmm5vlA7y9zJRdVjA X-Received: by 2002:a63:b34e:: with SMTP id x14-v6mr642629pgt.243.1530005001719; Tue, 26 Jun 2018 02:23:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530005001; cv=none; d=google.com; s=arc-20160816; b=XlnYX64ycbjz09odrr1tG+DMtX9dkh302GU8F2zJ9hJVoj1jySAjH5N0YzZtw8+Rhl Ic1LipWCUmIY6SPGsqEQ/88Jq7d3XO2Mxh3pD4wf2KB8hTn+a/xCKF2UWyx/UMd1WPKk dvq1gm+sI5/3K4X1WjkdG4VEsoacEehIvinPJ8zFs3Eh1BrawjAG5K/7UQJWa1T3FAdd vCIbqvTnKkeiFgySlisUj7z4aozC3IORmD5Z/lryjcxRzxKyE832Pl80SLN4aufp7OO8 hcK1Q1katc2f61m2y59ctROCnVfepJgu7+sUuYnh6Wgfxw8ZFKYW/CmTDoQhL5ejyACD xUVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Z8cQifS22+BwNW4/GYrMuZjPH47YuUxuB9EcEpOh/0A=; b=PPUtVqKmwm6dPXUM1oBsZfv6GkOVeXdRG17Zea65AuNaKlN4zLhb2MMT2Iy/P2tiLp yxTNESFmPmoFGgD8ErXLs/xG1YgyLzT224x8YllrE56652F9CWUYWUTxS+3HcgEYZEij bSsJmJX9IFrJcB8AXXATQsUTsa/T7EcOa55vXDM6kvrXJFH2bJR0PsMrjtc4xurvdwmn tgwZ5qCAU6UkLEXbqGEyZUYIWN/eMtx/DjLbk6gLj+vQht8vGfvI0ibYt7J5t9nFnynE jiLSXnY6/4HTpEmVRrlzSNS86Zn7LFnRVpbDpVDIyBZTSFlmGPIsbXrMPMQrjyRMrZvg iaIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Je1E1usH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7-v6si988146pgd.685.2018.06.26.02.23.21; Tue, 26 Jun 2018 02:23:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Je1E1usH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934031AbeFZJXH (ORCPT + 31 others); Tue, 26 Jun 2018 05:23:07 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53487 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933915AbeFZJWh (ORCPT ); Tue, 26 Jun 2018 05:22:37 -0400 Received: by mail-wm0-f66.google.com with SMTP id x6-v6so1024764wmc.3 for ; Tue, 26 Jun 2018 02:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z8cQifS22+BwNW4/GYrMuZjPH47YuUxuB9EcEpOh/0A=; b=Je1E1usH57yMpPxpQmwa4/nzwX3G12VvqkZBzCRPZWgtoqIUOXH3SKaHzBbkrjVTPc fqCzPmtKky6s1rtsUs87xepcisP5zQe0GT55HlQ3qc08brvMfEgaIbzT2QvdePgJdVVX FTflDaXwtUahDnvhUSXwtsJ1NzdZnV0zOszpU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z8cQifS22+BwNW4/GYrMuZjPH47YuUxuB9EcEpOh/0A=; b=KfASrDUBDMLsRfYpXlzxWeRxD0nEO0A+pYfmx5dooUYaDmPHPLUDFdLMu83dH/g2MG ZXzfCmpSvjz3Fg7BYo4xeBeo0dsq/WT912er3AtXZAZvBDJ7RiHb3mnJiwPOaYY9j9wU LUswQ5Duh4MNSJ3pMqF+3ldbdKZu7ymS6DX5Tyx3KrizA9VslXgTBIu5MvQOdDdQtejL DjLViAh0n6ooA0+KFoiviIraNfm1BNi1HnH6MWthWCqquu5FJsVcRP0FPJZXlys3FDpU A3JvLaf5dcsoJl3mZKy6VWI5WMpnXANuCyuZ7rdwhXLu1s1wdeT8IhrPedZ7Btrjjdev wEdg== X-Gm-Message-State: APt69E0ZpVFdUFc5CED+HY4VbEKjOlAMVJZm+hhzX86RsBrM1/BFvrgr ZFn3IQ9ta5B3NlUHtt0bJhRI7w== X-Received: by 2002:a1c:ab02:: with SMTP id u2-v6mr580875wme.10.1530004956627; Tue, 26 Jun 2018 02:22:36 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:36 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 12/12] ASoC: qdsp6: q6asm: remove unused struct q6asm member Date: Tue, 26 Jun 2018 10:20:16 +0100 Message-Id: <20180626092016.9296-13-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pcmdev in struct q6asm seems be left over and unused, so just remove it. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 1 - 1 file changed, 1 deletion(-) -- 2.16.2 diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index c4fd28f168d5..2b2c7233bb5f 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -174,7 +174,6 @@ struct q6asm { struct device *dev; struct q6core_svc_api_info ainfo; wait_queue_head_t mem_wait; - struct platform_device *pcmdev; spinlock_t slock; struct audio_client *session[MAX_SESSIONS + 1]; };