From patchwork Thu Jul 5 10:08:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 141111 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1748306ljj; Thu, 5 Jul 2018 03:09:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfMTvt3CInR+mc9cosD/ixt4sPgLboM7C8h/Gm6cYANNiheIRlTFcp3VZDMg8xu+V35P1jk X-Received: by 2002:a7b:c086:: with SMTP id r6-v6mr3467471wmh.119.1530785355662; Thu, 05 Jul 2018 03:09:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530785355; cv=none; d=google.com; s=arc-20160816; b=JMWHkQkUu78kg9BaQJVQTaBy5T/bXITayFAapKsSU8YOOITs+Ncj5seWpn1NkPQeDK gOtZNdMrt8wfL2/vOOyrlT+5gfqpzz6+c8P3vLqW/9zGpZR3jUV/CrKkfJt2OHh28dE5 KQNIN7u26t4nzswLkWbEfmO7EOoWfhDKV4V7E+gZ6LeCu1V2uHuByyU/lZs19OCDD4XQ 5TXQ5pJ2nW3evmkbh6U/nqGJ5gv0zXlmytgmE61YtXwwNxfAGo0QU+1GeyXk6HXfwwyK Gu1wPYLM+jfaMA0J7njsLfSw9QkGiVkuX0PIrjF+Qnz+Bt9N5lb5jqnQE0H5qqiRPtV4 uP2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=zH6UXJ4T9OU6MESvfeXCQelsKX5EaC8vGKlfumCBNG0=; b=OWisMF2ril3EvUBm5cYZJA7Ore115VO98A3Tizya8eyjkNKuRU7E98iJKSGkbJOAI6 lma4Oq14Uz+dF6gNcFqt5nckIeCJaWk0AG6kStnHjqogyMuUDnoS902zTHenf2nJWkX5 cvPuGjQI2yB+/UD5pFuwBpePZfq62WdhIM/tm4yu8cDGeLu5KhXxvQHYtSkiLd4JgRgM UcEb8DbIm2bKtV10frMQeapiN2Vuc2UKxJz+6Mex9DycZeu8oNEGhGv+7tUgcdDb+lkc AkWkvYojEmh61fTYD7PKTl7AVK5UeA7GAoORREuSQUQcvaRbEnSl4aCnR9zc5D2Qt/mZ QmFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=gq4KVce4; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id r71-v6si4604279wmf.166.2018.07.05.03.09.15; Thu, 05 Jul 2018 03:09:15 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=gq4KVce4; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 5F1332676E0; Thu, 5 Jul 2018 12:09:14 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7AD222676EC; Thu, 5 Jul 2018 12:09:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D96DF267214 for ; Thu, 5 Jul 2018 12:09:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=CVKLTXFyVkJw5eteesWP4zklo2MvtVFS/909nYJQeZo=; b=gq4KVce47au0 Tu4JJxIa21At2ncSXlmhFDyieqenwCO10BP9isucUUdLfdTbIXuBThYXPFrSYk64yY3/HrrPTnL1l K+GYQhDCabv8hWAlwzfSsPrUlj15vawwPT3iK5awV/6hyNu7Fzey5rlNzLJp95LCVaE1dxTty7O5l ogOPg=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fb1Bo-0008HN-B8; Thu, 05 Jul 2018 10:08:40 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fb1Bn-0002vz-Tf; Thu, 05 Jul 2018 11:08:39 +0100 From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: <20180704141833.GA6702@embeddedor.com> Message-Id: Date: Thu, 05 Jul 2018 11:08:39 +0100 Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , linux-kernel@vger.kernel.org, Takashi Iwai , "Gustavo A. R. Silva" , Liam Girdwood , Nicolin Chen , Mark Brown , Fabio Estevam , linuxppc-dev@lists.ozlabs.org Subject: [alsa-devel] Applied "ASoC: fsl_spdif: Use 64-bit arithmetic instead of 32-bit" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: fsl_spdif: Use 64-bit arithmetic instead of 32-bit has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From b999a7a9e72bd2d37b5d03772cedfc4dd45875bf Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Wed, 4 Jul 2018 09:18:33 -0500 Subject: [PATCH] ASoC: fsl_spdif: Use 64-bit arithmetic instead of 32-bit Add suffix ULL to constant 64 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: rate[index] * txclk_df * 64 Addresses-Coverity-ID: 1222129 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Acked-by: Nicolin Chen Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 9b59d87b61bf..740b90df44bb 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -1118,7 +1118,7 @@ static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv, for (sysclk_df = sysclk_dfmin; sysclk_df <= sysclk_dfmax; sysclk_df++) { for (txclk_df = 1; txclk_df <= 128; txclk_df++) { - rate_ideal = rate[index] * txclk_df * 64; + rate_ideal = rate[index] * txclk_df * 64ULL; if (round) rate_actual = clk_round_rate(clk, rate_ideal); else