From patchwork Fri Jul 6 08:09:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141261 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2834442ljj; Fri, 6 Jul 2018 01:12:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe8MhL9CGCY0YXndq33TK+KLq50mw2IEa/UK5esIucA6Wv3x45nnnOsosiYAluaaMRLz+uR X-Received: by 2002:a1c:34c9:: with SMTP id b192-v6mr6228641wma.21.1530864721212; Fri, 06 Jul 2018 01:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864721; cv=none; d=google.com; s=arc-20160816; b=LnSJe0K40AnzQejgKj5pyy58+xHj7but7a0eIs+QnTbhi01nY+oVG0I5aMj9SEs/Bg v7PVg1QzwaptKoZSPDLVehyAz3ZGDTzQp1N0QC8KP2esQirrJvyZ3ehm5zPDzh6jiVpQ gK8hGavJJy3KwZ9o0e+HPI14yiHJF1bFk9O2ltuZ6dDsD7XLnQbFNe60t82+RQU3qLa0 qlGYi66/SOUVjeuivjqj9nvC5w6BS/FGO5lNzb38LR3eTIJ6t7QTY2kpTd99KUGgleKd hhDbi/y8GYX4YMzphJYV5y3Go3AHNjcm5q1Gnz4MUwlY4oeE3HSIiEXulIdqZVCWIhNX rz2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=P/dfHdBF02eYEZbHoLE28tgKvs6PDCCGzeW3Zhtouzg=; b=d7POygSoO9PV/IuQPAqYKajNOSKGfUlcRea22AEGOQ3yFOgacwRes8lWmItJ7vZ27b P74qrm3ixPBOBP/AJvzsV5TKQhCRmS/Fun899hePywJ4YOGX0pwvvXfLJk+6Jlx3/Rrs Zhf1dztZtsuv9JLYEDtMrF25nhDGLdS6CAVYgn0Py8j5eSfJAxMoevO/+lQmAO0KTBgQ ntbDXHY3/uDMJ42IA9sK5mMNS4Lhh/c6DPXZskt4hqzUy/l2X8tKD6gAlE7oVl46qFo3 4OWspT5CkhFWWxjB9iymYOKvruyiDbLHE4VZIrw6lryeSq4KVcXLMPjOnGyL3VnXSLxd BAPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=VuVqaLOL; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id e21-v6si6544878wmf.85.2018.07.06.01.12.00; Fri, 06 Jul 2018 01:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=VuVqaLOL; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B64011C41A; Fri, 6 Jul 2018 10:12:00 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id B33531C416; Fri, 6 Jul 2018 10:11:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P/dfHdBF02eYEZbHoLE28tgKvs6PDCCGzeW3Zhtouzg=; b=VuVqaLOLIZ8n2riuASS1mwn+VXxR4XXBN4DydwGt6XfckUSCh1u8cWQ6sqGuKEV1bv1ZNF37eXxJL3PtpJvbWVy/Q25a4Qx+54FOncdICOac0bx7BfXKENN4p2zGt5HOVT51b5/TK8l0gTdngaXEx8GK+yocJWdho6XXC1+oAF8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:11:56 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Alok Makhariya , stable@dpdk.org Date: Fri, 6 Jul 2018 13:39:58 +0530 Message-Id: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88211ecc-6718-4b08-3199-08d5e3182478 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:tH9kE2x54rLchBF3pxri2JDPNi+va6GCT+4+PNlZVPXepUqd9bJ5O/LTBBuEGEO+ioZ/pGt4b0OYPdTZPY/4msy4H+QgP0ugJxU8y2U+zapWELP4Pynkkg/jyR6qGIK69xiJK5QXstUBE6WxdTbqteCMq+BUSNrgsVEsx22libggJwXCaHBoXPaLz9Waf0PWb2IuDV1VLZeCFFOu84o0QZO/FnzIp4jK1iccV5fASn+QfPlebZLyYbNLerD8qCXk; 25:Tm4eotq6+sWfJzQdOcq2MBd+uv4gw7z10QojPs+iD1InxtLqnMNySjMIKfhL4hJD2iWqxFjIKRAZaoyzb+2EtNARx2O9PfpkfxIVupje6n5gXTKUpn3siGmtsTuES6jcTSLfcSD8n4m1HAHeSTg34ke+pzplpmxPaFdVnLZt6ik/4alaMi7zC0ELaeAjr9svHzrg6OdzjBLvpcW0keO36AZIBQgVdrJbJoEnZH4QwCBOnm7/F0TgRjhMOl2F3LVhdA8HS9bMvDSg+AQ4PAXAdoCNfBPW42I9VQ3NU4gbq/IHuwKr7tdWMpMywBbnM5En/Bd9b2tyB8xOSc1+i9mefw==; 31:V08yGgG3Vcoey706593SbituO9thtFbp0xlgYgYiwwkkaYOp8bhML6oU4Y2HU52kEZUQh7Xdsdi381z/0p9MoEgzLW17V8VQr2OB9b3ZwXq1vM/wmk4i8iuW7+NXRmz8MdgC5bQ/RBhcdmEBsY1B1Stq3wYf8xoS8VTu6wTFR9OVFIsieb+R5Ycmb9HfhN5QC0niABAMRKcB0+UwidyZ5l5h2Y5V9Vcv9FXJ9JlwyJk= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:ztmICSy37K9zp/bJZuNwkNbtKSGHGMqzQQsN6toTAmBS1jGAhIlqE0CKRj+KCeeH+Vtm1pAGOLUmvRAeQo8fRzp3j0/TBMmOmTkqmIdR2+9oCGnIIEncVJRzjFcKRQVyxHygZAzvfMg7b4l8XV3KPKTGH8xj6ZpmkgKU+/qEsZwytNFhqjTNlrvhNPJhqLHrvTdU/MX+MY6/Eu3zjcadN4LmrB2doY2pUy/ZcCum3QJSmKIlx9fLJRK+paQgPUyBakIGwvJeaNEf6d2R5E99QCOjNtpjQbrKzzT/b3wwHaB+zmfeJnE1zVgQZhv0K6aOSeMnOPThWGhApOpsf7iwsvqwWCZcC81kMMoAcsXN+jAsl3KvTe6Oj7xUDcNOhj4JZbpGJntoUZwKxs2nYu/p8Za8sDbuSeHcccyhd42Jai3SpQqpsQKMsRRqrCv4my5mwNyrbG51x11lBlQY2EEPjBNS3JskG3+FZ5S4OIsBQ4cqNO6+2pku7mnBUCmG57z2; 4:cEXcbMoxRDWcnV6K/ytLPa1msjTYTYMYr9/rW86mje8NYCph6NertKpIZtydrTQBCml8avVKw7zsLJjj+sQBYjaZ0l7tWFUi7KNCqPReh489Yox+bCciBC8vAkNuZmz9iQG2e138YezyvQPepmdHtAKTM/FSLkLqIwp1LPhiP3X0aUa9LhAuzNuGhxFWWIva0Ef2bvHd7xg6rlk72hKlqg2rK/EhBP4ETuDheQibwccEE5UH5Kt5JyzwUxRobgmfQaoJUVTmBLOsNO+Dolf0LERwDOcmMtlsq1/piSM4lP5CnURpyV+LMMBlZzL4orMj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:rsae2mpC5/9IBGAZ1mtOGFlb+YuC7klamrs75cK7d?= OimPQlUee0CUkyvTnDPMqjoFcVR7HIUc/FiI5rGmRG7mY9my+tcaRhwT+j+U1wA6bBP+dS7CJJJ2jT0gA+xNgdcvXpju8NTH4lvTqV9y6C9KxuUOULD01LyLfaLXUOosaNwbW+5lv7NFTxY5majx+sTxFHvcIJzePXqNo71q0h1KlCLX2HgQ5mqKk4ZWOrk41Aje0fNNdn3xzLpHB42kJxAkw5c7pDecs7AVYmdaWHuSb43duAw9BhJyImVeypAhai9ZyLzXkWR8ZXBh6hwP7RB0H1HPvQQ1WHa2kMhV6idHE3sFvdgsD1E9MD9Isr6TYSUjpmtMz1tH6uH+sSMJ1bLb1hc27+vBu2KLFN4+ql/auHZ5pAGqDA8Zi6jPCK8L8dPwpE5HbG0+in2BFSGyNZWbVbu6CfKGZvqfaCwA05zwXn1GJmqxMv3IH4z0Mn8zitj3ZwtMzeYaQOaCIN4SdgpTQTiQU1EbcXJfbsmSjR1lyunkzy4nhtoDxJKbdGNzMZpYIB8aFaCOFFPLk9346GtTvF9D/g+uAFKariW+AL3fntZliGuuMTp6nB7I6Q5xUVleznvNpio//MNr97wVXQ8TuBMmW2icHDtwe5CNmYtveqPy7D4asOAfAc9/5FSo2bZ8l8bw77eLeBids8nA/OZ0U4XC6DtEDRxSmh9MDGz/oonn1PfNpwlQkmS0HFfc7dM6IqtYIQaUoEpG62GrkHbxeeYdbzldS5CmPbDAi14OV/QIOtN3K1EgGjeBPjOCnkBSCYM4JzJl5ffDWv69WK00k1e7b8WnopJbTYj9FnZSBG5f1j1ygMMw4/306eYUdFh0i3PzK0KN5zIxMV3ZhuS67BBT+DrN9wyU/3f/gGmh3i+y1q79tOQTo00y0VUiSML+r8V0Kes1EkNLooHJR06AY6aeVTArhZAuYcvVAsACJrLVMSjoCROUp6XIxeQit0SD8ghS8pkNAEdNSWYxOzhkoFhEuIdnsT4i0N7zJ6b551RyCD+UFJK56NmQY3j+uEAgdgwz8I4ZUBKqOdbnP69ltjrL4V0JVy154t0oiG3WiV7avD6Ly3xWkCyyJT1i/4VKfcAc2GNKTbsXJGbg87B998QvOXHjf02oH1hqDEpJTHyTpE3rsXzYtsh5lNXnjebpT431qaaxAA463nSBmScEWIxMCDWrerdoAcafzj3CQ3qqIQBz5F+qCymOX56FTVM8cGMSJe1/xNVm0Z2fnGM+3Zr9zeiDMJBxyuwlZ/F/aEzFRb1dmboe/uc8nwUVtw= X-Microsoft-Antispam-Message-Info: /g8u6sGdWLKpsGKIsC5MfJiylgcR71nXt4mewx4YUhi6es2YG4VBGW8J1lSXpnCF0X6lMm4Ex7D/1x6Z16fZ+eiAN78QbQsiUX8OyYctluYspOPoyX2iS5SKg29eHE+yf2240W46swNBfP9zPTqoCMtSLmpUZNIMTepwP+2L+uQEfyLvgWz3E144fizcrIEG3ZkUNTVG1Dgt/QO+nAd2cXZnkpl7LIu85m2HcoKy8p0sP1UlaShR03cwDMu890APkZHDcpvyCiiv61o2yCDEOF2sNEs90bPDRr7jKV/X2LcZpGtE6hTy9kp6I9+YVcnfEPMcfrpUAWf45aXuwtsNHIIOn7G6SxKsPto7AcFzPQ8= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:vAGWteMxajmE7pnvAsvL1KoER0gcao6qFBxFnNanNHqfWy08vNX3vPOQ/QqhMbcSrNnwnQ8oKa6MDjJXGbMFp/V1V6/A6SbHJvTEZWmWhou01BX4a6lHWErKsudLTPTz5rk9aiRtesZ7l4Au/0ISpuralsR5K/wdCigcsi4EEOyYP8tdr90nlHglBf17xTdmKlsLOBrfCCWneR3DPfnieDWm5oHFEVi92mTzrjG8DAgceSkM4gx2xM9oNwQrgJugeE8W0nBZsIrIS3a1fzYRMB9hQ9Byws/mT2dMaHmRBo6KAhWXIZ6101yXbTwzaStaw9cBLw+8XES0JbFYX1awQF9QqKcXUjsKrGvAiMTxERrCqN7B5YUFzuuKc3lmF1TqhnpNvVv81EoWqRgGAnsr33I9kALB/dphE4jPzVAAzNUefjX1/wvna0zqx03RlB8rpF2PhSSKRBZylP6GCU2Icg==; 5:l8wOpd0kL0prahcvrBk/uPLYyELtRd18tIBc5EHhDEReuESXMoyfLa/T+sCZLB2CCUh/89Ezh8PX3rY2utZ4nKcvGGHtB69+lw8y6trrgX/pHChhb9lOKlL1bCJQiWBkm4tm/IGErMkxsmYR4EKTyL3GrTQDrzGUBjFj+VqBMpc=; 24:qTh8+g/hSad9LXk7TMiaXECtQB3PMDRff0G6DOmXWC2Gyvczj06g7f3opEewl0kmONjKAaWjrZZFO7nJm0YVf9QrIJrJIrGQpZ+AYCHy+Vk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:ptEyMIg/IPrwuOx+geCWzhY2kYvzlWirEtjpaw67Wtp58fakK0X0I0dzVlIQ8rex6T+kr7RRPIjuwUxElzWS9rc8jb820hGx4SlSgti7LTWzr8YpH/vsUc6gSYd02iFH5hzR6PQA9G2D0SIeKU0TM79NqlAuOd/9XcfHow7xYycXQjy54LOKOMbLh3Lj8oyrhesB3W6MG1yoec3jM3X11q+mDMW9WqzF0LALSa6cDR2sAaCtJNP5j6zXUqQGQyJZ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:11:56.3062 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88211ecc-6718-4b08-3199-08d5e3182478 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 01/16] bus/dpaa: fix phandle support for kernel 4.16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alok Makhariya Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") Cc: Shreyansh Jain Cc: stable@dpdk.org Signed-off-by: Alok Makhariya Acked-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/of.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/fman/of.c b/drivers/bus/dpaa/base/fman/of.c index 1b2dbe2..eb55cb9 100644 --- a/drivers/bus/dpaa/base/fman/of.c +++ b/drivers/bus/dpaa/base/fman/of.c @@ -182,6 +182,11 @@ linear_dir(struct dt_dir *d) DPAA_BUS_LOG(DEBUG, "Duplicate lphandle in %s", d->node.node.full_name); d->lphandle = f; + } else if (!strcmp(f->node.node.name, "phandle")) { + if (d->lphandle) + DPAA_BUS_LOG(DEBUG, "Duplicate lphandle in %s", + d->node.node.full_name); + d->lphandle = f; } else if (!strcmp(f->node.node.name, "#address-cells")) { if (d->a_cells) DPAA_BUS_LOG(DEBUG, "Duplicate a_cells in %s", From patchwork Fri Jul 6 08:09:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141262 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2834587ljj; Fri, 6 Jul 2018 01:12:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdlMOt/M738uIYtYh1DneKn+3NVz/3gwIanRqw0egqGYjdUYU3ZoL13Oax/pAzFK3cLI/20 X-Received: by 2002:adf:a581:: with SMTP id g1-v6mr7053756wrc.233.1530864730939; Fri, 06 Jul 2018 01:12:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864730; cv=none; d=google.com; s=arc-20160816; b=V3bCYINGx2w+eR/JoDYH7h/KG4jRPSvpgTR330GfHirbaS5uEm/WkUanKynpaxPnSF +HUqGcIzktYqvB1Xtl3v4Vi89EjB/9B6rOWzXumHvFc/2c+brr8uOvbi9kb4HacmT3Sb 6927C42EU+nV163Ovr1GysCElvXzBYOwuhODS9R1ByXYe/kINocuf63GJukaX0KrjtYj cN0ismCKxhdsWQbHarTX812iShDuYaN8XaImFErQQ/ZnE/hku8o29pA3jQWMAjdRVPNV d5gHCVBwz2HH+dG2Hg6Zo8J5jtCh5JgNDrHyKKO3uSw47AB4eItq0omqHPptbEGEEQRJ pjLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=DWPhtb85NEBwiCrZYZpSF5Zo04OgaqlCJhIj7CmDzP0=; b=hYirxoakcpUJppEKCpGTG1PxfgOvVZZoSeq8DTXa/4qhlWSaXF4yi1kqsMQ7hjbJET Rc3j6VfnrKy9L48ZApAS5oc4/qBZ3wIohskvLRsHgtkxDOzVGZpttlabK2OSdFjhvrqZ XA8WVwiFB1y9s0VHu3T7JCmdhOFS4IeJMK+iarTzbOBYtHi+GlzVvY3XgUP8N/1yRVwA o1xnQA0Ml/7BRYSJqY5uZBoIeCc6l1bleepsh6Sdyy4jTraogVxxDZ5bv5VKvD+e+9cy duPfmO7y9gOOZuYzPRMlkli0dlQ+kDsV4YTWGeBC67Uk1bFEIjihhTkv2QbR1TPUckbD C+Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=X9Sxgm+3; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id s106-v6si6660113wrc.162.2018.07.06.01.12.10; Fri, 06 Jul 2018 01:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=X9Sxgm+3; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A9821C43E; Fri, 6 Jul 2018 10:12:03 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by dpdk.org (Postfix) with ESMTP id 15EA01C416; Fri, 6 Jul 2018 10:12:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWPhtb85NEBwiCrZYZpSF5Zo04OgaqlCJhIj7CmDzP0=; b=X9Sxgm+3COKK/5P3MRCQcCINK3lzyUHvipRAy2k3QI+irTOJxTKeQhXHIi522Dv2eJrjeaRI8CgGusS5L/eMa4i1hq1CotdGY0AxV1zY0142tFNxPRyIooVn0fG5D6Z2651nfLvZ+nCNO9SaKu8e+4QeGJaSoW8cH1DpLTiNQUI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:11:57 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, stable@dpdk.org Date: Fri, 6 Jul 2018 13:39:59 +0530 Message-Id: <1530864613-11754-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed334383-fee8-4598-2c93-08d5e3182548 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:GNSAwKQxmejCYJz95CbW4U33LA82xOYKb36ir439yLaeAlIvBwMF1dBGxHxsDBpJUGcB2a/7epj6/9JzULtkONJUIDjx3MLfYdgK2zyJiyh+cAVwWG8M4L5GwtQtkDhonzkKSUvK+9wO1Jjuy8PsIIGNCbpYYzdmXhSPYvQJc8mA7HIHisMfcuwTlyYrhaPTOK55t78rvFtpfu+xAdOZiHTxujG379x6EDYOS2aWY0vuxT7dFgrVCTFIHkkOLbCW; 25:wG1lXCEaXccRrs78OokDgLh68mN4Keu6Y1NbmOuaSERV6bzwSNScxcwU2KxHHMUBStRF9Wf6pC5rVbSBv1DWa1Yr+WPPsGKT+XNVuwBQFRVG9WBFP/CIqwRRPrBhpQohfMZg75DTn5E6R41Y2OU2yQ/AhSHzdedQO7Tv4/FlYfftwFhvVS4pkwqNiBr1D8YHSElI2dGHSjVnufhkdJqMIoIsLmS5LFFZiMpxk/ZXpXigYLDqmx5u+i4pRxog570oe9JbjBEzjbIJdS2IHdFgcYC00ecS9Bpg1aJlDWm2SNLqEJNoSPb+Dylya3DNlEl+NIt1pLt/DBv8RPlF/5xFYw==; 31:hjoD5z0xwHkIyYCOAkymYI5WNIkJSOVb0nBKsphtxr89+Ht+ng9cMw++zkBBCzugoPZ6gVL15BQVuY6A8WlChYHgRODNkoLHSnO44ie7pWWPeIHv90ZCQNWSgwCpuUat7fMdsZTOqSD7JXObpqRYRIgLe8h88LftJ9jQYHSl/wKSEXk9p6+2SC7dpnH/tEtnvXl+NjSV9sytLRwUVG4dk4C+dwKFJxVepVAsE1981Gs= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:w5iRtezj4+p7uXwiEQVOdPdYFnj1WEj6/Bp/dKnODqsLPGRaDOrFIAuq4xtmdLEpMfSLAoMWid4/+8K42drxMcXMGuy2XJTksHdEAWeyAj5yUYCnFljlwN2iyXXDmMt5q6AUUhxbpkx7rGUeowMgim+6oBxnyuozHKjFSG1jmeOMKpWYjrKe0bFokf7Cnj2lpArUwp5fWmZBj2c3wh6WyRexeRZ89AaScW2QfGvnEde8doHC35+GuVkVUkTgetitXdLKbvLF+LP0sUVFqDV6lzIYll3NDZThsN52oYG3iM8yK1FyHNm+coyNj5IhOsF0NMd5Ct3xiJ44xqoVfhnFAVUNMkJa7+RnrjaBVEklzrCpRNMXukzMTxXBodAGlx8M7kJ3L8ayIaHp/vtcMwGcrHqcPO16Qlw7dcWzecYcHBmnOyZYfNyk9UByqvK7ySQaFKtKtWV46Qj59NauT5DGctpqP1y8Xys7Ol+9sPTNtK/O/yiadv1QsYxFGqLzs/yu; 4:ZB716mi0q29AKgUNr+7iPDGGytuUV+m0kp8WvPy8qx5CX3M7ofiBRa/qqR9gPeMkaVYRIyijL4qmnOxBvioNI+u5HlpU9FKZY/E5qDSDr5Cvqw+0HAvxV3iSdORXTSelh8tFAOKhnWmLWM+JNF5PaXYrj63znVJ11Ew8Pa7+p8s7WQe+TcqrL36dqcMq/coiF/GfNkf6a4wf0llvRpNipenme0x5ymKgwFojwgAST4iXUpiB+6qGwaf0TEist0G8LHWtLjyTdq5nplw3nj0YSiIWWymus+8SNPQW/W6CuDQggYMQv0YFjokytFoR8263 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:V+idO+dUTx/UG3KfeUXenG46mvGoA2mY/tBFb/jXP?= 4rt9xdAMNbQ5sAhw2duA7w/+Mw49Tk+0S0cjn7pmdB4Cqf6CQIOwcXZVHYSSUXCZWJfsaoLLs3EVaLJiJ3p6fnl9TH43vvKVmU/IkZsyP72Pg9scGBFzDp6EOlh0sbR2hKb3uF9iwmxETizFMPeNBPuB2Fti2uF2RHo5kSpGQ+8r/Db1bvzZevAfMhPq5uDr3CRnA5UKAe/QfB/5bZfBFDXTF+0gFHQbyb2m7EwW0dNqx4hGttz5u0yNLQI9k266xgM/u0z7Hj3WuNdaZ391wT5sBYiJUt7+WPCWiHM8wxiK5sgjhzs8dQ6ir+J2dZblSA0b7jjEemEAfgDqMM/GuIYHXpxHmXptTByXaRTelczIee9D1+ELm3mQqslEeUhD8kqXj7oGZpeam9+W0DMRFapKnUwhUHfRqOEF4a6N0yWhE4jp2TAJFd2eJ65iean0aYsP6tp5wAJHvBtmStk2L8s2uDUnOFeEmH5p86l+VUKhF69RBACxE9lfvXoJxrTp0fsApIFLftDtza1pxMh/KFpTTqBuLFTa/lOYjaDm5dGyJF3v2EtlRSCWkZyvU/cj5UtYmggwcRKmjTIR0seqs0k5GfsLQiCyBZuqm9EzBvbZ+oRkjDiBs5gndNA9O08qamB+F2JMc5ODh93GQDVXCgnGhJMlKGpcd9Wf6MF/ZuiXMdOPOM4DVbZKEe09zPt2OWUsn8fGiLepgrDR48yHpnHRDj0IkeT7lmAOpkIvWj8W4LXnLq2vl27ovfKinrCwd2fo9HdPt4hjjDoXwVJf+mUTe5UlUkRSOT6hLyTYwy2se61LahidDerpiAmX/l4nyreKHm9/jBkGgLA0c1C+BFu1qbnrK1mDWkIECcUt30xZ5YMaPpljhRIkP2qP1XcW8R018k1YWcj+9xZWs1c6eFlUFtE870tlVzliTSGt7TVnBYn4wFG/IxqsGYgpJHpwtfSvya3D+z9m1j51wqQlzar+DOGZQjm9Lu8WKVxoL5Hxc/nQ3szoANApMf481HWzg+RP1mp2IS2jRUMZPoh2ARDTB8QS5iMKXC54YQN883Omeq/leVYV9sagDXAW0ITu2q07S+UNq3aMjr9Xyv9Nt5EagbBIMvDApeCHII0cw/uQ/TcZkXUixNCm9gcojs9ezQddu2WxrDmEilr7DDPJNGdkg6AxEFWMr5W9vuXo1Uz3yxjpUmRvYXvdmUFihWZGOngmq3AsrM1/SfujWw7OdHH3I3T+98F1JOLVFj0ztKgy/5Sp/zU7DsaBN/J7bWsDp0tZpg46OZLaberWBo/l9n+ X-Microsoft-Antispam-Message-Info: W34cYGkaDsDX6LkCRUhTM+tpeEJPJtOjP9o8a9As9DCHN0dhEZwJZuVOMuvHli+j+K9CSoCeJ9zDQdEzCrS1zNqTjx4nUzP2+EQ+MLEqPSONTOSpddVsmUtuJlUW5NbQJ6Gx3EWLtT/51EP0T9eT5igK/KFyYvWUEfVppLi4qXF7vEkBxv2tMrvaGrY5tQNf1fRfctomNxUYRd/D2zyeK9TjI4LEjZW/+hvS5RMSnPqM+ku6UUWQ5NorspQx/hcvlDNRHZvR1SEi7RQ6K847oqM+KOobL4F8wFlV6EO0bbuo9n9t28Z9r4El/G/Kul5Iu0PMNpymp+pL+cpSwUa4N65k5KvtPa/OAO1OckdbB7c= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:g6Eq6KI5FzLnF1vNKkHGT2u6Pk2dKeH1RIgfCNnaTPm9MQU+52iUefjAaabr5LO9FzQodiCWJOCp2aoKNoABCzoNmcDdx6URHd+1ZjEJXiQFC0nVkQuzrBnYSHOUXjrtsMcAVcR+O2ITWJwOawnQxijLdT3XHpD+UwtmlkKZzbUxgTjxeIPfglSvByhfALARs5q0jzzkNCnubVoAYkXgTce1GWXDBXEluYp/QC1ZdkCnq/+v8bB0mUY7vhH4iPRFYS/sAZGw3hPL1Hg8qCW0q9sIM1F6Tw+CBdiWJFr+Bt89PCnfOy3zUBePFVQ9jLUwBpk2ZEy2SwiAPiGI8D1AN200CLtR0nbTWCD6zXFd+eFUfqgUhzUbJguYsAVL8zIbHkN4Ff7aXubMiJudMK3r3RPaYfWu59ZD7ur4eituYBW6cOF3QCL9ZMXjvMEKuZIDWKeoLHBF7BzxhTiOBQfufA==; 5:dE6YVPpZrlx+LYmvnyfcKwe0A0fdghSB3DOmm1dLrhj/C29DYoLw3LPe4wFIcWl5T3q3eDx8Gy5oXAQ3MpkV3i5TZ/E0UqUZrtU099VKyh7eFth/nSuHOKC2X6r/yODCCeUG2QqfC4qyXvRSMT2PTOcdI6PnvZjHbwIABg2dAfc=; 24:bLURvyQf498i7+js6IHVF+WrvSNQ8LWCTxQtLovMps2sJN1AV5+2eo91R8gKCl7BROCVg99Mjhe+aYgEwTGaEycQ8gLd+OpbbmHbtpwPdE4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:/KOWv/ZUsWxn6VXeovty7t3lzuhHcMa1T9lWhCGQdZUBmwfG1rXxGOAvYCQWCsOQB9MHjykieycztuf0bke5lh+CK/ZDHXHu2YVkYw5DusYstQ+ipaQ2lYY6lyU+ZyWIxYgSCHG3oI3rnTsVxdMh7iy18omwuhGO5DqxyO58c8lR5gzAWB3jJ+ryu1xYCzAHKeOM9ypBDg02OLhumEiQzWmxIbZPTS9q5HAQ4IuzSRGkKCA48BngGGEODkJC4ENx X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:11:57.8083 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed334383-fee8-4598-2c93-08d5e3182548 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 02/16] bus/dpaa: fix svr id fetch location X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Otherwise the SVR may not be avilable for dpaa init. Fixes: 3b59b73dea08 ("bus/dpaa: update platform SoC value register routines") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 2046206..7956bd0 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -539,6 +539,13 @@ rte_dpaa_bus_probe(void) unsigned int svr_ver; int probe_all = rte_dpaa_bus.bus.conf.scan_mode != RTE_BUS_SCAN_WHITELIST; + svr_file = fopen(DPAA_SOC_ID_FILE, "r"); + if (svr_file) { + if (fscanf(svr_file, "svr:%x", &svr_ver) > 0) + dpaa_svr_family = svr_ver & SVR_MASK; + fclose(svr_file); + } + /* For each registered driver, and device, call the driver->probe */ TAILQ_FOREACH(dev, &rte_dpaa_bus.device_list, next) { TAILQ_FOREACH(drv, &rte_dpaa_bus.driver_list, next) { @@ -569,13 +576,6 @@ rte_dpaa_bus_probe(void) if (!TAILQ_EMPTY(&rte_dpaa_bus.device_list)) rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); - svr_file = fopen(DPAA_SOC_ID_FILE, "r"); - if (svr_file) { - if (fscanf(svr_file, "svr:%x", &svr_ver) > 0) - dpaa_svr_family = svr_ver & SVR_MASK; - fclose(svr_file); - } - return 0; } From patchwork Fri Jul 6 08:10:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141263 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2834723ljj; Fri, 6 Jul 2018 01:12:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeJn7n2ocWbJCBtL3mB/dG+M3LYH+0iOhHZmTwdKZ3xCkEk9Hgcg24MVAMiPB2E1CukQScv X-Received: by 2002:a1c:4983:: with SMTP id w125-v6mr2651843wma.68.1530864740513; Fri, 06 Jul 2018 01:12:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864740; cv=none; d=google.com; s=arc-20160816; b=UP/E/L4/9d/qW+2KoFly68Mhy/685eaPa9rRsluT+sS6d29JWkv2DnFZdR+vfFHic6 YHzx//tdkWApZmKog61NaoO5umdcYo+9GWoYpMM1cLI1V0wZ9hmf/0HHtln8AyW0AmmS MBcUB/8WSPRlN3ky1Dc7xPZqfs1TdrhRMEgGczQcPbKKedtEAC4ObkFBRJtvwYafFbTT WhkZnc7IDNbh6oVCsak2UJw7y/30FRP9MCLGPDyyxLPoM2D4sADEaR8uq911rg2dL4nN +gGg4TlSkYuM2vE4JnBPWUiCzxTf1lihhU//tdGM5z8B7vLSNagBJUwvYwn2nRCzKeY/ hIRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=EISB5PGDWfeiuYZX2AudSn7MbeOKxT5/3ozuIetq9x4=; b=F0ypYMB/OTQhRdqs981AOSGYndXG27e0dbldFEMn3bLqm7ZHAH8WJnPpW8GOZEicoe FoOL6i8L0FzwxMyw6/9EWbCuTMRSN8oqQanegqUqc7MCUpoA8o7cbu2s34xPp9d3hzoL TotMuWmng16QVaQICQ16iQKTSXFURr96NLze7XzEqnGfvvkjKRBqoib65mx3kQPrjIIt lcU51zBI5a27Vr/5vWapd8noZI3Ut9fxkvIdtogSn+7Q0KOmnw23qJ+30f2LPJ3r92H1 hMQRXdcX8Gx1gwp6ygpTctJmW4Gty+xs/mvXqW4zZfC+YRohz9sLspGGydMs0/Vx6261 gn8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=Zdbt2xH7; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id 32-v6si7524686wrc.289.2018.07.06.01.12.20; Fri, 06 Jul 2018 01:12:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=Zdbt2xH7; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 146BB1C448; Fri, 6 Jul 2018 10:12:05 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00080.outbound.protection.outlook.com [40.107.0.80]) by dpdk.org (Postfix) with ESMTP id 1DD831C435; Fri, 6 Jul 2018 10:12:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EISB5PGDWfeiuYZX2AudSn7MbeOKxT5/3ozuIetq9x4=; b=Zdbt2xH7VapvuNqSb7qH3Bab0ch064eNeFVtoE8e7yd3/UWQC050wIzQyHEYkI186WclFyzQW/A1WhK28iruCP+gOAw2J6ywag8sXwR/rMq1SAbCxHRhC7KVHK/SiwNypiyACGtTYhdx6BFGBHJ+rafoahHbZpPofYpyhFN6tmA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:11:59 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, stable@dpdk.org Date: Fri, 6 Jul 2018 13:40:00 +0530 Message-Id: <1530864613-11754-3-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7def8303-28d1-4d17-2e08-08d5e3182600 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:t04RyluLEPHfJVOXfHFAcwXocnFFwZFvVZqBrOf5xJJodS7p6LanVfmmVkfAgrNLGJ/NeDi6ivxFQ1AmOD22B2/3t4MpkWaIQGhZeOwkysDV0vdpKwqbP3DpbwSQ9f7lLXHQDrZpjZn7QJjZPFA9W/uaoYLurybQYPtM32fV96TM7asxX8VaxR/vJ/ty7WOhV7oQ0E+T+ylbuio2uIXqHz2k12/WPV9H2GYndlfoxovJzbE89EwMBv4ElCXHCvsC; 25:chkXCfu6A5+2aV6GOmQP5QcZ9P8vw2E4mZj6Bj1b7pM2oCCfUARid+cbq1rr4832jwYym9rtXL3Lnk5+0b4j+ldypC7+rzf/FA0AoK+orqPFLXytW+p8F8zs0+ML3gptI5yCCXQ428+OZl5sWJbIZqbTE3DKsU/ukYj39DtLtyU3jr0MI0OCQrT0y/7rme618oY7RU9efLlAI2p+OrbbTpK3Gu6Kim7BVrwhpn194gJq+/oqPM3EQ6v6EpZR5mLV73/w3IDpr86JftKwlrecctRdkY65Ebp0OqxntK5s7PGKVu+NxIDlwueA06267U/C+0t20q3lVU65UH4Zy6CHIg==; 31:BNe4k68US/8nz7rj5TLkZcLZ9cCbYHvagDZcYsKNeOS5yN5/xfke3+/fz5kWWaJ7taZJfooO+8Q09c3EjjxGE8Iz99oG6E6Hn95PPxiyayQCrJVywMklIgmJkgZT7WmIH/Q/107L/9Y1Gsu5/8rklYybIF+0u7nAfOKK3q3NnXwcRCf1Lx6TFBCN1l/UrkN3fmDND9uFgD3IbnJrNAaxvMIPnByvYRFtzu6gqoXN+5I= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:ybMOhB8DsDtxtzMf8bBBMQxkSGhdvNJsiVLvVYNECVBaO+3ESZ4bNu2Y3tXUqlAOqOxXBFsGvG6AA1q0V2YE+IGxwSh2qR4MDVgBRoV7v8mBc8pIq0cD/sImLTWoozddLdDwxOt+kNkfq9lCwfdzuflCWjnp9gpbUwTxy6ct2ntvMAzDl2FoXRkBqYCGkReFFN17v11pzFzSfz9dPDlotcTsg2hkWNIi7TayYlz2/mYYNRc8r24QJ1esXyZn5cObV8obH/gJf3/EFnBW0xPfY3XRYtre0KL/R8hMDXvnrkv482u+4y56rW0dGflqKYmV7bvZn2Kxeuzbt/L+JEBEzC/0t7TbgcpGHOYIilwNPzAYPlRq6qvIHWAguQOTuNjo/50Xyb4i2A17Haqc7GGJA3jhEpHCk765B6DZEOJnEc6fyf6NCluOnOfNC/406ekc0n4gomFa2x7yMOhEQVl6J/n1Ux/UTKbrr5Nu4dfj3T9y5zYQv2zqCbPV1UQy1XES; 4:zZzpPgtdM01r1K54Of+AjatzM8YIfCSGi5R6Vc/cXiICjb8N7pSC2Rdf7IB6Mn//DeQvHF4Ai/ur78s/gAHqt8K5s4s5OYNs8vBx8KHT+9+asHbThEbTWED5ruK+yH8lxqLxAZRS1SFWTZQ44UU6mRSFGM5mEbQ070uWdbooG42eQMWaCmHJ7qBEqtg06WOc9kkDsIKQYRtbg+LHz2oQe1tXqIgy+uvBk3xn0beTBBLQe96Bv7XXtPV4MeRDwKdUIzvhokG8CPGRPHk4cQtqLCZtiNb54kTt6YG7JzR7KGCQOGVkktSgoiBPnVEZnHkN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(6666003)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:Nz2+e0cZ9FockyW39oVOuIMQMz0RrvF8WhZw44hSz?= 0hCPxwxaotOcn7bblFMKXimSj8+JnhA/w5skF99L6HTlrp2rEkIjo+G3kwvESnyMp8oSgWfjLQLmtPjqVmjUHVhmDjaF6Zb62omHgDwjs/iOGqY6dP1H1doI81yXV2EOeWg9olin+oq2KnoYLvLp+P8tPkM6evrXFW3wg41QzXvHDAdEaCYXa+75ePlGy6+hqEI3tsGeuDzZQcq1h6LulP9ffV2K3XpXj4VCtlst+5PI014xHSOCNzF2+eMj98DXeHjaHjQRKUtkZtfi6NlfNIEPCeqWjItr38aQR8hAErPQPdRCFDK8xm+y7FH/CIGYjoL4fwArmDR5j2Pp7lVYkezF6z7ARwe8DGoTVkUZc69P5JH5XBq7EU03fOEOzyhRjfJ8QeX6yFbFzO5WaL4AXZVY0/GngQbIs+RDJZJbipXr/GEVm7zJ2pJwXPY+DZeteoNV7lS/+knlBdmcpyKCH+VXhE5o+9HTJdFwljS1sBENZ6xeKQfCE4rOhoFJzxESSKWaNLnYirtJpGAIxaHPX8gZoosFz/IF3t9oq4m1PeAOL3FR5l3q0VOn/ejXMNsLgqofafZ1bymVzpxYubXzV88M7cyu2QgzVYmx61SHkYa5RanGB6o0vKkPSa+i9PUPSaVdvoH/1lxQnxnrR/Q1ykxcPBcq+x0S/G0Z82taCOGe0yJTo2UqrYtxk5T3cB+pLeVWJxEQVJuivCwd//YzAzOTk87qM30eq1ZGHBZNcgDHa/qBFy6n5Pvw9rcsxI7X1htianBl1e/tGDtwfkD5rwDRhz2VD52L63Kk/qeETWmfQLk1mLrNK0BkOAfPfDRWAFwGqp8xqYQ9ec1DNW5Zb9AbLUEFQ8LG1dTI/3+mirc5/QxcYbXl7ux43Xmft+unh6IeDvZDm10Q4YzJZipxj/cbDBryyroZxC+UUuC75WgNeuJUNhIjGhmTiGMjqVrCRWarA2aBK/YQOTS/Xed08aDrlpGj9b9ANNIj2J6R9BgQGf8Ve+4+2sfQCwxLb7+xtzo02RqoH5vkt/qQfdh/ZbN/XpDa3kwfWcN44NdF4nyx2eFsCpzrv7L6gTzxdEgtpTWUzJ5S76U4rN5n+UZ8kSFjg02are2Ne2aL03ZcuQbGCUdr95l5hDjYxMyla+QF7l1DV25BHeHKl/WUzwKnu9fg1LhyZJq4BwitDYZ/o4YafByCSWfz9Er4H+mVfkclAG8bNV+U0jr5kROEqf4alTwBNuSaaz2QWdWCgFXbkl6jxQPUxOC0doUrQrSKbYa/xwaRwTdN3mGaMaGboK7bW8c X-Microsoft-Antispam-Message-Info: qAxdaqR0Tstkv8LtssU+rTrWE69910DzjSLSsjT4Y1ckgFRDAuSHzU+gyam+BGf/+61s0u2rFTejZ9oS2Tt5vTigf/Shrvks01ZGNKZed0NUrPHhbE9egMIPWaI/PUUiHMxV8AaEtJvPcdGgrS59FjgcTXELCdh8SjiPzTlgw8b2P4mtpoaIBZIevaHec/LuVTlFjaJQe8QPUDpuGhvad0YQ4KV8+75rUxel9Xu5F3TmlWphNaFLSIg95LUCZKVG+ULbAuguNPsDSBeWc1/4Kqpfumbds5ZV/SRaAO3CHIXFfvtJjF7SMa8hOrBZzas4zl00og487k5idQQlt4Kvp4YxBG9WhpODK5sVnW495IM= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:jDiR5AHkhfOdZGLVIMC+NR3Qy8WWg/UidU82W0A0A1AeC1qGVIxj7WLgeqMnFLD5Sr384Fiob4yBFhTaaX+RKr8ZJqMmgQ5NjXKyoG7Ql6WxjAWaeYJLj+LpjziH9Tg26SsrqkeMlY1FxSTsEzQ2PAVyOVSzoSfDs4hWYolYHl65RU99qhlC8POGq5xr6Q55ngIpT+A0NEUSjE3AWEYHfYgescflNHeJh2XUm6BLeWBZvZOp6rKeRwIHVQCtfl0eNBQN8O5ozbb/ypVmVBpRofH0levSrB+6rWUEueoM82bKyRUWqPcdvvbz8cb3ICU8albWzrfubdVOvIGjJI/Sgvw0CV1fxaByW+iVaEeQaz9gAZPsioscvzBxgzkdpr21eNlzlfTfGHuwLCehPv7YOpfGKOTlSRrSWaXvCwwuC3swt7obRVtqtPpK2MxG+bmvrMKqzDKJxEM8Ugi0THJVHQ==; 5:Ty2Q8kXu8OT9FIXXzfsrd0oobMII7iAy/qnccidZ6nyTe+HQxNNQRE6BLF8+nMHgTNXJ9Ji6pK6yJNSTtMi6ewzMo/vcqhm9VI6ZM/bnarEZ08COlf9qcTU1UogHlFOurSkklKuFliowBB10rzTfHAyb1fQ1SA/5FV3JBhH5GV4=; 24:Kl2Ef144uv8fsMH2t1QF97FreBa45RyA/PgxDFAhu3SawjQU4JOBbfC5fc7Rq5jZ1LGKKosWp1fp86O2uaHEaYoA+n0JqTs+WCNtP5UzKok= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:wJToOijjDRWsQhiVFIFH7fWztvq+3Gd/HK0tiiB8Yjna57CqgOjLH3IE6oj0C4/eA/eg1D9RlFTQUdxOeP2v4yn26nBCNTG2vuvrcERxSSvfC2/AGTRM/lhrSWtxWrGVn2ZWkCDCikW6vCxodXrZgUXy5gK4hzCeJrh+xejUSCfXKBOdXM9N94Czl4UDCIxiEjYjhRVdh+Othv6Jfsj6wf43wGwWlx8pSbiwQ7bJBoMf/oeGuaXeCk1B75p5CXJQ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:11:59.0262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7def8303-28d1-4d17-2e08-08d5e3182600 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 03/16] bus/dpaa: fix the buffer offset setting in FMAN X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The buffer offset was incorrectly being set at 64, thus not honoring the packet headroom. Fixes: 6d6b4f49a155 (bus/dpaa: add FMAN hardware operations") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman_hw.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) -- 2.7.4 Acked-by: Shreyansh Jain diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c index 0148b98..7ada7fa 100644 --- a/drivers/bus/dpaa/base/fman/fman_hw.c +++ b/drivers/bus/dpaa/base/fman/fman_hw.c @@ -16,6 +16,8 @@ #include #include +#define FMAN_SP_EXT_BUF_MARG_START_SHIFT 16 + /* Instantiate the global variable that the inline CRC64 implementation (in * ) depends on. */ @@ -422,20 +424,16 @@ fman_if_set_fc_quanta(struct fman_if *fm_if, u16 pause_quanta) int fman_if_get_fdoff(struct fman_if *fm_if) { - u32 fmbm_ricp; + u32 fmbm_rebm; int fdoff; - int iceof_mask = 0x001f0000; - int icsz_mask = 0x0000001f; struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if); assert(fman_ccsr_map_fd != -1); - fmbm_ricp = - in_be32(&((struct rx_bmi_regs *)__if->bmi_map)->fmbm_ricp); - /*iceof + icsz*/ - fdoff = ((fmbm_ricp & iceof_mask) >> 16) * 16 + - (fmbm_ricp & icsz_mask) * 16; + fmbm_rebm = in_be32(&((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rebm); + + fdoff = (fmbm_rebm >> FMAN_SP_EXT_BUF_MARG_START_SHIFT) & 0x1ff; return fdoff; } @@ -502,12 +500,16 @@ fman_if_set_fdoff(struct fman_if *fm_if, uint32_t fd_offset) { struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if); unsigned int *fmbm_rebm; + int val = 0; + int fmbm_mask = 0x01ff0000; + + val = fd_offset << FMAN_SP_EXT_BUF_MARG_START_SHIFT; assert(fman_ccsr_map_fd != -1); fmbm_rebm = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rebm; - out_be32(fmbm_rebm, in_be32(fmbm_rebm) | (fd_offset << 16)); + out_be32(fmbm_rebm, (in_be32(fmbm_rebm) & ~fmbm_mask) | val); } void From patchwork Fri Jul 6 08:10:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141264 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2834871ljj; Fri, 6 Jul 2018 01:12:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcyHcXqGHXWYeN0485MG5BG0XDenNclpjfWt+njolr7iABpuu0sYa7WdA3+6Mzmr+81RLOx X-Received: by 2002:a5d:4452:: with SMTP id x18-v6mr7328741wrr.227.1530864751463; Fri, 06 Jul 2018 01:12:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864751; cv=none; d=google.com; s=arc-20160816; b=BqioyiK7YpesNrkXggryKmS/j9ecsvgJL730eBlOylkeN+A8pLRRTWvVp1eabqznIF zhFXMVgQCvsHg9Gz3EBKtgHkSOkuqeAv756WBjqlmlyh3AzxXt4fCaa21KnDDecZBiqD xj0pRbIkXpPszsk1jOZAul8yqY0P9RM2pUx84skB7ZhLIY1vAa/x4ptKHGx9MgUCKnzh yC9Ipv8+zaG0LfDo5ZZFsGQrXnQymxDWmpTJxE7dqYulP6oVAAOfMGalure7XpBxZYEq WEXu7RFZdyoEK33VmH68o7ervsIlSkjQmeJNTy99xAFVIgO1ZI6t/Q4J7YEO2X5F3zLw NogA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=VM/Y6zCa7x/eeaO9INYVT8R3qtHuT+ev3wbrH2sTeGo=; b=bA1FFuoMibra1kZyTh8i8oN7cik0grwyj/lp+hUnXT/pf9RV0psNFjA6n3PU3kKs6s giO1NUzxdzn9h8FE9SgNeW8ouHGDXyrDOVZDaDOIMnAsLfhoRIfYxqKfvRzZZ0qTz9Bi N/Lew9K1O0aa0icoSpNPjix7SIYo6MMOi8BpuIv0D9wbVG945lmk38DswP5LfGihnx3r jfqGZGoOGM54qqbIjE+dIgGKezSYXRH92P3DPmrlfyRG50ZGWbyaanEFRpvG2jJgR11C k0s6mXVEEl3LCb2VMKN6QiLCn5VvlUAQI2WLu0l94xQ0VZkCsCNqh9b074C756RKq/fq 504g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=vAkURQoc; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id f198-v6si6122172wmd.27.2018.07.06.01.12.31; Fri, 06 Jul 2018 01:12:31 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=vAkURQoc; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C5081C458; Fri, 6 Jul 2018 10:12:07 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by dpdk.org (Postfix) with ESMTP id 265D41C43F; Fri, 6 Jul 2018 10:12:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VM/Y6zCa7x/eeaO9INYVT8R3qtHuT+ev3wbrH2sTeGo=; b=vAkURQoc/9GHUkoLbRt4PbXKnQo+SykJHPQpof1PGF+CjvRZpTGcJDdJ0qs4snUZBZ1pOkBZkbQXor1nJPeBP8HIQlTwuFxnlAn3d9gQR5xMQ/SLlLLKm3NmEy3X6kwdYMZrEnlM8qsvG2osNlmni/0B9ALL9gV+NwPE9TSP6Pc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:00 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, stable@dpdk.org Date: Fri, 6 Jul 2018 13:40:01 +0530 Message-Id: <1530864613-11754-4-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66d75303-c442-4e46-f30b-08d5e31826b8 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:kBlXYSM2POK+2d/+LpC8ughmdyYPUNdq/kLu8MD6Z+ZxJvMiHgoySvSheY517f1LehEZBdaWR3+PuD4KJfKW4aaK1LCAiJ6jf2YUFUMeUXaUQx/Mhu1c8WsW6lRTcn7BqrEkA2Lt8uUtOQSX9HY5zDU0u+tTk0XoBOn4AGf7S+LMczpWuUCDMenMCW8HHu1+8oW7KEaRGZy5UmbfIrnziF0Trpyl679CndM5mLJw2k+acIwQKUFSRQWnG2GwrnBp; 25:W3j9+8gTlUdIwFsyKoBEITMdvDtSouLHmi6b8A/JUwhUY67maAE4K3yRgKcM9s+EqQq/d6GluXCCXP6Ds/9HyZz54BYKwrpTcAPDM9NyGbTBZz9OP+9MRF9r040evwZ235Kf+7JCKr8A7CkFiufCXMNFJYD8nygu2GH8LSX3E8jjKc4Sq9A+sPzcSQ1mjVm2u7KyxzMlqZHQil/+hFCiRu6jDVOpvrtQPU9HbNBpL/JMFZkxHKEk9777ZhORlkt5GqAO+xq3l+8F4fLya5Dt7U5WpK8JyyfsJU32bopy/ePdVWYTmcAJIJ7QeDar9FafntKj0Gv4Q9f7yQB3Fxdctw==; 31:lz0c8CNDxDwezda7uIG3AqCE8YT0CD7TUa+0lctTjSAg2H+/NmBCZgoaaSe4xUg8VkTim+w7mihF9lIOFgl7VeinQ1rqwHGqG8CrcK45C6k8HKGVEdAoyYGNwD5MXeM1+nx1PVATahLTZSE8P4AU4Cv6McvuhWuoDpA4cC9mnAjZRRLgSIuN1GOMFBWvknsq7CFaajiKJeVWwQWs3GSQGT3QD7jK8OlUP+WXodRp4gI= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:epGR34BBEq1XutCD7/GMuvxTWRRf/wTeoQPc9Md9fgJc1uQuaW1ukOUlOFRtZ4WNRKma7l5aXht7BL61uNgoAiMs1RjSjKYvIwdA8OVBLvF8XxvR8z8cWBQatS8zKA5RB9ADvcAJQKqBOCEs+vyf5UdAlB5KWDylcIjyFvPXeCjHW5idyy7pxFRs7hSLuLfUk6EwL6ZyDl7Tn+4K0Lr02X5C1EvsDy3IEfH78G5hkuSWyMf3bpaLH+BBxGxAzYkDe7V0JmpsHky3A5Vo/4urQxIzO1JYDfYIICrxIgD1eV+jZM/A/wHvyML8oWWDNrhfAkzzKtk8taSoIgyYcOH7KyToxvxithuelU3o6ZA7SudPd0bdB52lCNAbQr3eP4hvSLZIbE0xlLICcLyItQpoS1zNJl/1m3D3jFPTLbSDUaGVuUIieHAPvJyyoJ6fxPSrXv2CvalW+6WhsRliGSd6VICrt7WfOp5+8XXtOPgng+BpSj94kbxRd1dkcCeJG0hh; 4:8n4inje5Okau4weWIzjzgXvC0QMnTEW2xsVJz7qG4sG/lwnHNZDaVsFCDD+t20/e/oXtgCT1T8A6KOwQ46aEbAY10eQM0L3cx9TdqlZI6cdb4hfsaIN5462FQgi+YtZOVR786fG8ACJdJxAtX58N/se+guDoz6AraWutv3o+3KDSA9V0LNMy9qDzXpXIBSUMF9mZmg/Tu02E8ApUeJylDbPmdqBsQh0Rwr16eEL8vBNaT5MVqBFJ/i0rlGJEchngg47sC7QxXIYOb4xVua/UlePC3xVon8Rv45Zwld4OtgAJ/9UEuQCJU6b1RV73ceAF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(4326008)(5024004)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:791lE79OkA+l5cpTU7Ob6qkZPz0yupRioQ43H+T05?= gARNg8PjnZJ7WRpy+Ch6m36fsaFnns++WyTDLZtkhDxM1bf30zWZCOdAjoBiLDGut9JmG347GpCRZX5HYSKKiwEAenViQc821FyQ5nOumwMBPpafuzEWicnW0O3uypEV8dTGAxfBAI/ba9EiHIabF6sbq2u5uX3nBpgebPiTtFmmuVGZemUMXUlnmTlkoia0if0e1p07VReulzSBkLYEs4QIvMQ3iu92+UHblowlHFed8z9YGNpCLuTDfLL1qqFXlDGQRmZaahuvAAZBImc9GVCgihUo3t7/PJ/h6abFiROVEaRbApUA3ARa1VWdG+CAQJScU0+C791K+KjagHGARkw5GWxbSbEBk3OIk+BeuGp/aFGhUoYqHhWRoVEv89ArrCe+ygZry0M3d4pbir23RdfCUTKm4C9aMnmFs01GGoO4zzsrOBJdYRF+PDqOxlpScrRhzWv+qq8Uxl3uyo0ilBM2tShM6cnff1z0J2aBwUvdcTL6H+flMIfIGaoHtfa86ffxx32uCp3XL9hkycaA6xGhhOD3+2PMzr7MqfOzaCs2T2hcFBiIAfaCH+0uLq0HCTLxpnHIL1GwGAbrlADvBy5MWRpnZkVSI3AjUOBYIIExP8cUg1sjg3E1gBLIPfmP112NeJQ7r8b0eIopN4QlyH5JYlHFtXO8PQVEcnT6CCBRbm6l/4ehDH37OzPcuVcf8BkK9S9gj4+GxP2X3Z2UZQrFiIl6IhIuF2Hybqypvrzw3pMXrHC/ZInyXkcaLoq+JHg964qGgQLvOLX4wSVVZDSCsQQM8pNIsZSd1+CE6TzwWBvDHguNtK03iTCD2wKcdXCMMMcc6AWg097vgFiLyWn8x1sqeGt0/rz+sEoMObb7XMbCHr5L2ujib9Cr5jcuxCEoGUk90tDof1oYsU/En6RwcAt5/SvZul4eJLrK9RKIRi/UJbYaLgDg6mrFDV8wpWcKZnPSW9Q592iz/d2sQLAYaodwdiDO6ngYKFFe4wCFg71aQQFLIsU+cvUhSnXmdSUbT+zDHqqlOicLqNkzgHtsFd3HqFjrdtjDdGHy1dXhNG0/Pzrpnbabtuk8mCZ7s4aDZHJrKidoLMDpp0tcgzOXOea9U9CArXZ9oaqiTTxnOfFhdgXoTXx9QOfmyTk7SjBhOg5m02ULUBxhMlsYSA44nbokDsE6H6qd2WdsrDvr2+fFDUUSJGgAWk7iClk35vgLGvxhUCAo5SPD3RptQ518+VzoLEDBCdMZCt1pS3V71nD8PdM42ZYwM/J9FJtuUKP1lMnUyWg0w8ziD74aeyUU7JgN/oF4Tp7WjsQIW58VuCs/COJBgOdcbv+2XgmugJ6eA7LfGGBM728DnZWhHjX0hx7hVT4b66tGMBb7OcIGA== X-Microsoft-Antispam-Message-Info: +p238KtePdaUqS26pj1Z0o50Kukyx60AgIrUyfLIAI+zcqec9UYL/BONsHke/XRQW2T42Ox/47aekH50fI61ZDZp/Bl9v4NM/9CbwCoqUWkN6XyUtJQO32AvJBWIGo4XMnNZuWDefh0eQ/MQzNGDecGGUIlej5PTFooL8VxigOoSPR5SME2yz0qLjXOuiaRSP2e+G6JSaDOyYECsam1uedskXuw+ei14/0+/8xWJv+Bw7Jr9Wv+Q67PVZYTYASyvCUGDN6251rUHONQM7qbK1d6s72hwZzp4DEnTL99ceVxS3r3BBXLTP/JryaMef1AXpRfTadTHu58KROgP4P4dll2keluSO1uwi7BBX7obxEo= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:UHWrcPBEecJXxzpvIUJNUqRMeA54qRgh3xLKAkrEwkVyY6Pfg7D7esPDPWaX2BdxjPRmK/SO+aIpunSoHr1SAT/isjXmeWhe26aUMMxerVtdNT9bmL136freSBvjMdEepEVi0Va3N9e7+h7McZIHUCJ6vltmNbs7KWaxCzyMJaeYtDIaW5m70uwNxPOKYGNW6np+QtVhptylarhAAzNLKKR5lMxxpQjawYR9OOONw1BxnAbWrg/juqM4C/3XIv3jsC+FxsEt0PRHNKexNIGLjDzqcXiKEKvSJT8Cd8TsnnAznOAMYHhlj0qxc0iZjiwprdobazG/goypFJl0ZZXSK03ZL1apfNQZbs/3E4Zxe6Zki7pIWp4q44Zi5KGpfpGhtXNkaPNG0xMzj3c5zQEBkm3mhooXPbsJJ+YQRGwuI7Q6+r2kYAW++vGBiN8Muy1VsXYsr3qs5fTh3e3Qu9BG8g==; 5:xavOM2Buh4UqniMArmW0tGEVNUJYxbgoIoI+pF0aUmzd2rdQ/Q5cwsXigOrOCcGjDQ1IpoGUVRd+nye0X0HFz/129lEz769i15pAfW4N55vk897FivWsAhlWQsUsUh3iv7vHQDm9VV69qAjEH2UBoI5UVRIdS6L7GY7qfusVk3M=; 24:LsB+yrn7uqabArej5+eXfylxbGx5L/5MXy8DTaye8D4Jf2pYPPO8yhMBVBd7vZOFtBVDM0VyPlpRH1NgyZQew9M4nUE3AP2RCRReqMst2ug= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:2QldV1n3U2r+1t999Ff7H4aHgSg6eDUnSFFaqyL0V6uKjSPewoW69i0i1QgRgKnZbTNp8U1o5tB9VRjwuB1uGNEKGVQTOATOdCuOYweVzjjlp/SL0DaipCQTKt/W/DyKu2VfjqOGCTgtnYVuNtP/Ja4NT6A1Ez+BDewAALCYQhNA+//aDAyRU/O10/yBfCZkE3c+7V3sJOpzylnwFvc7FmB43BL9sRldpJEu+fTCRisLCc38ylHYjaMOI2A9nIrg X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:00.2421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66d75303-c442-4e46-f30b-08d5e31826b8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 04/16] net/dpaa: fix the queue err handling and logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 5e7455931442 ("net/dpaa: support Rx queue configurations with eventdev") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index d014a11..79ba6bd 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -516,7 +516,15 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, PMD_INIT_FUNC_TRACE(); - DPAA_PMD_INFO("Rx queue setup for queue index: %d", queue_idx); + if (queue_idx >= dev->data->nb_rx_queues) { + rte_errno = EOVERFLOW; + DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)", + (void *)dev, queue_idx, dev->data->nb_rx_queues); + return -rte_errno; + } + + DPAA_PMD_INFO("Rx queue setup for queue index: %d fq_id (0x%x)", + queue_idx, rxq->fqid); if (!dpaa_intf->bp_info || dpaa_intf->bp_info->mp != mp) { struct fman_if_ic_params icp; @@ -580,9 +588,11 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, opts.fqd.fq_ctrl |= QM_FQCTRL_CGE; } ret = qman_init_fq(rxq, flags, &opts); - if (ret) - DPAA_PMD_ERR("Channel/Queue association failed. fqid %d" - " ret: %d", rxq->fqid, ret); + if (ret) { + DPAA_PMD_ERR("Channel/Q association failed. fqid 0x%x " + "ret:%d(%s)", rxq->fqid, ret, strerror(ret)); + return ret; + } rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb; rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare; rxq->is_static = true; @@ -657,8 +667,8 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev, ret = qman_init_fq(rxq, flags, &opts); if (ret) { - DPAA_PMD_ERR("Channel/Queue association failed. fqid %d ret:%d", - rxq->fqid, ret); + DPAA_PMD_ERR("Ev-Channel/Q association failed. fqid 0x%x " + "ret:%d(%s)", rxq->fqid, ret, strerror(ret)); return ret; } @@ -715,7 +725,15 @@ int dpaa_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, PMD_INIT_FUNC_TRACE(); - DPAA_PMD_INFO("Tx queue setup for queue index: %d", queue_idx); + if (queue_idx >= dev->data->nb_tx_queues) { + rte_errno = EOVERFLOW; + DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)", + (void *)dev, queue_idx, dev->data->nb_tx_queues); + return -rte_errno; + } + + DPAA_PMD_INFO("Tx queue setup for queue index: %d fq_id (0x%x)", + queue_idx, dpaa_intf->tx_queues[queue_idx].fqid); dev->data->tx_queues[queue_idx] = &dpaa_intf->tx_queues[queue_idx]; return 0; } @@ -1016,7 +1034,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx, DPAA_PMD_DEBUG("creating rx fq %p, fqid %d", fq, fqid); ret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq); if (ret) { - DPAA_PMD_ERR("create rx fqid %d failed with ret: %d", + DPAA_PMD_ERR("create rx fqid 0x%x failed with ret: %d", fqid, ret); return ret; } From patchwork Fri Jul 6 08:10:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141265 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835026ljj; Fri, 6 Jul 2018 01:12:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdI+zzTzJ+wfePWxAZfaQvmEPekQu/SXfxCGSUtM0CctkYUKqiw4GQLJ17xnD+gyM6FQg1a X-Received: by 2002:a1c:d750:: with SMTP id o77-v6mr5480789wmg.67.1530864761563; Fri, 06 Jul 2018 01:12:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864761; cv=none; d=google.com; s=arc-20160816; b=TN2bsYO+DTlNPzWsPgbpuDjT0zQRflEKtw7XTblrnBzgcrsDNVfHlwDiUTXV8lQAE8 ZW+6LxO7g9rWgT/BxXzT52CDuYseQOreIrYS030jgRlAnE/MMvo/w5TTrNszXEk24Brm PugO3T5hRSiG8316t6QtGQ5uA1fBDaY5IJl6b49ycoGh08uYghQnRnvCTh8QThOEIp0h qKsPxpbKi8xOwv6zNt+6jTW8a/dBvBlM3BpjNFTh+Ced4vl1q7X/VM06qz46sV9OVJSr XhT4o+WQP0bUoDj26rGd9MUS7eFPMRYdwiDOl71EUe4LE/eiB4vXVTSqJMCJ6XlxtZqx 1I4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=MWTxpKvReQoRM5Ph77r1ZW302bvBShlMaY0A1PlFdos=; b=ZbXcYZPF5W75eTHtVrB7sGOdS7pVpYbBPVXopmXdgCoMk6TDW7s3mhtL90jrvtUf9y G2eoF3H8eRhOkJ9RmJ4gOHkeBYUmq47A1RodHdKXXIDoCSS/PNMmykAzJBwvwfXXX3xF 4NZLcjS04F7Dz6m4FCJjHthd49oRizMG3ZXu3Ak0858XdI2M4z0AiSXVIzDLITUyR3WW zuAYGrtwdgvWTwWH/0UxFWbHNlv0Ix9pGMpBCjtmBwkTH6R5DgBQYPC+Z9MoNVBm4s+L WOYDviqacOTEJ0K6zv0wkr6BbK05pqs2HQb3kj9Z2SOuOxQMr+tzc7uBTHRhg7rrSIOb /h2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=dLcl7MZ8; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id v18-v6si6119435wrm.102.2018.07.06.01.12.41; Fri, 06 Jul 2018 01:12:41 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=dLcl7MZ8; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 962531C460; Fri, 6 Jul 2018 10:12:09 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88]) by dpdk.org (Postfix) with ESMTP id F27B71C43F; Fri, 6 Jul 2018 10:12:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MWTxpKvReQoRM5Ph77r1ZW302bvBShlMaY0A1PlFdos=; b=dLcl7MZ8gaXH3fMADSin8FChi+OGTguaAcxnCdP9yfzALcaiSM4bvKym0dHmL0V4cSzlZp06BqxXx2ZdVEw58tFYg8a3J0sJKAZ2muIdPLuEgT+ZXV1dpVUzyLRi91wbG3edzapJak/OaTNBWwDGxEQDf/PRUqHRBLPwblpZpWU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:01 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, stable@dpdk.org Date: Fri, 6 Jul 2018 13:40:02 +0530 Message-Id: <1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e92f36c2-d669-4f71-e3f7-08d5e3182783 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:1mRuNNsGOc5I9wS3U0GJ+hrb14sp1Cbg+3UHlkKN9DFk9ByCyk0Tn1hYNVTpRQmGoubczEhaN0BCndmQfJUowjxsX5JQ03G2Gc/OQk039Bt4iOUKcC3m8XAf4zIFH/aEvyKgGQmttPXuPJiZA4ipBtXV/QWdfQbdGcwK0JJWfD8jqaat7SYSnrlBdWO+5/EmFvBfrezUaVor9v+CbYa0OTPXBbBindfCJzVGZiGI7HwhXXD4YqgHTioeMVKY5n17; 25:L8WyMt0wM66TpwWwj5MwNUMna0PSdkTn0+atLcZTsSk39uuxqCRnHDFMEnxTYRLSEmKJFTmkgbsEOIMwU3bPsZ9szjvKI8LMOIMeOKHS8PlvjtENZMHfV3uggdXKE9hFA4RmQByTid2u6ZgQJPx52foAmt/1kyWHjTSt2Wf6UICMltdm6TOis92jzderdNhmtFoOP3DTc83wOXOfpNipZYw7GYXo6jBe9cpGD8geU761Wm1LQMq+93xHTdU/8by5LxC+LyrJhD+SmRV5RSPcW4wzG0Zmv2Od3YSzwfIqqrjvc8K1Of6sttKyd+owuEwFl6iTItwRbEQNJPSlKKUtyQ==; 31:hVfxLpw1VMre/REfM+z8aqS+sbPLqYkcdAxrTkltMchk6MpWMkFzLB/IeK5PxEll6S43w9njuS5iY4wFpnnih5Dk3nB2L5AEcXm/nu+q1KdOtyybg5ujfcqPLZGH25MEjyckfr1dk1DQgs+/NWZfC3AVWzJ2MWxJPXqGwpUSuKcO3W3XDQyCx6If6KklNkQUvvcxZs3rcJtwlJPMKuKtjFg1IGwW+0So0gQa6mtK1Hw= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:al1glhk+qWkWTrts4ZLkX0t5TWR0KPqoB+CdKX3u/F/Nkzsh9Pg7CsflvC/CjxEV3QMziyQKHaGmYHVTSfcFfKbFARmePGiQvz3f40TUSh/mOiPo7v5+S9RP6r9MvvTmR/PgLoBJdbCHcjt2x6FA5Pp/DZPpVWBe5ncNNzn2tlEFOKjp+IvMBMQrnjoY/mG4AJ6aoHWP/pP1ailDyS0zkZJyAhi2L35qNuBRh306IaEW4hVc2WM6uqOEmj6yD9SKc8MOk+OGvraw5QRRIuQYTfQyqE/JdgYZcaR3xzYmJvCStsbRQ/G3mlk99b6zVYTc7oCBC5NZ5BDgdP+ekUkJjB9qkh36bjPr7DuiEHXIsX1i5oKMW8SfJHWY0RVV1Js50HnLs6YhL8Y1LOQOi0dMUUbGlV71wQeSfVzLErqeDXBHyglg3KEs/ZkSqP+1nxRfyumfxue6hfzGzDwy1EENB4LI1AXfuNU+gf3q1RiEZWCmeA6v6YZUqea7O9BedaUI; 4:O2QyFfPHy2l6pcLompx20vzkTpVFpGbNf0LGqbMguOV1H00PanumeWtBtkf7Yg0XRVSpoC/KY/m2C2I55S2gIhTX0ru/6fBCOjyVCkOJ+ekDpl2VXMNRmgjync3LxzdirLeIQTu/TzKDKFuCeGo+uirDqGwgL2ceF5ec8Bs7MJ62QCt9apOKa8jBMh3RrD8gbxJhKD6SFQ4+EofhCQynsHdmmHFuHGihIQyzP7yLaROhQP8o0kM8Ct9kpDOPqR+85ciC05NdCVvVBnidjqRy2jDmE8ffA+xVFt8RCPHMLBbMYxuPmfERjCGTkVl/jluy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:0eGnOqlGF6miKwEj0GUFwAtxt5jmfngQzllfB+8tC?= uVwZop7D9qSNYMjD8X5/PsTZelRq1yLs9JSoWWVChhRkUN2O0ma/vjjnJVqWazsKbjXi0BphALmi06SPPq9MIp++NcGt+b/HeJWwvQgAFDe+tNmvNehaP43TdUojbUN1NjALUbxsnUjiEHfoLHSFhevjNWs8BtJOU0FuYhsUvtx9tnjvuYMjFPSHgNjk3ZgQqYs/qEQztc1Kr6EOtcB0eHHRXcMRHl5MP503iEPXG86ibd9SiZF14X18SIp64wcKZlByGUS74ttCmMVhl0uTboC5UodC6QRDS+teiTPc6E6Yl0TkHshX5jZ39bY56ytuLsQ9o/cxLJIISk62RRPHcXjDPP1Ov/8ywYqPzrJv5A84whSOo7dgfp+3dyzv4IOqDAYhsmeewhjodLAEMJTBqlQnduJ0Vzxu66ySWelg0yi1A99Tr+OUXzyVDDrvE86VD+U4vJ4eFL0f6PT3xqnrD1xmgKvWolrTQWJulpRJwynEXJZ2PdRMnOBPdqZKoIwPtdbKL2jq2+kBHbZ1+1DVi14CC7DJ8I49ZygZP+Qkz7YQJ4LD9MlLM7XLWdi5dpoY6OZa356SQxGBktkZPzQg4BH2CLQs6nxgl4ALdCqyHKxE3nEAJalY1eOTDaT77W4lRLrF1rtX//f5nTV/c00UW8EOvAo3to2DP+k8uaRACLUyauRKKxmTaOdhArBEkl+EefrEDJ13z/Y6D3YTbQlmS9KAE3wdXCndU23+5au6G236jkdHDLo77LyS9kNxMrSsQt9cFniBIUk5OohxNg25E7wiGgGNJw2o5NiP9MQCjbTResoeg928/AR+INc9V9f0OsuAXB0cp1Bi5lUafz53Pf5pV1OZoLQ2wGTpUOklyUb1qSWwVSp83sZjVPPhgObpMBqwRzZI0Og4dLOmQBQbKrvcdxdv1Dq4QKy7WR/6YkVZzZVYT/Gp7wQyENEEJSN4HUMQpmTU1X6Yn/7hnLPJn/DYOqUxorlMdTvChxcRc9nBUcxHIvkSss+aWEfmkbslArd/AczPzJGm2hbgstyDE1xLZIrvIAmCPUieo64TEhVowpJgWqT6jNvWuuPNKsx4BaUDshSFLXn8EXi3qTw9UPQJDEHOf33WUC2S8u554PfH/4a9px8yzXUj9SyRz0IWG9/HrW9MZnHQK5rMLmmZMRGaWAZEI3ni1s0VEGexznLQd+9osIHxdNwzQQ4M7/86e++VeJISrx2v6H7RswKs/JgGE0ygRl0Ygi0P1JaOzPvWhHl1kpD5EGkUJ30vH8hORdKvRTMycOSOZ2QXJoNa65a X-Microsoft-Antispam-Message-Info: BB+q1/mpFca5TrhERcX3YFBV4XR2yOKG2ge7Ai4Gub7IArxlDUCsh3x4YqSdDx8LNgyUsIr5FoIUcRPH/I83RSqhdhVsfz5F1BFJNT1TD5ZflhFHf/m0PQPelHuFlJTC1ocwGDD6teQZprmacBs9HVbRMwguXN42ZZWy9fU+ROWFjkDLpUp5H1N9jVFElYhyy1keuFpCq905RD2GjjVcxJ0KApOEND5YqnrBi3Ho7z6juiEFZRBFFMU1guiivXOxLgkw8ipjeLhpjB+ElA+3dZh3u2irzQWwE169Bqb7dktyjotiEf+gCLZVMMjhK0bToHkPtwyAb0Hb4SqGnIRbpjOQorEuOB6C45GLzLJ2fak= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:x7eBAyPJBLSAJZqx8kqvU+pFd+rx8Kf0hdMfASrPSXWJHL/EvQ86TcJ/gKGEdWqqfNdCE2U7lOz8q3VYWkSY4UV0DU4tqetlhP/Oalz4l3oICBXHHLu666Ih1Ck8xnspKtGcmFij82LHmYs9aaARwkVyg2DsXtgiXl/JKIoDWF2Jmq8U8lIa3Ndc87opBly9074/m7drYeqvW2FaR/uT7zEhcC8VUXYgKtMDfwNLYqCJQX7NddP8jNVHXRqKc7xIbsIwbIc9XShLWV3QhE2aZBKQIgWr18d2XfixNR+we4mlnDsLXLvUQ5talXEExzG/wAS8MTGmvTepeK4+jN4jTcU8ytWFG02jBDTYienufl5cSBozMJUl1G65Tk5NIN7evCetAks7wttZXrvYlx3Llru1SVuk1yJE6HTJgl0Y8uLGg87qlxGFExT/3U3hU2LWABfz/y1AsFcLelD3xu/2XQ==; 5:rgGR82qrz0qzQbUqhmhXWZsf55M3m85vR7X5/lKm0rc0J4t9/R/3pJn5jvpL4OX6Iwp1ymKhGWeA7pcCyP0qAoHKueb0VbFReg8mzljmYJhDmqm/N/ATzaS3jCoUTf5AAsC6eF79J1H5CBzkVqHQdG1QRI7MhOVFmrv2XuHi9hk=; 24:E0487VEZUS8XoF5nRMpD221ftzeM0bdEhzbasktH1DSFd15cm3j+K5Ofg62ojYDxJ0QHzsxwFQRubSppqr2kjENh6WtaBbhdvg9uLXwaj/Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:bvaSi90BJFqNBjdrcML+DzLUqoQaGTalAC7V0TrBQw6MzYXEG6jPkUPlyQOLtoyJ+6F4/dBX9m46KQyR3g3/2oOccegtxz7Ig5kI4EJ0PtdC/5/dJjw0JGeA36VBR+18Nn/gxUb4iGGlK41M1F+/hYPnUoRwM32OInbwv170bEtzbk/gDDIv5XfCNNKuRJAYC0MWQnpCzGtvSVGRlVGpes1yO4Z1Kde8bB+qBzkdhlnJ439Bfm/if8nSmyzWyHVJ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:01.5661 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e92f36c2-d669-4f71-e3f7-08d5e3182783 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 05/16] net/dpaa2: fix the prefetch Rx to honor nb pkts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes prefetch rx routine to set the next prefetch request to the size of nb_pkts. It assumes that next request would ideally be of same size. Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_rxtx.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index dac086d..ef109a6 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -447,6 +447,12 @@ eth_copy_mbuf_to_fd(struct rte_mbuf *mbuf, return 0; } +/* This function assumes that caller will be keep the same value for nb_pkts + * across calls per queue, if that is not the case, better use non-prefetch + * version of rx call. + * It will return the packets as requested in previous call without honoring + * the current nb_pkts or bufs space. + */ uint16_t dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) { @@ -454,7 +460,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) struct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)queue; struct qbman_result *dq_storage, *dq_storage1 = NULL; uint32_t fqid = dpaa2_q->fqid; - int ret, num_rx = 0; + int ret, num_rx = 0, pull_size; uint8_t pending, status; struct qbman_swp *swp; const struct qbman_fd *fd, *next_fd; @@ -470,12 +476,12 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) } } swp = DPAA2_PER_LCORE_ETHRX_PORTAL; - + pull_size = (nb_pkts > DPAA2_DQRR_RING_SIZE) ? + DPAA2_DQRR_RING_SIZE : nb_pkts; if (unlikely(!q_storage->active_dqs)) { q_storage->toggle = 0; dq_storage = q_storage->dq_storage[q_storage->toggle]; - q_storage->last_num_pkts = (nb_pkts > DPAA2_DQRR_RING_SIZE) ? - DPAA2_DQRR_RING_SIZE : nb_pkts; + q_storage->last_num_pkts = pull_size; qbman_pull_desc_clear(&pulldesc); qbman_pull_desc_set_numframes(&pulldesc, q_storage->last_num_pkts); @@ -514,7 +520,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) q_storage->toggle ^= 1; dq_storage1 = q_storage->dq_storage[q_storage->toggle]; qbman_pull_desc_clear(&pulldesc); - qbman_pull_desc_set_numframes(&pulldesc, DPAA2_DQRR_RING_SIZE); + qbman_pull_desc_set_numframes(&pulldesc, pull_size); qbman_pull_desc_set_fq(&pulldesc, fqid); qbman_pull_desc_set_storage(&pulldesc, dq_storage1, (uint64_t)(DPAA2_VADDR_TO_IOVA(dq_storage1)), 1); From patchwork Fri Jul 6 08:10:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141266 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835269ljj; Fri, 6 Jul 2018 01:12:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeBURsVOCDwnG1L+IvH8Wy7hFewA8DIIp75JDuEtx9+b+kAgeQaPJnQ3A59FQA3PAVFtLGF X-Received: by 2002:adf:a285:: with SMTP id s5-v6mr6323446wra.114.1530864776242; Fri, 06 Jul 2018 01:12:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864776; cv=none; d=google.com; s=arc-20160816; b=M+V9YTTSlnRjfxudfTU1OHL5lXsTZtrq5n4Vd+i+TJqagoKP3fDbtGGRUa0HK+ALBM dNgu/TWSvA6AvFEkSwCirvhSjZWQ5IYad5GDhB9hI/mOGUPVpYYzbGKIAG376RLJ+0NI otBqaChzidSXb8GLvCxvfTo1ZjsFQEh6D/bS/KiQW7mnGQ2P7Th3aCBWyusYGNT5E+Iz mPIaRWjMGH/kGZng/Lu5JXRfMzFzd+4QNTD0tQxPKINkoBNYIheCRxOFANBaoBoV5kOo u8SNYVaBKr8HkxVP6lmRY5DdW4rHXWYoDaWKpklGAOYCEEFaISSO+P22bII4DWFvMopz I0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=DF6V9T3FvcVErTEAuA+ewU/DLm0PowqPkQH73+gH8a8=; b=BvmaQmc0umTQQl8Xclm9nJvUC9lFBe9R4P4u8CFg97F6oTm/h7d8jEy/8d5+SapLyX hiUeiolzD0RMBMVEUBO9sDE4ZjID0zkYOAaewRtiNbrKoe+LNqdyjMYnzW79StAzy0L4 TJPSg4dyQeLX+ieMrIn5WNIXJuIM7pT8lhSLeCSfjE9fKbqVQpFzZi9McVY9fxHfd46p usPXV+mP0yfuf2bkg5M+ud9oVoXZayEliYvRNCmwEpEiZ7+f5QBe/JoT1EjPyF9pCRc9 AAeXdWxj6zHUMvZfdUNCX/yc4w1mlqpQz7ofYdU9WCyj4Pcktrn7qaIdN7hZWfex7w0U rK3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=D+q9UkMK; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id b7-v6si3121100wrt.307.2018.07.06.01.12.56; Fri, 06 Jul 2018 01:12:56 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=D+q9UkMK; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 738EA1C47A; Fri, 6 Jul 2018 10:12:11 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00064.outbound.protection.outlook.com [40.107.0.64]) by dpdk.org (Postfix) with ESMTP id 42CCA1C44E for ; Fri, 6 Jul 2018 10:12:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF6V9T3FvcVErTEAuA+ewU/DLm0PowqPkQH73+gH8a8=; b=D+q9UkMKs1iDGzYq6n8YkxybuuT1q4nWqRvHdsJ+Ls5bzlXtG8j4s8GZU5J6eOUkrs30lZSMX6NJndPVmWz1BM1AjrVEs43HcEfZgSrSdlFuw0FzqCgi+pLh6kmXunYnGeaBSmY4LtxdVg12hTbULieIVF3UUnTeU0aEAMXJLFY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:02 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Sunil Kumar Kori Date: Fri, 6 Jul 2018 13:40:03 +0530 Message-Id: <1530864613-11754-6-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f48c23af-59bf-4e6a-13d2-08d5e3182857 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:tERCuhXcUQHqikyXKbguY8rIh3nMC6HQtGnaQ6CQkupccfbVxw47ah5AVn1P5wEc4U8gj5vWxLrt+jpKxa/SSG6QlzajmR+tzYrrl79Tb1AWXelwQdUO1nCWIsl+xM1Fs6ROLgyXZxIgDqAQJZPR8AFVMP35StfSmV76p+NfS8YeH9jknWtl+QO0PdxOASdLRgsuD1XMbr9N2FePMTQ0Icq8e38KdQuYch0QadEaJDoo3hDAoiGBYAzyRZ7+kd6B; 25:4en2eGMJqD1ycYMZYiCyc2BEKwopKsTbotx6j8kmXD+z5xZpdHjTcSzRjqA8azluDipXXy7S7A203XFJcYYphJsQI4+as5WEbeqhy0B9ilaciRZt8aNanpz5ExAp5s6JbFFIPgi34MQDd+k6CUUXppy8okLMvS3LDZAskCvyluDyCcx750RHddMYpy8LgnWJz4VlVVkkMw00xnTIEmq7GQc6CwnTpn4bc6wLi7NuSsJuathhAh3lm9v++lPcW0MCVNd9cMzDvTLRL/4xvmXQ4rmJTDVq6ax6XAh/eVKPC0wUu+vvGvJ8bNg3WkhXfTbQFGesdOuDYoAZ8wZ/5Dzh8Q==; 31:pIRqBJ2ixrnrd5sBvhOasehGeRRY/HAqaSYkXFbwx1SS+m3Aakddr/Mu6c1hvUTCtmCE5X3rTuNEnfH8Tftkb3B/R3LcigwN1meXiJnHTZOpvKwVaDCdIDg4DiDVvXCjZctAs6eL/QmYO4ront+wDAmZ/pSGirMYhdXkiNln6Xspxt9jR+mdOD0qVyuZDwyPVHeQlcfgleXn9rrVknK+SCRNWjMOzNXZ3aekXzPUwxc= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:5qx0J9tLjfcdCto8h/9bnDj6HIlYIO0YjVoysOPZymasWnG6UIY1X6x5C61wNvaHTrskpUeHHqoywxePV7acuOCa4PelT1jnEMNQNcRq3RkvWtLC0hdDzQVD3EaE3Y7hKvOTVE64moWEkP5AjbPGear1fdxKwr53B2Xf4VTEk2W3znU69l31AXzJkgC4NcBs+hpxbdA+78lpoJ9hze5dlLaDToov+XuPWjHxeDFlXYH2UnhdrWrr56xHbomapUcaElMrGRriGZ3fGyZ1hvQ4KL2Q3V8bqfltrheXCW4mpEcVRan/6/SyvQTRv8ocfWEtXY0z4K7vAQMPAdKUDyOfPSYvzRdomwpV3R8S40TgKpKXch2rxPBNbnc4ohvECBE+MrLvZn9Q2U9GyHIKo4cdaxGha7iHRXiCnHxKPZxDBElDhUVmz+QCpo8asSCSuXefgiK4+3osApuS+Oap6IRFrA1h3xyHCz2LRA5ibiRyl62bqUvZLA+nGfgDhkwd69Ip; 4:ac7Ha9W1uLu/HfBqI7e9WP3J7iawT6sXigGJZ27xzY5yPT79KKUSCxMCEW92ixVbRy6AweFkcWTwwdQSeCu6V+RSezAYysgURi6AQFqDFBjEPNZc3r1rvgbTqdihD8bg2Ukm+JeaVtgCy17eKrKmgkZrFNsIBJg+xpe6P1HMOQ886O58UK1Ef4EJQ5UR3HuI5dItNOkjuUlqxBIac6agkfLRR6WZ01BZePAMxyGUxck9NdXEMbZrtai8rHe3awZVqqb0khPCZlSfsmHr8jQb8PMvgUxgFKWGothcu9idgyxmfJlIlyf5uhyEOHFI9hFx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:vpj9dw+k6EVYYlLcI2bylMxHM4gmi/AznnOiOAcxi?= V1bqXt4B4xyLmvajC9NyaBDCXzTtui2rcr8kvyw7uu8SnB9mL4M4JGbm7wgdnnKjZ/B0F1W92UTcNqKWptY7tlgI/K6byjhqf/+yUJlSBW+idbWO7UqgHQOa0hHwar8mw2BUJ3c1Pck3ZcYupukudcUOKT731nN/aw4AWp0XYmUKB6ByjEMOONxJXqEzlrXuaM9Fr7/wWWzloHXmtSD3sbxj6UcZoPmgctOqbyBUmnKkgRYgitEQWti4AkHSrObvxO91l1ejAWT7/fG9kO4zB0mOSFmv4He156SbmcwS01r/wsr5pQnmCycJnVUK0/kdPV4M+mZ8ACyHeORoUvdhKzr3Kgz34ONdalZVzWIuEVkgzq8hn/l0yOLLVuu8ni+t829oTV3+9jBpJwL7PSqDps6V4ivKqz2zTcy843b2vN+iSID9gflmvvVTuvUpjApI0rzvz/ZAxj4eL8xqDn5UP2JYBBM6C/mraCWPzVQDubUwJi22H5zBUegl6H0zd6FtuA085Nmwz9CmvpavdRrgrffz8TyYWIZBmpB1G/eFTax121rDOEQ24z5g/ZTUFPHJ8dbkHm8Ccg8E3HmuPfRHiPLIVAc4VBd17ke1fQOpOSHM4S/y4ri/1YGzSNngD3sstbsz/j9C/LErEqn5CqteHKLtsGEFH+eKH3D9ReGkijUjLvvM470TInrYGNQDSsswb6cYgvBxRR8f8x7SgDA2zrAhHZzPgHWU4LeWeqWa8ONgGPxCb2v7yAUGqkEotouMGblBNLfRMcDJJ/7HtST9tnuXZteGofHt5yHH0Z+XlDdQnqqyPz9cI6s16T6NLuBbHJRjibgp+OmCjDGsaR/O6WBhnZwkjoajLBL9Xi8mkK8ukDxTaBnXt7iBUH9q1qggBwQT6mSW5VYOf8PkyKGUDfkoU1qYOHsX9o0NQXUDK0f3foZAo14waOVIj6AzWVRtqjklnWqxG3Dh1JBGJCmnPMMZfpNExI7AxsipNtqocFH1t4nDmwzMUffnKtJSP524pmQ062uyix3fmm2dhrSbR5hct94O6IjuIcjktGUOdb+7F0tU1ugKWx4L0aIbLU5wBIFG5rObtaY0UdIf3vfRIs7ZTkLVlM84pGBZvgTWqctmH/46oHY5VGeSY3tZcjNNy60JXb/WpbdGifNM/tGFmcRPE0Ua9PxR2wQtDdnQfMmwh4FPPFhXHRc/UiCZspGLZQ6IFbmZ+CMJIq9rf2IOrHuwkt+cFRN2+W3ZDPzFR2xrHypfEaaoYvrp65siUIbIps= X-Microsoft-Antispam-Message-Info: /oLX/2MxWoF8ijMnrn9jiQxUUJa8N0m6lGNZjGS7Uu7T5GI2Xt5bBYWfoHKTtN0GIr/b/7c2Jws9SajBKsvbFEFquIPmZxeZs3o5biyhltyXCbp0jDwZyz0XcarNv9yqIniw6qdet0q6+F/8qgICT9iBYDW9BBDtFFpCAvWc882Is51lHH9tqbzQYYQnD2+7rTioVHkEPlEK+dchqHjL5948KVWJha0dVI9DYKKxDG8zxSZmP54BWrJBYpAOL9Gl8+xltlZNDES3SYMB2jjW37TGRy9qsTaUoRwd9YdrtcnUjv2Uf3l6F0aEDujhOrwdqWw5MnTPTaC1uYl+rzUhKdPNaPOeuNbKmNlKcAzVZOg= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:WO3fJKedM46Q9BRJipjBcEqPT0w1x6t31T8gti34OhB15tJFHNARI+zoFTz0xk/0rNL1qeqZCbGhY9kbUxE+Jr+ejRIs59DA8KflwS9GYQzlsNo4fS/e8WWwbeaRo7bzCLat+hlTmAh8z7xQWie54EwA26dbAQR3wA7q/fwDOiB3MP8aSdqE7LlGfU3POk1j46A7wlrBLyObzv2IXtPJ8xmAGZTne+Nd4RpryRvLT+AI6a8i6R/BkvZyd8aOm3pZRijCwerlXE+S6ECW80RYkmRe5N7zWP1mRrcVDsmltOnI2YwbfB9FzNC/dpmxkQMGBSUSH5+AnBKPcKAUtJGgjwuT6vB0s/842k75uEYpX2HZKhZIyEBgMFWYiQ5u6zZvDi9ylh85JVequdBcVweY8EUMOxP+3ukRy9xbswdgJTIFq+r1KPYl/uzebG0qa8P64QZRRUPHryDJsTyU8GmSTA==; 5:0XASjmLZvSKJZfGDiD5s8nb+p6oFNGi8BKnaTkYd6nIuILogywspu94jXrJyrF9JUP2CQnCGcAN/Q2uyo+p7wPZGW/427HpLvCAP28gA65he3Z3+9xZuKK+OtStjLFJ7J2tSIFAriPMaW2UD+RU+zxl1cddh2nzoOOKOQLmvGs0=; 24:zXyLO5s83IpC6Ogbls3kzVAJjlJr/g3fo9GHM5TW7Kv/dlOBVhO/sF2IYjCmK6PPDXIXsiIaHI+vIcMjf8O0uyxlM2UDJzTs6d9hPw3yxoo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:PqMcOzJ7h5bVQRp1k6h2ycVUAFVU5VR4gle7AjVOTGn/XBtEtUaYJYP10pOHP/2qIDXdj/bk6A0fOeWxTg9yZwA/6aYsxF9xUzVK28uIeo72wz4LhUJPAF4F/2413BiDk2mp2lAzQnVoSEejllp+6voabmNl2BYBvKpd7tKRa/0k9vqaYRUME64W2zmrlUEJhQK/bLthKB8u5C/NP8JwXgJuBnsZj8nFi5Fih0SXzOr9pxul55sOsNBHSLFDrIHC X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:02.9522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f48c23af-59bf-4e6a-13d2-08d5e3182857 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 06/16] bus/dpaa: optimize the fq callback routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Avoid array of fq as packets are dq only from a single q. Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/dpaa/base/qbman/qman.c | 15 +++++++-------- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 27d98cc..13c4315 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -1058,7 +1058,7 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, struct qm_portal *portal = &p->p; register struct qm_dqrr *dqrr = &portal->dqrr; struct qm_dqrr_entry *dq[QM_DQRR_SIZE], *shadow[QM_DQRR_SIZE]; - struct qman_fq *fq[QM_DQRR_SIZE]; + struct qman_fq *fq; unsigned int limit = 0, rx_number = 0; uint32_t consume = 0; @@ -1092,14 +1092,13 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, /* SDQCR: context_b points to the FQ */ #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP - fq[rx_number] = qman_fq_lookup_table[be32_to_cpu( - dq[rx_number]->contextB)]; + fq = qman_fq_lookup_table[be32_to_cpu(dq[rx_number]->contextB)]; #else - fq[rx_number] = (void *)be32_to_cpu( - dq[rx_number]->contextB); + fq = (void *)be32_to_cpu(dq[rx_number]->contextB); #endif - fq[rx_number]->cb.dqrr_prepare(shadow[rx_number], - &bufs[rx_number]); + if (fq->cb.dqrr_prepare) + fq->cb.dqrr_prepare(shadow[rx_number], + &bufs[rx_number]); consume |= (1 << (31 - DQRR_PTR2IDX(shadow[rx_number]))); rx_number++; @@ -1107,7 +1106,7 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, } while (++limit < poll_limit); if (rx_number) - fq[0]->cb.dqrr_dpdk_pull_cb(fq, shadow, bufs, rx_number); + fq->cb.dqrr_dpdk_pull_cb(&fq, shadow, bufs, rx_number); /* Consume all the DQRR enries together */ qm_out(DQRR_DCAP, (1 << 8) | consume); diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 1316d2a..805bc30 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -431,7 +431,7 @@ dpaa_rx_cb(struct qman_fq **fq, struct qm_dqrr_entry **dqrr, } fd = &dqrr[i]->fd; - dpaa_intf = fq[i]->dpaa_intf; + dpaa_intf = fq[0]->dpaa_intf; format = (fd->opaque & DPAA_FD_FORMAT_MASK) >> DPAA_FD_FORMAT_SHIFT; From patchwork Fri Jul 6 08:10:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141267 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835412ljj; Fri, 6 Jul 2018 01:13:07 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfTjSOH4TZNY371EgE6NqSp2PHPlXeLX4qXBPQ/rhH3V/gEPsO129KfO6W89FT29UfA6U/B X-Received: by 2002:a1c:3b54:: with SMTP id i81-v6mr6136389wma.143.1530864787736; Fri, 06 Jul 2018 01:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864787; cv=none; d=google.com; s=arc-20160816; b=pAQ2D/owEOIPNAEy1wmFjqpjyen/u8iYJWneiArqAdrXLsKdYGN+pg36QH6tak4RUn QAjgn1E8xw4y6CoPSKuEHY712BSBXtAbI79G2G3stchQUY+5nSbc7zOmsopXpXmBFGLn +cuu/SbLt455AGnoQi9mSMlZrJBVjhxJH9K2Ljb5jDax7V7yPTdubg9RoiWMzLnfCFCq jqpDvOoBelzJ6gmOaMceePapBeN2GGge4Qb024a52p2LhQiBeyoMUiJpU2lil3ybTJ1C kmd8cJeD8hskI90IRmvvboMJk3F6+mt6IUT8XMztNNTdrHOgmAYMgzRVDd6GkI4sr0O+ B+4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=EwCpVbrB33pYBR+EiOKlVN766GCOUUI5XCGhSrXfjD4=; b=s3eiZ23eDaAz3cCFFxmPF6Xos0r5FHb0SvpHCv9ybOb60j6A3frGBOVW+cNXpFI3t1 p/pB89om6PetG/SCfoVaw/qfYNDMIAeotEI+UAReTNrphOQL1DLxWL8rFPi+luJ9J7t3 huXYlZLSOuaxl+nxjfHglOnroWYDT0vm2iLyTAkq58W8g/Gwgq3RmQQ6BLgqO4Xrczto H8UtBELqXoTgWXU69aZj4rv5VpyNzr0J6tXr3RHnKcgqyaI0nhpKNIWoPjqV7HC1v0vn hL5K8oyUw0wg/1zNqRY9ZQ7Nm64k1Fsu0OuWdSehkBMiukbILwzqVe0mftcDFC2z/efW HNSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=GlM0PlVD; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id j58-v6si6949044wra.37.2018.07.06.01.13.07; Fri, 06 Jul 2018 01:13:07 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=GlM0PlVD; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10D7C1C482; Fri, 6 Jul 2018 10:12:13 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00053.outbound.protection.outlook.com [40.107.0.53]) by dpdk.org (Postfix) with ESMTP id 8CB1C1C445 for ; Fri, 6 Jul 2018 10:12:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwCpVbrB33pYBR+EiOKlVN766GCOUUI5XCGhSrXfjD4=; b=GlM0PlVDklFXMNn2xwGinh9K0NS4S890gZHn0/sm8h6YjITtQ/WKkHxSenus/sbAR6mHcMWqpVUzXSdfeOQgXAE9k3KvnJtxXnHsghJH0dun0UPAsRn2uVSPR1I3SBThBOVn4H58HUWE2OOC+kHxlDJ0zQliGc+E7NPuGdxkk2I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:04 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Akhil Goyal Date: Fri, 6 Jul 2018 13:40:04 +0530 Message-Id: <1530864613-11754-7-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c52ac5f-4176-44d9-34c7-08d5e3182913 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:MH/CHWiAaBxKPIMBkauXlX8El5CaHuIrNGIIa6kKHrrjZ4lqvNFepH5+nprdxTlyOpfbF0b8KNVo46OjDTuae96CigDeJdvumzAI7EpPuJ9x8E0oGenOZIoNkNQJQ3XzbQ9iVbvaTGvOfo5CdFgR/VtG66sMW8IIsAEiSPTnd5d0YjWRK65BjCkRsEAkk64UlbgzzhU8KHyiyVaiqPHLvYqpSYkxU5KSOrnEWQXILzEIn1s88T/YobxhHDMMUtD7; 25:JR1tWlygcTPRUuM50hK1hQTuWDvE2Iwxs65T3D2Sesb77FGdmvE6URwRISf5ImwfYnifITJJztSN+fL3eB8EcYDRy+yEdG3FQ7eqiRfa7EuOKblNwji4anMeEDdli/whe3PvEDiIMwoX4+AGjX+MZ7dxJV0jgRsSZmvO7dFG8rZwiOugA+uQ0XFaiXB0J3YO0cXQ3XJuQfqrRD/aMYe4c/zgZHqtSn3o2vX5xXfG5Hx0OMwZVtORVBKAPnaCl2CBdSRGn0mO6W/mVaDfl8HMybsQycWO6+kC8q3ayQ7/+ObkOyMM/grQbZIwlco4GByxY4OjsvxfLe42xAUZ2SifZw==; 31:BfIrqquAqXzJrFUQzkc8IsCQIDsHjRDADMJFjDK14TIeh7WOHMy82Sj0Aeo3sG2kcXnezjgVT2CHXWprwbivuVjv5Zs7vIelimknDb/uemH63i/moFN+T8hh/6cjgomkVCo9zWXPPH7/mWW+n9as7GfY200TzEbF26/tyXYNrNWoahkvoOTCFwcdNS+BksgDsovtJqZI5mqKsYqcb/QfQtY6U5TW4TiNRCb1JQrkSdg= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:sPOnvhU8C5s25DnMo8c8BVNse6Gm8H2DxNRydma1bdMHcaB+30gR4Tnv/gGEfzSCLVD6TQCwHUVUOSrOiJa22bo4ZaP77e9k2Yq6pMGE2RDObh9BpwP7YTZtDpANocpkBxjGLF1KRQkj30sSRhicxyqSr6yqNhEbjxyz6dWoWSncZNdQWYi2Yad/evK9qvAa637uJ2ogvbYqJAj+oFsItOCU6dhmzmxlVeuoF1QbMjuQGY6+KXbTD6A23rEeMRzOGuX3b+O+1t31Pt8kXncxJnJZEw44cU+wTCUBQ5LKaeF2LR9AU9DCTsdf0r81N5QnIC3PTKCkfK3S2MIwJY8zeraNtH9rriF8ohSVngGorpPujW59R2kd/SAfO/tK8yAsUYySS/D6ajGZ9LWlMabRDBVTqMfyGhbHv7yi/UNdw59GvFvPwD422d6vdMN2nZ5Jap2DytYZolWA7eZthJrMcu+wl5q073kjH+mi67mktsCFq8Qk4mid6BOYGWFmVh2k; 4:wgxGjl78tWyAj+Rl7cxS9YfJF7PZjRXHpb6Zopl2evUPuIlv/pTWbqmJiTclmeGoNKIXEHbrnqUl3nGZpwNGYA2DVIag0pV9djHICiCSqW59UN80AcUPOtnLNrLtfFL+qLOGEas5wKSCJmETseOUyx5wRb63LAqtW+imlgrtrgkKQLGJO8WvAe+IQuAwIFWmfYYbW8T9aozi9H1dAoAM6ltvUH+H6us2HVwU5RbIsXBoeu1YxhR/YCS74A55otV80fbQY9eMVdrBZmduQ3CXEsZgveDymlxY6GtP6qvRl791sG50YN2V2OTWwcwUCO82 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:yrI+GoamZq55wnW0ShRumKEgKDt/DJTAlRmppee45?= TXAlvR246Izcc5xAcoCauu9nQunKTqGFr7a2K5fequKsVS9UQBxAwavNHCwaKxoNlJo/0Iq0k+3dxK7XgXJuiEc/KnOuayZ3gn3JpR9QRskw3vmrcLiVNQdkj+qndhQeGQtD7lvdvI1oueIRa/F8JUPv1iXUv4IkNdBPgge5sDFCOQavm9lq6xbyQmdjZ+hE95fQClHWfPPAjKkilSLSigCFmhw/RTbgJuPE7/mcDGBp8OweHQr+rbi/H6bKMC43t+6mnYuyFdzUI02NfcVSS2fPX34fRsgo7oacCcYxB2IQPPsTo4oQo3piqkG+xCwGFW/lF7QGv5BTNSu35QsWi2dfid+BcUImPtv1llbI8S9OM0PZWJcY8fny6gd9yF1jW3ezlvwWrT0JywDzPhLw9n2yclVXiNenRX5I6BTwm5nhlOk6Rm7p39Jeglfsm3vADF7EGIhtotQVxIAxX+BdcMTTDQpu65sQ/ZkK6uQ8haAOARRZkHnMPibk55amqqzFIpnpJo7pEpm/FuGN0SA/8JTmkaCbCnSdDlTwYHLu9cv3zcgUGk4Ra5PKBrZU9ZQZ2O6hFaVLJvgWVVwzOfzk2g20Rizops4Zfv0mSh92NG3xv3WD5EExmARZOlClzRYpn1uql1UM6jLsnQHmuXsSXbHB7anZjZqm+8bAKlozsXDXvFWz7F5NmzOWWngnbPo5tX4Us49fKT+NNpb9YNYMllFipJbAsDVRYEHAMIhX59s/KEuVa1HqD1PEUDIhgaKfO9MwCrrCEhHYRxCnY0Vec4gj3sEp3PXdVC2ddzWViCUXLvyxkWRycj57G+juBvrnGOpZbEvbvNotkgSlCbrW3CGNUFnkm9TcKuYK/RHh1NSFtd/XWuKFf/hs3w3zDyQstme+hSvCwdJCEV8ND+q2KmNhGBxJhqLcuvFQPKFQehPVuRPKg6SM0MfgTetlHtjgyCiMaQm8ucXL7xJrPPAbgS0oIDHiBv4MLPwld3EycKa5hYHmQG1P1QWK7mR19JHr++PtPYWTiMyTnV+PUKIMeT0TAP1IqLtsn6nGbpyuQM2NtwoEILgtJVVcRfj9Q7vQJJLQuCexuzGN5ueKQubWyyxPFv36Z11cUnU8QsYsQxHBaxp3xqSifL+kEfY58fsBNCjIfPhCf+QoN0MtK82T2e/NJa165BTgWCRInfkwkc8JYQ/Y4B7jQzrx2DbyDF5/8P+dlZcxxl8tJJMKX6VEElkwALdpEVsKzQ6at8t9p73hw== X-Microsoft-Antispam-Message-Info: b9rGqTDjijOlju7iSc8V3HL9q9HbTaqoBOep/sSR+X12FIkTZEUuFsmmP0l6uXWIjSyQ1M4djpGlw/CDkZa4F2ngEB86DWRG+M6stWciGrITH6wjMvqUbwnHVgIo6kfAXagW7o4RMQxwI0nxR+sHaVclLQ4uu/g50RZVWTzYuBqaL5rVWh3jbxg/YI1el0R7fzrMVbayY7xufcDYm4CpdUB+pkCkx8hJ2oXIAHaGm1lRucGCPa8dMvQZEVdHfoqI5WFHOXvx4F1jib0i/EB5N1sWdBT/uY1dqUbk+ZFvwbCVU3OqceFUcXgdXrtgtoCI/Pw712W3NLKch2wKUCHxTK3iNwkTZUyjj55kbpN8qvo= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:MP+L2NavSKjv7U01HXX9ugMLaY39O20gMBWybcYXcZWN9RBfH0v8N5HjIO3aQjKcf4Teosj6a861/O9noxBYTm1CUn+skzPtiq+awYkhsAq2d4VgmSA9u85R8JLKuIGFDJQofO7wevnqcTpoudEpr4OwbQndqaeZaL6lM9g8jWSIasgpVZYOTsiJbfp1zDZqV+2y7qfDbRS9Xvkg47nVimM8QQvQDw5ilkXImt83zM0h23JhlgKTmyt7oGEdjwBt55rUpy2z7EAEQGC1yjaYs0+q3MnlBFGsW1gQ1lEr6mJieWC7bBLgjhWBp+tXL8KRg17s4DoPb62YeMpFhvlW6OLj9HMvA2yweVOouaxDSyOuAgWm7z1AUtFZVmDpb0GnmbdCnk8GNQ85XKO3cjQ6+65zzZOUK+lH8hKdZX5EPoxjlUixNhHLFfIUBEXChFfBrT4+630PEoPvCHXk/8sPjQ==; 5:tc6Q4dFWtM9x8TZ0DaVa9paKG4zIpgQmY4MV1LHtNETOLP99ID+qdUluJnTshC//K91XwVPFu9+iF8OQvqCqDRMY635at5ZHdWvGdWJiG5uyXlvKqrW+60v/z4ohPDlHMoxgpTK8/xbfVNK9E8uSHBxE+f7X6aPHjGYkzwvWeq4=; 24:x7etJjddVB3rhpgR2B27ODzTPHdgq5sizfEPodaGlsmnyMeHJsoRl51SO1g+fJRGKFW8HCTsqnI6AWdo5QhZ2+TLb9rQUEw3UleO6WANluk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:4yk0siupVuxeMzjiplDESVFo6cODexXxnqri3CfPTtoSpCu5ivAu4jSQLF+VPZabCNhFvoDLuSL0L5M2qjyDVcsIngv9MTBHcw2V/1upoRgkv/byZlQM2jS7vGEr7MsbGP5KQ0Vq5+HABGGTIqK9tepWgFQ0qr0fj2oNlxIOqU5V9WfS6XiX3thnYYFjmHmFS6ps8yiCHnuCZSvrSmkma69VlwmZ55fobjRE5+cmYdxMNCu6XNRl9Ld0JXj3+48o X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:04.1841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c52ac5f-4176-44d9-34c7-08d5e3182913 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 07/16] bus/dpaa: implement new of API to get MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal Signed-off-by: Akhil Goyal Acked-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/of.c | 39 +++++++++++++++++++++++++++++++ drivers/bus/dpaa/include/of.h | 2 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 8 +++++++ 3 files changed, 49 insertions(+) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/fman/of.c b/drivers/bus/dpaa/base/fman/of.c index eb55cb9..a7f3174 100644 --- a/drivers/bus/dpaa/base/fman/of.c +++ b/drivers/bus/dpaa/base/fman/of.c @@ -546,3 +546,42 @@ of_device_is_compatible(const struct device_node *dev_node, return true; return false; } + +static const void *of_get_mac_addr(const struct device_node *np, + const char *name) +{ + return of_get_property(np, name, NULL); +} + +/** + * Search the device tree for the best MAC address to use. 'mac-address' is + * checked first, because that is supposed to contain to "most recent" MAC + * address. If that isn't set, then 'local-mac-address' is checked next, + * because that is the default address. If that isn't set, then the obsolete + * 'address' is checked, just in case we're using an old device tree. + * + * Note that the 'address' property is supposed to contain a virtual address of + * the register set, but some DTS files have redefined that property to be the + * MAC address. + * + * All-zero MAC addresses are rejected, because those could be properties that + * exist in the device tree, but were not set by U-Boot. For example, the + * DTS could define 'mac-address' and 'local-mac-address', with zero MAC + * addresses. Some older U-Boots only initialized 'local-mac-address'. In + * this case, the real MAC is in 'local-mac-address', and 'mac-address' exists + * but is all zeros. + */ +const void *of_get_mac_address(const struct device_node *np) +{ + const void *addr; + + addr = of_get_mac_addr(np, "mac-address"); + if (addr) + return addr; + + addr = of_get_mac_addr(np, "local-mac-address"); + if (addr) + return addr; + + return of_get_mac_addr(np, "address"); +} diff --git a/drivers/bus/dpaa/include/of.h b/drivers/bus/dpaa/include/of.h index 151be5a..7ea7608 100644 --- a/drivers/bus/dpaa/include/of.h +++ b/drivers/bus/dpaa/include/of.h @@ -109,6 +109,8 @@ const struct device_node *of_get_parent(const struct device_node *dev_node); const struct device_node *of_get_next_child(const struct device_node *dev_node, const struct device_node *prev); +const void *of_get_mac_address(const struct device_node *np); + #define for_each_child_node(parent, child) \ for (child = of_get_next_child(parent, NULL); child != NULL; \ child = of_get_next_child(parent, child)) diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map index 8d90285..e00c911 100644 --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map @@ -92,3 +92,11 @@ DPDK_18.02 { local: *; } DPDK_17.11; + +DPDK_18.08 { + global: + + of_get_mac_address; + + local: *; +} DPDK_18.02; From patchwork Fri Jul 6 08:10:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141268 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835590ljj; Fri, 6 Jul 2018 01:13:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf4ukyCe/0Gf96BpVMuYSmex0Ji2O5eb6+d6ufys6F+0WYQd0J6u5pxv5MihBkKOJagPOFt X-Received: by 2002:adf:8281:: with SMTP id 1-v6mr7449056wrc.234.1530864799491; Fri, 06 Jul 2018 01:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864799; cv=none; d=google.com; s=arc-20160816; b=o7zRm2JacvjB1TuO1FH2a/Fy6roISOnoHfOU1sil1qTDpmC7pW4KjPH35Ly1fJ3Y2o fd4JkVEhq069IkPvAf71YlQ7voAkobkv72UC9PalmSiQQKgx6uDSJiSrfQe/o9j8PFwL DY+noKR95esYlg2va7wEibSZlxQoAKMf615ivw2GEW4gi7ESJ6oAWvuFEm8TSpvTWjrq fBBU8ZX0dtUFjmZEetI+scV+GrXSfDY7pLD32zCqztoHYHA8+MZqhHPO/HUknTUi4NSY F9l8Ii6YzDLfNL1eptoiuxoXpLsJD5wgJ/vCJ1UEKTTHQ4lrYP3Kl34zBlHNBOYcAkGI ScNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=rn2s4tq6mP/jLClExidUmyOZcDz7hKK4UVN2t3E3NR4=; b=qirbWa/zERlNyiWcxFHvLBne6vvFMCU9POsAEVaxm4SIvwslwQnH1LlpQ0SjXeCqDf k6yQ8Ugh4Suk7K5KcCyUe3EWiSVtXAT8zYigtrpXH918i2ZzcPhG0Sq/w+VtraW+piUd IiWFSBhjRlSWndZZ59Y22YiFwggE+1hlkYhqzQJq/UQbCe4rnwdl/+7fJh1qreOpb7HQ ABlHoivp/zdMrgKPM/VL/oC9ErFLMsCCbCtU912ArvyFCYAoU6sa5ti6mqq1J+hER2+c zJYmSIWL6t2kDRwgbYl8HDiKBrWI+WaYHV+9uS71jnqwLkuOtD1H3FTPfDIdk3Q6P3UH zZ9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=cHD4gEPJ; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id y15-v6si6104856wro.68.2018.07.06.01.13.19; Fri, 06 Jul 2018 01:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=cHD4gEPJ; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3473B1C48A; Fri, 6 Jul 2018 10:12:15 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00049.outbound.protection.outlook.com [40.107.0.49]) by dpdk.org (Postfix) with ESMTP id 9BB0B1C45C for ; Fri, 6 Jul 2018 10:12:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rn2s4tq6mP/jLClExidUmyOZcDz7hKK4UVN2t3E3NR4=; b=cHD4gEPJ1qH83AjG3Yt7XMHV5vXA0lTKuURGCcpEOPtQydVTv5rTYJQf/hcbU0eGn9BwkLiRn+5UhRk4jQV1fmlgNoJAtEpU7wr3OZClLv6Y+WWVPjaJd8nM6dNPlk4qGgQvYsp69wnkOzDSsvJwNj+EzIEIHyCm1xKSfg5mkKw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:05 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Nipun Gupta Date: Fri, 6 Jul 2018 13:40:05 +0530 Message-Id: <1530864613-11754-8-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74a0283d-c506-4b1a-a034-08d5e31829d1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:7ac+dez/dOdycOBJ2spa0KYQGahWxxm2H2OSIlcXmrDRBJbQKFE2f0b940tEqCdNaa8Z1haGEj6RCFtZUkxk0wZoveyAyATFmoQtuu1y7IAKqNSbYExUaYW2oVj37EcfOQUaqSb4MjEKhFRWQjgcfcjekXgJHNogVfJW8IxbF1Pn1G5imiQGg8BtLlgpAbIqQEo1iKJ9pr+xCFywOivvYGxR+tvuX5H035FaOtZ3cpzYBGfgvPWd6X/yRIY1ZG4P; 25:7VJpcnCVwS8+WeupwGgZCqZrcki3hnCVbEPZNiDSGgmNualDIV/V+nhR3t77O6Z0a2BkSGIbwU1t439yMwpYtprAcVAhb/qN3LVJ4O/6gxd9wKgo9NXNf9C71iAWTgU2ysS4yxfXcpLyXH/zRv5LtLJGY76Big/1haXIAaun1ksQB8UZ7HYOEbfkTCaSZuStblwp3Z34hytwwYKDGXElKR4Mjk/Cp2TuHOLq/AF2xpfYrsfDFCtGibYygUrzly3jsAjqBlNMURsI79TkH/bm6x39sb5xA+vkXl2j4ycAUxH4t4BC+WjrGs4yPWWcOj5zsybc//P1hyws85ndqiDVKQ==; 31:903Fuam83dY208YkyrIj4ZHinNvOND/9ms11Htns/fh/BLQeaNblyTYjWBG4Eq4tvsJ2t76bmCDOIgow1RsdulhxMfzQB+0w3B8daOMVruJX+Gh/Xg13yk1WSeCpx4YScS7CjxewN9ZCCwJDlpGVKYlMQWAMQxGVAFBcHYBKNmIwMI2R63twegG5JpcyBvuyGiWsZffKvYgH/FVUuy/KUHQ78PkxaZZYbsmzFZC62q0= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:6A91wXbkvLiF0I2eTCouMxvRy7FXUieTJHPjKeGREfJIOTueX53jGRwQQ53RsRZnUwRZAZpGT2DlOEFVVkBz6UATxoQDqT8nLF+6lwNnk11UGSGFvB9jvbexLd9a3tsGlxi9LZVJOtINJpI7KFbiMqwZr0XGvAIhtIlBEIY7HBPExrLMEaIcq7Xh4h9AM6ffHiSpBnE3GORFb1amMGh63jBlc3+Kgj/+TlAMFeJ7WttCr+AbYE+BrTH8KCCNM/Pijw/lZWBJG+HLKEFLaFtJeDHC+BboQ6n1wwztv9jBsRFEXSsiHCbNr5GCDMz+fCQL5vEhOGCjt34wGlfEalp6FGhlpLN0qkIScCFwGAB1YjQoOvPP9QpQSBRRyK0ysgAdLmp+Xq7/M6issqm5LN4lFluP+EP+pTFjCkGXzUMVng0SzSwrmcF5+Npq50OdQKM17nb8LGywjFeANppKQkf+4aiL4AOaijrMB1/eMXcZUgPQKREB6bTGFAlx8K7EFfGy; 4:vkOaDyNSTnI0EWQNRXdu+sttAOPg0a+CHvRJu5ahDSVJU+gy0kNnXMCaUeuRKrJB4KvvEbM4VBQ45rGflNb+VFSLO0ofwu5RszrIyKNk+nCGGbfz4iRspWbdkV2MxDwOjQTkM491CnjOUs6ZBoDbDgBlT6jHqgMMSac1XK1p72L4SsZEn3TY4bOi32j8ZnPTYGxDYmU2VMS2XPnBGlmliS1BD6xMytGn0yFoD2mi1Dn/+u7JM+S+rkPaCrj6CY7343udEcIKAN13O1hhRtj6OrnviXQiQBf3IrOKQT8wgll5QvOMBTpgSI2PcGS/mUmP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:japVNAMkdEX4+r/vQsACkVJJcNuMRRZb6guQHpoHy?= GLdYC1X64redpVVwY9iVkqIWqPmjvzjqQ62gYcjks7+elrvyezb6QAhbAVHAs7Fxu2JCwdat60vXcQAbXwm8/8BbCwd6HpdE3BtSHVu3HHluPfbX2bvSztqXMX7TqTuq0dTLfdAfD1IgeKPENZMBdtpEzOnSolF+1yd1y34mN3pDgYDUGsK2o0+eABc7a+4jGTd4pQ8MXBjdJSdGA99aoUZZADKJBcmcAVyZ9b1TDgRb1Zp8Z7OzQIXRHrW+X1a7S2FzKSiY1cY73+GDd+xhn9d3vrdtBUpan/WFxUy030IwAuQzJAHtyMSSb3fU/jYPMmGYHG0dW05/n55mT2xhL2NH4BsR8CH+zXAMN3LBrwowBIzlyMqZurOSH0R7MmaeRrSLVRUFc1PFN1yk2Q/IPKcfxeyhKpKjEPEtuXz/hefSayKF4f7dP8hF5X/PAjXlVIxV3lsWi6t7QPob3iNdtI9OaPk9kg8dk0Pw+blZ3t4pQAqusW7ToosS2eagbK3ljUG33M2HY+sy8e/Z7T8VSwcrzA7jGLPi3PUM5RApaA+nKvT1KxxMkyu4ufbql9t32cQp7jNvXyN6TWIRulC+Q71Stthw8Wrr+Cx3se0G8FWRkvLO0BrFl1U7MHU2it+TYq6tiw9L+AXSohh5c+IsywuRdf2y6jMq8hs0W2Q2YsiHaOguz8UvLd7VhWoUKEIK4q9jocpEUA9YP4j/vSew5K66/EdVYGJjSpMotVTfEPM14qmKr/IHbNkWnmbA4xy87IE/+L3UbYP0DHDPkrvSvWzcJdHaPfkKhMnHDbzFKjvAplZcCI5uIHa+3AafGlrtAIpwlAMdLwjKr+6Qsil3GJdbvn5VTGdHQazTrDtMWjUCzNDFuw8X485cfbapCfJMTtgs6dmqc5taLrx/SJ2FyCVS0LpumYPzgg2ORDQEJg2Fb1RyFRzr6Bi0Eimhjc/C1EYG+BK+A1ygvDe9q9QCUNy5nX2Ph4x/Hqb83reRBHdLwELIY8pSotbq6b9DlUdOk/vbTjXX74z6K7suGAt27suS80/FMyto/QClMMJ86R0pmNmcwbiYw41jDIb4zq7KvYt36LbfrjcTvrWXdKwZ0OkPlZoYud7RFjR44duCYqKy1ZVRxHOZC5kfWqSiJ0mKibjIaE8mqUajKB268ZsRSHWWvzu03OUe9ONOOS9ZkKjylXlIoW1g3wM2VBKEzSxCQyQQizE2cHf86uraGo5TeyufZIKXy5tztqzFxoMn5Px3+FdmWAfyFAajVlZmKeMU60= X-Microsoft-Antispam-Message-Info: zK7qgu+mjHsijWd0XZ6nju5iFBfYCxoe9mPblqULBSDSHxHqcgqdM/aQ8TlCq5zlUTAxoVsxiWtGXZbx5KgjNaelucov/W6SVicmsuGRMp/StO3sY9Zpd5nQckDlH4GrhH+KZH7E9hcjKdbL4yOBC4EfBhA6zA3TTqb/LRKu2XKM6zrPWsZ1jUZScanTU/YYnotxhjpe6Zb8JUNFtCYDCMXfV/Ctnl93PK4Rmh1AA+FoLYdUz7v4ohhLeLEdglrTquaeVch/7PlRjvYRCGmhpq9CJN/Wj/0FmZU6YfYbyH5u8BYNMY5MUVT+CoxwbzAvI0Df0ywmwvUvlgeD1urLS+KcOFaZL3wfElpyt3NEDf8= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:Kbd/S9WXV+9gcaDE7s+VP7GzaDUsmteaGCnHtZIw/zWyJPs8Bv8AIYRqfuts6IHBJ/NGE+O7Po0lByeb0P33tQwEvHNMutpQhWKuFZOrQCsPq4Nm75sEr9Hid8/g9ZNp7/0BUghHMWMrgSMHTRjWRdTTIgddwKZGdLkI16+ieDC7GwvmFvjUhytn4wuhvU/n1dTajripNFYh5n4et6plGvIwJ+HYfP8Wzz8pfv+bjU/xBqwWq1QTWAkVkaaD/pq11Nph9bA8oicuD3f/y4EwQIY2FK8No9GGNVAy9RffablIHr1viWKsTpsPhUjtcziaQDam7SDWtR9ZbsMxVJNX6eEUiXGwh6jpNhY7vjAjor3NpGoeCQ7SnUDTuEJs+ICJyBB4bhI3pJAkztsFLFcU2PTLTJg6hrgBw4Mzju/oHG0SGiCUbms/HslYnAuZZpSGl3suNsI+JeU8Z2vF287YYg==; 5:CqAb3Nt6ykHFIVxKRWymPZE9iHuZjGX692aAd4WubSXIEDYmmTI0iv1HVvKpXZTbWhrPSwgZK3p5zYmZN9lKuFT83sjTE/xoIaEKPWfdFisAT719tMJ+5M+FqXQCiYsd2Ak7yNtuhUkaqqa8oZLiy+SIoHl+DokuTR7QjdiWqi8=; 24:KvufElIL7QNsciIfjZ1Xt4/mRfoxP3HR+p7g+6qOmRcyy5waUBSFwqssIkYmjNshf76YDq5EnCV3+cMr3uCPzVXuUhJ/Iu8gkf72Km99dps= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:WP2R6rMBPp+ejnO4CpkgJT3Iu0g8yxH1eaF4yqzqPCWfxnbYfq3ydiRvEC7Dlw54+0oTf1U6GymrLfYoeVbfSycyKyvdaRlYDBaM27I6HFbwcN3CKmXRpcPQ7USLiQGLAg8ap6YW2zMroiUwsBpGXBEYAcNEfbPyMhxLfWfsoYy4crpncwZfrbyCbUnSGYYEhR6/ZU7dkJP2dCjkz3aug65l5/Cp3Dn10FhKS+fGjXvdIUIJcDza8lkxsAbEAUgF X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:05.4350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74a0283d-c506-4b1a-a034-08d5e31829d1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 08/16] bus/dpaa: make vdqcr configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Nipun Gupta This patch add support for configurable vdqcr exact flag. This boost the performance, however this can give side effects for some extra packet fetch. Which has been taken care in the patch as well. Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/dpaa/base/qbman/qman.c | 4 ++-- drivers/bus/dpaa/include/fsl_qman.h | 3 ++- drivers/crypto/dpaa_sec/dpaa_sec.c | 19 ++++++++++++++++--- drivers/net/dpaa/dpaa_rxtx.c | 18 +++++++++++++++--- 4 files changed, 35 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 13c4315..f5fe5ef 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -2002,13 +2002,13 @@ int qman_query_congestion(struct qm_mcr_querycongestion *congestion) return 0; } -int qman_set_vdq(struct qman_fq *fq, u16 num) +int qman_set_vdq(struct qman_fq *fq, u16 num, uint32_t vdqcr_flags) { struct qman_portal *p = get_affine_portal(); uint32_t vdqcr; int ret = -EBUSY; - vdqcr = QM_VDQCR_EXACT; + vdqcr = vdqcr_flags; vdqcr |= QM_VDQCR_NUMFRAMES_SET(num); if ((fq->state != qman_fq_state_parked) && diff --git a/drivers/bus/dpaa/include/fsl_qman.h b/drivers/bus/dpaa/include/fsl_qman.h index e4ad7ae..b18cf03 100644 --- a/drivers/bus/dpaa/include/fsl_qman.h +++ b/drivers/bus/dpaa/include/fsl_qman.h @@ -1332,10 +1332,11 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, * qman_set_vdq - Issue a volatile dequeue command * @fq: Frame Queue on which the volatile dequeue command is issued * @num: Number of Frames requested for volatile dequeue + * @vdqcr_flags: QM_VDQCR_EXACT flag to for VDQCR command * * This function will issue a volatile dequeue command to the QMAN. */ -int qman_set_vdq(struct qman_fq *fq, u16 num); +int qman_set_vdq(struct qman_fq *fq, u16 num, uint32_t vdqcr_flags); /** * qman_dequeue - Get the DQRR entry after volatile dequeue command diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 06f7e43..a07869f 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -526,12 +526,25 @@ dpaa_sec_deq(struct dpaa_sec_qp *qp, struct rte_crypto_op **ops, int nb_ops) { struct qman_fq *fq; unsigned int pkts = 0; - int ret; + int num_rx_bufs, ret; struct qm_dqrr_entry *dq; + uint32_t vdqcr_flags = 0; fq = &qp->outq; - ret = qman_set_vdq(fq, (nb_ops > DPAA_MAX_DEQUEUE_NUM_FRAMES) ? - DPAA_MAX_DEQUEUE_NUM_FRAMES : nb_ops); + /* + * Until request for four buffers, we provide exact number of buffers. + * Otherwise we do not set the QM_VDQCR_EXACT flag. + * Not setting QM_VDQCR_EXACT flag can provide two more buffers than + * requested, so we request two less in this case. + */ + if (nb_ops < 4) { + vdqcr_flags = QM_VDQCR_EXACT; + num_rx_bufs = nb_ops; + } else { + num_rx_bufs = nb_ops > DPAA_MAX_DEQUEUE_NUM_FRAMES ? + (DPAA_MAX_DEQUEUE_NUM_FRAMES - 2) : (nb_ops - 2); + } + ret = qman_set_vdq(fq, num_rx_bufs, vdqcr_flags); if (ret) return 0; diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 805bc30..168b77e 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -560,7 +560,8 @@ uint16_t dpaa_eth_queue_rx(void *q, struct qman_fq *fq = q; struct qm_dqrr_entry *dq; uint32_t num_rx = 0, ifid = ((struct dpaa_if *)fq->dpaa_intf)->ifid; - int ret; + int num_rx_bufs, ret; + uint32_t vdqcr_flags = 0; if (likely(fq->is_static)) return dpaa_eth_queue_portal_rx(fq, bufs, nb_bufs); @@ -573,8 +574,19 @@ uint16_t dpaa_eth_queue_rx(void *q, } } - ret = qman_set_vdq(fq, (nb_bufs > DPAA_MAX_DEQUEUE_NUM_FRAMES) ? - DPAA_MAX_DEQUEUE_NUM_FRAMES : nb_bufs); + /* Until request for four buffers, we provide exact number of buffers. + * Otherwise we do not set the QM_VDQCR_EXACT flag. + * Not setting QM_VDQCR_EXACT flag can provide two more buffers than + * requested, so we request two less in this case. + */ + if (nb_bufs < 4) { + vdqcr_flags = QM_VDQCR_EXACT; + num_rx_bufs = nb_bufs; + } else { + num_rx_bufs = nb_bufs > DPAA_MAX_DEQUEUE_NUM_FRAMES ? + (DPAA_MAX_DEQUEUE_NUM_FRAMES - 2) : (nb_bufs - 2); + } + ret = qman_set_vdq(fq, num_rx_bufs, vdqcr_flags); if (ret) return 0; From patchwork Fri Jul 6 08:10:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141269 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835762ljj; Fri, 6 Jul 2018 01:13:34 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdD9AzUgOuFvMlN4Qer+G31DQGW5TI1duIwFHqasPZM4MrgG+yhK4bXXlOdHomNWpDVnDFg X-Received: by 2002:adf:b2f4:: with SMTP id g107-v6mr7110075wrd.53.1530864814515; Fri, 06 Jul 2018 01:13:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864814; cv=none; d=google.com; s=arc-20160816; b=FJ9l71LZUpI91nZaPZyPOYfJkF293vJp25BCgdurYWH4zir1BAxKsH4A58IF1lzMH1 8gew2Zn4DrlDjvOvzBwPl/IrVYp9Ie6UZcHhaopG0inbBOPLjXo7jT/dChcauqkvIslc UMauiMgTli5cpVDQYs3VjNrrm5xUuScQts1pWU1hV6T2C2n2kLOpFN0g7Jy9t30nTRtl 4GqbM1KPIUo1sRKOZPkZU29BIcb/RcUxQCyQmk49XCYsxvbanW3fQYoVGB5POeS1phcX tx0pMK1kXaPfO+GydeQogY/k1zlp2ZlKQEagangTnLPD0gHxLZ+NA4SKCofuxm+Wi4Vr 5Bow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=ZG6LswLLtx70OrfyDRkohE/IJwOnrFxZZfjbW7EQKiQ=; b=tngbe89soHQZEs9VjJDsNG3He9E8y9dKMMP/+pOyDYvwNbGI6ueftNSoLqF+OCKnlZ 6llyO6eV1uhaYZ2SM5DRS7Qnviys5SS71Sj6cZWA9v+kEKEP74iysWBEyG5MBxk3Ihiw ivyoUEfGkUfLpBfiqUfxqYo/PxRsefFLuA4quzgE4N1NiaDGy199wiw++0YJfgbM5fjk aUiB8ITCZp9cVh3gjJS/prnnnmAeKT+5pPhqKw6FXKWtCCdyLrr4B/T1AzerP3UAtNWD 7PqXkvXWl34Uex24TWyOx9chgTYnLbaRIQa1eHxPW8MOiiDtK7vgV40/J2ToOAHA9fZK MpGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=LLRX78g8; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id o9-v6si6192306wrm.397.2018.07.06.01.13.34; Fri, 06 Jul 2018 01:13:34 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=LLRX78g8; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CEFB1C496; Fri, 6 Jul 2018 10:12:17 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00055.outbound.protection.outlook.com [40.107.0.55]) by dpdk.org (Postfix) with ESMTP id AD8F11C45C for ; Fri, 6 Jul 2018 10:12:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZG6LswLLtx70OrfyDRkohE/IJwOnrFxZZfjbW7EQKiQ=; b=LLRX78g81XFmRBO0hJ91fONBqwYuwL4RgtZ7nLClDATr/qN9oypsahvgLNtccB6Pwn79YM0uWp2LcrrbyIPyIYiIVKkva9KmhIwNUtoASDO8ZLOu9TC67SJziA0OhXa2nqR9oRrOXBCFaRC/DiGxvklEMqyjpgI1rvLddqxoNA0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:06 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:06 +0530 Message-Id: <1530864613-11754-9-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c114f32-747e-4fec-3d15-08d5e3182a76 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:Of2FubuoyQZIh1A+W1hoLRCqBqRZH7N63/4QPSBLoyXoZ9XZODD+Omz1VW6RTexKEcbXsyeVHTX+HlgiNkeL4swwGbUy1cnG9CVkL7J+pZopmo0mODTQ/vF79TPZdVy8d0+GLEpvlM6c28lN3GRSfnxCJ+9HxmjtSBOEUDIMLh2cOppjF724gv9SltT/LaRbyzYwz03XFwwLy0LQdcoOAaEdRqZLv8i7C1QX0pqSU0mQ46mmDJwDi2hm30txUkWF; 25:apQHDjmSdct0RhXsQZTQ4GDdHRmwjIc0HZa3dkhxVGCuKhK/swqsgnKlUD66P8mRGdQ1dwByLjtlOOD0oWwKX9TCwNNXNr2WUD4xN5wCBPviKbAwqdfyVtinnZzxFhYY6pjmEB9RSKUEexRo8sQxsdPrcYAI9BwbTZNeLrAyFfL9Lw5G73w8gC1dFAZVJGF+9xVF6OJ535R1wPIkL+peo+iZmKPxjloAD8S0mInJ5O70J6VlH7FTmcXxU8q8zSsdvkbVW9HqDV6aU6K5dKsCYBwvFicuaETETCYghRLFimOjHHmUG/vC4QbGpPTPdEXMtAu8GYpUwlaqQjSePINzJA==; 31:zdGd0TO155ij+ZcvJ3jvg/GLWCxbevgSRmUUHR2PhgguH2hUI+lbjdX0fDpWLExh4vVMVXP1MyroSTq7CkwrfO3l65JOIyeGteUpbCdIPwmaqteb1Y7BCh5Qw55YED+lhzlwtYIfb2jhHIhXzrXOOvKBq6OwVSB8im+/b5QI0Lt0R0W4SARWIXH/XTBHzVWkxfhOlXyJ8yNeArIyNVchHcGGnDSb9/i601zJLhBUYIA= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:ezljIwyn6q+KTeexrtCDXAu75DCkVMZIXi9C1LgQL+L2oYqHxzOgv7RArv6BJs8YdFru83aBczSrkM0czilqhItESs+TATK4HB42h2u0aotjFK2WOAClCKMdWwrXHKg4cgIpKOkwgE4EIHs7hbIkKdJzZ9Zd8NIiCEmZrY1EmOvewMCYE43u4xJqIUtQCDkci/4s0+3Ae19qq89EOXwR7uhsms8GYIaQTSf/O07ImYwsgYo/b7A+rpD57YvVbqViOF9emqhCOrUT0VOWMfqTUcGDOLMbNjbARw9oDSLKkfFQJvVhGhMU+cTJB3iyvp+1u/qVNjPI11h0lJR/VMJsQ8NQBYX26Qij0PnC0fIyNPQgJlmN1/sYh6kGsnbcb5pioj1WRwK6ZetuIgbZcSozSBFhtTDz3hUOtDeyp4N/atnmt6JtTONDrQuXENUm8tf4wHaInUlIjBAhgeE3Uq//yD7gcO4vFsBZ8Y0QtQ1JjsE44h1d6y/tb5nrsKA2q/2R; 4:VLUxurZ04D6mIQyE4jBdZNettIsrvLLBIJ5uPls0LCkUcTLISqaCzgXedP6BJJLLbjyQKHEl16WweoblXmJKfpltRoSABIOTjCcGR6uDcapUSrFOGG6DZvBzS4uU56wUlU4AjxolC9hK7xBxLxpmLvF27JyhTAF6u5bOBlr1a2RpwOrQcfQUVEjb8i0SSVtEzZPSfrTNXEZPyiiUeW4u2F+KHkbp7ISJurON+h6b3jgNxsrkIXe25ARz3VHJB885OEDZGqrMmYKsSfHMWEgsoja0hVfCAx2o9vqTpWej11+5TOiQELf+CD5SsXByX+IbV8f3b2o14ja15dYXde5v/7/4iK4jDYeh5BcSR3ORffg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:50n4HeyE8NS0tu4xk+BXz/ThGRTY6baBE6Do/X5KT?= MAj8Gr7+vr3MtPXhIvyJdkgjSISbnZQ+xN7XbW5ID8duixjwTAueA8UNh/CvTUfVvWo0xcJXEkw/OCHkDys9xV8w5XeZapCwZuhfEwEhGzyJiXZoUj8wP+HW2q2x5vON5etQbSEberLoT93QHwWr2yjo7MebEeb55oJX/D+6zZtJGDk4RwrTA10FEO+xexzeeF8bE6bO/GJe7/D/mrU9OLUTF47rD6TyaKalqmInccff8fcaPfACXjXVv1RuFKUW0zZWarAGktWZmAHle3s7g1iQuW2pOjgWo3iraq7K14VnQMkjmvk1HfAZo947tRHo65aZ1kpmztsWwOR+g2latKqbVNxKhno/ImhznIWtMCVXah1HqxctG2xPvpPk3SNSmzkTkR8tgCFkAlL5NmC0A7u3YB6gQFUZ1WsGQWhril3fqzchKLWKh8dXktn3+QGkshRynFnV/p/vbPIo6ZtIXWjV6Z2H6T3HsiHqfXzTTUbB69FwdLfcy9zKqxXls28k+n9uhaRECLUxw9J6FP1Sq5Unfa3NRLZlC8ljRlavfMcFFB6l1dShIcRVvBDZceBhwz8WgPEugTQL9+zdwOf8YfCw4z1o1IALFYPSOxiVAsNtK+ooKAPcspcTKApSgAWYnckvITrXnr3PUmvVtqIkgroIPzvXpsO6NjksAJ1BrF8WRSzEhvw3Zbd9l3ABXmK9URQ6ayacCP3238uI9rQbvq3lzPkcpAedk+L6EprTq8sqGd+QjwQrKxGOZRxT3XE+TgvfUxpbSKT/tOeTK7aRvaXk42hJ37Kj6kXYzdglqjvsmHrkZLXh9VTrHEV6L1sxub9eE1/c/IZUuCmHsepLQqk5gEDbLRaIIri1PcdWvLV7ch3PAL72RocHdt111fF0ETLIUQ6P3Wt4P4T9BFriAHDz4K4zVvNZMWgRHjmgHmph4VtNa6snjk7TgYrqgwd118M2bhd9X8yGf987ZOLaUp0niJPkKmfGrnjaUnM1ybiyFzhMEwgAI76aRZ7hxK9oVLwNnq6HF2Kt4EaO/zYIBOvefhKsX8x3YIe34p20nXWJTDB78f9ifK9s3RU6SLwn+Pw3LhgHYAKqY98unTPJCcAnDDlgRdCD8B6zlh5BjyfGVfWZJzUEeJccksq0pv0rvEu5n6LHu8LeQlwMzwfxhbSClYfZrU1F/9EH0e7NddVeLJ/MvCDY9n/HVBBar+e5TToJ1osLZ4Thir/T54UmG9bi/ye999nSjBgiCMF0Cxm+pIbSN15fgZqKKDZYP+mARY= X-Microsoft-Antispam-Message-Info: qJ7Vnnh0OCXu1UZU49tL71kt2Qp0jr/fS11ZXtpm7Yt70fzXT8w7qaNPgmUJKxxuNMG9ByhHUBF/ANpTqg9aDAUW04Bdyi2WB7ZEPtBb0oeH5bvXrr3Z8mxqpbHGElWisuks1A3aHfgSEHNk11lPy8pcRlGeMTVOZsgTPC0ByM+W1xqz95/Jwbz6EluOCbm/QzfsMVuOR900AbYK+gv+SsiwGjLL1oipCuRkDWYE9m3SjIAgxbJklz5FFn5J557iZL8X26l3SU0qvpib86uYBWD6LNbt6eNHQ8uLWw2qmE1L6qy5zVzx89oc5c/rVLe1zB7TSfTGY8wFruhXpjYLGu97un5svKvqenhHlDiRPC8= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:dQHnovETEKZ6HxfNZaCgcyd5hmMBVDBou5BjSs7sjCFZRyuBhekg8adum2ssToQ71DiVxr91SNbhFP7XNm33n/Tpk8OYX6ym0pX/cSo9NgFR0pKSQCCGQ9vZiTF98+17eHDZL6qO6Ac5W2kZIAK7xNMU/NkvjUEONCEVlj8x8BWhqeHSECPpT5MGFwGZQvA/+GvwcvNiov/gczp+ywHf4yh7MlQ688Q7uASKfJF7Wei6Ob/K3v1e7/NsMkbuPDcRFuUM0Kz+Qfj4Fh342uQiAWyktPVweprPnmwq4y4IQsNZ4UzpV2M+SQwVM927KV/X6nDhVFeqYe93Etp2Lu/nou6y2OBlgDJVGdw0vYobExI8oq/g8D23XVq9QOC+NdpGPbc1K3QGGRJzNL1BWFvuSuk8JHjzwwXgN0+zyDrfjF29xoAEUQ/zgqwVNQxFtgJ36ax/p/iRvbvOVuu4DNcZWA==; 5:aONoNbSWKMRqfHuF2jRkoI9KtOIazZKGNoqG/wbcEvFiIQe+CwbWqOgAs86Pd+8eM+wubcXJuHyI1ktPl6X5BuB8RIrUmigFsD02R+Lw89CpIpyMRkJpK/4VNRYfVsj/B4XQcVKYRKgn5Yl6HqorKnse4j0cpO9SkmkDa4GKkDs=; 24:88mZq6CCLbKIw5RZkUUl+lOM14iR1bynbV/BZIkWvrAq31hh/SQ9Mh9Ps6oeV2YE9Asim9JxOee0+mIUVY+EsGHGFgkJblFYPBcZvRmdr7U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:4VtgPFUeTtjYOR3+nCJl04jZUWopqcL9J+z88FDTfzaaThlgFtF5oftiPn1w1n969TSu6fESrSaFoSEbrqRsknyrLpnoKqWiEZqXPBTTFSGcfCBlCbGUxJOuDRnJ58aOWLB8vz3ve5nTbi0TcfeniSuPaGpMpgLXgiWBdquiR3/Qmie131oMPZwBe4SXi8RcGVVY1lfMtODm6EL8w9wywgY+DAuyN6Z+GjgKpWn6M5FDPIQdik6elNrA8cor06AB X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:06.6609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c114f32-747e-4fec-3d15-08d5e3182a76 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 09/16] net/dpaa: support default queue mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case DPAA FMAN configuration tool (FMC) is not available, the system can still work with default queue(1 queue per port). This patch also fixes some logs related to FQ ids, which were idetified while testing this support. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++++++++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 11 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 79ba6bd..def9483 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -74,6 +74,7 @@ static uint64_t dev_tx_offloads_nodis = /* Keep track of whether QMAN and BMAN have been globally initialized */ static int is_global_init; +static int default_q; /* use default queue - FMC is not executed*/ /* At present we only allow up to 4 push mode queues as default - as each of * this queue need dedicated portal and we are short of portals. */ @@ -1026,12 +1027,12 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx, ret = qman_reserve_fqid(fqid); if (ret) { - DPAA_PMD_ERR("reserve rx fqid %d failed with ret: %d", + DPAA_PMD_ERR("reserve rx fqid 0x%x failed with ret: %d", fqid, ret); return -EINVAL; } - DPAA_PMD_DEBUG("creating rx fq %p, fqid %d", fq, fqid); + DPAA_PMD_DEBUG("creating rx fq %p, fqid 0x%x", fq, fqid); ret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq); if (ret) { DPAA_PMD_ERR("create rx fqid 0x%x failed with ret: %d", @@ -1050,7 +1051,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx, &cgr_opts); if (ret) { DPAA_PMD_WARN( - "rx taildrop init fail on rx fqid %d (ret=%d)", + "rx taildrop init fail on rx fqid 0x%x(ret=%d)", fqid, ret); goto without_cgr; } @@ -1061,7 +1062,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx, without_cgr: ret = qman_init_fq(fq, flags, &opts); if (ret) - DPAA_PMD_ERR("init rx fqid %d failed with ret: %d", fqid, ret); + DPAA_PMD_ERR("init rx fqid 0x%x failed with ret:%d", fqid, ret); return ret; } @@ -1089,10 +1090,10 @@ static int dpaa_tx_queue_init(struct qman_fq *fq, /* no tx-confirmation */ opts.fqd.context_a.hi = 0x80000000 | fman_dealloc_bufs_mask_hi; opts.fqd.context_a.lo = 0 | fman_dealloc_bufs_mask_lo; - DPAA_PMD_DEBUG("init tx fq %p, fqid %d", fq, fq->fqid); + DPAA_PMD_DEBUG("init tx fq %p, fqid 0x%x", fq, fq->fqid); ret = qman_init_fq(fq, QMAN_INITFQ_FLAG_SCHED, &opts); if (ret) - DPAA_PMD_ERR("init tx fqid %d failed %d", fq->fqid, ret); + DPAA_PMD_ERR("init tx fqid 0x%x failed %d", fq->fqid, ret); return ret; } @@ -1163,10 +1164,15 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) dpaa_intf->cfg = cfg; /* Initialize Rx FQ's */ - if (getenv("DPAA_NUM_RX_QUEUES")) - num_rx_fqs = atoi(getenv("DPAA_NUM_RX_QUEUES")); - else + if (default_q) { num_rx_fqs = DPAA_DEFAULT_NUM_PCD_QUEUES; + } else { + if (getenv("DPAA_NUM_RX_QUEUES")) + num_rx_fqs = atoi(getenv("DPAA_NUM_RX_QUEUES")); + else + num_rx_fqs = DPAA_DEFAULT_NUM_PCD_QUEUES; + } + /* if push mode queues to be enabled. Currenly we are allowing only * one queue per thread. @@ -1214,8 +1220,11 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) } for (loop = 0; loop < num_rx_fqs; loop++) { - fqid = DPAA_PCD_FQID_START + dpaa_intf->ifid * - DPAA_PCD_FQID_MULTIPLIER + loop; + if (default_q) + fqid = cfg->rx_def; + else + fqid = DPAA_PCD_FQID_START + dpaa_intf->ifid * + DPAA_PCD_FQID_MULTIPLIER + loop; if (dpaa_intf->cgr_rx) dpaa_intf->cgr_rx[loop].cgrid = cgrid[loop]; @@ -1409,6 +1418,12 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, return ret; } + if (access("/tmp/fmc.bin", F_OK) == -1) { + RTE_LOG(INFO, PMD, + "* FMC not configured.Enabling default mode\n"); + default_q = 1; + } + is_global_init = 1; } From patchwork Fri Jul 6 08:10:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141270 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2835867ljj; Fri, 6 Jul 2018 01:13:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc2ThqCM0vWh6qqB2vBD8g3i2+jr7MgAag4cZHNrCcI0m22dpwnQtbE0OqaSEXieGBOU6+3 X-Received: by 2002:adf:9603:: with SMTP id b3-v6mr6665785wra.253.1530864823547; Fri, 06 Jul 2018 01:13:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864823; cv=none; d=google.com; s=arc-20160816; b=LVChx/1LitqweonlL+ZiisAZhVrT+bUxBhifhJ+T+A9ohnZyzWwrPOjfgaAwlDCVFC dcaE2DIhVPylWEMTx7twApSscSamsMOX7+Lflas4Cliz+3PxMl+Vc2ES2ben4ngamLTP a+1z+JmKAwc3uo0Ld/Sj4qGc+3r5k1o9oMt+43iDR+Zepx6qzHd0fWtaTGuPNDXknAlp 9nLkyDvvz1bQLThn7XPYMZ8CZsIYZOuQqx3Ob3T6Cg7EpsihSo62a+7caXWul+69GFNL b/A3dQ8959z92fkn51HP00wK6Nk6PPEAoXKyZU8qG/uICqBwKvsVaPxy+s/HCY2E2aVo kKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=c9lgrqWJiF5fSMGiw3ki1hr38670QHCUOJsiXGTr4VE=; b=k4ch24niRCyP3So4ATE+Giy7HAnkbaaUU/+/Dunih7UlQMCvYxIxWKVKbKjFnEnAm5 VGG2fd8V0pKac9ESBRyHKf9L5B/GSxnHwqo9a7yLRgAsasgM6/PBdy7j1sye5+5BPtn1 3YFDgkjjeS5wqjd2ubPq78kS9d3PxrVMlnLLgWedIw/MxODpoxkXITi0NEvuueRqzqxh Mof0CWLs0lTIFUcV6CYnZdrZsFc8nzJVLlFhqLzI3nhFZGQBw9lZ5QHOgd54TN33NAzC 9tZHXNrliCBcxOUGWvfIjO4j6O2WkxEyIY0ULB1FG9g64z6nVAO/hO2gn63iWb71HCSf e1og== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=RFFKDMGm; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id w18-v6si5865282wrk.170.2018.07.06.01.13.43; Fri, 06 Jul 2018 01:13:43 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=RFFKDMGm; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D6AB1C499; Fri, 6 Jul 2018 10:12:19 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00061.outbound.protection.outlook.com [40.107.0.61]) by dpdk.org (Postfix) with ESMTP id BFD031C465 for ; Fri, 6 Jul 2018 10:12:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9lgrqWJiF5fSMGiw3ki1hr38670QHCUOJsiXGTr4VE=; b=RFFKDMGmrTS++VSljXhu8KcNKsQQN7tOIuJAk/7yUuzUNxLOAcdVbevNwn/KfCTd4wm3UYKQVCWIyfJd5j35tCzo6zXFlBEz6i9TeNgpOzOA/OzhOwgEBIKU6jyjgZc0/SVjG08LBTl8QfDONVCgCx6iHrsM9Lk4qAUQWYY55rM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:07 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:07 +0530 Message-Id: <1530864613-11754-10-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08fe3b7b-a289-4e72-b6eb-08d5e3182b18 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:wvtrNI6Vg5ZliODgOlVgp3vdkl6a0KJiKQbjAUeSymNNxK1lT8aJiA1RuwnQRzCzpLg3HtV0J3MfdM13CdJIQy0KPr3VIrBiuYk4XNsq+NX/X6IfFlkk97eW2Pte5SQN3ApaRNAe5OleT63TaB9ZA8CO6N/zHFejcdX/Gg0AvpLVi+YmNY2KDVTpZ0otItIgkQ7tf4XTetE6DQTWQS6UlXsGg7jl1mISKN9nKeXdG4bxX9t5AeyVQZREuKuTFOIo; 25:NQzVbF0bjUUmKkrrse27NTFrZT3fdRXnM6knTv8/CCK974sv/9rxZMcknwAoyMoNRsfV3AumgbicUn1FNKFHks1dcUUrX/PJVre9xRa0ru4ojrFEu4wTLAL9y4T9Bkcyq3u+PEduqXWGa7czsDiAwtS49CU+4JcsyKODzNSf+H3vblb/TaMaOCZsP/dRpALwZyRLpKU3LJevZAXOHY50nzcbVOEE67RrxYZpNb8G9f02TB74+FefaWufQJg8W5sitPSo+5C8dxXYvsWwVGnROdNF7ZeFO4ZrigmoOSwkYr768ojn2DQOktbFfgmfrSynpSYjgaDWDTbAPymrW64Ueg==; 31:Y4RwaQz0geh5X32o2Sunk7cx/HV3TVIh7l7hr7LnRR8MNfnrNMj8d9qzcylWVRfapuCF00n7lgt+CCMAxif64i48LZ9Kr1p1xd/dMje5cUJaRwFwhA3zHxwYaPWLucP/DN4fT5v+M0fr1PMq0B0JIABhK+Owelqr+ZaN0NWDybL+0dYR4qSU5ScvaCY0dysqn1M+112XFHgtrGSSDr61YPInm6mZHQ4H5/ZSII1QbRg= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:hVnqaCg4rCSg1dv7Zf+OwPjNuIBjOj9UWeLSOGD5XI77dpHiLUAV8Rfzcd+xgjY3sjGJwzDGa4WE1Fp/PQlMAWzjz2vSuO1AFRpzPQ1kH9dit16sQ/QSlndN08OiHyUEpcGbLG8r7hHL1BemNRYkchIyi29pVBklgMpf1N4QDAv9l02u930tPoLOmdmDHGFGgj1HN66wnz6ubOCAgvWeH8b5cEAUoNtCqk34XikCLA7AHNKUvZYWKtDt8ahnsmkB/NiSW2lelu10xGslQqpTHQVGBc41/yau0m7k0lwhwwN7gM7n/WZD9XRaNEEwPbpIs1n3aOEfgEfEHbQ/hevUSuGl1zgc0M3zC4JHD0FsO5A6e6eqi7thtzeZwKVqeMyBP8kMIQPpe4BeATXDRLVEOWcANIbYW/l1nKyvWLihzHMvDN1I4eXaSsvZas5dO4PlDfI4CvLMeJZV51kNM7X/w7TZEaa3PXFaqLQfX2jZkYK07gTpJlQaR+t8GsWLrl2u; 4:+jwZfzR8Yh0m2WOEtyaJUZlVXcFRz4RFZDuAJiLrDHVsCgg1BYFwQvO0ysM6Px+0k0jrit7rxduY+MB5mrTCvKJPr79yyhsxCX2rpX+2Q+bgjkoxx9GRmwnVdMNlncwmEc7EQxTjdL+GNwUxHLupmp/of8mtuvE7YF/cX/GKo9yxt5zYNBvxMoQYZRZUEL7pef86m+qtz8udYFYtN87U4SfHXm9bscJOrLwMQ3OqnZ5Wsm22SKMANq7m3aOE/139rhjtEC/vqGwT57PJg/JeGT7Bv9iSGtsMkUDUZM77y+jRxlFzI+k4MFB+CAzaL799 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(5024004)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:9b+qoDZ9SV9hYO9fBbCi+RzpxQyuFlITniUDJOSfF?= 54UIbO8Ba/3mZ8bhJxwQ8Tgb0F8cmOaWzY95lBProoUh7zUO58bSnMYzw8okEXoROwmoIA8OlDXL7uaCqn5HfA52oEKt7uzjqT5eg6A8xOWrGgyLhofeF0YXDttKwChtqr6S8s/xNxtcW8TdpATUTKJt2Mo9FaEsCvvJL3uxCVbLZ39o6BV9VgBmgX2QpGggbWpelCzORqB5rwjPykbI74ylSvai/f/uhSo40djQKNV9U4MG3qyOyKWbYuhSMYfzwRxDEL1EWkrVdM6toxHAH7atbs7ruvqgBO2flE8MlpRJ5BbTfKiUQDG9tOMP/NVxEIrkr0fQTFROdldgFhr6yUmNk/7bSCfQsR/r7FeerLoIumaKJbx2cxVtuBNaKhiXgOty/UjGMram+nhDBgHIZE/nNIjuKf85WArq/9nMfYDc2he8IUhb4DipQhPTv6WTpJTfzD9Ub+TIaoSRWtjB/kfi56F0Hb6+ZLKazZ6tCofR0J7GP0E8oXpoMo8ryUXJ4sat5JKDGI+Zm+uiPN2DvZKAewH6dlcQzotcAcbcBS52dNIfD3aCdqeXE/5RJgxEj7xwsIOvEAjY3DWoFZXdYtG4g9OSR8+mGBD01+OBxyud6YHS2mUsGukEJ4SO4hieq5XZllYS8MBv+bx3C+2w8wLVwh7tCJypw3IcUtIgLDnWnvyfStKLPR2xR1yg3aONMgP7tJYeii2cPXLfe1HrTp6bhWhJyud4TKLzoWMm/vKElbYmdofq+DHgLVUgERcFNEAXV/N1qiE0tzpLnEPBDp2WwVMVREMwUVVFgjLwCeRAbTEr4jk0SXl1nxYKZ8MQEfl9XVH4dqzNYarT6vVChCUr7R8urn/u2euD3FobJT7XUQnlHEMlq0W8aN74cFqZn/OsODnb9C2Dq6JOtXlXb/e7eEbdlBGQGqsvTJ2sc7yEDCEr4Mx/7ZBe18f4Dzi4vbLsfWZwttEU+HNDCSM1LvbDTQvAFwlkEHonwTQTbA+g2Sc7esBtnq3ZcX4sg3d50O+M1M0YwPLQl7wEVTw0US/XotXw2EvconJcN1o2/IEayrBBBdUxJc3L/jECulUNP0mtki23zAoPtmjQJBbGq+jxiwa1hgsGC0z8muM8G8zxL8xjnAszlABr65XcIDArJWrW6EGxw95g5/96Graux33j8mn1ZKMmRIoMsqbzD7QFGqcnU5AFzFLlRDg+lsKvfqAZ8iKtKw6XJKCMl3aC4U9ptMW4XnQsBdcgzLQio0DbEPRkZlq7UBNlO2aQw75HVw= X-Microsoft-Antispam-Message-Info: acdmow5fsr5mg3bJ27EA6LiCI4gBPKDC8X9i6aoOtVbb/BaYM8YUJTAQAYAIVCa6CvxuBfxvoNtKGw64ckv2SgYgDapn5oyjKnPwTdvoRuaHlFdb0vvK2mWvXKGrvd46q1pMrqYbOr/4FXoliO35F01mfyUDvRxEUdEtk/upqIseEMmOLU9i84cyKc//PS/3bcGKDzOsyZpwieqynmowvXC/lI5/6K/faVexcbe87354NzYsNb3GujxStauMM948X8EpMMb9tvfYNNoe6I2IukLPMDEuDIqYbeJK3zq/vBFCGPsOu4kshzI/TsHXVtxymx+k6a736vJDNdIS8RXD/e948yOTv47lcZ4iIOCOCQ8= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:GP+b97j1g4+jeKepls6PQpPBIFKu6B7r49YGILhqEWwlflZuU75cy2eTds7UurF1xfRIF2Fglks0I080o8phyhgOLYKW8vC2b/+O+5xrV36ZqN7TnFYiDDEXxayjqA1Bby6Z3fJsJdcl246kpFLspohJutY4e2nCKDetCTP1IKVbEG4GXDOG6dpQnaP9CgPRGfHNPztbezrTM59qDwPY8pdI4UhzNHEsWWukty7FA3unAwcgWems4n81eskWumegdWHH8L/KafwkikgeZeiuG3Z0tubkPs0CRhJc1FGOf1+ulC2Z+0pZu4ST20O5e9CZ6/9Fx75MMLFH1PB7kc7aoWMj2NKjqJcWJcQJVX3ys1YFpsNJO/GW6YOm1skDonhY0tGyAlGFSrxIWC0IyN6CrboFIyekXMe1OEclcVy6EcboFhyGnTz7kqY1VT4vt6wi5kyfqd3hQJIr4E7DEuGoTQ==; 5:kSELj5sRBx77kqIFIFdH5jy88ATrFdQtzxEP2uL7hdAyrVkPJDcvSExIggfwSc60Fsxo5hFSdklguULCHHUv6T5pxvealIhbKtbCySrTWY7SMwx3qPI1zcQoCUWXINB1t3DIMF+Vdd95Cj5HC3DYy1GUBQg0aUvYoAi3g6X6wu0=; 24:WSD/kGqKpdiYRuT55Kr+xuoaQBR9afGltyWXP/ElqANr4zb8ePGjysMmgG53JOUHjJJvhaKjeEm0Fgos3Z1ZZdp3j4ooi8HnMXgrAhEOabM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:3SrJMyFKELL/UcZNlEPPJL5NktfiuI5INqHrFRQAd4wtYGDkpMubnnGxkW86uoMAcmqdYo4/rIGA4GS7w+JFXof3EkfiHErOUzlhiJYzBL9k2PyLvhgxCbWeIVRm9/uoLN5ZS7wNFqiU+k9Nf5reOi9JtXxR52ZLGyexDuShqnlZmrGUHzLlg5NL9oo7/LNuOaO5v2m3fLrdvOgG5MfzqaBt/i5EV2kQwibYaUMMfYZcYvpAEE6krcxmZMrxTDde X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:07.7257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08fe3b7b-a289-4e72-b6eb-08d5e3182b18 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 10/16] net/dpaa: remove experimental tag from PMD APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- drivers/net/dpaa/dpaa_ethdev.h | 8 +++++--- drivers/net/dpaa/rte_pmd_dpaa.h | 5 +---- drivers/net/dpaa/rte_pmd_dpaa_version.map | 4 ++-- 4 files changed, 11 insertions(+), 12 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index def9483..00611f8 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -617,7 +617,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, return 0; } -int __rte_experimental +int dpaa_eth_eventq_attach(const struct rte_eth_dev *dev, int eth_rx_queue_id, u16 ch_id, @@ -680,7 +680,7 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev, return ret; } -int __rte_experimental +int dpaa_eth_eventq_detach(const struct rte_eth_dev *dev, int eth_rx_queue_id) { @@ -956,7 +956,7 @@ is_dpaa_supported(struct rte_eth_dev *dev) return is_device_supported(dev, &rte_dpaa_pmd); } -int __rte_experimental +int rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on) { struct rte_eth_dev *dev; diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h index 1897b9e..c79b9f8 100644 --- a/drivers/net/dpaa/dpaa_ethdev.h +++ b/drivers/net/dpaa/dpaa_ethdev.h @@ -160,12 +160,14 @@ struct dpaa_if_stats { uint64_t tund; /** /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enable/Disable TX loopback * * @param port @@ -33,7 +30,7 @@ * - (-ENODEV) if *port* invalid. * - (-EINVAL) if bad parameter. */ -int __rte_experimental +int rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on); #endif /* _PMD_DPAA_H_ */ diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map index c7ad403..8cb4500 100644 --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map @@ -3,10 +3,10 @@ DPDK_17.11 { local: *; }; -EXPERIMENTAL { +DPDK_18.08 { global: dpaa_eth_eventq_attach; dpaa_eth_eventq_detach; rte_pmd_dpaa_set_tx_loopback; -}; +} DPDK_17.11; From patchwork Fri Jul 6 08:10:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141271 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836081ljj; Fri, 6 Jul 2018 01:13:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpedvMWb1S7+SBODlHyaoOhZfj0ycsDUEHlP3vcAYutMG1+HOmGJ7ujG9g5JKRufNsK6eNlc X-Received: by 2002:adf:99ea:: with SMTP id y97-v6mr6548347wrb.215.1530864839778; Fri, 06 Jul 2018 01:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864839; cv=none; d=google.com; s=arc-20160816; b=UGPa1/whwNb5g09X7QZRkxehxbwzlIdomVPh1k/RhbRLxvgDA/FcLmZctPSgFFFyRM RH+gyiJ2QA8z+Xaopn2Hl9mvo8qwW9rOXAKVZIYytdYYs4ysUP0H1/nMpjc+QuIDgc2u 8HXUFTzYUFC2lnUmo/3cOcBSKAt6J8l/Mzb9R9O3neEYKFQ4LV/7hMYOOYBirfdinwnd KZYoReEcT7KI1NvM/pc+910YOD7Hr92t7dSLB3bgo0X9Tba/mYFlBtNFpp/3LjlcTI0n ci6nHfUC2BgTs/zQN6a8mTDBc2P2zgIPoJD8QkWAjR35jrnmG4u99WnsQrgw1BdQVyyD JdEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=OWmMKkNfGsjK80X0TOUgvNEyqeh/yf6yNW4+8JZCEhU=; b=SKp+eEZ/zbEpt/9Bn1R+gRvJW/FXK4rrOBKgurm4/mJoD/WpI2VEk5XsvWAlj9tX43 5g5isod4vpG7d8mam5sO/oD3cKu9Qt5KHNOrbOzYSNZSGcRd6W0ir6tZ/6h2w2n8ZGRq vq5mdHRqzaxwMk+RTc2cilp+ZkhKReuyx+eFVlDjCJkVJV6b87zi5CNG6L2y2Vbv3C2E OXvdvuQnX7qQS4w525Np1a+HQ7o9HtyS/1co8/j59uOIJpEOdARaJnlRxxMUgFiDvscr TolSLHhBUB6bTR1se6bqp7/WuJE+Z6Ibi9jlscQBtikkbaTol3e2XLqOGn/88t5MX633 ZJDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=cPyPxsgw; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id k127-v6si6016533wme.46.2018.07.06.01.13.59; Fri, 06 Jul 2018 01:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=cPyPxsgw; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7417E1C4C4; Fri, 6 Jul 2018 10:12:21 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00064.outbound.protection.outlook.com [40.107.0.64]) by dpdk.org (Postfix) with ESMTP id D34AC1C47E for ; Fri, 6 Jul 2018 10:12:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OWmMKkNfGsjK80X0TOUgvNEyqeh/yf6yNW4+8JZCEhU=; b=cPyPxsgwrhTQ+28So2AL9LN0BRNJGEfEw6PDL/WvqMZSx9A869289EBEXoFGq+oDCZt+BbDhbyh4RIePSaiwi6KWgavUclvRI6Ov4Fjjhkgc04AntFXFYO0FLjTAswbRR1ErCgFdv0N6TrNF2sTegKAu7zKjcy47tqDlpHZt7Qw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:08 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Pavan Nikhilesh Date: Fri, 6 Jul 2018 13:40:08 +0530 Message-Id: <1530864613-11754-11-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d58c3315-fc39-4524-97e3-08d5e3182bd7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:0UJOy8i5hWTlQPqQT4w6Qahkzok2dFm+lQd2jWJ+oA/JtZOS1VDd9dBzZWWgtwvJuGjFjSXisOax1cBQ+2HK9DtixmpS/LS+trnjwQt/fzJDkFhgvb/p+yqbz7LiBHehvw5/YBH4UDa36MgHqkMMTehqoUvdBE0s1z9AkToyLzjOdSTf+qXWSzj2FVch7AAyYoTgLe8k4Sk9qmjBr97KLdSMPeo6cJ5yAUF8GEDcgIdXD+2iwrypxM99eUApeU5i; 25:U50RuEQawx3TEfiehJKxdCNmUJYk2kua4vY43ooCXuAgooHiLXdYEZaqDRNK0L0pF01Y7T7FbAhJfgCySfc8n2SG32ShwtX/hUYUN5XsjId1GbLtmobstAbSGVhlzj5YzxJjvzKTznncb7oT2jXk+WrH/rAdUjKrCsihFW1DpHYoj9B+Cb1IqQ0disS4Qr7HcvxJ9hhCPRUZj+bL6dCQF28qpmMsaQkrIN7ue6QYBS5M+OWWZK+3cfcJqQAsOg57JiLzjLQ2P6MuSVxUUuP7P+NK9MKFaHHOdRaui6YMquzHKTXNSck3G/yy+jtvLO4Wu9ymJK0CKIYuXuUvqfBujw==; 31:KgIejGxwje/PT/TuJGa9Itm15w7BhHpGZ2SP6R86hmTlklpWD1vMcKi4bFBv7G5KfYqqnv2GLOBcbHkguwyDX0gQNGq4EOwOqWKVtAYbMQrgsGZg3LLFW9whlISSQBz6sxE+k04053c4svh9GjeHJKZAtbN3IDmbcpNjjXwp14lx7u6d5SbY9KHbnN4wIkaxiuexI3aWauSjpNGgLhLwa2KMaZYDwL0+RHT70Qfkv90= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:/i1XO55jkwxv2xMVdkvduU8bHaTdYq/pygdV5QhaiONELxJhdCnJ7mlI0d/LxZ30+VZrFNGPEp1hQI1WQY5uVSny2X5fg10QFHBkDcxhgX0pTQvC4s3+gvMzuCOlDDnbVhNPbfvew/esuw3hqdGmMLX0WFFpguxBMlS/QluF5T48ZV1nf3d58BiRzIZ/b7pOoOqKEjvmKSsipupZS4SEKGKIkA7IpP495T8GtmwmJevww7szMjjPfce2oJBn5ehqet7y+moh9mS3pcYH+665Ke+VR9ESOyu8L6fXuDQjpkVYhpJf0vk0W4Kt1BNHn8Xr1qtceyTbm8G5ZVAoGpI10udT4jLtCGGM5RmfQxKNLmcxlLsHhqQR1nGnBkKaOeKvG57qyfuc7LyuuWTD0JUqz3Hp8FHr/okYJI3cMIdSfASdHtKmz3Lb97Qbz/uayqpqnusAlMiq9K6jIgPiutKgOjJc/3eRycc6ZhTCNCNQek1n04OiJNEDsoh6HGJ9b65b; 4:bSLwFvw/hnLz/Bva7LOoR0hnXa2sQt7tlHtJtb1kGUIG74HieKAAip3ZOE/4NyMAdasGaju8wVKrURYegy/kdjmHWeTz3Vqk6/T9h1UHTUyYKl8z0zlW7bM6npW0ghNHQYI+ELumg8ach1fGUMi84qZQAmLA5mduacLemjTePj5ma6GRNjYcYv632FnhTgGEQD8vmUk2wjC6B9Tkz/d+GEmQY1L+W3iQ3eQptKUA2Y7hx2DgEi1cmhsr8cK2IkpZGK5wNw83iu328PUJMZAQuSAmemJpIUqBkBKCQ0k4AtjBxxSQOIXPvmx8p0svYjfwlUmulnVo14HeE43YqxIbBGdhhu73XZxMuNKWr/Ewiwg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:rrB8BwuH5YBFsbKemkMIyMM1IDo+NTQxOP+XRrk10?= k7qwVX5SXW8TXV9Hd4C2feVTEIAVeLhAa48VmgKV1Uq9jqZds/tPMCJX3WbirtiFKJnAf3ZfI7/kVDqZJ0pchZy7zGcFG0sZvKHKUu8RtOvzu/WActuhL0Ub/L+bMRisOEze5slImH7VjJOS7G9Fz169qBLloitj9/E5Rz0qs+1krnUALQ3Z8G6bOsLDS71eiJIvxYb/DcC8ZHQUNO7SYckJmdF7O8ZzEGmid5kmdqwR32kgHYOwc6vOc4sSHXsEAIlRHZOHeoM/IDCLhO3MWldx6ZcPCtCgddqLTOSpY7Tj9hTZ0pjI6r74d8jhhuNsD1O+OMvXxJ2rLMhaXyC3jatGXznodpsstugekiXgxd3RfkKP1w2IxxkXpd6dfY6dIc3M2IZqsUvIYcvtuHKS+hsFrNezpGCBe8oPOc0MDYyvMznphIfrCXJBifLa5/Rm4m3V64VgAFIRFeg4/jQ1XyuHQ5rqzNr2Z/sSB7LZs9NPa8n5zIXoCNgONfp1J2IuG5AAA2hKgmS/ZXD2L2YDa9D0hwX+SmlK4xiYYQA3Mh5kD1tsdPikMMKpDMBHpkY6ks359Ej1GWNWgmd2rmK42uZaKLJnpdsVRHIhXuDSfhem9Om1SwRaFmIv8TKxypuMd90wsQzpfKW4c7nf7wg4RJ1inoeuQYBjuRuNxCK4xwIjmPHoxTjrdbLrgZiRch//u9vCD6g5N5/JICLSdatQmgTCDcAz6euPdE/A2OGGYKC0JZkHOch/g1QSatSMk9WP/zpx34MT440zyXLaYZ9QbbAYH553FArP/XuQ9A8KAFP5xMU+0XQVXJZCNxvQq1SXMhAuG2DDWWXQgKpeaza1tJ8Q9mkNC02PESSot1j6tkhZPQ+tSDoCzSX574OuYFS0UatLNQFORpgdjI772yGraZFSR66j1d+3oKmNCM3q/DEJqp8+HmxKkj+iTJwvaEkDHuPSX+dfjVvo9UcWqMnucZKxF7Oc/Fk8APd+oQaJYavOK1vppZ/qpRIB5MsqDgfJjhXHtJAAeliWGYqomkzmN9emV0/QERUTXasBv6hUGg2roQixZT8GG9XUPG/2tNbrjta+q0D6TlqdV+Y0+f2k2lWDpejUip/QqCWdgv/5QChaJpz0i+l/o4otqUDtJGu+vgs7vqWwJTl3SnaSJHHOs+226cGHUnSHLgWr+4mF4IspAO5q/cJycJGhjIDi8j8DbYsG6jKaKf6M4KUBQhHWuaHitUreNFkbrFaVMA+zmjAn3biOWf9zNtQq8anlHGVPtw= X-Microsoft-Antispam-Message-Info: VTv2Ic4hRZSOVEFve5paxbhs7qxlPUsIpexSM0E8heJHeXdyJfz6X3Sh3OD3Ou0XCWsMY2VxiEfUALgU2C+YSwRXwIDqzYOWs3kFsIK+xc/tAiFKchixkvb7XliTLNFjYAqhgY2wOBHCDy11V+Z5IytTwcF0ZAJ89fkBuPRsiIGLkndjMwLSdZ+iQHaGA+V3XJNO/jAeWIs86HRtVVH4e9Kuua4cKZWBz5Qd7vCJOb6j3jyiKPOb3GdhCXJv04XNfWhh2xKDjcPyFX0CJmOxt4BSraQ3EJsrjM7FJ5AH3CD7CIUdpjsWU63+MgqCaHBWgB7fLWyknfTPhCrV95gqAev/wHK2YGBcta9yOD3rtTU= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:DVLVx4pU0RnK7ytRUXuVh4XyrUfOQ16N4Bq82SjZfihLV/SaaPc1VlNaRKsa0nS8EV0ZKIxYfuJD7/ETiWkKoIZ3hAYAQHu0GyWeKBJSYbEOVKu/o+k6HDQpvqQbu2TWhn4yMXZ8zDEUpNd/kpje1xTLBDiaqRitwDx4Rc93WJ3wuoKDI36foXQgGNOIdDlgzFQLK/y+ItK//6RcZ60RurXI8I1ofZPZDCjt2EJ3xjAbs4rPaUHW0ZNItlk/fYH5O0eHcclGPayhooHfn0KN6goClofVoHBbd5QCQVc+d+fpznOj1ZrEiuo8oG1jbq02lGc39Guj7jX0Enyff+YygmVycoR6OxQ+yuGLaSsI0dGO2Pp2d0YP/yw4CQ1b8VftKCF6sh6LM28k86ZnCEBIEBk/R66W/w9c2dVBOyZ4F4kps44777CheRp/WKhLoA0Tjfz4JH+dBlJEDfRwbqNh3A==; 5:15CxtndxLRVtfoDz7H6IlUNu7vXRQrdo96SSqCLvg+tyuEcoGiZcfsbzUNBBxh5woHRypAEgho+4RsOp5NydZpV3KCp5Vz2KezxaZeUgp3OT2YhL8nYP8BppvFT0gnt1FD8xeuXGUzwMFPYsK0tHJHK7Tj9t+tA+D82B09lizAM=; 24:zB1jDyBvfuRlLoyGpuLpuc9ORn3ItZ5Knoeq+zZO34KJC2ftmKHaD49qQhBYh9B9vvjVAee/+6w4d1u3iChWUH+/Q8OzFAbO62DKUtpLEV4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:LYegnuMJuWEh7lG+EPnTV1ogkqqG4G6Smakulv2sinJYMAZddPdy1ieUAoA/QPOo54qBf3Rp548Yzopgj6sXCKND39njENX7G2InGqORL2Nhmv84yg3QDUg851ahvwx2OBVC7/6bq7xISVk7kA/pMVwNNIsbk8JbVlfscAeGd1JGQkzxbhtwNRDaHDo+pYOjIVveqVKW9Jdne3rB++gtJzrPXyfaq2bZdbEEuklAKtNleSTTQSceicTxMxY0tmKv X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:08.7725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d58c3315-fc39-4524-97e3-08d5e3182bd7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 11/16] bus/dpaa: cleanup unnecessary global variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 ----- drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c | 2 +- drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman_priv.h | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 +- 6 files changed, 6 insertions(+), 12 deletions(-) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c b/drivers/bus/dpaa/base/fman/netcfg_layer.c index 3e956ce..031c6f1 100644 --- a/drivers/bus/dpaa/base/fman/netcfg_layer.c +++ b/drivers/bus/dpaa/base/fman/netcfg_layer.c @@ -18,11 +18,6 @@ #include #include -/* Structure contains information about all the interfaces given by user - * on command line. - */ -struct netcfg_interface *netcfg_interface; - /* This data structure contaings all configurations information * related to usages of DPA devices. */ diff --git a/drivers/bus/dpaa/base/qbman/bman_driver.c b/drivers/bus/dpaa/base/qbman/bman_driver.c index 1381da3..b14b590 100644 --- a/drivers/bus/dpaa/base/qbman/bman_driver.c +++ b/drivers/bus/dpaa/base/qbman/bman_driver.c @@ -15,9 +15,9 @@ /* * Global variables of the max portal/pool number this bman version supported */ -u16 bman_ip_rev; +static u16 bman_ip_rev; u16 bman_pool_max; -void *bman_ccsr_map; +static void *bman_ccsr_map; /*****************/ /* Portal driver */ diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index f5fe5ef..7c17027 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -625,7 +625,7 @@ struct qman_portal *qman_create_portal( #define MAX_GLOBAL_PORTALS 8 static struct qman_portal global_portals[MAX_GLOBAL_PORTALS]; -rte_atomic16_t global_portals_used[MAX_GLOBAL_PORTALS]; +static rte_atomic16_t global_portals_used[MAX_GLOBAL_PORTALS]; static struct qman_portal * qman_alloc_global_portal(void) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index 07b29d5..f6ecd6b 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -20,9 +20,9 @@ u16 qm_channel_caam = QMAN_CHANNEL_CAAM; u16 qm_channel_pme = QMAN_CHANNEL_PME; /* Ccsr map address to access ccsrbased register */ -void *qman_ccsr_map; +static void *qman_ccsr_map; /* The qman clock frequency */ -u32 qman_clk; +static u32 qman_clk; static __thread int qmfd = -1; static __thread struct qm_portal_config qpcfg; diff --git a/drivers/bus/dpaa/base/qbman/qman_priv.h b/drivers/bus/dpaa/base/qbman/qman_priv.h index 9e4471e..02f6301 100644 --- a/drivers/bus/dpaa/base/qbman/qman_priv.h +++ b/drivers/bus/dpaa/base/qbman/qman_priv.h @@ -139,7 +139,6 @@ struct qm_portal_config { #define QMAN_REV31 0x0301 #define QMAN_REV32 0x0302 extern u16 qman_ip_rev; /* 0 if uninitialised, otherwise QMAN_REVx */ -extern u32 qman_clk; int qm_set_wpm(int wpm); int qm_get_wpm(int *wpm); diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 7956bd0..5ba3d28 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -50,7 +50,7 @@ struct rte_dpaa_bus rte_dpaa_bus; struct netcfg_info *dpaa_netcfg; /* define a variable to hold the portal_key, once created.*/ -pthread_key_t dpaa_portal_key; +static pthread_key_t dpaa_portal_key; unsigned int dpaa_svr_family; From patchwork Fri Jul 6 08:10:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141272 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836192ljj; Fri, 6 Jul 2018 01:14:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdGcXUaRbzzXXrjHcbr02ihMD9OQkrf+WWbIbLsSsA0+B3jaIO4gHhqsZU/FpjWZpqVk3ep X-Received: by 2002:a1c:1314:: with SMTP id 20-v6mr5705262wmt.55.1530864848988; Fri, 06 Jul 2018 01:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864848; cv=none; d=google.com; s=arc-20160816; b=SCBjJcvUiTqdJY7ZU+suPveXT6f3uiMbEF0wtJTV/cWiRLX1Fa1RvzjLDcTMUgRCjS ro5EQel0VVNA1Vr+giX/8xLrbFZ9QCTL4I7Pf2P9vayug7Pmo47WlJvSo4EuSf8ZBuXk E/KsPDIjfnCY9v/7EahcZKBRdq371f/uXofu4DTs4AA+hZGLKciJj0hYKKgMebi1xZeu 4DC9hK5yrYghdVhMjOviih2pPACenuNIaLs88LqgRBwx1HHHr0h1ko/BGyfrLrNgHjTK o9wns4zo5nzkulvIk6rFibS/a8b11m/2zoQAmwc/VnUPArkrGdn+WZaRygdcWznppTvM pq4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=L/jJtob5CXKogEzC/QC9JU2jwIEySO4TkMfwNGY7mk0=; b=JJwzg3tP4XLokyECuctdT1PlYfV6pKzO1X/kOlqRHJYMmCtXnjd5iMYXnEDG/GN1eZ iDcW3DWevEuvllHbWaae7BD21HL1qF1Hviej8yVn5EvMyJBi7b984vyxSTFEzIkbydgB EwVep5L/m/+DzheB+H54ty14aoCdeqz1Yh3DILSzfc9hF5q7DCEwiJ/dYZPTW9pfzaL+ tWMD/f0F818NjIJL0ikFvt7aNhmO8by3uBO7/5CxNhP/RdU/U2pZk5dJnatsUu0+uC/8 GFS1JoBIKewcT6LiAee+Geurv5djCTaoO80YbOsjUix98yKOYWp6MJQ2NAmbk/d6eYXO 20Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=T2ZftC2g; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id z49-v6si7544609wrb.368.2018.07.06.01.14.08; Fri, 06 Jul 2018 01:14:08 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=T2ZftC2g; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A6801C4CA; Fri, 6 Jul 2018 10:12:23 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00087.outbound.protection.outlook.com [40.107.0.87]) by dpdk.org (Postfix) with ESMTP id 42E371C459 for ; Fri, 6 Jul 2018 10:12:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/jJtob5CXKogEzC/QC9JU2jwIEySO4TkMfwNGY7mk0=; b=T2ZftC2guvoX5jJ03ig/QvtSfsER3TAPii4ztznI9PzeRrlEz1EYWE4FLTdao9cb/pP4WnlFycBxwtZdAbURjMChXhyinMtbdF6mTzgz2aoS2RdyHO0TBo23TG4TVmTsrT+lA6bxdvUAcnkpCWx2hTdMgsNvQVlGA/h8ytKZLII= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:10 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Pavan Nikhilesh Date: Fri, 6 Jul 2018 13:40:09 +0530 Message-Id: <1530864613-11754-12-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f3d33ab-cb34-4d58-deef-08d5e3182c9e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:ji4sFflUpjNTB9nysHOR0LJrLEkd7fy29e1/Hyb0szIBYbJrGjRJhyUsFhnUpeDCkxuFK53DoXZbiRSkRF8E+VO9GhvyriUgegdH4lCkQraO5+d0OLQ8xPDooePNnykHwJyAEp1B6Xw94p6FOt54DT58+8Ieln9zAu+Mtyr2GywaNr6zviZTQgwVo/nqGA81trtSvBnsOZUMEOXyF56+HF0hgnLFaTd5RRVNS2Lwhvd1MAJuTmeJqPaG18zz+ohG; 25:E/AJ+x69EL7aUeVwJKWFk5SBcSUEUAmTcIOTMvH0PqxTG8XWFzjvxU4c7RqJbp65iDm7VkVhID4tdxxs0EbJlDY5x7pU3seVaZN4tRGr4oJ9gp2KY7QAgf3tqE6EvWXMkDp1I85rMTCvr1IFNap/iHM5EILF7EbUDDykcHxhDRy04SYxVinb6j44TIjKo+0yNj+5wSKz+ZANiE+aaYmlsxlK7yknjolh9na7MPHQzd8as4B9UAWT3qKV2P2AJI/ELfkokxnSd73grk818fWfBLkWCYvKOnOuMBo/qe0tFjARWvr3wbtTnHD+XHl3RZ5tgP/Ug+oy9eHCGqBLowFEfQ==; 31:W1Dzs7ZagiaB8BiqsUbr6khCCZ3sNx/py6+2dzZY+Kj3Yx0qp7ez56ZVmoX/Q5MnNhGh+x6PYjGALTQBAYfoKdCrrug4HKjbnZdsfYqe/WTiMliBDIv7A1baM3oQUZRhVMTHQr+jzCDRuNk97kKoJs077Wc+S/eihSc/x3jmJgO9/ukCgorrw6uWP6I9NWIlJEpCd3fXgxtWBc/H5S+hL7crFxyaJQHotdM+eZHdlT8= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:DHhqbbcEw3QJhVC8QrERT8lNQGFu+bxGNrQSVb++10OKkGR6txrMyimaVCDexHpRIeoieKQA+i0Rs9oI72qV3iEv5U5xnDgbaUGHnZin7kGfSZsf4ZvH2Qy8T8nQtegtKvZjl4H8EFpsPNF19TSLZKT5wi4zbZRmokJAJVg2xGWM2qm/dXmDJWr6KEkc9Au16sbV5Izhv/++rdU2MwGW/84B+zl89ULPjqAFf3mZZL5mpbDOw4yYKcPBFXnWe+ZC26GEVMB9YurkgJdMsgnlqsq8vC7fuWefO4HylXrbTTvCgXSE6N0l2mQ1N+wa4NC9Z8Q1VVovOpjjNK2xHfL22dpktJUs8lBlY5EwJnLeJS6J+LiFP+O9hMHBJP58eF5Mhv7bvintr62xaXXzPVNUn8dLANiJcFGLoeDT+6t+85kZGbQHKfp3VsbiVX7HY/yLApISyH1a7Rwn2heaFxVRQDCVktG6F+LunK1UzuN7chaXaWcQDfXtUjqvawVrE4+c; 4:bh4tOy5Y2oYrWiWAZv7w2b+m+1GT8r4LjY5uwzwFwPcZPQfzBUcXnIJM4gIEVUrmDFgHxEBZvMqemvHuv2jDHSYSniRXvd8vx9XnPWnnSrqKQ4j8lDFmR0yTdi/q+uTdOWY0dAvisUdD26lXSNVpWCUv1QtjpnWi8z7FvtUJX12uJIghlTm98NMssiAUTDLa4Axi4x+KJOtAhaLZE8HYN023b/tYAkX9krpdfgphtcotSLAXfVsQQ7Oj/T+7URxgbgeZ6PDoOfusuU730Z8fse3mR3osTcw9sjSwVu7BUOmEbOy6dMZp8Znn38XHFFuI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(575784001)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:9MokAPLxBcKIDmRwF+dJIhAuvTi61xsDBjauAKjiU?= Qycp25oOJgpOnBbPXmmHKss9nv/O/HojlvRj7P6m0JAtb4l7E0/JiIbbyr9Rhh22u+sdyntt6lzZV0B9zP+z1Tt0QBnbSTIOSQdjehONQxKcNJDQ17YeMUTHqukYJ70K5uuTkRX+s8FZ1f0ajcgg7nAIabOU0l0eVx+sky6GRipXLIluK6euqI3jVMNkiieSn7rVBjw4y0iJ+fUJoMWeoX4Q35qnBLQe8O8QNRHXD1Fi+YH998SzUtN1EIQp14hwMt0EW20PfEd0z/hnMObmN3DDV9YWFNcu9y6GE4XwAmXqSmm1SXlXFfud9sfssx0TTt6IrpnvDZy+oAfU5RX9BAJTB0WQrHbVGFuskt1sDB1eQ/pljHZhLqjutolZWHd0PNiHz6CC0zlYGWsfFs2Or+YZyXIM668h7omxZonm7lBOK1bCD9Ok+3s9bw5n3LGS7esLD1PNUrOLsuw7ybeLqssdVImK14pYEipHE+7PEjpgA3DpalaLLHqs59m3jRg/BtS6/2r3JqnKaCbmVZ5UrvSL17ZkKiTV3fwb7aTjj7tXvMcDDVhE84Os3og6TDdmmhhKBehalRxMlaeT8rFhfI5igZy0d/oNGuSDK1yY7RRx6J3ZIXPQyKCpYNXwylKCe3/jqpmRTz3NGMAvsxuZQMgo7FtTZ9liz/Y0sEXSLsKCwkiMonifZLy3VRGVlJkJmKtemL3NRvkC53CuJUqjAW6F09TlgnCBi8glx0FAc79j/JLtCdbsHf78ZiDT7Abs9Q1L9uTmV8GvnjGHigKtcsGdwHP7VG94iKnHgJmiNWtW7tLQbzPUNhfvSaTcAYtr+pVIKN0GpASgQMQTkmlOtr6YLFHVn3Rlbow8CsBfW9QQy6HHCkqoBbT2HzQqz2c1vnGHz/RpUekVZRhWxyxm7YnJ1Mu7ojUplqzY4ep1+5+sqEbvaFtVE1uFvczqJGrGtQRaoJ3Sxh1fkwQEt3wbnacRrW3mZkrm6GtQ4WJUUCfck+PQh2wHlJvwQ0VY5QQvoOK47Q7nDAtzi5kGm6j3wrZEgh6rvqP6jBnWviBZuYPv+5s0s9ScOoNlDrd37wSt92zsZMrHuvj3Mauib2YXiBkK7ZMIDVl8ir4Giv4nlsgjMm341IUpUym9zs30mTAuyY1LVE1O/hp2KRFTrHo/QZdkwSVX1OOCSK5XUtVYTweG8W5eL+Ok8XGWd9vkiueyiSHDwSgGQEnmPE66Lrq3dT6alYjhxyaT4u6he2rZzgj6x5bBFTqWOh4imWssatoGa8= X-Microsoft-Antispam-Message-Info: l2Xt+ydfhLk2cVlW6unCwTlTrtGZ0L7Cals9ceHK3FBUXPdO56biVwWGkhU2Qj7ER9kp+I7x4mil24MhS39/jHu8zjt1tG5C6ABFk0QH9NkgdLyIFYHu30VLawjUPRgqgv/kCBOhSoMN/f9s4mLSBZaZ/bc9+zuHYXBpvf/piZ9j6THfTiQzoESOGZ3DCijkrbjGBFDkuNLEVNbBOXah6qQLjCcuByT6B9nOIkQbKZw00OSem99K8hzToyFfx/rHcGmGIi7Ux7wCCfz8LO+jrzgsQ9gySinwa/jym5lCbQCoo5bJf4KrspwBoCTc79WCwPlhesNVIg4uBTCcPmB7Cj7Ye8wYE87bkypB2+x0ZXY= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:w2zKP6pc9VjUviMPjGNTQYvoDO3e39iLkCrf+QOaBfCi36f59W8uUrl53mHuWjHLwT5opCAve007mWdSb88Jr93KrRapQW83B7+xzJGH5vGLH5v9uF6I4T7XoJYkME9VnY7K03GNGY2mIzEWOvRpUc+tj9Q+mfdt5s5JBSxAiSjMkzIexoH/vQ6j2jwxHF9val0sjzUOMlrmfnTPunZMDoXtkFn39EKcPxJFUelYi2MB4zGLkiY7Ps0CuUVAOq8vsLJMpskPl8G8HbkMnbCPk8ZGVq17stNnpbTn9UXu+ZHcsgkhBkj3SXD4fLC3rIc3t0ZELHg6C+uDqa/9bmekEiV4xl6fEs//OfzylIiF6VmDZ5hGOzsy8MFaCUHg/lVbdLmC72a4yHsB0MeJdnj8agCyFWkXYEWlZDsxiIZpip7XyOCx4kCCdaMlaPitmdb5MnJTVXW3ckO6EpdXV3rGXw==; 5:dvyW53Ur/EtbTUtWxhpMpTkbNKTAPk6Q4F+Ijy/0BFnmbUiARL/nF/QaHH0tJHIbvc+8rxdipo1bj0mMvbRtkLo95UH4rJESyjmVYDl8e+SMvGJTvknpknxAoDxisOq5M6SbRy8+wF4duz8tmixeQXQRTjCRTX5jjYakF/W5jk0=; 24:3d7iidTmh/lrRvsTJWUi+lxJ1mWLrFYax+4foKU2EmpkDeMX5WcLEarwZzkuLIzJM7jG8V27hK9s5zzbdLR8URfFzjlKqD5f4g/THoBS8xE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:JBG30QEb8vu4qX/i2YS0Lb+XvARm86yDuaS+RJINGdpYHy1bJu9/JNhiB2Aq+xXiS+h7dKFpC63rRUCL60pHi6+EX1HI7yhUWyvY+VCeW3+bcogXl2nwSyg1hJdbf+5uFirZj4dxZT6d2NLB7Qhg54ADnqzYUIX5c+OvstAiVJQRpXsejVEOzwRNcWyfn10Ntl2I2UjBuvcynJNaATWF2Zr2zMdZcmTX9ST2JXfaj4OKOo+e7J+sm3tWq3r9WQp9 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:10.1336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3d33ab-cb34-4d58-deef-08d5e3182c9e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 12/16] bus/fslmc: cleanup unnecessary global variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 +-- drivers/bus/fslmc/qbman/qbman_portal.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 713ec96..0714500 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -122,8 +122,7 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d) p->vdq.valid_bit = QB_VALID_BIT; p->dqrr.next_idx = 0; p->dqrr.valid_bit = QB_VALID_BIT; - qman_version = p->desc.qman_version; - if ((qman_version & 0xFFFF0000) < QMAN_REV_4100) { + if ((p->desc.qman_version & 0xFFFF0000) < QMAN_REV_4100) { p->dqrr.dqrr_size = 4; p->dqrr.reset_bug = 1; } else { diff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h index 8bff0b4..dbea22a 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.h +++ b/drivers/bus/fslmc/qbman/qbman_portal.h @@ -7,7 +7,6 @@ #include "qbman_sys.h" #include -uint32_t qman_version; #define QMAN_REV_4000 0x04000000 #define QMAN_REV_4100 0x04010000 #define QMAN_REV_4101 0x04010001 From patchwork Fri Jul 6 08:10:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141273 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836415ljj; Fri, 6 Jul 2018 01:14:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfa7t5Hj2YF+VKlCYDL2X3NR1TKAeHr7F5IYbvV9dKyMu5myIpPLJGAZB1XOC3Kufskk0AV X-Received: by 2002:a1c:3e92:: with SMTP id l140-v6mr5577891wma.134.1530864862878; Fri, 06 Jul 2018 01:14:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864862; cv=none; d=google.com; s=arc-20160816; b=CcrXvS3S6BjsrYp5P2TFLOu9yiJkh6WyUXqShwg/mHys/8H0mPEGCX0S5HmDchlLD6 jsmuetSqHl/D+mXzIOXwUiSZsEvaxkFsG56dEPkgLCONn5TSmnTHnx0VC+mCiTSe13Pc 11fgq1+3tMde/FCwNcyOANb/wxupnlJ+GWEHKyu83sYfU4meC7cvJ5SkjfcnsCnuZ+MZ X6hl5CmU6LAcz2cZNYMdGWTY+LWXSGSHWO+RSQDsLdQ1PAwSuWaSeEkgVwQznC30L+n6 XhkE2QTWAg0V62Nknz3pGRBOTN1LsB686kobUyqN/I0GVvDRHc5H04/ky3achq9ZBf2C l5ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=Hi4vi5u7vMuf2CSyK9a2QP2KE5zbUf2pkBugQq4e50I=; b=WkrpjLt6mIbdhUHXwG9ALcLEIxME/T07Tcfd6I+NpfoJMWvK+DYKy12NZ1x8dhs95Z BVdlyG/Pxer82Se0/ssMC9lvoGXO8k7q01Z9nOjcbDLPgplAq8O6cd+Q8kYbR4hVHPNJ Dm3C6o3IFnVjPyx/e4F+eMIXll+xSPpsnCfRnDcZf6+/gGWbDLEGApI+NZ3gtwaY7Jnm L1esC4Fo3hIwa3LuQYD7ySmlY5pBPNNfaGjiaBB55rK5Ycr7PYc1jMAms9dNRcJQhK1w QfeKwhW2nTd0N3M0DzLgsaKgE8Isag7/OPUlDWigfT76561OLpKKYifcCnoNpge+NNEa OddQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=U6On7i8a; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id e3-v6si7163322wrg.249.2018.07.06.01.14.22; Fri, 06 Jul 2018 01:14:22 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=U6On7i8a; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5844E1C48B; Fri, 6 Jul 2018 10:12:25 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by dpdk.org (Postfix) with ESMTP id D46131C486 for ; Fri, 6 Jul 2018 10:12:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hi4vi5u7vMuf2CSyK9a2QP2KE5zbUf2pkBugQq4e50I=; b=U6On7i8aSn5JabJdjEqD+7mdMXeLBmeTpRs1pZmmDvqj1Q+30Mqt2wm0PsIP7wYmKatmZZf1XQ7wD9Yd16rEE4BSBKzEe+qBNpNXm7Vom9PAdbk+OjFhIQN/C2gD48KjD6USJ0M6rxoqOOKIhfYj6Au2wzo8Ix6na8Dw5u46X+s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:11 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:10 +0530 Message-Id: <1530864613-11754-13-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc9d0a2b-f50a-456d-6654-08d5e3182d63 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:CrKIdDNPyUu8uxsHLz6YfG/zzoqrvLm06rLxM3KKuSs6zJkBXES2UdZOvRYBp2r/Virw6ggKsDbtl7CGt9kemU1vnuoMG9/LVkmobw1eHhFaWqZTq1C6KxmWc9AAI5powHKE70ohXZTJs1kRVvybRB6KSaguFCUFIO/Hz7Nb66d67pBJ41A3DmozQpONM4dMVwrFmHrd8oM7xF5lAhqIIqCwJydimMF/0A3Pyf9FzN4fH+IX+IuTYvJEF26sH2lV; 25:W4BYoHxWXhoxPSWDcvCs88mT/eKuQwZ6jzzrJVAJvh3Ue4vOgpCf5M364Rm/S+0h8gl7JuWeFogC+putiSnh/AiOjxexROvItkvmMsBc4uKF1HbqYSIInjS9s/xIfq//KOJUNLcprlGWr36hQYxnBfGc4fBnxp0ptYOXf7Y4H6b5oQYMMdtw1uTiJsAjsPIh9eXuv8fITEWF2Jks8eM60hiMXFWFl+ApIR+X56dYaBu7JfCmbpK0m2Run8nQXw3T1dvrPYApBcPesR4FfzHQot35wRfhjeDzEFyLrlsaWnFGOj7OhBngdY5aewaDOpb3tjZFOWIoXHe3clRNSH10Ow==; 31:+MR7e4ruZ2r40un+NeQb/SmTDSPoZz+ZjHQAUQzk9L/On1bV+adPE5BunFaJH6FeMJ3n+KkTAopR0xnXcQnaFhRnSfbx3V1LKuXCcqPAW5utNeEYfh/1Tg/Ft0jpfuWkfoikU/YC8UhxOrmicqy3/DLUk0A4wgnYR0pFBM4YQY8Wbdvn1cl4emZu/rswL/UjiG7Iak3JdfUBG1BTASxR5+KPhh990WJ799CIfzyN07U= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:3dQfz28EpCMDYx2Vz0dEftieQawxzTKrv3+blwiFERZ2fq10PNGzkEVFh2+WOkIOMFySkePevw5sQqB+iN0kr50FhJKcmM60QDlK2RaB8fv1EEALgHIoyY2joQjXk+1e7dHl4Bbqe/TP1JArkdn6htg7PggUUThUKObXlZ248WsRHnKI7QIIbSvZVXZO8w0DAqiDNMxv2/G3WqRpGpp0Kpv2b+hQHdB2VT/tLI2Axl66R5RH8IScyq3WcRQGMIKXcUWwyFR/T0AtMAHBFnNxIxGd8JvvDiNzqqe1Qs24XsZbhLvIU0SJPBOQvgYzFJHTUkbGrthyDz4+BWkuZptikDMGMHygUeeNAHmQxyuiegSCleOkjpUKn/9cRMNmSh4iyNdAoXGv5dl+FmILBEsHOdgcOxe7uvAtlIRGYMjma9TAc/5P2ry9TSoyHMOyu9uOAcWsWCwvXlEylqzf9/rWp1pWc3YMwXj5mLdzr39+3HVzncE73tQvIp/NByNdOMQF; 4:ZL8S5xqzADoZxRnF8YeCh4LGGLzIsrjkyn8byvLfdT6b6PcFPo8N7j1b2o0t1Sukp2crK1eyf88URIEW6/hI9TfilCRd/3BJ3TxynfEdmiMRiXGaMfHbrosx+bvaCjgAHeuU/Etxc266Yl6lCAApgNVnJCrrWnPZh/Jv0IbdABla6Vutb3Fw0/pK7hKhHr8qUE3nlukIKpTwhDBWObnQRPLMDNzmbJftUGxIhmBO188gQWaAdsfAtsXxDgxiICBXyg5EeRmyCJxjJ0bq3fV1V0soaC4nUpJBCvZNczcTajUNFnT0vGm8HRYs1cLhIqCJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:anWWw8VhgJ6MBXLcxvzcLnmmykmwlRUrvei0OUy3h?= jiQ9M22lbReINjcphvSPqgT8d0HCRT1CAcAfObDG12ohO/YzTntuzob/Lb5cDTjCpJHmPUrAUZZ+6dj5f7co1TwwmRGdLWo3tYobrThBtHGjofomqRMGvqoU7wMRFjPOevhupUqy2mroBHEH4fT1cSf7Gr1tPZlOTdq2FnmLF6zBraJ5bphnewQhCj3GGwydBE+NEaL+TQxwrA+ePNdrPm7A8PwtpjpoJcZoTx/RpMsac9BzfG1Bvr8rw4bUGszqrrPqb5SrK9v2buLdV/+J+o9O+WnRbk3UyUDbev3/7CFopWeK18c7qgWwBYSSoCS+np8uUJv6KACHGjlSHNojdEfUNUo0oUEOn5E9tVBwdRfxJyoAQklxOgEV38cbrP7tZLjrmb/UB+/2t4dWbth1yjUEiV7ZLrE4XlisKpeqvgnCuY9VF7bi5hsluNdb0YR/qt5a9Z3CQFk5lCCXWpy+T42eXh5luEXF+McOzNBL9vyLiS3gXw3b8HWVspBvVYUraPp04v2wSVzSU8yjLasGRujwnvqCkCn81IowIjbDn7W9ed69yylSSp/0E4klv+O1031MZF/t2C0XNS2n6NmRh//X+jYHX8/eFgeUBA54M+LvQRvISKorFFU5WnPQLOpCriZyoJIP0vHmLu47laazGbUeD1e4VogdJgFuL/pPg3vHTUZdyJ2GsKUQ42OuRhO4sHwEQAYGQsG6gZWXy90jmywH2BOEjODEmc4an6PvrGnpVIbCauP7x6aV7BBPTx4V2YeDX54xflBJJx4WyliVyEWBIa4gQNvWXvUjjXYLwMNSRXAT8pNcK5d+kPMlqVWerOfb2swUF27sz+xS5TTyqspze0FKIkDKP8kebHCVfwyYDgPy+2Bs4EJ7GQLjrJzcCohsABhvAVROigco5by1l2mPY+Le/W3xM710KnSq87pgp6psB1hNdYhpRt72VtYM3fsM8OFBj4oHi293pgbp0esxeQ9PX4voy3wbjrusYf0KkCi3e+VgWBKnk+BIT8lV/HQrzqlenIRQ0hnQ7aWF+x4LPu01nsMFmqt0Z8o0vBB1nqvoRbzv+i20eOCMVg3tBGjFAXiLwTkM4eE/44XwaezC9bPpFlN1R0vk58Sqm9q2OTLpWh3wAUCvMieEMD7AbxHnw4KVw+ccYiKl3FQDzwqxpXAZOBcvLyIrh1Y63xPxydODP7JvQMNa7+V5BNrYisuM7KCMHTO9v7eUTjwtmuNeu7zYaG5X0FW78l2+DiIkw== X-Microsoft-Antispam-Message-Info: ilvA97+h+qi6vhC5WOhU82WblqbU4WQXRC5OVGDLKm9eoyXPnUHboVw7SUVaSrnT9iEYa+1i5q00zsXSicP7H2pv61kC/6KVrv4cMQ47YKtO/9W95OsA+LTY1d2lRjn5/HQ5qFRni8ubrtBShUho8+a6Lgh3koywOhU7AT6b2IsnjnyhmBK4NMJmn+QSV4jzYG+bDIUVSpp6uXXiKcd9kQlM9/BOhdB/hNLQN5aIpWtA5ld/Bx6N16sMY8IPEGuPz8kjvlCaBRYtDc7X+bPP6/9a9yJ2IVrdU1pIo5ZjFpsOqAvc2+2iylfL2obNyDDyCknrruTlbu0ViwRHGwiqdmI2dZ+SpZJ8xanKIFMt2Yw= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:IlqSwsD4a8noowqv6bdTh41NgxGR9zwrWMwwgnHFeY1toMiO3L3FTkG1P7jxFLx6ET6mTvqqvgRkHTuZYMOCLVtHLa02zZ228O85+sptZDDqZJ9YQcDc2YsEfpuyO2vxYK6PlUsuLVMTPRGT8e93kzMcZUj0Yjyppz+O/kZD11mH+1rliSo8QFe+DC7XOKXNu0swl+zIhsz1bEYVZ+m1R38yC53Ki2WyU3NbZIacAmXcCeezclsCs/NH7weJBvMrZl8eDaqKHh5ILYeKQWTqEWeBO33aTJrDqFlxdv6Oq2T8ovk57dry4T2MqyB9vnFmOAdTt8sGXGSIdNN+PMMXG4zBydnV/ZCVEPIQA4GtzmIX7nASQcL0Gtlp8kSX5XjM2U/peKDuHzToMbxmZNM3ZjJo7svRsnrrSKCyir8cY9Czzq5HP6RDZZtWeBLFSswsRlkKNc1ubtIYhfJFNehSbQ==; 5:/Gcx3xCJ80HwBQ0syCZ7xI84Sv4MtzX1QL8a0MNpSKPXmLqDKmm/tQCwQrRUgblhFuKrJHksF+I/joo8KqLDSpWPyycVXX0vXuMC+sGJfEtl/tba/m3W6WO8yII4kGzv+I7EcZlmYLO7MV9gJqCLnEf0dXj4Hc3c2Q0oNBKnp4U=; 24:JI72sq92rC0AP9CMn/fhleY6ug39iMlKxh42ZwYa6D7EWNBdhJ++ooNtBFYoLVh9fhD4/e43SscmSUtEzMY9XBPUO8kgoeLeAWPXgpk0XS8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:7LnXWAS8OvgxxLXIu+ke174dKnT8sreAbmHR1tFN+vHz7vYY2EOOeYGUpF/c6hwYf4mdVfaA55CIHowm1nHEWMRZQBZ29VBEHdxbzdkC/wjBgFM0Zqp/LbZR0IWF0rmsmszdEr0ncDOblDYjqh64bXDuq4ZWCZPNWMQO6wR+eKyF0cKa5S7YPojp9XhrUoslFITcT3jeNcDJCbpjr4FdwZshqFLetYxHadiNpXIh1ZvFh/hZQEoujiL7E3GBAgnn X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:11.5676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc9d0a2b-f50a-456d-6654-08d5e3182d63 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 13/16] drivers: support function name in logs trace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_logs.h | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 2 +- drivers/crypto/dpaa_sec/dpaa_sec_log.h | 2 +- drivers/event/dpaa2/dpaa2_eventdev_logs.h | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 2 +- drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index 9750b8c..dd74cb7 100644 --- a/drivers/bus/fslmc/fslmc_logs.h +++ b/drivers/bus/fslmc/fslmc_logs.h @@ -18,7 +18,7 @@ extern int dpaa2_logtype_bus; rte_log(RTE_LOG_DEBUG, dpaa2_logtype_bus, "fslmc: %s(): " fmt "\n", \ __func__, ##args) -#define BUS_INIT_FUNC_TRACE() DPAA2_BUS_LOG(DEBUG, " >>") +#define BUS_INIT_FUNC_TRACE() DPAA2_BUS_DEBUG(" >>") #define DPAA2_BUS_INFO(fmt, args...) \ DPAA2_BUS_LOG(INFO, fmt, ## args) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h index 7c1f5e7..8a99044 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h @@ -18,7 +18,7 @@ extern int dpaa2_logtype_sec; rte_log(RTE_LOG_DEBUG, dpaa2_logtype_sec, "dpaa2_sec: %s(): " \ fmt "\n", __func__, ##args) -#define PMD_INIT_FUNC_TRACE() DPAA2_SEC_LOG(DEBUG, " >>") +#define PMD_INIT_FUNC_TRACE() DPAA2_SEC_DEBUG(">>") #define DPAA2_SEC_INFO(fmt, args...) \ DPAA2_SEC_LOG(INFO, fmt, ## args) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_log.h b/drivers/crypto/dpaa_sec/dpaa_sec_log.h index 9784fcb..fb895a8 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec_log.h +++ b/drivers/crypto/dpaa_sec/dpaa_sec_log.h @@ -18,7 +18,7 @@ extern int dpaa_logtype_sec; rte_log(RTE_LOG_DEBUG, dpaa_logtype_sec, "dpaa_sec: %s(): " \ fmt "\n", __func__, ##args) -#define PMD_INIT_FUNC_TRACE() DPAA_SEC_LOG(DEBUG, " >>") +#define PMD_INIT_FUNC_TRACE() DPAA_SEC_DEBUG(" >>") #define DPAA_SEC_INFO(fmt, args...) \ DPAA_SEC_LOG(INFO, fmt, ## args) diff --git a/drivers/event/dpaa2/dpaa2_eventdev_logs.h b/drivers/event/dpaa2/dpaa2_eventdev_logs.h index 48f1abd..a2c2060 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev_logs.h +++ b/drivers/event/dpaa2/dpaa2_eventdev_logs.h @@ -16,7 +16,7 @@ extern int dpaa2_logtype_event; rte_log(RTE_LOG_DEBUG, dpaa2_logtype_event, "dpaa2_event: %s(): " \ fmt "\n", __func__, ##args) -#define EVENTDEV_INIT_FUNC_TRACE() DPAA2_EVENTDEV_LOG(DEBUG, " >>") +#define EVENTDEV_INIT_FUNC_TRACE() DPAA2_EVENTDEV_DEBUG(" >>") #define DPAA2_EVENTDEV_INFO(fmt, args...) \ DPAA2_EVENTDEV_LOG(INFO, fmt, ## args) diff --git a/drivers/net/dpaa2/dpaa2_pmd_logs.h b/drivers/net/dpaa2/dpaa2_pmd_logs.h index 98a4896..c04babd 100644 --- a/drivers/net/dpaa2/dpaa2_pmd_logs.h +++ b/drivers/net/dpaa2/dpaa2_pmd_logs.h @@ -16,7 +16,7 @@ extern int dpaa2_logtype_pmd; rte_log(RTE_LOG_DEBUG, dpaa2_logtype_pmd, "dpaa2_net: %s(): "\ fmt "\n", __func__, ##args) -#define PMD_INIT_FUNC_TRACE() DPAA2_PMD_LOG(DEBUG, " >>") +#define PMD_INIT_FUNC_TRACE() DPAA2_PMD_DEBUG(">>") #define DPAA2_PMD_CRIT(fmt, args...) \ DPAA2_PMD_LOG(CRIT, fmt, ## args) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h index 598a621..8991e83 100644 --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h @@ -19,7 +19,7 @@ extern int dpaa2_cmdif_logtype; rte_log(RTE_LOG_DEBUG, dpaa2_cmdif_logtype, "dpaa2_cmdif: %s(): " \ fmt "\n", __func__, ## args) -#define DPAA2_CMDIF_FUNC_TRACE() DPAA2_CMDIF_LOG(DEBUG, ">>") +#define DPAA2_CMDIF_FUNC_TRACE() DPAA2_CMDIF_DEBUG(">>") #define DPAA2_CMDIF_INFO(fmt, args...) \ DPAA2_CMDIF_LOG(INFO, fmt, ## args) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h b/drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h index fafe352..4779e4c 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h @@ -19,7 +19,7 @@ extern int dpaa2_qdma_logtype; rte_log(RTE_LOG_DEBUG, dpaa2_qdma_logtype, "dpaa2_qdma: %s(): " \ fmt "\n", __func__, ## args) -#define DPAA2_QDMA_FUNC_TRACE() DPAA2_QDMA_LOG(DEBUG, ">>") +#define DPAA2_QDMA_FUNC_TRACE() DPAA2_QDMA_DEBUG(">>") #define DPAA2_QDMA_INFO(fmt, args...) \ DPAA2_QDMA_LOG(INFO, fmt, ## args) From patchwork Fri Jul 6 08:10:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141274 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836543ljj; Fri, 6 Jul 2018 01:14:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeJblrQQaZITwJQW2cLzxn9XKt5GRsI59PK/HVtjAapEuKNIRnugUXPOFTXDGZQtEjr71H8 X-Received: by 2002:adf:e24d:: with SMTP id n13-v6mr6995078wri.205.1530864875685; Fri, 06 Jul 2018 01:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864875; cv=none; d=google.com; s=arc-20160816; b=hm9KULx+2kIvP5SU1DmaYDrj0U5qkjX4MQYARvIPP6skNVO5w9wFVVkUSkMK4jNxXB G9hzEzDedrNRp7fRVnUwkycyr9LC0q3nMAkZq96HVzHU2b54bgt93cK9MwEYvKTJQYHM KINEQZEdUURw/J3QYdJ72DnA7O/Nx0h991r5QQrF+HeW69ytcAEuHgHV4OjNTR5GZ6fF V3MFdM1IdwX8GQaMuVjwShxp9W5RDnXcXkFJ7UUy29amRbkR2creARhjwfpTqie1C1Km 6O8HUm8mRrskLmTyA8dhd3Qth3fd4NhO7gyvio4H6l9dTIcGHe4pn7iFF/d2wEhqr6eW qw9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=2tQbmhCMWLDfLtddoc4xK6UvltCkAB3EMvu5cy5LNPQ=; b=flhu3sBCnVcdUyC6sT03iAbHDSrCIv6qhXwJebDQVZPDftzHwmooPHvt7XOq1T/Bla Q9QCtqMrmX8lJWbKuFH/SUlkGSkjK5wz2yrFja1Bb/Kx7LjeRxJl0MjaY53l7JE6XEJi BmyxveLMFYewbCHRBdyxpltLw+/HLEvS4LViHnBoU4tycT7f7tLMPCrKcqKKaPHCzvA6 296ERaQ3VoyF8wZiK6ZWLAdF5UjliDneqEx4TQEFuuCekd883Js4l7e3i1GvTrZx97oo FlXbaYJZzES09w/wvm6M3zcJSF2nVY6DuLVsgBLhmr+dNBHwnZBJ6xTaTY6ZsIf9d7tv 66Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=IHExIJOK; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id g129-v6si5968885wmg.58.2018.07.06.01.14.35; Fri, 06 Jul 2018 01:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=IHExIJOK; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10A951C4D9; Fri, 6 Jul 2018 10:12:27 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00055.outbound.protection.outlook.com [40.107.0.55]) by dpdk.org (Postfix) with ESMTP id E3B8B1C48D for ; Fri, 6 Jul 2018 10:12:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tQbmhCMWLDfLtddoc4xK6UvltCkAB3EMvu5cy5LNPQ=; b=IHExIJOKd8DQuwIzVFTahvhDkWtmwy2+vqL0WIHeGU6fDH8OmlHz10fl5GmNZd/ML/0Vxwdi8I1OFeyu/r/yYPL1hhlj+nyBbHMOcKEkpAQsWUM5nOyU2vHDqZNkIyPGfjgezDmMP2ZTF8CNvhpvweXNqr+mAu2/5++wVwUV7ZU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:12 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:11 +0530 Message-Id: <1530864613-11754-14-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42ecf2da-7204-4f26-3c41-08d5e3182e09 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:Shirw11quGpGFtYQSy5QEA8rJr+YNr5McI8FOa8eVjEpqO98xUsfZRFlEaXxXuWYhVnw8Vt7T1JsDnOiMYSNUPVD4+dowf+zEOgPqCweN8VvqXkplIKtOVCTAF1shmQIEVvS09L7mtvEhlaXQI42y+F7UToAY+nHXBWQ9XoWGwCYSJqNr/uf8wq2fddDQtWI+NzFibBGHP0rJPX+k7oWP93BzN4acpzX70qKngKAsjUUO92LEzqYPIIFmcmnsWLm; 25:i8OeRpVOuAMhpKxB/I5v76mj8WIzorDDHAunkLcEpWSAaQ727ABSxfvM7dMxLG6G9HaOCLtwoDEOF23Vnc9DT/hWazDcunTgzDZOxYK0SJNNTzG8wG6lzuFA5rhxwklJ6dYgvJkdbdkLT3lvKOLkHPO/+b3XMDlGBc9lcd6CFCNCn4f1BOHCEhbD2hvA1dXgkdXP1/GLGHA2aKeE5ol/6YjfLulv8mlvkt8wa3g/7kU2ZpzubNfbhROFS+8zKWooZN78Yu6dHcdYwE/eXCyU8gE78b3jQrLt0gfMKjv+ZAIX9hmbsBuvKn0vAodyijx5EUK962z+rf3SWM0KqeEvLA==; 31:0NpggwTOy56dpYmA/F9r4uT8KweoVrRcHSgpGtgwUAIbdYuTb+srDaw1aAj4UUI4Isf3b9I8S22e7uy+d7YGSe0wBzHsLsXZGSnz4nWy72ya+GksF6HeNzx9DybXd6NilqTlyD8jYzqduyC2JSXuUcz4O5EYr7JbcYp2d1RfTZxx6i+GLvoniC9o1/f1ep1WLr4vaSBzXhHM/cXmSi+JXpalVyvd3cOqsTrXUbHw8Yc= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:/dfUg6VoHPMMirvgIZ7MKPhRVo7wCgIb7sDJkOopOc4KxmYCJkFRI6d49P8qg0kjYbWX0vfFKTps+FoP3AOGzc77XzaSNMR9um30uz6dAJgpbYrl7EG6FI0KZPDBu5jdHTk//qqIBsohoufzFdeSpv23hQmNtiaF/YRhUj/7uC9eNqStjqPzVlo8d2iRjbsFc3A2FNLyXnbmW2IUpyO4fa1kgLXF7ujiyfe3+9GkuHYyi6YgF140tTf3am4mV6+OamgYOVgIZHtrZbziofQcCnBdu0c/qDZERGk9j3geD9G4oT9p/rbRp8k+X2Crr3QUfdsD4XQlSBIBmFmJBcJkiOiQ5upw9LdzoH6/SAVwoeHV8dh9mn/J5ONoZk8392uUdy5/vGDcF6H43b/wkS45zf/tbnnd+U74+XMiAouRyZqycQDL4EWkHxPMhyKWVg9vQ/JXF4iWccXRWG1KJwbYJTdKTjyRG6Lx8t+ADqZJM0grpTrt2npWHX6dswrTiBZA; 4:arM7mUWKA3DoDoZWHYvWOEZiOXs/UNhP0yTvc/u0u4orctVxF2DPnAmb9KxM9OzbvWtuBn0iFzKNah8aM+m3ghwUqOsOcG+3ZcSPlG340j+GeDpgxPNFXKud8oJN2Yy93ZBUHmj9Xhq6gRfZAl3X0pT/nv7LLy+FOIUfCkf3jrUUjRGTgB5kczkjXLboGATbfVCTTFBoB6rwXvzhY4sPG1RgT1BK5k9h+akxcGi7wAK8a10H7Yi1JrTRM4h1b+borJYF8vZs/7L39n/zZhnxo9iORYP4KsE8gQ73IU/HlB+6zYZbJYArBimEpslqsLAE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(16526019)(575784001)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:Zpjrp/bCx12HpKFT2aEZ10JUZyp2kzYF7j5oPSF6t?= JvJz54QuBZJ1CRW1oYaf7Lp3xv+zoG4oCho7Y4UIRdorjFkQ8nf4YDlVQ17hZmTFe+aJrX4iw2zmOKjYeihwfc0kVLmstSU7DGCJ5i9pseUQhKEBHIdA6gCWikLKroEg4eIvD+y2Ce99OOBSV0z1tBZWCHT7k5vZgRc8dhga/1jvdWbgyd/fKNVM/18+r9a4byUaN9jlaEcRkU7tZ1w+PUDONV2aa0tFYyDA2nmU/XDZO/GwZTWDAPXYl5+B81DHYbNqpbzRbGlZUYjb0yxdnuiwejxHIE+eRaAFaEYH7FRLpHsf197fUU4xe89JkSQ9UGLE84Wdtjdg0RsoMgDUScZCpTTWs0Gfp48glpcjJ3cOBTJolxCAEWPa4D/3oFckgXGcuvWUij5oifBOnEF5IziHwyu5AphX7gUkxpxjycTCb7iRpDxt72B4I4NhrkNjqL7tvVLJ5XoXIzLypCu/RY7Rk8Jc4fspaXS/yvx+fmke/Kt8ZrjtD20cPEsahFAWu+pZN85dIbCy6fsZfM1r6vCzHhdh99Ws0AGF7diVpdm36CIdZ8KcJz+7fqIeK5b9m1oJSrdbg+nJp35XeAO6zuaI/GUNUU6bUl45YuFf4/auQBGYr/CXkOJAWjY/DI/8pRq8hyp4g9gVkUpWQjDZyQq/906r2vnGqkR2DzL3tcqsSpZD2Q00Q1+IqToF0JJ8oyScN04WAgdIZ9cJ9yfkKqfcM5P8QZxpZkinylFCRvGFyPQB9yoTTai2kQDDWTCBST3LmaOy6/h7/dfKZ2dHUeckjmlY7/vsdz4tQAx+uE3ZPmGlZMny6TAyp49V5D8a8vDB9oS8Y+X+q8WJkLD2iYuluJPkiWwlmnul8jMzQ+4cnqXo391Up92PzjGlkeyyEmmoZP9csa6yUMueWbiJoqWPhHKlj6SxtQfcF7DbgTx2u23YH4OPJtqoZ7yVoM0KdORoLG5+CFc1mIbM7D7qocnDcJ2jQbcoEA1ZspL++rGGT1jL0x3uYWl00ivI8+wQyL2l+yihRQ3ZAixfFWImT2OSbUcvlWqrKLKZsP5VRNy0Yiqt1lWAvo3vAXeieIn/nBqfyaEAqXYqO8aq9jkw+05xeXuAMBwsnSvJBr3EqZ8/EuGJOYCS3Riyo9u4uoVyRmXCPZFyvplqTs1+R8Rwm7AOcWkymNDbqKD+g6gQMnTsDXW0ri8qO1tLg6oVHKD+nbf4dZmCoVX6CQ7K1csOkxIYpZVIGLb8uutM6lrh3pwswVBjkixua7GhOkcsk2j9dQ= X-Microsoft-Antispam-Message-Info: nq7jMLSvLmktW+fsClkTUyI9BO/YTvH0oQxgWPMvS1xr7Q8aSKvJQskwcDL1Xid6bcs8plb1pZCHOikWpnHL502XD4yCPtMkVH3wi0j3W6Zf3mggi/uTH/Vm4G6elx19RxwreU7r3NJX2U5NwRXxPyVeyOcEjfOTkrdGssrKhAMABMNScPZAGtJL9PMbHAsgFtY3b1mApXeu6EEPqb9ZH4lRdP3n+gN6tOPKxa0bCIcOlERuIQEGl4wXMwcztYCcaZuBXMr4anqeXFbkHmXipyMdv0686hfj+ZRfhuNWEO6xdPqH0zDSB3BCVr3ntqJzg5yO24227z4bvdz270NMXsB0yNereDxfNGKdzTfCoJw= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:jD1XWhqQ6UbOTDq4i2GdHUGxCtesQirYuigNmLoRTfqIWf6aDumb2++mb1ixxI9mL9rC/yFSrl1RRkI+2GiuFuKiz0iogqdtK9L5tcBxk7jMWAdccFFbVa2sEPa1ndtbY5yK3jiZlhQ/g3J0D/SfUFmX3t5ByXCUDn6gebl8pI/Guiihi9Adu/U3KuEO437j/3WnhPQJBy8BScKgVOJUs8pn9QGLlqag6IVN1t2Wdk1B6zb+jH4Gb7cyQ/B+6VidbagMY9ql0hbsTYvUvqA439j4NO0q3ylLOmISX4wbObz+QVQkb15o/FzcVH8O/qu+Lmut6axf7uwMNFdrlx7PcH9izivq4Rb+iBTe9SZmWxZEuVC3JdOjbJQODnbMt3QNf5Uw1R4wLqneHRN5/yrwWavNgb1j7lUq/D1AjsghFFmfazgc2LwFbwXJ8RUUI7QoWg/i/OHEFZ1BkWGccBuCCw==; 5:X6bIdZfn646WDLaY5lLUPBVxTx2dUs+/VdtxU46bgBQQ8/sutmE39IJeDULtSPpmb9Uzveb5NhDJXRVGv/l2PHTmjj8smWfU14jofH3izH5LCcqAy+bPnjLwzk4U4hQhl8tGIBa3CRTdBqyTQi8fnVQkVYnQdsdzGCotZY8PVpE=; 24:eFlgJNDcHoOOo1Rx8d1LGFGN4VlrNFLbwe2t+7KtT30wcQn71cv1JnrP+CGqWlt+ibffGDCxLpqJcX0QMNvuz2zLIHhY2mLLxMOT+fbNxbA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:EorIN1KRf1n8BY2biv4VK65L5Ch49FmttOcMMZWJkzjSaGNmqHigi8BpOBfkPGU2mBMpkCL228P6/cYyfcyL+3ItwzPn+gos90K1sgF6Yg/SUWDeBIjSwlsF5QKmCK1Wx4H7FAnTIYpykJhFv5I7rvzZQrSgtsuZkVBva2uC7xArhwjIKnRVlJJkrU7Dd+so6FH39QKOOfg+1Ny3N90uk3aMyrSs1cPWNxbnQ3cEf88//9qTCGvnuz2hlFqgwWLZ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:12.6525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42ecf2da-7204-4f26-3c41-08d5e3182e09 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 14/16] net/dpaa: move the push queue set to global init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 00611f8..5c0aafb 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1174,16 +1174,6 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) } - /* if push mode queues to be enabled. Currenly we are allowing only - * one queue per thread. - */ - if (getenv("DPAA_PUSH_QUEUES_NUMBER")) { - dpaa_push_mode_max_queue = - atoi(getenv("DPAA_PUSH_QUEUES_NUMBER")); - if (dpaa_push_mode_max_queue > DPAA_MAX_PUSH_MODE_QUEUE) - dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE; - } - /* Each device can not have more than DPAA_MAX_NUM_PCD_QUEUES RX * queues. */ @@ -1424,6 +1414,20 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, default_q = 1; } + /* disabling the default push mode for LS1043 */ + if (dpaa_svr_family == SVR_LS1043A_FAMILY) + dpaa_push_mode_max_queue = 0; + + /* if push mode queues to be enabled. Currenly we are allowing + * only one queue per thread. + */ + if (getenv("DPAA_PUSH_QUEUES_NUMBER")) { + dpaa_push_mode_max_queue = + atoi(getenv("DPAA_PUSH_QUEUES_NUMBER")); + if (dpaa_push_mode_max_queue > DPAA_MAX_PUSH_MODE_QUEUE) + dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE; + } + is_global_init = 1; } From patchwork Fri Jul 6 08:10:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141275 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836654ljj; Fri, 6 Jul 2018 01:14:45 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcZwkUYC+NbqmZURs5kkfFEdKXhHkQlQ5rBE0z+pNRCJhC21ThK2fb5bZjkDXLCPMkT9gSV X-Received: by 2002:adf:af45:: with SMTP id z63-v6mr6533422wrc.238.1530864885093; Fri, 06 Jul 2018 01:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864885; cv=none; d=google.com; s=arc-20160816; b=vBlrkVeW6JBepBf3dj/ZXL/EnoyZcvR/H3E7bMBMJgqdFPGQ3/xfpeH9PCTZs3XH/M nQOEYRvB91/1P6IqIpd0SJDbGuCsPEfhp8WXEgvcLfjEytCP4dR6gCs3RORo49WPY07u gajPzdF3JRqr6eMkZKR1c8fJa8ejKzgHbLHUDC3qWKQfupz8TqQg7G0DeXAyF/dtwiHs aRPlDuv4/PDCuDHLSar80KC5pZdEDtCaacQ9pB5uofR2wLCiZ1STDJwfFjEOZts3trri reNWt0jUQ4Pk4sAaN7IGqe7QpF2Rf/loQokgwUpwLeFBBfhtPIuL8urs7yYj0zygfS7Z 7VAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=OkFq+pupzUd2y+jDFi/Y2B3JyDuIIwTLcpk1rVVwK9I=; b=zCV7oYg4yzyydDZGOdpxou50bBuE4yEbsBbRed6Kv8ffNI6atz6PGSPKSAq4oO0k6y CmytCb1LTDiMFeNVMyr357vDbvnf4vno/ug2nQDr80OtHropYQ/qV7VRoXxotHSa+qiE dpj+LmKp+XCZ+8/Boukh891thsiSSYPM+KxhW8FVORf91n4ftjtsUMUs22kDLb9VJVsB kvek5HanhHQ64a7EKPTvoIeN10q9sdFM4GhwO2GdnPLXPM/wnJk5D6KmBt+bjrOmREXq BzSxcKu8l/+Ev1E3MmVoMhM7YI8M29Fh0ePS+JjfcuJXoIR/fiKRvUN42/woOODXc3JB OJxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b="h5prCXO/"; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id t9-v6si90940wrq.111.2018.07.06.01.14.44; Fri, 06 Jul 2018 01:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b="h5prCXO/"; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 349F51C4E1; Fri, 6 Jul 2018 10:12:28 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00050.outbound.protection.outlook.com [40.107.0.50]) by dpdk.org (Postfix) with ESMTP id D061E1C494 for ; Fri, 6 Jul 2018 10:12:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OkFq+pupzUd2y+jDFi/Y2B3JyDuIIwTLcpk1rVVwK9I=; b=h5prCXO/6bpsR16fheWhMiAaCjP5sBxGRz6qSkQ0J7welMCzlY5NNHNgZg8JaUa0QmdQ8o6XPd4Zap+vLPGjJtNY2UJOQLbATtVmxv7dQ13MN9TV/sxlzE9bLeoBBjeZ51WH1B12WrnwsLiH0lYC19xSjhdtX84a61DfUDd5ALs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:14 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:12 +0530 Message-Id: <1530864613-11754-15-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80cd8093-406e-4ed6-09e5-08d5e3182ef1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:rVnqkzAiVQJ3tJyEiT09VDuYsjgENzgXCWQQVvcbnT7d1QUVWP/cDBQfmVmWzOxeJ0IV6IDvEjPWKKJiEP5Vz0bAl6YZoBXcsLuVC2IJKIEG++b/u4/4w66fpD+L0eJUmG3ImEiURfi5CYnz9BDXDbT8FZ047AQO14I4cjhHUODPl8IKRSZni4qtjNpvEgFZMNWrggw0sBCDUR97ODcEmfBA74mX088mTpgMrE+K716bXLe6rJeIu3PKqRwzS4eH; 25:t64hkRw1nJw63aDrivtQm3viHLpQfEHMMScyPwyGtbiqBbUPm031EpHkiXh7P9PEQrBIPdJUymsAambgZgvNOjj/ZlnlGjv5uyFLQFIFrKMEAYZlIyDM4RHOvkUAac9Ipef0Z/vkjcp6IBWIfbFwlLzo2Xbn+ruFCSVqKKxg2T/ScE7YERrUdEzg4HS35qrWWEfM8dl3YoTMCNn3HWCqPL5ntiME4rAylF1+ITPwiQzyrQh2Xp/2HcAqzot1LYjgxRIJHUixf3Icyn9GCRHAtwou1/mNvmEfsKePwa1fEFDMo9+YPvsi9b0wUYq0UwiFJAVdlmxeG7DvZ50lSuwYjw==; 31:rPt+c717d6nGiQML4SNTaMxmpn1NhVTiEJtfBVawZOCfvuxvtjWB0GuqoZ+09KbXvnMpPkV02GEU+uaDBsyFyifiUvHvkPjzMCIl0yZPVyTrVTODYeVKR3T/yX6DCOW1YIuVeoksX99uyVkvjgje/KpBEjf0Q9ag0puO/FCmAnzS/0uvLM5cnLbVszQEvGqT1NHkXdZrKanEv44Zo2jB04KK1uYWLYUFPYqSDE7coNY= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:Dry6Qald/+tLyMUK1+niM8zSlwJ83U01RC0Up79JV2PVzTO2JZ/cwEa13pl44doGX6JoKZ3quuu9o92kplSAGWu/FcMabPsO9+ABFzuQyYrrcfOkLcX3kWkNcuk8vyGWgbXhcOFsCSq9F/5/afgzaPXp8kdKEij2ptfMZOqakhsF98/wEPxKdsbZ05qNspNAcADTO1bGlzKNdvYgdimz73Hrh6TbIUJxbmQb/IgH/SYXw5o67PM63xU8gQprAHm61keFQrhZKax0CYi7ETqAT7dV/cFHgvGXVTF3pzEGlY27/oFZa0OX+wZxXaNfUA9O2av0SHOegUj5YFhwz9XWxVpUxFuxr0aDjFOeztSKcMVmqAiKOKc29oObeo2x5pjWzwWHE+g0ITFDrwRZpf6Xe3JsMas0a27wg6cCDMheJsNGVCaQ0DV/uvp7HwTBx5B69EC+NgETTSYUqlTJpdedG19f5cXnCbKhP7yzWdSmb2vxTqKX2IIBcQeaRfBUNgow; 4:oRXO7EOk+f1+MuFDLrbixCU1WBwLxacKf/M/kHmWdvZgWGJiljyAz8pgYmwz79V2pdPmK4uQCrOUb8p1cHW1LcotwOALBC1PbsmXdMWpxIhvAkyviesbYkxcH7kx7rtSYsPHDkvd3Fpl57nwO6Pnq1IjeKqTw15neX6IXJiJz/lVQ2EPjBnNfwLgYiThelSsrN3inqqhKs30gAi3KGrm2wEEamHHDP8EqWgqrIqAVPJ1ALg9KoHfaOtHniCsicBKXIc8vyLRTTrMD42MOfOHtQfn9sZhROTvomDWihgrzz1tw+GW7nzNXVTmeAQsegzg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(575784001)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:6OjYFlpOSK0TN8JnlhjpbQi4/z5/OJPtO+ap+0YsB?= W5g124xRiUl/z4zmj6yhuO5e5BcdGZ4eMZn5f2HmsOFNSvu8u3hfIEmfGdK4gAK26mod3C//IbqG2yVbiy2Q6MDz+UT1J3LcKV0QahmkYoQTq2HNus4Tc4SfyjgzMcUT8MQ8vjqhH2RTSsLwLBxYcQA513XZGUoIJOCDu0VpSiGD9s+EM6ZiM77UseChUG+HSFC9Qbkm6qHt1P/5G/Vq6rb8RAbGrKDjmMGWgizOtla3DMIgBTr3uPnNscXSiL+4rjzDiSUbQhICFfhyfwN2qwYKfr27uqbApgM7159PtZxbYle0rhnMYSGnusoIDktUbMNwyDZVaxhuDp5oEpyT9XVpvQi6XNEPjMKvEHZpSMBf0/lcil9s+loHQ1teYcvr0ytCNxm7Xd/oPeVcEFxS/sR4zD2X4P4XZOKZdcvQHv5rmjYKtSGTkIRx7YRlQiep8k4zstMZ5IWUBD7R2GhqBm4S+31gdBVIiWIiDCtrt+U09RpVuhtoqGwMx5ar6rbbSuG6zbOtkhkOS+VTyuvfMQhrDeKSqymT7BMpbaBHhqn5cLd8ao5YMwQul0KKjX6y6h0LAHGodQJ7HXo+Tfh2he+32/KrI15jqAe2ntjx+4I4fBnmkRl+rX05jmsul4lyBHD7F+RwcVnjSHRiQuILqGGZoBWq8pdfloTCcbNyIAcYZtyMrJURJeUCmG7NEL77tzM34fxx5+vO1JmDgVKkHYMZpmyx+/QtVI9nwiTUea8TZqOMSO/ubJMBLP85QAQhwOTy+DtKKpfE/kqbIg6B6pSGLvkNOM90bGolm/j4QH8/5QQIUNtwCAx1VvJs8ZxDa/YWMBauLlLXX4TXqflGLPgfVXo+NvCrha7jsqgwkcPZtpizwCNJ1xkbK+YnLQhOxlCEw9QgOf54y/bGFo3h8XpwPeWAyBmP5v27ummgS7PazmVjr302yIcDMqLl1BEKdDLbZc+28i0y1RNV3OAIqiAS0WHI2LuvOkb2q3kk5fLjMaO+jzkFuXvsWQDLo0I1zPPaPP5Xmk81/RNRi5bjfXgTYocKDJZmdn7x72220SyTZN6ieYqy8ErTlUkuGJxRvzTVC7Keohm5rQbmVWEjYwNuISfT1Yf5D0kXR9zGWwiGdmJwfn4S6t+EJ+P7AlEbn9dLicw59HCLSuvpxBuQ+La3lHt6rYF/V8568Y3wp5Xylvkjy5kbgo7ygBP+9vdn1fyPQx3R7ZHFLfTmobs7uleNWmWI/MAVS7638Len3nsjoHVh+C/B/2VwQwURbmSvnJWs8bec6aewPmQNnbkO26e X-Microsoft-Antispam-Message-Info: DZoyFivc/5K8jf369NZTgWEoI3INFHOhkRTFFy/lMJex65oxvyjSWT4KQJNLVIMdNr9H8BZjdjwVk7ZrUh4+y2JT+ttFkjkVG6LwBF3eXOH/AK2IqdIOKI8fer/hJnCMMnQV5cCrhukN5Tg91+qtLbSz+K5c14x8QPp41Ml4S3wgO755a8VjItVwGH1CiiqDsu7BWhbW1wpszyC/RJtqN+sU+O69i5dfS6S31UQc7+m4+G7+r7q7ADEdTmUjPjdq6zc+cced8uRpsz7j9aHHgwJbgM1FEP1NfctGR59nVKqgkpXuqgf801VywtCxij7Pct7Rk9umFxNtUA8Z4Xzw3SIxpMcTpI/szRfQkJndiv4= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:r7feRHgAYn9EKmHEFtYBs55KJM5A9EGQTkS6JHZUDzgIJVT7fDmBRXDmiyo++QttPpbYbvHr06C9WPnyXs0G1vfYPkuk5L1B6/4YtqVkHk5H4TMP07FY+ELnQdKQnu6N1G932hZHapfSWptcfqaV7JDpZuA0ade2d6fBd5Mp4WcEBMluN/61PnVrwbGEQnZb5acBxY1dGsQZ5krhMPvhfTgtILp0PkeFmcKcUnj3YMawT4JlOSnA57z4DotIIUE23KGQx2OCp9QYbQIOPO3DLT1l9F2HE7sIQkFjO995udm0laAXMts/uWYLS8TJgobiTNO5ZPVbT/58APbdDbLmB19b+/hHYfTy7fm8AhINDc3sXiOvyO7tBrJZWFgWsET5q0LmPAWK08xRXEUAqB5k4lsbh4iCXWDoIPfIv33kGGT8n88rk8qpmdIItNzwZx34aRzsDzfmOY+jf1Ek4498Kg==; 5:Gy/9RzpO/yVUIJmjBzWb8b9S2Z5u+HhpNntaYTSIiM1zeSCy2/CvKe9MpLWYQPC/ymVbSgwO+B+tVRYrjXHsDuTV/x9SVat9Pfk00anHzcx3djpmb7mpHN9ScuP7o7xTQ01mXyN6IvqGDCQRj+z+aTf1Zi+gkqOMsheCOr9BPP8=; 24:uE1+XCXF6k1ZRYikpaGMMFk1NSxPOeMx1AAWuqIOH1DQHB1HYAZ+GYP6bTy2dJMqqG9iZsiwlXDVTJhZyIGF7EKdh9Pm0vVojLgatYHdnw4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:IFzS8hkvqVbNBKyqc6PP+k8rYbMJuVQbGRvsvdVyyno1nPbTNzZdZSZ3ZX2STWdc5748miNbSuwx1ZXd+nbyTTWmH5PTC14z1ouNev/BC2oyJlzbXZam6VX4IyJ35ZRGyBovL+P52rjKlAA94yZmW3CDYd6WPaY8LzTqGw0A7aWA67En4zmich/8MD05jIMY4B9qMZdIpxKbGfnNXmgxd2yEhl9XpuP+Qo0KkluCU178cMgx3jAMOObsCI0Wxh+V X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:14.1786 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80cd8093-406e-4ed6-09e5-08d5e3182ef1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 15/16] bus/dpaa: add support for SG config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman_hw.c | 42 +++++++++++++++++++++++++++++++ drivers/bus/dpaa/include/fsl_fman.h | 6 +++++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 2 ++ 3 files changed, 50 insertions(+) -- 2.7.4 diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c index 7ada7fa..4ebbc3d 100644 --- a/drivers/bus/dpaa/base/fman/fman_hw.c +++ b/drivers/bus/dpaa/base/fman/fman_hw.c @@ -16,6 +16,7 @@ #include #include +#define FMAN_SP_SG_DISABLE 0x80000000 #define FMAN_SP_EXT_BUF_MARG_START_SHIFT 16 /* Instantiate the global variable that the inline CRC64 implementation (in @@ -538,6 +539,47 @@ fman_if_get_maxfrm(struct fman_if *fm_if) return (in_be32(reg_maxfrm) | 0x0000FFFF); } +/* MSB in fmbm_rebm register + * 0 - If BMI cannot store the frame in a single buffer it may select a buffer + * of smaller size and store the frame in scatter gather (S/G) buffers + * 1 - Scatter gather format is not enabled for frame storage. If BMI cannot + * store the frame in a single buffer, the frame is discarded. + */ + +int +fman_if_get_sg_enable(struct fman_if *fm_if) +{ + u32 fmbm_rebm; + + struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if); + + assert(fman_ccsr_map_fd != -1); + + fmbm_rebm = in_be32(&((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rebm); + + return (fmbm_rebm & FMAN_SP_SG_DISABLE) ? 0 : 1; +} + +void +fman_if_set_sg(struct fman_if *fm_if, int enable) +{ + struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if); + unsigned int *fmbm_rebm; + int val; + int fmbm_mask = FMAN_SP_SG_DISABLE; + + if (enable) + val = 0; + else + val = FMAN_SP_SG_DISABLE; + + assert(fman_ccsr_map_fd != -1); + + fmbm_rebm = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rebm; + + out_be32(fmbm_rebm, (in_be32(fmbm_rebm) & ~fmbm_mask) | val); +} + void fman_if_set_dnia(struct fman_if *fm_if, uint32_t nia) { diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h index c0ef1bf..1d1ce86 100644 --- a/drivers/bus/dpaa/include/fsl_fman.h +++ b/drivers/bus/dpaa/include/fsl_fman.h @@ -108,6 +108,12 @@ int fman_if_get_fdoff(struct fman_if *fm_if); /* Set interface fd->offset value */ void fman_if_set_fdoff(struct fman_if *fm_if, uint32_t fd_offset); +/* Get interface SG enable status value */ +int fman_if_get_sg_enable(struct fman_if *fm_if); + +/* Set interface SG support mode */ +void fman_if_set_sg(struct fman_if *fm_if, int enable); + /* Get interface Max Frame length (MTU) */ uint16_t fman_if_get_maxfrm(struct fman_if *fm_if); diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map index e00c911..7d6d624 100644 --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map @@ -96,6 +96,8 @@ DPDK_18.02 { DPDK_18.08 { global: + fman_if_get_sg_enable; + fman_if_set_sg; of_get_mac_address; local: *; From patchwork Fri Jul 6 08:10:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 141276 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2836816ljj; Fri, 6 Jul 2018 01:14:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc/B1gTbYHN0ZbkdIGl2vjNGOKeZ1bhQLZgtjVliADi0IkVZ1MLsD7QK9jUcK4NRNBbecCe X-Received: by 2002:adf:b1d2:: with SMTP id r18-v6mr7259200wra.79.1530864895445; Fri, 06 Jul 2018 01:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530864895; cv=none; d=google.com; s=arc-20160816; b=RMHG4x49jzUhPV+aZJbVywrSuA8avWqFCYXSc/Vh3oXZXi+yxOfyFiIKjTOr4qBwQf IIc4LwhsZTHQ7/uh6AUlxy8bPRBL+2nLJ6FNQVJsk0kHmMILfMncIQAaXMZzu9XkK/oJ fFMVTFBbIBRNdk2oON//JTXxBw/R8xfC9oLpVYZlHs/yfS4fMf/nBK1VLmANxIlVX/ap x2ZUq5822Q7V8MeHyHzD8cMsJf7vIK2j9oTfyaPrd+gGL6rVfQ4FW2/t4yx0ycL5iZHO OGso4W4xdqIiiYP+81stt5FIFbUe61YOEWO+SNMlYBYtujpE7Ui8D9EE+RYUf8wO8eNp WloA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=OsLBsMdYSskxlKGg88nmbBouVFlcApTClbJbzTdixnk=; b=IiO5m2J6Cozh/v3PktBPQBJjN0o45avFTvUFmRqpnPPGdOfL63DBx1SrptWHxIR3jI KcGnMqtgiwdRZ+FsMNyqX1yD/m6jdCHy6d6Ho9/Kb9Mf14B/8dbBFQTUe1cx634axAGQ uuMjihOyEYvnMvzGvqYahkwIQ4qqgN9kV42Cxtl3Oke0xLVQmI1j4diWuAwYY6BY1h6o 1e6LlPuA71ftInZT9MZWmeCm1wPQRk/v5ycUmCucZsvCCo1lObBc1YKJz3XlWHDS8XzI d8MaUwvNMsTW0flyobeir83ae55f7WRNqg8KJ5xbN6acX0o5RITKJToC3GWKT/vgbyjd 7i4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=TXyXkzmT; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id h14-v6si6106094wrq.378.2018.07.06.01.14.55; Fri, 06 Jul 2018 01:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=TXyXkzmT; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84FA81C4DE; Fri, 6 Jul 2018 10:12:29 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00055.outbound.protection.outlook.com [40.107.0.55]) by dpdk.org (Postfix) with ESMTP id BC94B1C44E for ; Fri, 6 Jul 2018 10:12:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OsLBsMdYSskxlKGg88nmbBouVFlcApTClbJbzTdixnk=; b=TXyXkzmTrPyDN+MBl0MsEAcysI6MfSeCCS1B1FpukYBK2lviAPWAIkvGeRt4Fwj9AwOnk7yhJkUOCipxf1wADxG/I5stXvf87ikPdO1qAYiQZ+bpTdMDrgLFcXqBCn9gavy3Syjtq/E+To0ECNTkkAtUSM/lL9qGeObYpkFLGHY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:15 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com Date: Fri, 6 Jul 2018 13:40:13 +0530 Message-Id: <1530864613-11754-16-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4db23da7-b092-4d8a-f27e-08d5e3182fab X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:wYUmY9RpHzuUlbDswzr6BW8zUcq9sktuFwemjsVE1fGJMaWm1sp1sz35Gv/3LymIMta8Aok486EQUP9zDM14U6inHncdF/BuchT6d4lkAILIq8IeeR2LPPUGG5SZFUopqGKOSzI60tLz3oDWczl+Ia/+cKEfkvwAmWooaC8uwty9FJ3THXOiVYsnz3LPl/7yjWfXfaB/xYptvX2rOpeMz0guTx/IkUmNJX/3E1diTSlB1EMpIy5Knl3nWRdZqjXC; 25:CGwr7he0/JMdYvvYGxmXjifKlT78Zto7y2wdAM/O+j2LUJvibROLs3uBYv0Tz/AJl7ynLytyg3zUQZ+kTg1w5AB0j4TI7esG22W5srXRdwkBSqM1QOJC5MX5nLnpHjevDg/tsfZRLs98TKz8I+kaOAryJF3kQBsJpeiWdcKkXdkA1RguHIfK8qPgTB+DO3tyiKsdpNHZE8K9HF9IS6XUXU7dwzxnDMhKmgiiQXOHX/jNIG24yoiGaLxdbMWUBKn8CRiV02UnQq/UbjFTb1khN4ZmvRYjvvl/hSMH5utnOXaY2Ly2UEGaMNLODJaBzpsG2O/nc4guZEhjlm6cq3X5PA==; 31:5pWlPQtW1ngHQJ1GRiMSjYcuHRkPOxPFj1TWfy3TssypXimbKTTKkIFCqOxHAiQrYIvZmjFLq+bl3tLkysPri9bngBFET/K25jEr1gNxbzdYm/6TDTvDBYeguhQrpf2vWVGluiu4ouQbJe62nRhmknBq/p8d2Gd/5QZW48SV3odcOBpSYl0cDdTmxo9PaeXyuZ9kAWLCyJIBGNONzGLcLaEcmbfH3gxYuG97bipvN9o= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:vaEc6Fh3WRbAvvIicSysKTr2Dk1Zd40vqlQvOctrxtEBgDsHVxSw9+q1BF/O7KBhGLrz8SPepeoZdsatXZiyOQdapQfByS7dt9AQTOGGGFBmmgUixNU9lAWb8kPeNYgsi8vmPNQmcXy3hsvr5iSXr+O82pTyHc2T2gP9K4+7Q77POEycvegFv0h+Xuav44qtlTVfQtAw4QdQD+cGFBqcM5xaSQR4Fl4xYBAH2i6+f6Z9jSAm2axwtk2u8qkDek9KroPzf1HgtbUupkJYerWciQOnPvHeSAWK3co4x2cUA1gukld1mJHWyj++HlIhv6ln6NIUJqoVHeXsnTh1vtweuuSdkzRJ38aCUrDoR9tOuyGnB7pkmTSfoNK329maFk37N6PV5ViZBA5+16owpWoXSc/LojxqsyHMD2B3vEMt8XySH63nj/a4RpqA5SGukyCN/cIEGetbTmHeRwBeEiU+IRCxf0McDmP3xVvjwEoC93aE0qpzJ9oaIqMmKUrT3Ag4; 4:MMFnY+hP+9EskAA5ihGZwqOS3QkXuNlC2UbNEegt1VOCJo8AII8UzcPKM7vD2D93rJWM189Ga2X7tGAF9lyGoKoED8IwNSBlylAOR0qjAMqCnFsHfaRJIlAWHebVYTRTjfdv+ehp5c8/ZY4rhMZAPxmcLcrnpghCyEVVYOvXLNVf56g7aQbp52jn8efwNYGD3gXPZEZMMyashmQK6B4osJT6ymm1Wc6jCBThONsGEiM/k0aqOr9VpUQMzOGNrof/p5NhU44SKQWtoqhnF0WDF8g5oR7kGh3bEZEy6ddfJfe+EVJehDEHKzVD3l3oTV3V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(136003)(396003)(39860400002)(199004)(189003)(6512007)(48376002)(5660300001)(68736007)(36756003)(8936002)(50466002)(305945005)(47776003)(7736002)(2361001)(8676002)(2351001)(52116002)(316002)(81166006)(81156014)(386003)(53936002)(26005)(55236004)(6506007)(97736004)(51416003)(50226002)(186003)(16586007)(14444005)(16526019)(6916009)(76176011)(478600001)(105586002)(86362001)(575784001)(66066001)(956004)(2616005)(5009440100003)(476003)(6116002)(446003)(486006)(11346002)(6486002)(25786009)(2906002)(44832011)(3846002)(106356001)(4326008)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:EQyoY3TxuRMHtcvqSX51E7XOK4xjwAxSPYD5lUynk?= rd37AFEMWsAg5bicRGkHUpro2s263drOKjcs3wlxkJQItAz69ggeXlq6SEx5+oQClJcK9fxHpA8N8HBLMwvFMfV2lI1rTXB6tyKf1bAVOGR7K1Zu7a/3t/vkG+G5qlybyOnKiL73Uu8JGA8rj7aoVDppvSBKO3hVk4odXaao0GoQaGtifuQnVNqulHPnO3Vv2RGyMoZ9bi1TiOzJWRtbDrlIKXg/xTlMO/fnyfmvPU+MOdeTlleTyM4KTmkHxrIMACuPvunum0uyZkdaq4pMtnFWqC2WuRVnU10V7zLsO8rN2m7oqMZKHjJ5H+kgEmOAvjFl5IGUWWCD12I1q9oo8394DpN0UU5POeH8ESod0ML02GdkkStrG+vQ42ZnAphXBzlPLiwtRxskL1GPMkPiH/L2r3Zghf11yvpS8pie/kCBycnq++Q6tXD3nq5ntcv6YRsXN/R95j4LhHo7Jk52TIsgI3Fu7AyPmASU6kK8qZQ5YhA6i8ISaWLKSgsT/8F4B6tEY1tgMpzn6vC+NYfe814UXTRNgxQDjpqYcmNhVzP//Quxam51kDxAy/q3exj1RpY7wxlxziknravHNNeAgqDpeO9/Bf9h3QE/VJTWXckbrypKlRGNWN8JoNWLm4tAQEeyYhrxhIX75+CrFA4ndSToZN+ZLVExRnIeB5dKYbLBCJKntAQ1kC55RP0kq4CBdLVfZHtAicbGL3Kn7IuLSXS+qTnw3QpehGhPBVE8peQGOWmNvBtMm2zLqsLl7yiu+wwotRHz+8kZDZa6o9ukaUwA7H81yKXRaOfG4V3sw9aJHOMjzab2DYOvqOnSWRTJKIZswHRTfKMHn9uxNYGYO+MNs5TSOxwDBDLyJOXrh2w9UqdWCQCppAYQVgzKMn+l+JXHl033xwxtIHEyDDmJmz6u4K+m4EkJWmf07nYjrtVevMum7ZYc/Sp8EocT4OxBWuEBo30tTqw1tpE0T62XYKd80xjwAySms6JKE6Jom7i6Atf2RvzU3w5lEWo0NdEIvZ1Wid9fQWu6LTD5en7eO6ZPMMzCcGGyEHcjPw3BBRopTfRbvvbXmf+HYSogd6mtMmKHZVmHTPyXkWpmbpaxTws7Rb6u63hYiCLQ3e/JPOOQ4yzs5LssOFud1xO+LJwAJS3d0U+ElSK1uQn+h6JEMhqvbgoQXlTOoMOw4AyLhKmuzR7uIJAC9rS2mF5QvElGE+ITZCkJElmqcNvRS8+yPkclWd5taxgUlYYu7042t6FGwKDa9M5gpPNghceCD63enLmxwjd2lSlUmVpSzx1Vzrv X-Microsoft-Antispam-Message-Info: E4pehGxwH6Vapx2u6CZbzw31wP92UPy0zpWYzMymfIMa12ab2vws15pD8yE4VIhmz7c2D8Xu/cedbpSOhI/3mAjdoPGNfvaOx10s6tJysKdWfvYZK1UuUSmoox6pcaAwcZFw53wpdi8oILjjBs8c+aJuY7ExGy+EGgKteoDAToZas1AIjpXRMyUWs2wsZABSg8lpY8iI+UoAUjfs6b3CT+Oah4hhbS5nkKWsq1cWDldW/Lrv2+emI4RdmVGwpKjM63LOOpnq/CZrifPPheUKoP4+Ma8lnhT3DhCU9MbTPi2H3iVQ983Pj66WwEyG4rMlZxz4uYOkPBhT1UCwPjzf8DSymT4do3dE8Yxk5nrF1Vo= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:fwR4aBNvrit1acccuYvzu1b3SYoQkne4Pn77WP01jDp4L8ZkBhE/q+hKxiEr++ERL8ayx+v+Wf+jR5IpD8HUXwM2ab/O9tVFchqvIZn81yF+2cdpTKlL3ASzSxiu8h2Qj1ANuyWn0EvVlB4TBXhnRG6Uss0XhFqZfZgQw5TheSs67QYnaFwjzhqEAnJCHbfoGW4kffD8T8ljVcore/F0w80YUX3lnZks3DK3nxfpBGtsHZTdpaCWkQ/JO/TJg9G8Oywn/lpCcg6ieLPnzjwHJwaq+ctsdhuMLmQzbdirMcu4K/lkbrdrjfwUMnYo1CvPrSR02p6Rmy4Yhy9FSlQWY3fTle4Isg0cdEQYvWeNH2U5XHeBFHAQ7WGBUhVPfniSAcasiPpmEQlGco3CNzD//y2+wi6dVzfUrq5XsALovUwnqQNeVbc328UIYjGHzSmeCxowHgdPE5AII3SFVBRBpA==; 5:6Fgety7kMj2qg5DfRWLgYSGRcL6SgJINs0nigDNoYdOChqPYw3ULr9CBYGF/IaZKTNQeUsaPhmXI9TSF9+PYK3VYliWZTFSG1Ns1LCkMP5N18iUVuu9W/FIttOWQNRMF2I8A51olsdRUiKosyTOCv3OKSD7BQv95ouxn67Cf+Uw=; 24:b6TmKjNm3sox2zp0/EXZj3c8PLo2cwvl1vmZ3RddLtPPzIXoPLM838aDC9rWJ0tmd/u/Xd/VDnfpXvLEoaRuULdL4gnOJb0omFCVfTedubw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:RTrH3LNdeTLTCQcAQ7BlFav4ePABfyqi9qkBeRqM+pI/TwCZKxTcW6GIGy6DUBoOVersrG68Q+tV5qmQHkz0iRdJrvmb+gq0igsVGwsmq6bc1p2inICglMzYxvJrWUTybDbKDDoLU1RehzPM/iWtTChPqpHrck8tNeOpgHmiNAoCC1M3ztiZhvZZka8Tbogh7ecorffUvMlx+TeqEbCdpszmhVmkrYLPWJAvyiezPJ4ZaEmG+/Zu7FCVOPddu+/5 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:15.2464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4db23da7-b092-4d8a-f27e-08d5e3182fab X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 75 +++++++++++++++++++++++++++++++++++++----- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 4 +-- drivers/net/dpaa/dpaa_rxtx.h | 2 -- 4 files changed, 70 insertions(+), 14 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 5c0aafb..c49d3a5 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -47,7 +47,8 @@ /* Supported Rx offloads */ static uint64_t dev_rx_offloads_sup = - DEV_RX_OFFLOAD_JUMBO_FRAME; + DEV_RX_OFFLOAD_JUMBO_FRAME | + DEV_RX_OFFLOAD_SCATTER; /* Rx offloads which cannot be disabled */ static uint64_t dev_rx_offloads_nodis = @@ -55,8 +56,7 @@ static uint64_t dev_rx_offloads_nodis = DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | - DEV_RX_OFFLOAD_CRC_STRIP | - DEV_RX_OFFLOAD_SCATTER; + DEV_RX_OFFLOAD_CRC_STRIP; /* Supported Tx offloads */ static uint64_t dev_tx_offloads_sup; @@ -148,11 +148,30 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) struct dpaa_if *dpaa_intf = dev->data->dev_private; uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + VLAN_TAG_SIZE; + uint32_t buffsz = dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM; PMD_INIT_FUNC_TRACE(); if (mtu < ETHER_MIN_MTU || frame_size > DPAA_MAX_RX_PKT_LEN) return -EINVAL; + /* + * Refuse mtu that requires the support of scattered packets + * when this feature has not been enabled before. + */ + if (dev->data->min_rx_buf_size && + !dev->data->scattered_rx && frame_size > buffsz) { + DPAA_PMD_ERR("SG not enabled, will not fit in one buffer"); + return -EINVAL; + } + + /* check * >= max_frame */ + if (dev->data->min_rx_buf_size && dev->data->scattered_rx && + (frame_size > buffsz * DPAA_SGT_MAX_ENTRIES)) { + DPAA_PMD_ERR("Too big to fit for Max SG list %d", + buffsz * DPAA_SGT_MAX_ENTRIES); + return -EINVAL; + } + if (frame_size > ETHER_MAX_LEN) dev->data->dev_conf.rxmode.offloads &= DEV_RX_OFFLOAD_JUMBO_FRAME; @@ -196,13 +215,24 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) { if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= DPAA_MAX_RX_PKT_LEN) { + DPAA_PMD_DEBUG("enabling jumbo"); fman_if_set_maxfrm(dpaa_intf->fif, dev->data->dev_conf.rxmode.max_rx_pkt_len); - return 0; + dev->data->mtu = + dev->data->dev_conf.rxmode.max_rx_pkt_len - + ETHER_HDR_LEN - ETHER_CRC_LEN - VLAN_TAG_SIZE; } else { - return -1; + DPAA_PMD_ERR("enabling jumbo err conf max len=%d " + "supported is %d", + dev->data->dev_conf.rxmode.max_rx_pkt_len, + DPAA_MAX_RX_PKT_LEN); } } + if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) { + DPAA_PMD_DEBUG("enabling scatter mode"); + fman_if_set_sg(dpaa_intf->fif, 1); + dev->data->scattered_rx = 1; + } return 0; } @@ -300,7 +330,6 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = dpaa_intf->nb_rx_queues; dev_info->max_tx_queues = dpaa_intf->nb_tx_queues; - dev_info->min_rx_bufsize = DPAA_MIN_RX_BUF_SIZE; dev_info->max_rx_pktlen = DPAA_MAX_RX_PKT_LEN; dev_info->max_mac_addrs = DPAA_MAX_MAC_FILTER; dev_info->max_hash_mac_addrs = 0; @@ -514,6 +543,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, struct qm_mcc_initfq opts = {0}; u32 flags = 0; int ret; + u32 buffsz = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM; PMD_INIT_FUNC_TRACE(); @@ -527,6 +557,27 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, DPAA_PMD_INFO("Rx queue setup for queue index: %d fq_id (0x%x)", queue_idx, rxq->fqid); + /* Max packet can fit in single buffer */ + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { + ; + } else if (dev->data->dev_conf.rxmode.enable_scatter) { + if (dev->data->dev_conf.rxmode.max_rx_pkt_len > + buffsz * DPAA_SGT_MAX_ENTRIES) { + DPAA_PMD_ERR("max RxPkt size %d too big to fit " + "MaxSGlist %d", + dev->data->dev_conf.rxmode.max_rx_pkt_len, + buffsz * DPAA_SGT_MAX_ENTRIES); + rte_errno = EOVERFLOW; + return -rte_errno; + } + } else { + DPAA_PMD_WARN("The requested maximum Rx packet size (%u) is" + " larger than a single mbuf (%u) and scattered" + " mode has not been requested", + dev->data->dev_conf.rxmode.max_rx_pkt_len, + buffsz - RTE_PKTMBUF_HEADROOM); + } + if (!dpaa_intf->bp_info || dpaa_intf->bp_info->mp != mp) { struct fman_if_ic_params icp; uint32_t fd_offset; @@ -553,10 +604,13 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, fman_if_set_bp(dpaa_intf->fif, mp->size, dpaa_intf->bp_info->bpid, bp_size); dpaa_intf->valid = 1; - DPAA_PMD_INFO("if =%s - fd_offset = %d offset = %d", - dpaa_intf->name, fd_offset, - fman_if_get_fdoff(dpaa_intf->fif)); + DPAA_PMD_DEBUG("if:%s fd_offset = %d offset = %d", + dpaa_intf->name, fd_offset, + fman_if_get_fdoff(dpaa_intf->fif)); } + DPAA_PMD_DEBUG("if:%s sg_on = %d, max_frm =%d", dpaa_intf->name, + fman_if_get_sg_enable(dpaa_intf->fif), + dev->data->dev_conf.rxmode.max_rx_pkt_len); /* checking if push mode only, no error check for now */ if (dpaa_push_mode_max_queue > dpaa_push_queue_idx) { dpaa_push_queue_idx++; @@ -1304,6 +1358,9 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) fman_if_reset_mcast_filter_table(fman_intf); /* Reset interface statistics */ fman_if_stats_reset(fman_intf); + /* Disable SG by default */ + fman_if_set_sg(fman_intf, 0); + fman_if_set_maxfrm(fman_intf, ETHER_MAX_LEN + VLAN_TAG_SIZE); return 0; diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h index c79b9f8..1e7a656 100644 --- a/drivers/net/dpaa/dpaa_ethdev.h +++ b/drivers/net/dpaa/dpaa_ethdev.h @@ -39,9 +39,10 @@ /* Alignment to use for cpu-local structs to avoid coherency problems. */ #define MAX_CACHELINE 64 -#define DPAA_MIN_RX_BUF_SIZE 512 #define DPAA_MAX_RX_PKT_LEN 10240 +#define DPAA_SGT_MAX_ENTRIES 16 /* maximum number of entries in SG Table */ + /* RX queue tail drop threshold (CGR Based) in frame count */ #define CGR_RX_PERFQ_THRESH 256 diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 168b77e..6e96a80 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -306,8 +306,6 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid) int i = 0; uint8_t fd_offset = fd->offset; - DPAA_DP_LOG(DEBUG, "Received an SG frame"); - vaddr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd)); if (!vaddr) { DPAA_PMD_ERR("unable to convert physical address"); @@ -349,6 +347,8 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid) } prev_seg = cur_seg; } + DPAA_DP_LOG(DEBUG, "Received an SG frame len =%d, num_sg =%d", + first_seg->pkt_len, first_seg->nb_segs); dpaa_eth_packet_info(first_seg, vaddr); rte_pktmbuf_free_seg(temp); diff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h index d3e6351..6de70a7 100644 --- a/drivers/net/dpaa/dpaa_rxtx.h +++ b/drivers/net/dpaa/dpaa_rxtx.h @@ -32,8 +32,6 @@ /* L4 Type field: TCP */ #define DPAA_L4_PARSE_RESULT_TCP 0x20 -#define DPAA_SGT_MAX_ENTRIES 16 /* maximum number of entries in SG Table */ - #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63 /**