From patchwork Fri Jul 6 12:48:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141305 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3075518ljj; Fri, 6 Jul 2018 05:49:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeqPsslijRDgRUvMM6k8NCJ4Wb0laqlMlcg5dhJIocH6Os5kHdL2ztU0QQmlNCPnW7zKnG4 X-Received: by 2002:a17:902:a60b:: with SMTP id u11-v6mr10189351plq.158.1530881368808; Fri, 06 Jul 2018 05:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530881368; cv=none; d=google.com; s=arc-20160816; b=hgAsJ/8M71BIj7NN+Xr2YswcSyCCAMoOvrAGqufd8V4nsB6spb1kVZAI/l7Nuy6uYR eSZZBibILZ4GSc/jw3ij7YY1yl75ebRjNUBBDHqXjkDVrKzY1sWg5ajlW6feq98W8B75 vmu2p7mw5x9uh6PlQyg9RP/pSeEMagQlG2haDdWl8LL+rruxdgTn9HMtY2ZjNb/OTBcS K4vS8t6TS0N+WHysNvbTznj7zsqtgUm4r0E9TLElBioglUPDBmzsa6CnHdqTrZr3DDd3 PuThkwXMG9aiweRUvp77mSxBTNb7xrHeywuMN/eICyMxDZpuj5hEpVvL/ztWmfy4hUqS RXWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=1SoTS0eXwjX/+446iRIPbIeHiokhcQlJ/B2YyNQA4zI=; b=V8eRyXyX36CbtjZnVgKa2Bck7vAlShezd3+z/vLuRjgKd/wyHOyrg8oBFut2K9VPIB VwMlVvnPChCrhIpJYdMtvdwOiVDtyoS+FsN4nwkm9t0mmjtBcnr7gbzxXt/eBpBY1tWF de9CPZwTmB/qzJo5T0jJTzyc/nNjIvytJvzH7khTs+uok5dg0OQOygeUjv2eZHSvGX/J GubsqBtfmLadwXhQnnzJdbxjlyoMhkbV3sFVEkggPkG4Vcec9+yJqTVZpTI+yTn8KnxW D/A8Lij62KlZrCBfpsrxhA0jEK5ls2kOyB20dLBY53NNEADtjSkEY5cUoee7OGO7VgdV nPiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2-v6si8046717plp.459.2018.07.06.05.49.28; Fri, 06 Jul 2018 05:49:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933302AbeGFMt0 (ORCPT + 30 others); Fri, 6 Jul 2018 08:49:26 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:50703 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932569AbeGFMtW (ORCPT ); Fri, 6 Jul 2018 08:49:22 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0M1XmT-1gPota1r45-00tPRZ; Fri, 06 Jul 2018 14:49:03 +0200 From: Arnd Bergmann To: Jessica Yu , Russell King Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: module: fix modsign build error Date: Fri, 6 Jul 2018 14:48:47 +0200 Message-Id: <20180706124900.3294525-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:xOGyPsidIog15L88nfSJv2PQVsq3aWtSU/GyaHNoNTFoyuZxc+x E9SpBcFCYUr2qngnvoVPwlYhL8OqLdjzKNnBZvSeMIShFaBKHYaelUFBqapkaC0d0mmB5p+ yzlQARcnBN4nPHK3BLSlkTiDJB0/7P/x1PqrItvxUfTCu8ZIN20fzvugm9RBYfCo4PZYLCd /EMzcm4lTIgPF4wdi6rKg== X-UI-Out-Filterresults: notjunk:1; V01:K0:ac1ydgGFRw0=:lFr7Hfj7f+1mYNkJDUzpmE iW98jm3xCPVV4OnkWjsfZiGUgrHx3iEa2LwunmT47OLSMNZWnhTNH3ECxd/2PVL0ANw2cqidn 1FY0M+OBM0FblMIw8vmVaFCVL85+Ws5tEnAcCgOwyQjPcgAZeCJzFgQ9HZxpMlIb4Upapz1Pz PsJV/5Jtlpsx/lZPaQr18FLGG1XFh/ky4dgbGnA/8Pc6zyaFAMZsSx9KDYxrxb0PPp9wAMbBs Hz84JKuO6CnO9YRixrUIR2tkuT/ewO8r8dDh7d5gRMD6Tp3Aw1vm5gp9qqrrgZMfv9gC8H+Zv XDNTyjy+ZyVYq5mGRSLNOaofUnFYU0sUzPQRZDFGwQsjywwToQucjebiU6xRCig8SLEZTNOXk mcFtouz2xa+hC9ifb4dRp4s0TefojBP9V4Ri5WrvFJEx+MsM39JYHeOU+wpBg+CZq0NfgiDsT sapKx7/KStMqowc8uEKnIkTBDSPE6If1U6xwOLigIWh5ThRmJ9iNeG4mpZQB3qBEd+KVENaUO 4/gaDw7zcXT15DqNtiqONcn3PUGa90YLnsjSYVdFr7veZKXBbuJJRu32AqP3tiJDSWUQ+q57H vVCjU4hFS2kmxCNUzc+nsqqNCO3m12ZAL75b+8g9Wq8DQ3Rj7nPaNSBLmSf1kn5j1aPbDsHC+ tcykvKFHXQSFjcBFPV/9SfsqDPzXXpBghgVs503LSiYw6RYlBdpe6RtNzgYwyQNIwYhY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The asm/module.h header file can not be included standalone, which breaks the module signing code after a recent change: In file included from kernel/module-internal.h:13, from kernel/module_signing.c:17: arch/arm/include/asm/module.h:37:27: error: 'struct module' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val); This adds a forward declaration of struct module to make it all work. Fixes: f314dfea16a0 ("modsign: log module name in the event of an error") Signed-off-by: Arnd Bergmann --- I guess it would be useful if Jessica can pick this change up in her tree that introduced the warning. --- arch/arm/include/asm/module.h | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Acked-by: Russell King diff --git a/arch/arm/include/asm/module.h b/arch/arm/include/asm/module.h index 89ad0596033a..9e81b7c498d8 100644 --- a/arch/arm/include/asm/module.h +++ b/arch/arm/include/asm/module.h @@ -34,6 +34,7 @@ struct mod_arch_specific { #endif }; +struct module; u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val); /*