From patchwork Sat Jul 21 20:00:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 142506 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4383300ljj; Sat, 21 Jul 2018 13:01:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcsrgKZHAtyE2yTQL/WphFllK1MpW1SuY5KKuQGd8F0JBUIDcfdhn8oCaTNVTqLN28aFUas X-Received: by 2002:a62:6283:: with SMTP id w125-v6mr3186604pfb.108.1532203265529; Sat, 21 Jul 2018 13:01:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532203265; cv=none; d=google.com; s=arc-20160816; b=cIzdqNfItR833lGWx3DS2SEtfdAIz37wNyM0NUqWNL1LrKkVQ3KAg2X6eMuGgcHiZh 0l9/gf8VyTqQIU+Vb8GmnptFgIFVZNFtgGywkouKaBHM7wDFnTddN05aUSlAKKFEfPPW tO/EToH9AnHswEndKaFnfi+/dtB3xLjpSkrxw776rsidhYwdymAXGGwBY+U0VqTBVYOc i6ZmzT92/b05HZHWATqTTkPcBlRsjSS1Fdn/NKGbxp47eHryQwhujd2dt6LHRpoAuWeJ jD+LXJ1Xx+KxlwLCUocxSKHpm/iSaMtH6Fe1CIYOL1jX8e9wA88ygw4pMYVdCtvPijzt zSMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=f+Q+IdSlDjHDyIp31hmZ6I/QGxqGx/Z2Fo3yoqpRJnI=; b=doT28zFneBGAuq13GfG3umfrM3v38/xR5U/Gb/GlkYrJTOVDrOLxl1H1O59XjDgsqA D3P4V3kl5c4vAUxiuhMbKDBMcyendipbtiqF4oYPHIPJFFn+/ENVsYQauJJYqHavgxmQ BlZsrfzY+37wjmACQGw5Tw/+/Unb9QRnUNwXWwWgvqaTlH9GnYseswCmx7zeosAvbwAO Y25+qKhzFyACs1tA0Ftkf3INeF2JZgvGYTgd8BGqQCnapmlHEEYBsF/6yK+SbVRkC4cY CJPKRYeDn0UZF3fEl7qZ8t9mWLICFH3HDefPYjGtkmLdysfR/eSsdcF2SAKb9TJ6Azai dmsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dBAvNf/2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v127-v6si4829575pgb.200.2018.07.21.13.01.04; Sat, 21 Jul 2018 13:01:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dBAvNf/2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728159AbeGUUyy (ORCPT + 31 others); Sat, 21 Jul 2018 16:54:54 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:40653 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727952AbeGUUyx (ORCPT ); Sat, 21 Jul 2018 16:54:53 -0400 Received: by mail-lj1-f194.google.com with SMTP id j19-v6so13741483ljc.7 for ; Sat, 21 Jul 2018 13:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f+Q+IdSlDjHDyIp31hmZ6I/QGxqGx/Z2Fo3yoqpRJnI=; b=dBAvNf/2G1EI7ygoCnXWdxKhSV7Xke+K5mae7QppgbURx1yA7rNXzBNZ9GwDgrVMG8 FZn+j8y9ao9yg1yHLfU3AWFPzppeRyQscO7mYAtAOQ/5yoYVN5U6E08oM1x/QN1A6glf QtLM5X0fYbG3OyOjoVL9XLc5hf1QGlNaiNKdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f+Q+IdSlDjHDyIp31hmZ6I/QGxqGx/Z2Fo3yoqpRJnI=; b=jbrAkrcFWw9UuLHJ+/ptF88F48FRNhtXLRqaZKx9wXTcSWMNzZBjuZEK9cyoJLI9cv 8VIM7TiKj53mOm91EUjiF9siA5CEKGwGwjpO+ijraJWfzHvHpGievcus8T9kCtY1udW0 90CAEPhHkUp21xkVBD/v8rPvW2L/vU5geDSE6JGNs+BRUTL0DysBUQfEUUpZ7MnQYTfl h93Xr/JNNZsK4o0RTeMyD4UCrPNvgTyZBJ1UBGOxzFGVzeqIM8+zWLsjv+p2TBgYzj7y htYnHScnDhxfz/knp7YMAkR+PnDg0viR4wr6r8AKMwlYKgKuspQVXX2ub4Ns/g8BG1tj jVQg== X-Gm-Message-State: AOUpUlFEf9ai7ARohuiWwS43t3tA+XGBrSLE6AvXXTvkZdC8AgG6WBmy K6TcnrwOX6HMUeGnXjAYOC2ekw== X-Received: by 2002:a2e:9a16:: with SMTP id o22-v6mr5215940lji.17.1532203257300; Sat, 21 Jul 2018 13:00:57 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.bbcust.telenor.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id q65-v6sm772607lfb.80.2018.07.21.13.00.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Jul 2018 13:00:56 -0700 (PDT) From: Anders Roxell To: miquel.raynal@bootlin.com, boris.brezillon@bootlin.com, rdunlap@infradead.org Cc: linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency Date: Sat, 21 Jul 2018 22:00:49 +0200 Message-Id: <20180721200049.7553-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this error: drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’: drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’; did you mean ‘down_read_nested’? [-Werror=implicit-function-declaration] bank = of_read_number(prop, 1); ^~~~~~~~~~~~~~ down_read_nested Make JZ4780_NEMC depend on OF. Fixes: ab99e11062c1 ("memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y") Reported-by: Randy Dunlap Signed-off-by: Anders Roxell --- drivers/memory/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 Acked-by: Randy Dunlap diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index a642552dfdc9..63389f075f1d 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -123,7 +123,7 @@ config JZ4780_NEMC bool "Ingenic JZ4780 SoC NEMC driver" default y depends on MACH_JZ4780 || COMPILE_TEST - depends on HAS_IOMEM + depends on HAS_IOMEM && OF help This driver is for the NAND/External Memory Controller (NEMC) in the Ingenic JZ4780. This controller is used to handle external