From patchwork Wed Jul 25 13:43:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 142856 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp837102ljj; Wed, 25 Jul 2018 06:43:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdR9d/k0CqDUF+jZ90r/vtax+gLu1srRxVPu2k9qaZS64bnu0lujW67HmX6cqHDxL5xcZRK X-Received: by 2002:a17:902:6907:: with SMTP id j7-v6mr8494092plk.323.1532526223282; Wed, 25 Jul 2018 06:43:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532526223; cv=none; d=google.com; s=arc-20160816; b=uWUYUK98KTC3/S01cvi9KaYZnIYbpxFmCQVR7xod0nBMHY+Z/vh6du0Sl+4up0DCxj Qoh3SwsQRyMRa7dVchY1ON5dLUgt5Ut+IKraFQpcMOEoKiaQqM44UnjIpWFCjVQoQagO vHVpYYSuDQZlXsRKFecM/m9XdIUEAajgM7GwqqTKeuElGcJt5P0dNh2T8wC1MXK2gpTJ afqtOu/NM8DLZHw4QpF/8C7uoK4rCoryC62zrXzHz32boGMYJeFZ1e1EmerMk6mtcNS2 1H8IRjQkuyJ6l5YFk+cq/zj7SbsfX2h/wjeN3hXLpFqrAd+Pfco3CSAPcI3Rx3shFcAp IceA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:to:from:dkim-signature:delivered-to:sender :list-help:list-post:list-archive:list-subscribe:list-unsubscribe :list-id:precedence:mailing-list:dkim-signature:domainkey-signature :arc-authentication-results; bh=1BMVILm40Ed9VIh5iX2ue+hbJsNqOtBWQR0d/qiL+Xw=; b=vdWowvVY4ipN4AnyHOi7sp34EBDgFbmamSH2RzKBtsOoKPVGYhO9bgbkaMnJCMBPKf nmuraK3/whxCHQuQLaNFk0sPGltAxyFUcwmqcQQQ6eVcQFWrWoRih+2d3FXtFs82x1oW impA73P8gOFNuGcLs7ThMJTVTQ59bElg2jM0BlTcqSemHWOKObQMLIyRThsLGslAaLy4 83caI4v3Z3MEnTorOQ02ENZ8zkjBWXx3eqKxtAT/4jkFbHrdYW3BeK0SYElA/ZbhBL9P UZCVV0xiAr0P7ihRVXXBa68EtsW1TuJd/5h+NvHlzFC2NpiUZ4VfgGb/llEHFd65d2kg /0Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tN+449YY; dkim=pass header.i=@linaro.org header.s=google header.b=a44R8HRO; spf=pass (google.com: domain of libc-alpha-return-94695-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-94695-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 82-v6si13404094pfo.229.2018.07.25.06.43.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 06:43:43 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-94695-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tN+449YY; dkim=pass header.i=@linaro.org header.s=google header.b=a44R8HRO; spf=pass (google.com: domain of libc-alpha-return-94695-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-94695-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=KTN1IjhZxvhIZ7fCDshpsRO8DQRlYZRgLaO/lHKEx0g+DzfgRg3YU fFAmLcl/ye3RO+bJ01n8lZLJBfY8iapXEhYyt+LCPolIVkjuJgV3+rOPZwBXxlML Lk+DscqdOYSjCuVdMcBza3DORTeQqgqxlbzttCmnGlOXODP/oNWplY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=iQtFteacIuRn9K630d+BLNvDWRQ=; b=tN+449YY2KT889ItvIIlrVLVg7dZ mjp0hK6VSjmyGeMiwXOGjMysSAsexGc8636X/G5SrgghuLJNerMCiwXZHiHyZ+cK VVU92xgnKxt8610YczNS0Q44lpGXr1eQxqVoo5QKi/XPJvb3VLpisHS8+JotYg7X kxYRx4o9Lx0d1z8= Received: (qmail 77303 invoked by alias); 25 Jul 2018 13:43:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 77293 invoked by uid 89); 25 Jul 2018 13:43:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=1979, Hx-languages-length:2132 X-HELO: mail-qt0-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=1BMVILm40Ed9VIh5iX2ue+hbJsNqOtBWQR0d/qiL+Xw=; b=a44R8HROiBsbbIy2z3xfepf+c0R3QALZfzdczuFk0KKOxTGNXXq2FqUkfIWiifJY+M /ZvsG/1UlPQ63BkaYb4Jrf8n3oDvqDVO7JdQozo3qsuX+Z2itCFsnk9z1pR1+654Yl7o jM8NW9L/yG+W7c56IdTC4dSHcDTYC0GoDWnYQ= Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH] Fix C11 conformance issues Date: Wed, 25 Jul 2018 10:43:25 -0300 Message-Id: <1532526205-5708-1-git-send-email-adhemerval.zanella@linaro.org> Remove conformace assumption of NPTL implementation for ISO C threads and revert wrong libcrypt addition on linknamespace-libs-XPG4. The i686-gnu target now shows two new conformance failures: FAIL: conform/ISO11/threads.h/conform FAIL: conform/ISO11/threads.h/linknamespace It is expected due missing HTL ISO C threads support and both conformance .out files indicates the reason ("#error "HTL does not implement ISO C threads"). Checked on i686-linux-gnu and i686-gnu. * include/threads.h: Move to ... * sysdeps/nptl/threads.h: ... here. * sysdeps/htl/threads.h: New file. * conform/Makefile (linknamespace-libs-ISO11): Use static-thread-library instead of linking libpthread. (linknamespace-libs-XPG4): Revert wrong libcrypt.a addition. --- ChangeLog | 9 +++++++++ conform/Makefile | 5 ++--- sysdeps/htl/threads.h | 1 + {include => sysdeps/nptl}/threads.h | 0 4 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 sysdeps/htl/threads.h rename {include => sysdeps/nptl}/threads.h (100%) -- 2.7.4 Reviewed-by: Carlos O'Donell Reviewed-by: Carlos O'Donell Reviewed-by: Carlos O'Donell diff --git a/conform/Makefile b/conform/Makefile index a0ab70e..d430931 100644 --- a/conform/Makefile +++ b/conform/Makefile @@ -197,9 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) linknamespace-libs-ISO = $(linknamespace-libs-isoc) linknamespace-libs-ISO99 = $(linknamespace-libs-isoc) linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \ - $(common-objpfx)nptl/libpthread.a -linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \ - $(common-objpfx)crypt/libcrypt.a + $(static-thread-library) +linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) linknamespace-libs-XPG42 = $(linknamespace-libs-XPG4) linknamespace-libs-POSIX = $(linknamespace-libs-thr) linknamespace-libs-UNIX98 = $(linknamespace-libs-xsi) diff --git a/sysdeps/htl/threads.h b/sysdeps/htl/threads.h new file mode 100644 index 0000000..3c04fbc --- /dev/null +++ b/sysdeps/htl/threads.h @@ -0,0 +1 @@ +#error "HTL does not implement ISO C threads" diff --git a/include/threads.h b/sysdeps/nptl/threads.h similarity index 100% rename from include/threads.h rename to sysdeps/nptl/threads.h