From patchwork Wed Jul 25 22:20:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 142913 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1328294ljj; Wed, 25 Jul 2018 15:20:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf/k6fi+tWNjcCjHRrmA9Svdjs/9BhiD0kJ72H5NC4vCAAmL64xkdLRJeyZWh9AFzIA8vP5 X-Received: by 2002:a63:6345:: with SMTP id x66-v6mr22437982pgb.43.1532557218297; Wed, 25 Jul 2018 15:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532557218; cv=none; d=google.com; s=arc-20160816; b=JD+Xy7BjH2zKQogFpTEk7bLaIH5/ssJTUrMyl7k4suGnkvWnzNgvEbQ8wrmQVTdx29 3na/HAmxE9txkxQVmIq8HvtMmaEHnP/FrQnGIMZ6Z/NoVY4pzOvt9b36/aq1/9iZVjYz Yrhq28ZxE50pyFh4UIio3sNSlIED8AQEGvDqz1oCAhdGbJb0+M8uXgqJzYOwqELkUMzI P6OerBadLaJ6QgINgC5R1IYPomqMvEXrRi9C/Er9PQEgdpYY7YhQ95VMsCsYdDvkM5Rs R4pufXPYnFC/KsBzUUHnAQmrzsPo0HMa2TgYpZn2wBSeBEJR//jS/zg4RJcHlkSdL9o/ YvlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=7iSybzDmIqLwKWBZIaRGtwBnUI0SFEpnPkyOYs5pykE=; b=oC6+YHCJCTbgPqaSRRw/xLNl0/DBJQKkCJ4aAIRl7TIYS9YZYHoGzrt4PcZ1WDZxxL azUkPUw7hl5DCVu/4hRU5nRMc1/b4WaXsh9r9GGTrvAFFytKGGTsakOu+VFlUfYp9+JN aKh7wEY7l4TZXTv4OlLCo08IpNiHQf6yGlvI5w2+fePp+dgBGU0rTwbLK2POu0U0rer4 I8SQsrB8h60YSavcBwpU9PVp3BwG76vO56YoAG+3myavE51XF5VgXmy0nBScxLuKDJwY mqRK/MSCUDc/xZVWpHaOLCklxvPxBASnBsHBoaWLQ9f7eKMi180H9qzQNEis5aQkLPiN J+Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NpQf+GWX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s199-v6si16425632pfs.255.2018.07.25.15.20.18; Wed, 25 Jul 2018 15:20:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NpQf+GWX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731545AbeGYXd7 (ORCPT + 31 others); Wed, 25 Jul 2018 19:33:59 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45131 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731259AbeGYXd6 (ORCPT ); Wed, 25 Jul 2018 19:33:58 -0400 Received: by mail-lj1-f193.google.com with SMTP id q5-v6so8005196ljh.12 for ; Wed, 25 Jul 2018 15:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7iSybzDmIqLwKWBZIaRGtwBnUI0SFEpnPkyOYs5pykE=; b=NpQf+GWXXK6A8g4hvNaMO77KZUShNZrpXvya9BEjx4W9Bp8E6yvLDO4D3Kt7mbpVs2 UpGnXAr2zfsGthrUKo/xig8Vd6FGLgxMkencGTXhAlLOZgdLqdgil0NRN+Z0tcyUP2kp kv9rjOTIacfJ5dIGCN7nlwE0+/Ul8yEl0Hj1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7iSybzDmIqLwKWBZIaRGtwBnUI0SFEpnPkyOYs5pykE=; b=bXvS7CVwKMs4p1khj9J/9YzVbmZyKJYtZVbtcneAE3AxmiGE2hy09D7Ge2lXJavfK8 CUmqodixVyI2WT8Il0PfSr3bkQyxMYU/P5YJU3+IfvGBxQtuI7sROkM69lfS5cVSoKkV lwzuoeUpqLldM+g/3opWT0XC3YtNDjS3NluK1/cAGz0sBUqVplVIQtWWsCyIjoTwCiO4 ThNan4Ar50VQI2G3aYFwgi/SKnhav2HqL6rndc+g6APop1jjDp0gKlNqr6j9WdLKKw7T gFDMbvRUPUv45l5OEc7pB3aJHOP01vEclyg7G+xL5GelCGYkc4J3mw98a6vRhQeXPWME QCrw== X-Gm-Message-State: AOUpUlHQPROQPeZjswzHxoGcrqsWLKFOUifJTGcGycNLqJ/vWgMVQiUE ZZKTPB4QF7B8PSJafvj7eGAtCQ== X-Received: by 2002:a2e:1609:: with SMTP id w9-v6mr16348435ljd.120.1532557213929; Wed, 25 Jul 2018 15:20:13 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.bbcust.telenor.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id b87-v6sm2355529lfh.33.2018.07.25.15.20.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 15:20:13 -0700 (PDT) From: Anders Roxell To: davem@davemloft.net, santosh.shilimkar@oracle.com, ka-cheong.poon@oracle.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] net/rds/Kconfig: RDS should depend on IPV6 Date: Thu, 26 Jul 2018 00:20:08 +0200 Message-Id: <20180725222008.32186-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Build error, implicit declaration of function __inet6_ehashfn shows up When RDS is enabled but not IPV6. net/rds/connection.c: In function ‘rds_conn_bucket’: net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration] hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret); ^~~~~~~~~~~~~~~ __inet_ehashfn Current code adds IPV6 as a depends on in config RDS. Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr") Signed-off-by: Anders Roxell --- net/rds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 Acked-by: Santosh Shilimkar diff --git a/net/rds/Kconfig b/net/rds/Kconfig index 41f75563b54b..607128f10bcd 100644 --- a/net/rds/Kconfig +++ b/net/rds/Kconfig @@ -1,7 +1,7 @@ config RDS tristate "The RDS Protocol" - depends on INET + depends on INET && CONFIG_IPV6 ---help--- The RDS (Reliable Datagram Sockets) protocol provides reliable, sequenced delivery of datagrams over Infiniband or TCP.