From patchwork Mon Jul 30 12:29:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 143135 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4020255ljj; Mon, 30 Jul 2018 05:30:45 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfR1dnXJn4X3moeTsW3ef9B22yqwSx/+IVZF9j9iSlxoHV9NeASggbMErAc7jRILiTu34iM X-Received: by 2002:a62:3a9d:: with SMTP id v29-v6mr17725445pfj.215.1532953845090; Mon, 30 Jul 2018 05:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532953845; cv=none; d=google.com; s=arc-20160816; b=Cz1TeOqaj4rZKL4PakO/QEnWatnNhoKKvBZOzzREki+ETd0p6BgSH+LSUrrxGt/vK0 PPP7fmUbGv1c8eUeNzcc0iXutqyEIN2IvixWHnhqkpmkssF3tTxT4C5WfLFfYikQnTb3 +pR7Js4LFNtdt1akA9s4jqrgy1U23e05m4185JUw1n+TQOY9/zQK2mCAnrN4ToT/XC28 t/YLtmpgRONv6jykC7h0UD3ynnEzxnB9YlG/oUwM9CTn1o1u2N6JUR/ZwolE1K3mClkC izQw2KfG+znixqadJU7KYTqcdSbplDbvIpo5vO2cpwx44snmDFk0t0eGtm8MKB2JV1ub cpqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=3Y7dyqAR/c5T0OLG1T0MYQ0uCf6Buc92nGGVldgocvI=; b=PHNK8uXdvtX8wAgqIkI2yleFxzznCm7uCwu978JCeuZMWy7cqRGSi8L/Ydo2x7rNuV +gLTY4xxwSYOmYxQcJMNvOFj7SJ37DVqxxE25K05FQHIDTWiJLMVMhqn4uvq3Wnz2C5z rmjUZmWE2rmqBlBys1NJ7H77ZUY1MOknJ2DftrLHpU2mjhngF8uWJU0NjhvO6ZSGm4yN H7JVr5yo5GJ/U68vBnRMUuELG68nmyMj7hJUc9uuaNJByboE+G/nMlBbhoIBJvsg8S0F 0DrkDBHOFC917/B1whPlRt5zKtHh3VcDzTQ7y5ddQNUfa8JkAgu2eKRy9nNpm79Ko87D pSrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=arNYGJUC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj4-v6si8946352plb.119.2018.07.30.05.30.44; Mon, 30 Jul 2018 05:30:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=arNYGJUC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730482AbeG3OF1 (ORCPT + 31 others); Mon, 30 Jul 2018 10:05:27 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45204 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728798AbeG3OF0 (ORCPT ); Mon, 30 Jul 2018 10:05:26 -0400 Received: by mail-pf1-f196.google.com with SMTP id i26-v6so4471941pfo.12 for ; Mon, 30 Jul 2018 05:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3Y7dyqAR/c5T0OLG1T0MYQ0uCf6Buc92nGGVldgocvI=; b=arNYGJUC/5puDfKayeEahQTPo+E5ZxZqDODJAWJfJ3jvRoqXGzcXlaUP/pldnkSCCU KLCdPw5oy99DuFapOsD7AMU6Ne6TYozkGcyrtVAdiIX2KPF3SxC2ebZWP7tt7CrjDIVs tV/DJq4Uies5wf4Qfm+r6xFeMWODLuMBwPtkc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3Y7dyqAR/c5T0OLG1T0MYQ0uCf6Buc92nGGVldgocvI=; b=On61lZeykOSyVNDwcu9cfzuWwm7KUzMjLYqtdm5ThYMH5OZZhPbMZ4zInonkB5/8WR CZGyy3E1E/xbj5mEH/Am9eEqKkiBH33kQ2Pz+K0QGNF2GFXZvLnwlWHTPcPe5U4Njoh2 B42zLPO/OFkIro3GQzVBBIexiVLRzXgbil+k3NX7Xu0JbY7x2akrSHtchi23+j/kT/XW EwYsTNc/n7yYbwyg3fZb6YiIexJ/D4HCm5qhbnM4r6cQ+0szR74dhRAOl+CBynRPO1BM 4f9saSivmaZhGODuUZE6v8Ltkd623kZyH0Ob93Lz+M9SjJGeljiJVQo6tJZoI5IusABn 0B3A== X-Gm-Message-State: AOUpUlGymSWXCPNnuqVJxItlY16U4EzYtSraiZ0AunP0oAROP4hje9sR /cDG1IQ2FxRBlOfLBnB6ldmXzg== X-Received: by 2002:a63:e516:: with SMTP id r22-v6mr15947563pgh.170.1532953840755; Mon, 30 Jul 2018 05:30:40 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id e8-v6sm26640139pgi.24.2018.07.30.05.30.38 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Jul 2018 05:30:40 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: bjorn.andersson@linaro.org, david@lechnology.com, baolin.wang@linaro.org, broonie@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] leds: sc27xx: Add pattern_set/get/clear interfaces for LED controller Date: Mon, 30 Jul 2018 20:29:30 +0800 Message-Id: <3ed70a68eaa6318c9afb2536956f4886c10a2764.1532953083.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch implements the 'pattern_set', 'pattern_get' and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- drivers/leds/leds-sc27xx-bltc.c | 151 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+) -- 1.7.9.5 diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..ebe23e1 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,13 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +127,148 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 patterns to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, pattern[0].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, pattern[1].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + pattern[2].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + pattern[3].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[0].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_get(struct led_classdev *ldev, + struct led_pattern *pattern, int *len, + u32 *repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + struct regmap *regmap = leds->priv->regmap; + int i, err; + u32 val; + + mutex_lock(&leds->priv->lock); + + err = regmap_read(regmap, base + SC27XX_LEDS_CURVE0, &val); + if (err) + goto out; + + pattern[0].delta_t = val & SC27XX_CURVE_L_MASK; + + err = regmap_read(regmap, base + SC27XX_LEDS_CURVE1, &val); + if (err) + goto out; + + pattern[1].delta_t = val & SC27XX_CURVE_L_MASK; + + err = regmap_read(regmap, base + SC27XX_LEDS_CURVE0, &val); + if (err) + goto out; + + pattern[2].delta_t = (val & SC27XX_CURVE_H_MASK) >> SC27XX_CURVE_SHIFT; + + err = regmap_read(regmap, base + SC27XX_LEDS_CURVE1, &val); + if (err) + goto out; + + pattern[3].delta_t = (val & SC27XX_CURVE_H_MASK) >> SC27XX_CURVE_SHIFT; + + err = regmap_read(regmap, base + SC27XX_LEDS_DUTY, &val); + if (err) + goto out; + + mutex_unlock(&leds->priv->lock); + + val = (val & SC27XX_DUTY_MASK) >> SC27XX_DUTY_SHIFT; + for (i = 0; i < SC27XX_LEDS_PATTERN_CNT; i++) + pattern[i].brightness = val; + + *len = SC27XX_LEDS_PATTERN_CNT; + *repeat = 0; + + return 0; + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +287,10 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_get = sc27xx_led_pattern_get; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err)