From patchwork Mon Jul 30 12:54:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 143136 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4043611ljj; Mon, 30 Jul 2018 05:55:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcWN9Z4awMdXABtb6/tMWNu4AY7GlPkd/47FkG2Fjw3Hxj9oa9gfo1pniZwnANQzkD6iyC7 X-Received: by 2002:a17:902:9a8a:: with SMTP id w10-v6mr16418177plp.14.1532955315646; Mon, 30 Jul 2018 05:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532955315; cv=none; d=google.com; s=arc-20160816; b=EnmfEehavqSvtu0EZtwmzR0Bg5jGoTbMQHRdKF6hklFYWsq4Zcbck19WDt6Bi4SksB 3r64LZH7r5TKKmmq4XJE9sBbyUw0ddeT6+1YHZ0HW6tut3UYftvee5jlUio/3ZStGonb LRzQ5KSUyqFAcxwKobjErdvVRi4twHF2I8G4lRiy198GI05aj+TglApbnjAU9ZKb6kvg u7+OO+uRx3oOXIuLw+L1Mh/fJ6+lEg0sAKD7XGu9a1wF2VivqYbndzACxOI4uLcvbq7l JrKM788H8sv5ATj9P4PmxxIhwXTOHOeisZGXAawHBu9vBmpBQOLWZByCG0sUsy5aKkgU AGzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature :delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=EDrvvAjajrCPbDvmZjl9wS1v+UfdKoxpvxBLXwGkMsw=; b=XOHSdOi4tk7+NI/iJcJGdr1wZAoPQiEeMSetPSZLoaU0/RDqfKqwZxHIx98gHv31a+ lf2B0KJfgLW3px74MzliU6ntuBaSbew8PXXBQGO3RFWyaUuA1x7e5H+XYVW8m/aAeLyC AL0HG0euZXV1wGyrJ98AwZmarzHP7Y5L1eVUjKWcyY64tmwT/A+tGoktG6WAIXiLMNhN iUgum/FurPfhBm6WcuugFBtNCF1pIEnRpw4hZ+QoQH3B7oAmeddCqzxpHm0s5kElEPN+ U36vKhR4jRGTsptDrREvNBmw4e7LZfDEu2YdFbdGZ7aEi5GhPDS+339YG/0cJw7oX78X 7/vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=j283FzQd; dkim=pass header.i=@linaro.org header.s=google header.b=GN8H80pM; spf=pass (google.com: domain of gcc-patches-return-482637-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-482637-patch=linaro.org@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id g87-v6si11846069pfg.225.2018.07.30.05.55.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jul 2018 05:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-482637-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=j283FzQd; dkim=pass header.i=@linaro.org header.s=google header.b=GN8H80pM; spf=pass (google.com: domain of gcc-patches-return-482637-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-482637-patch=linaro.org@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=cnPb7A+W/O+sadgOMCYIFyLfTuTs/Kc/4RWRITqaiAnEQS FiayIJzVdcRiKwLzpHmkIvdwmdq6uo4nfGOEmGEYJk3+zfqI0r7MBt6Z8jX3dXXA 1dAFd51ojPXtx2zUXQtH6Fh83c9mqeCrCxsKSnliFDUxfbvr7r709QqYVgLGk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=naw/3SlW4qL+rWyNlVRSRJgBEXg=; b=j283FzQdltHWneOk7ZOT mXY/aPvSpfGYWqc9l+dTEdi28/dkuOlJoRohxNhfIT8wibq3+5+VeaFN2eo/ToKZ T/3T5nX/Vfyl4+b+xPYlO5Ywa29Xm596AP+eskeGigDY2B+NYDMcxjlvpCC8bbwW oYjff9v8dg08LabLqQLZU0E= Received: (qmail 9750 invoked by alias); 30 Jul 2018 12:55:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9731 invoked by uid 89); 30 Jul 2018 12:55:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:mail-vk, LSYM, lsym, H*r:sk:y9-v6so X-HELO: mail-vk0-f48.google.com Received: from mail-vk0-f48.google.com (HELO mail-vk0-f48.google.com) (209.85.213.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 12:55:02 +0000 Received: by mail-vk0-f48.google.com with SMTP id y9-v6so5644544vky.3 for ; Mon, 30 Jul 2018 05:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=EDrvvAjajrCPbDvmZjl9wS1v+UfdKoxpvxBLXwGkMsw=; b=GN8H80pM+PMTUvZstnMNY/VcOv8Z7Ehfa6WyEjYA4PrllDbvAahCoUiZpZ57+PW0LU OfyGWH+nwIk79cOWXteYhur41bwp3hsSFvXDE/33S6FCC0sism9CTD44OfwBol3e/lUY GCVBIaXAt1OXVRToGBlwZBd5566Ldf3k4zhTY= MIME-Version: 1.0 From: Christophe Lyon Date: Mon, 30 Jul 2018 14:54:48 +0200 Message-ID: Subject: [OBVIOUS][ARM][libgcc] Fix comment for code working on architectures >= 4 To: gcc Patches X-IsSubscribed: yes Hi, In r261840 I added an inaccurate comment: the code works on architectures >= 4, not > 4. I committed this obvious fix as r263066: 2018-07-30 Christophe Lyon * config/arm/ieee754-df.S: Fix comment for code working on architectures >= 4. * config/arm/ieee754-sf.S: Likewise. Index: libgcc/config/arm/ieee754-df.S =================================================================== --- libgcc/config/arm/ieee754-df.S (revision 263065) +++ libgcc/config/arm/ieee754-df.S (revision 263066) @@ -657,7 +657,7 @@ beq LSYM(Lml_1) @ Here is the actual multiplication. - @ This code works on architecture versions > 4 + @ This code works on architecture versions >= 4 umull ip, lr, xl, yl mov r5, #0 umlal lr, r5, xh, yl Index: libgcc/config/arm/ieee754-sf.S =================================================================== --- libgcc/config/arm/ieee754-sf.S (revision 263065) +++ libgcc/config/arm/ieee754-sf.S (revision 263066) @@ -461,7 +461,7 @@ orr r1, r3, r1, lsr #5 @ The actual multiplication. - @ This code works on architecture versions > 4 + @ This code works on architecture versions >= 4 umull r3, r1, r0, r1 @ Put final sign in r0.