From patchwork Mon Aug 6 12:06:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 143502 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3207252ljj; Mon, 6 Aug 2018 05:06:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf/7v2ijio+/yYy+RLVR4NCmEwjCWyqz5C/aoT+GuVnBuZR+ZY6cjll72C5mmTRWsYgUDv+ X-Received: by 2002:a63:e14a:: with SMTP id h10-v6mr14703478pgk.358.1533557185772; Mon, 06 Aug 2018 05:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533557185; cv=none; d=google.com; s=arc-20160816; b=XsrGZ+x1zJlOeXjLDHXmuc4wA3lkqZ32yyRHkyiEPvh6oYsRvvZ6mHy0KRfcyEwYYl 796qmxC9gHCv+UPfm/epX/9Tk4y0bNwMmNlwHyUgjytTeCp9fWrGjIrcaOKxr0S00ULJ RKi0xRa8M1Je9WURKsQ4AS4XKBNUMIXizXUXzDlvPMFfd6WUxWo3Jl1tae0nDD2BKayc Z0SDQNDfGpmimCLz6mAAFFR/Pi7PX89Oikl+5DOnQuWCNIl3xLdOLCJbEQS5CiA2R5Mh 7Dx08PscPdvTAjR1WQWeQMT9I7nUWE9JeQ7n2NUghX99BzblWKCbx17uoIPWz6qInrqw YF4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=6OweEQF4blgca9x+9WOfZwW8lLDXX9E03wJIYWGhaOE=; b=B3QVEGkUN+Lmzke5L63sKli5fx40TR9jAKWMw/SJpHcOTuicj+Yjp1/rW2buxBNh31 ZORTEcq7isswZ49onNTMPRu7NHTdWGonfpX5cSlARMKiZD7RnHAQixOOnF9yr3HG0wR0 bIwRFf4W34EhJW6tLnsHTJoiKaGok0BF7RF/M8eMi6Cc3+nvTzdI7VJ0PcDKokXZhF5g eNZWXur2J5u03HBMnucK616Ua67D6n4jPwXkgoL7A4QAw+zBka/zYLN2kyfj5rMUaeDF MjZDN+E3WpMFp2ELtxihuvzTEK09uQSFZIuc2L40h8pWwIa1/u5NY8+sS8HtoPZiNnDR OdnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WBziubs2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c62-v6si14203036pfb.98.2018.08.06.05.06.25; Mon, 06 Aug 2018 05:06:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WBziubs2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732196AbeHFOPL (ORCPT + 31 others); Mon, 6 Aug 2018 10:15:11 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:32934 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732150AbeHFOPK (ORCPT ); Mon, 6 Aug 2018 10:15:10 -0400 Received: by mail-pl0-f68.google.com with SMTP id b90-v6so4781426plb.0 for ; Mon, 06 Aug 2018 05:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=6OweEQF4blgca9x+9WOfZwW8lLDXX9E03wJIYWGhaOE=; b=WBziubs2sMpL+YgTHHcJ6Tz6AGzR27ySXt7MljjsC5vnyl1mAI108l3D+05PF0DhFB AJJUncpdhIoPCgq6DCBh1FwYyHHyxdVyjIkPOm8o16xHTKaIG4If/pBFgUxSBJxZ2ClN HGP6+veWG/9dk5yYV5FQ4OMW95uSyqbhblbrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=6OweEQF4blgca9x+9WOfZwW8lLDXX9E03wJIYWGhaOE=; b=b4nmg3Yd/LkMOr7ecferoJONgq8hniAemuiFYikLAEK1PZErHurKBtMuJBqCi3OeT1 AyUWoL3ULvNk2BHvG/C2EceffS4aiw1W5tXnb7X5U+WCHQtYTk1uUSVtCwtF7XLbwfht duqGNRk/8wbUfb2rWKud3vNgHJhOzMQ70ctQeEYc1H4o0apYLYhNeNz/wKmUIudItw1B arGebA3KlnKAQgiMK7irPQfW6BEdnafsZ9v/XydMQ9ZttheTQ/cMfOkwODdh02T12GlV GddS+sYw2ya6eiD2KF38u4e12b1Bq/Sb9TPArBnYgOl1QU3TwwK/KUKw+Q74X3hXZnGv yzZw== X-Gm-Message-State: AOUpUlEQ7GRLt2djbm1cMT6LQ0QvsJcX69vGf+iXhySkCXILefE5I4xV PMiOdtuE+zCl6AHRsGE+MOmJoA== X-Received: by 2002:a17:902:e3:: with SMTP id a90-v6mr13971189pla.227.1533557181541; Mon, 06 Aug 2018 05:06:21 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id 21-v6sm16592354pgx.20.2018.08.06.05.06.19 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Aug 2018 05:06:21 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Mon, 6 Aug 2018 20:06:00 +0800 Message-Id: <9cafaf169e15698ec1c936e07b6a520307009f08.1533556992.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1dc5d394324b2bf1ffe229b8e42691fab6d749e0.1533556992.git.baolin.wang@linaro.org> References: <1dc5d394324b2bf1ffe229b8e42691fab6d749e0.1533556992.git.baolin.wang@linaro.org> In-Reply-To: <1dc5d394324b2bf1ffe229b8e42691fab6d749e0.1533556992.git.baolin.wang@linaro.org> References: <1dc5d394324b2bf1ffe229b8e42691fab6d749e0.1533556992.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v4: - None. Changes from v3: - None. Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- drivers/leds/leds-sc27xx-bltc.c | 94 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) -- 1.7.9.5 diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..297dd43 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,13 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +127,91 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 patterns to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, pattern[0].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, pattern[1].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + pattern[2].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + pattern[3].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[0].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +230,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +334,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");