From patchwork Tue Aug 7 15:56:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 143590 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4668646ljj; Tue, 7 Aug 2018 08:56:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeKL9WU9wdewbaHb01nRhFS3o6fzfYeICNYxFB14YARnQcA6U133b3TY1BxLjsfHeich2vU X-Received: by 2002:a62:cc4d:: with SMTP id a74-v6mr22583376pfg.200.1533657400692; Tue, 07 Aug 2018 08:56:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533657400; cv=none; d=google.com; s=arc-20160816; b=U7AmabjSU+TRQrSJ29sdkbtuAWGe/XxDa4s/SiLqzFoSzsLcHMqizvjPkS1fxEiUNV wvJudYKgxPAlSpGIOA35OCQclo3RaUhMXlv4RUCx697Dw/23jo7Gc6q+a/cRb51cRnTH FwzdsbNdtNkJUwxYxcE5nqqifNvJYcWp+twiwWtK7IE+BnSqxpofc7tdm04LMRZazCyX 0LihYRRPPj8eKLYpFC41vcAGCVJ0Wj/xFPFeFT7d5nqve3dGFqMosTWlSlfisSZ6O4ML 8Vw2SserIp5X/f2gXdT8omgPXLTNtvW1+OakkdixVI8MvyKbYZWaEO0aQ/Yg4mjuwMOu eqtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=dwnEuOfvwkhUPwkhLMArV3ygXldRpqW8K54UcT0yLyM=; b=aJ1bYhQfNhJdUUyNvWwwG3pqtcmgLQMr5X/zEKOJ8n7J1L3vTKQq3P5+FGq4/Yp8zd ktqqADjR2UY8DzFo1jmg/N0Qn+Crnf8JgnYwq/VqpzymNkMyiombb/0XfEz7PNIi9gqw zi69Qtj/Y8CMVXHylnHgVVZf69Iu1xbXmsVkN7Fp+MMo9wigI0L4q6ITna0dZhYcMY+g 4AcxmP7TdyhJp8i4FhRCHnhVZCHcmMqI8bQuVIFrLOJEv5bEKPlz6Q1NzrHLMdMZBAhv J0ZNldhBFKFZKZfrvIY38aOWOGG/e3rNGZRcaEgQ4bQJLEKyXHLPpbcEektTDTLLfGPA 7eXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JVUMaxLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si1685020pga.298.2018.08.07.08.56.40; Tue, 07 Aug 2018 08:56:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JVUMaxLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390023AbeHGSLd (ORCPT + 31 others); Tue, 7 Aug 2018 14:11:33 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46218 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388481AbeHGSLc (ORCPT ); Tue, 7 Aug 2018 14:11:32 -0400 Received: by mail-wr1-f67.google.com with SMTP id h14-v6so16230385wrw.13 for ; Tue, 07 Aug 2018 08:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dwnEuOfvwkhUPwkhLMArV3ygXldRpqW8K54UcT0yLyM=; b=JVUMaxLVKtdy9L0fArqR+35obj9iXp7E7CdS9ozqBjeFJxQOjxwc9cHSmLAvR9Rjwo fiEO7XmM22XiDcweeGF6JP9zyDBIXQMM/5kkH2KzGr/bHAF8/EMYiAvGZSrLVYDj8RsB 1XRiHElueUJmIBPBUm8eZKbpp5nsFBy/IQwZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dwnEuOfvwkhUPwkhLMArV3ygXldRpqW8K54UcT0yLyM=; b=Xp3ZJrM6Oe7UQ6oyi323XYW9Z0EPjsMyEA+eUOBZOlfnzaQVW/BljwYDudNMAZC//W 46EQi6LT5YhMpy2yxuqq8SbWPkhw3DUQJRkAvo5wbEieMfFJxWES1AEQylJ9zBZxYvNU BEEmDy5we+Xyr/JlsSZuTfLgO+1Ni13fD3TtpulIPzhMWUA+uJS2iJz7QH7qfjReaeOD OL1vpeE9iowRJkOAAxksOrtG5ub+0RifsGEOPZTea30PGrne+iuA/cxvlfPkQLRhkIdB IlyX36x9iobBBT4chGITY+mF/+1gl47O+XxBVf0zvoE07aLddwhQVGxsPwLAlg4Mn9bQ YHsg== X-Gm-Message-State: AOUpUlGvnVKRL4tC9jYVY/hwusp6Ue56W/RCJjft9yxGpWB1uCOo9Q0j ii9pmwcoyqNvCWNdCYwE3cfLqw== X-Received: by 2002:adf:8b1e:: with SMTP id n30-v6mr5019651wra.282.1533657394648; Tue, 07 Aug 2018 08:56:34 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:41ad:95bb:4cb8:621f]) by smtp.gmail.com with ESMTPSA id y203-v6sm2903644wmd.1.2018.08.07.08.56.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Aug 2018 08:56:33 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH 1/3] sched/fair: fix rounding issue for asym packing Date: Tue, 7 Aug 2018 17:56:25 +0200 Message-Id: <1533657387-29039-2-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> References: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When check_asym_packing() is triggered, the imbalance is set to : busiest_stat.avg_load * busiest_stat.group_capacity / SCHED_CAPACITY_SCALE busiest_stat.avg_load also comes from a division and the final rounding can make imbalance slightly lower than the weighted load of the cfs_rq. But this is enough to skip the rq in find_busiest_queue and prevents asym migration to happen. Add 1 to the avg_load to make sure that the targeted cpu will not be skipped unexpectidly. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 309c93f..c376cd0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7780,6 +7780,12 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Adjust by relative CPU capacity of the group */ sgs->group_capacity = group->sgc->capacity; sgs->avg_load = (sgs->group_load*SCHED_CAPACITY_SCALE) / sgs->group_capacity; + /* + * Prevent division rounding to make the computation of imbalance + * slightly less than original value and to prevent the rq to be then + * selected as busiest queue + */ + sgs->avg_load += 1; if (sgs->sum_nr_running) sgs->load_per_task = sgs->sum_weighted_load / sgs->sum_nr_running; From patchwork Tue Aug 7 15:56:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 143591 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4668651ljj; Tue, 7 Aug 2018 08:56:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfvHkQfFJVdAmrCx4tyISY9zb7syEmhXvLMyAwABybhrWljCCIRuOpy2sCKjt5E/LMZ08vH X-Received: by 2002:a62:4808:: with SMTP id v8-v6mr22475803pfa.89.1533657401135; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533657401; cv=none; d=google.com; s=arc-20160816; b=HXd1LPel6aRSiy8RJEk9rYv6H8PLaD/En5Y/OC47mpoJ/HEF/rCx0hvYHA29cLcnOa F8/bMkFDq0vojkiQ0deypBlTiKIVYQoVNfUNG3FBOcygujuvlGdWxkWce5JMRHd+Q/X9 L++dQvFYPx2vw7H6yJu2DLhaXBoXqHpNbIUh0ROs9O/MAscqt623WdCUvqwZek+E5h2y +Fuo4naeu1mLji48q3s2yGrAcoft92wYXhp2hlnWoGcOXZXn6/rXJuw9/VCuXX/F7MgD DeHIO+eyUahKXOvqcTQiQyrN+dR08iKeYmSfHCMIroAdzZRpBftkaX9zCGjSJ64AqXto MVvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=fTCJJHBMNkUJJN3RgEd6oBgcwXlHnayaWgAjMiLpqTgC3tAS6Q32qR2TkMDDoTV4QI 74lqWz2/CFA++h03ox5fyFtPgONEqfR/pTVMZKQOYrqgcvaRaTJqG8WvmOmCAnatWIed R3uT96ZdyBFlwYbkhCHOHTHLnn6+TD/kszOVMuniuPjCEBBpsY3FcgPUKYCW+0nCH7DC jpwTcB40pm31MS7zaaxzlpF9uumr84u+dSJI86IwkhAqYyYyPEpF85+qGuqstOQ6OA8A RoYtv27slr7dy01thd1b3xbpB2IGr+OZT9QKdM6Q6nkt0L8t/VMcS8KAB2B8pVKrcBLQ tEpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G4Q2PFD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si1685020pga.298.2018.08.07.08.56.40; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G4Q2PFD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390067AbeHGSLe (ORCPT + 31 others); Tue, 7 Aug 2018 14:11:34 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37749 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbeHGSLd (ORCPT ); Tue, 7 Aug 2018 14:11:33 -0400 Received: by mail-wr1-f66.google.com with SMTP id u12-v6so16267505wrr.4 for ; Tue, 07 Aug 2018 08:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=G4Q2PFD8DmvwEUMVS0nuzVo+S2aU3kQZKcbUAMd6wzw7UkIj7GM9rpuDLe/AxwuEC4 vxj3iiC9ZEBKwjnzNvDwE6ZUo4guIdrAPfA93dcyGXf3MOTHrvNVIVC/xxzBjC009wK3 BJdVfUqt3Ibo3WItw0+8hi9dbcEUQJ4D2jp7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=D75ZQeHbZKPP/BCEtr4wPJbieySVh0rBXWiFQ9NWNZ1TYCJGc4Fn2u8onoLGYbwe+L Vpw/NdsGMk4KAA0wh+E4az7qw036/p8BSFpQqeb7Mv4NH7VYHxGxRxYNWMUDUBXXsvGg vUk0NHdMniqZ51flj3J0uOprONiIWMp5thAhpqsXe8J77Y735i1ZEXYOdaK7OkrUVaqF kSERCkyQdr7W1pA+CvvBOS9Hj0GqRUqGfCp5xPcN/NT3Dx6Vwwyy7/nBQlrUlFHOcFnG jFFvsHDBm58gwiZPBIe5Wq8AOuqyqWiYjGuhgRBRLtJXuctE0wtW+xTAvlWIPGl2/1c4 zZ2w== X-Gm-Message-State: AOUpUlFK4TBqLw/zDUOpHjspWqvxfBp+wpoLw2Qkht5WnZvPznd7HPTY XbwJAcYHMH1P9oWuZbwxWU8TFw== X-Received: by 2002:adf:bbd4:: with SMTP id z20-v6mr13463970wrg.183.1533657395823; Tue, 07 Aug 2018 08:56:35 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:41ad:95bb:4cb8:621f]) by smtp.gmail.com with ESMTPSA id y203-v6sm2903644wmd.1.2018.08.07.08.56.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Aug 2018 08:56:34 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH 2/3] sched/fair: trigger asym_packing during idle load balance Date: Tue, 7 Aug 2018 17:56:26 +0200 Message-Id: <1533657387-29039-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> References: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c376cd0..5f1b6c6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8364,7 +8364,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but From patchwork Tue Aug 7 15:56:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 143592 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4668657ljj; Tue, 7 Aug 2018 08:56:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcz662c0nJ0EGh6ZkFPDbNYTfhdKll+GZOpog7llHsGiyF0292vz1soL4+lbbCVTJjDHBpr X-Received: by 2002:a65:41c6:: with SMTP id b6-v6mr19119048pgq.174.1533657401494; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533657401; cv=none; d=google.com; s=arc-20160816; b=MI5/tOVxK3TkC4cAx/0aKJfLsHr0DY+A5JW8gNgEqNj3bXYbZUpRYHm7IgR3XYgj2y keoIYv5ITG1fO3fRi64e3Uc21phEM+X7zvhhIHVcAYKwiNNm1bFh23iMDW+NcQwLhPgV dE+h7GfP5AUiB9sGkGyw4ATCup00RL/V5jGjwgu7Vz4D477CSQ7W1b6KOEEEggKmy6Bl om8N0J37G9nBlWwL/p2FBFClPbbpyMC0ruXX8Yr4hQgxCE8GEpMwu25YJAjkewJ6zT+b 24tOc/PGtDQO40fTqW6U9zpPY2kSol05RdXT9H00KI+tPlUU14i2j6QZYG6JKhbOm+4X wElw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=zsbT0P20/sYtkb53CZMMxTX0UzHPPoWw6TQr3C9fHXs=; b=kZHKEM2nDXMNL3Vr1UZLSG3oIxt41gafVOoqw7Vb4FFZefyBJqNVoCmYDl2CjKqavt V7LZWQWqkxeoXTCc3+sQWC/9kFbzu6L3jiG3RC7YvD67OKVg91SatG/aRXMhe2eeFyix 6Fx9MVPWoQt1R9XtxTadKePMbPu+5jz46UFEaGiVGDSM+2YukWJeiSAlP9L9BOHJdebH eCABCvTpBke8PIaFa6Nw+yc9WWeOcSwVb1uUZavFbvAF5y5M4dPCmt511ZvWDl+qdFzm +WSIs4ClIxApqngMuxVbOqZNLd+MFCCCjvWPkcNf4ZmD+uGhRi6RB4dSfnHDHolkB1UE AEgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CZGyoVQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si1685020pga.298.2018.08.07.08.56.41; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CZGyoVQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390081AbeHGSLf (ORCPT + 31 others); Tue, 7 Aug 2018 14:11:35 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33083 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388481AbeHGSLe (ORCPT ); Tue, 7 Aug 2018 14:11:34 -0400 Received: by mail-wr1-f66.google.com with SMTP id g6-v6so16284482wrp.0 for ; Tue, 07 Aug 2018 08:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zsbT0P20/sYtkb53CZMMxTX0UzHPPoWw6TQr3C9fHXs=; b=CZGyoVQEbRJTOPIWdQDZjNw6wGPqEVRUM/eKPkzdL8HEZZG9q4PLdESaURmaXDmfEI edsUe5Jk90EF8XmG8g0iV0AFe+F0RZA6vguo5bqt/w6Mi7pvZQKSWds1JuK2A1AUrTc3 InhsmpJcKSJsfboerQhNENN9WE2e3mvPoAs/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zsbT0P20/sYtkb53CZMMxTX0UzHPPoWw6TQr3C9fHXs=; b=OTL4UE7ywFpzZCWzZOrz87tTdAzgS6IpwiUZNk9RnU6UZQTylpENjp2OqqXAP2eyPu pbhcZK4cZ4+IlyD9VqBCIq2KMnVsJ7yC/GNHT1Omvb0Mp89YhBtkZVc1kcF4omZaovLu twDn/6/MCzsk6efBOWfBtDRlMNb9hQ3IsvhzNBkrOSqJKR0kmCrskSXF1mqohmcGSivJ RtlnSleQDoxRpbZlnovEu71d1/GWcVut58aZvajv2oabIC6AzMrE3l1oIDRSC6QxpMqd N3akdTxB8OrtjuByCZxFAxq/ZtyzFe3V+Fl6/QsIm1YRkfKshfGOIQP5Ek2im04KdA5a HZCg== X-Gm-Message-State: AOUpUlHOoaep0LUiKLFFOc4FObYlK5bdmqg719MriTVHglslDbpuap/i rdWETFeRJcQFPlLBUVJjWU17S41/nFU= X-Received: by 2002:adf:a197:: with SMTP id u23-v6mr13916157wru.50.1533657396773; Tue, 07 Aug 2018 08:56:36 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:41ad:95bb:4cb8:621f]) by smtp.gmail.com with ESMTPSA id y203-v6sm2903644wmd.1.2018.08.07.08.56.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Aug 2018 08:56:36 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH 3/3] sched/fair: fix unnecessary increase of balance interval Date: Tue, 7 Aug 2018 17:56:27 +0200 Message-Id: <1533657387-29039-4-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> References: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of active balance, we increase the balance interval to cover pinned tasks cases not covered by all_pinned logic. Neverthless, the active migration triggered by asym packing should be treated as the normal unbalanced case and reset the interval to default value otherwise active migration for asym_packing can be easily delayed for hundreds of ms because of this all_pinned detection mecanism. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5f1b6c6..ceb6bed 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8360,22 +8360,32 @@ static struct rq *find_busiest_queue(struct lb_env *env, */ #define MAX_PINNED_INTERVAL 512 -static int need_active_balance(struct lb_env *env) +static inline bool +asym_active_balance(enum cpu_idle_type idle, unsigned int flags, int dst, int src) { - struct sched_domain *sd = env->sd; - - if (env->idle != CPU_NOT_IDLE) { + if (idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but * lower priority CPUs in order to pack all tasks in the * highest priority CPUs. */ - if ((sd->flags & SD_ASYM_PACKING) && - sched_asym_prefer(env->dst_cpu, env->src_cpu)) - return 1; + if ((flags & SD_ASYM_PACKING) && + sched_asym_prefer(dst, src)) + return true; } + return false; +} + +static int need_active_balance(struct lb_env *env) +{ + struct sched_domain *sd = env->sd; + + + if (asym_active_balance(env->idle, sd->flags, env->dst_cpu, env->src_cpu)) + return 1; + /* * The dst_cpu is idle and the src_cpu CPU has only 1 CFS task. * It's worth migrating the task if the src_cpu's capacity is reduced @@ -8650,7 +8660,8 @@ static int load_balance(int this_cpu, struct rq *this_rq, } else sd->nr_balance_failed = 0; - if (likely(!active_balance)) { + if (likely(!active_balance) || + asym_active_balance(env.idle, sd->flags, env.dst_cpu, env.src_cpu)) { /* We were unbalanced, so reset the balancing interval */ sd->balance_interval = sd->min_interval; } else {